45844 2010-09-15 15:47:08 -0700 Fix linking issues with windows versions of the gtk+ port 2010-09-21 10:44:51 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 fridrich.strba webkit-unassigned commit-queue oldest_to_newest 279783 0 fridrich.strba 2010-09-15 15:47:08 -0700 The gtk+ port needs some additional windows libraries to link with when building for windows. It also needs to specify $(EXEEXT) for some tools in makefiles because a raw copy is done in one rule. One more symbol must be also exported from the libwebkitgtk dll. 279805 1 67739 fridrich.strba 2010-09-15 16:22:11 -0700 Created attachment 67739 Patch 279821 2 67739 mrobinson 2010-09-15 16:46:47 -0700 Comment on attachment 67739 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67739&action=prettypatch > GNUmakefile.am:251 > + $(OLE32_LIBS) Do you think you can put these flags behind a if TARGET_WIN32, just so Unixy people don't get confused about them? :) 279828 3 fridrich.strba 2010-09-15 16:57:10 -0700 (In reply to comment #2) > (From update of attachment 67739 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=67739&action=prettypatch > > > GNUmakefile.am:251 > > + $(OLE32_LIBS) > Do you think you can put these flags behind a if TARGET_WIN32, just so Unixy people don't get confused about them? :) Those flags are set to empty by configure for non-windows platforms and to the appropriate libraries on other platforms. Having an additional if - endif forest is thus not necessary 282345 4 67739 mrobinson 2010-09-21 09:12:58 -0700 Comment on attachment 67739 Patch Okay. 282420 5 67739 commit-queue 2010-09-21 10:44:47 -0700 Comment on attachment 67739 Patch Clearing flags on attachment: 67739 Committed r67963: <http://trac.webkit.org/changeset/67963> 282421 6 commit-queue 2010-09-21 10:44:51 -0700 All reviewed patches have been landed. Closing bug. 67739 2010-09-15 16:22:11 -0700 2010-09-21 10:44:47 -0700 Patch bug-45844-20100916012208.patch text/plain 5509 fridrich.strba SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDY3NTcy KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDkt MTUgIEZyaWRyaWNoIFN0cmJhICA8ZnJpZHJpY2guc3RyYmFAYmx1ZXdpbi5jaD4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggbGlua2luZyBpc3N1 ZXMgb2YgdGhlIEdUSysgcG9ydCBvbiBXaW5kb3dzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTg0NAorCisgICAgICAgICogR05VbWFrZWZpbGUuYW06 IGxpbmsgb24gV2luZG93cyB3aXRoIG9sZTMyLmRsbCwgd2lubW0uZGxsIGFuZCBzaGx3YXBpLmRs bAorICAgICAgICAqIGNvbmZpZ3VyZS5hYzogbGluayBvbiBXaW5kb3dzIHdpdGggb2xlMzIuZGxs LCB3aW5tbS5kbGwgYW5kIHNobHdhcGkuZGxsCisgICAgICAgIGFuZCBleHBvcnQgY29ycmVjdGx5 IGFsbCBuZWVkZWQgc3ltYm9scyBmcm9tIHRoZSBsaWJ3ZWJraXRndGsgRExMLgorCiAyMDEwLTA5 LTE0ICBBbmRyYXMgQmVjc2kgIDxhYmVjc2lAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBDc2FiYSBPc3p0cm9nb27DoWMuCkluZGV4OiBHTlVtYWtlZmlsZS5hbQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBHTlVtYWtlZmlsZS5hbQkocmV2aXNpb24gNjc1NjgpCisrKyBHTlVtYWtlZmlsZS5hbQko d29ya2luZyBjb3B5KQpAQCAtMTAxLDcgKzEwMSw3IEBAIGdsb2JhbF9jeHhmbGFncyArPSBcCiAj IEl0IGJyZWFrcyB0aGUgYnVpbGQgb24gb3RoZXIgcGxhdGZvcm1zLCBzbyB3ZSB1c2UgaXQgY29u ZGl0aW9uYWxseQogaWYgT1NfV0lOMzIKIG5vX3VuZGVmaW5lZCA9IC1uby11bmRlZmluZWQKLXZl cnNpb25fc2NyaXB0ID0gLWV4cG9ydC1zeW1ib2xzLXJlZ2V4ICJeKHdlYmtpdF98SlMpLioiCit2 ZXJzaW9uX3NjcmlwdCA9IC1leHBvcnQtc3ltYm9scy1yZWdleCAiXih3ZWJraXRffGs/SlMpLioi CiBlbmRpZgogCiBpZiBPU19HTlUKQEAgLTI0NSw3ICsyNDUsMTAgQEAgbGlid2Via2l0Z3RrX0BX RUJLSVRHVEtfQVBJX01BSk9SX1ZFUlNJTwogCSQoUE5HX0xJQlMpIFwKIAkkKFNRTElURTNfTElC UykgXAogCSQoVU5JQ09ERV9MSUJTKSBcCi0JJChYVF9MSUJTKQorCSQoWFRfTElCUykgXAorCSQo V0lOTU1fTElCUykgXAorCSQoU0hMV0FQSV9MSUJTKSBcCisJJChPTEUzMl9MSUJTKQogCiAjCiAj IEV4dHJhIGNoZWNrcyBhbmQgZmxhZ3MKSW5kZXg6IGNvbmZpZ3VyZS5hYwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBjb25maWd1cmUuYWMJKHJldmlzaW9uIDY3NTY4KQorKysgY29uZmlndXJlLmFjCSh3b3JraW5n IGNvcHkpCkBAIC0xNjcsNiArMTY3LDE3IEBAIGlmIHRlc3QgIiRwbmdfb2siICE9IHllczsgdGhl bgogZmkKIEFDX1NVQlNUKFtQTkdfTElCU10pCiAKKworaWYgdGVzdCAiJG9zX3dpbjMyIiA9ICJ5 ZXMiOyB0aGVuCisgIFdJTk1NX0xJQlM9LWx3aW5tbQorICBTSExXQVBJX0xJQlM9LWxzaGx3YXBp CisgIE9MRTMyX0xJQlM9LWxvbGUzMgorZmkKK0FDX1NVQlNUKFtXSU5NTV9MSUJTXSkKK0FDX1NV QlNUKFtTSExXQVBJX0xJQlNdKQorQUNfU1VCU1QoW09MRTMyX0xJQlNdKQorCisKICMgZGV0ZXJt aW5lIHRoZSBHVEsrIHZlcnNpb24gdG8gdXNlCiBBQ19NU0dfQ0hFQ0tJTkcoW3RoZSBHVEsrIHZl cnNpb24gdG8gdXNlXSkKIEFDX0FSR19XSVRIKFtndGtdLApJbmRleDogSmF2YVNjcmlwdENvcmUv Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNp b24gNjc1NzIpCisrKyBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxOSBAQAorMjAxMC0wOS0xNSAgRnJpZHJpY2ggU3RyYmEgIDxmcmlkcmljaC5zdHJi YUBibHVld2luLmNoPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEJ1aWxkIGlzc3VlcyB3aXRoIFdpbmRvd3MgdmVyc2lvbnMgb2YgdGhlIEdUSysgcG9y dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU4NDQK KworICAgICAgICBMaW5rIHdpdGggd2lubW0uZGxsIHdoZW4gbmVjZXNzYXJ5IGFuZCBzcGVjaWZ5 IHRoZSBleGVjdXRhYmxlIGV4dGVuc2lvbgorICAgICAgICBleHBsaWNpdGVseSBzbyB0aGF0IHRo ZSBQcm9ncmFtcy9qc2MtQFdFQktJVEdUS19BUElfTUFKT1JfVkVSU0lPTkAKKyAgICAgICAgcnVs ZSBhY3R1YWxseSB3b3Jrcy4KKworICAgICAgICBEb24ndCB0cnkgdG8gYnVpbGQgdGhlIFRocmVh ZFNwZWNpZmljV2luLmNwcCBzaW5jZSBHVEsrIHBvcnQgdXNlcworICAgICAgICBhIHNlY3Rpb24g aW4gVGhyZWFkU3BlY2lmaWMuY3BwCisKKyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbToKKwogMjAx MC0wOS0xNCAgSHl1bmcgU29uZyAgPGJlZXJndW5AY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgS2VudCBUYW11cmEuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9HTlVtYWtlZmls ZS5hbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9HTlVtYWtlZmlsZS5hbQkocmV2aXNp b24gNjc1NjgpCisrKyBKYXZhU2NyaXB0Q29yZS9HTlVtYWtlZmlsZS5hbQkod29ya2luZyBjb3B5 KQpAQCAtNTQ2LDcgKzU0Niw2IEBAIGphdmFzY3JpcHRjb3JlX3NvdXJjZXMgKz0gXAogCiBpZiBU QVJHRVRfV0lOMzIKIGphdmFzY3JpcHRjb3JlX3NvdXJjZXMgKz0gXAotCUphdmFTY3JpcHRDb3Jl L3d0Zi9UaHJlYWRTcGVjaWZpY1dpbi5jcHAgXAogCUphdmFTY3JpcHRDb3JlL3J1bnRpbWUvTWFy a1N0YWNrV2luLmNwcAogZWxzZQogamF2YXNjcmlwdGNvcmVfc291cmNlcyArPSBcCkBAIC01ODYs NyArNTg1LDcgQEAgSmF2YVNjcmlwdENvcmUvcGNyZS9jaGFydGFibGVzLmM6ICQoc3JjZAogCSQo QU1fVl9HRU4pJChQRVJMKSAkXiAkQAogCiBiaW5fUFJPR1JBTVMgKz0gXAotCVByb2dyYW1zL2pz Yy1AV0VCS0lUR1RLX0FQSV9NQUpPUl9WRVJTSU9OQAorCVByb2dyYW1zL2pzYy1AV0VCS0lUR1RL X0FQSV9NQUpPUl9WRVJTSU9OQCQoRVhFRVhUKQogCiBub2luc3RfUFJPR1JBTVMgKz0gXAogCVBy b2dyYW1zL2pzYyBcCkBAIC02MTYsNiArNjE1LDcgQEAgUHJvZ3JhbXNfbWluaWRvbV9DRkxBR1Mg PSBcCiAKIFByb2dyYW1zX21pbmlkb21fTERBREQgPSBcCiAJIGxpYkphdmFTY3JpcHRDb3JlLmxh IFwKKwkgJChXSU5NTV9MSUJTKSBcCiAJIC1sbSBcCiAJIC1sc3RkYysrCiAKQEAgLTYyNCw4ICs2 MjQsOCBAQCBQcm9ncmFtc19taW5pZG9tX0xERkxBR1MgPSBcCiAJLW5vLWZhc3QtaW5zdGFsbAog CiAjIGpzYwotUHJvZ3JhbXMvanNjLUBXRUJLSVRHVEtfQVBJX01BSk9SX1ZFUlNJT05AOiBQcm9n cmFtcy9qc2MKLQkkKEFNX1ZfR0VOKWNwIC1mIFByb2dyYW1zL2pzYyBQcm9ncmFtcy9qc2MtQFdF QktJVEdUS19BUElfTUFKT1JfVkVSU0lPTkAKK1Byb2dyYW1zL2pzYy1AV0VCS0lUR1RLX0FQSV9N QUpPUl9WRVJTSU9OQCQoRVhFRVhUKTogUHJvZ3JhbXMvanNjJChFWEVFWFQpCisJJChBTV9WX0dF TiljcCAtZiBQcm9ncmFtcy9qc2MkKEVYRUVYVCkgUHJvZ3JhbXMvanNjLUBXRUJLSVRHVEtfQVBJ X01BSk9SX1ZFUlNJT05AJChFWEVFWFQpCiBQcm9ncmFtc19qc2NfQFdFQktJVEdUS19BUElfTUFK T1JfVkVSU0lPTkBfTERBREQgPQogUHJvZ3JhbXNfanNjX0BXRUJLSVRHVEtfQVBJX01BSk9SX1ZF UlNJT05AX1NPVVJDRVMgPQogCkBAIC02NDQsNyArNjQ0LDggQEAgUHJvZ3JhbXNfanNjX0NYWEZM QUdTID0gXAogCSQoVU5JQ09ERV9DRkxBR1MpCiAKIFByb2dyYW1zX2pzY19MREFERCA9IFwKLQls aWJKYXZhU2NyaXB0Q29yZS5sYQorCWxpYkphdmFTY3JpcHRDb3JlLmxhIFwKKwkkKFdJTk1NX0xJ QlMpCiAKIEVYVFJBX0RJU1QgKz0gXAogCUphdmFTY3JpcHRDb3JlL0FVVEhPUlMgXApJbmRleDog V2ViS2l0VG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL0NoYW5nZUxv ZwkocmV2aXNpb24gNjc1NzIpCisrKyBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wOS0xNSAgRnJpZHJpY2ggU3RyYmEgIDxmcmlkcmlj aC5zdHJiYUBibHVld2luLmNoPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEZpeCBsaW5raW5nIHByb2JsZW1zIG9uIFdpbmRvd3MuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTg0NAorCisgICAgICAgICog R05VbWFrZWZpbGUuYW06IGxpbmsgdGhlIGV4ZWN1dGFibGVzIHdpdGggd2lubW0uZGxsCisKIDIw MTAtMDktMTQgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBXZWJLaXRUb29scy9HTlVtYWtlZmlsZS5hbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJLaXRUb29scy9HTlVtYWtlZmlsZS5hbQkocmV2aXNpb24gNjc1NjgpCisr KyBXZWJLaXRUb29scy9HTlVtYWtlZmlsZS5hbQkod29ya2luZyBjb3B5KQpAQCAtMjQsNyArMjQs OCBAQCBQcm9ncmFtc19HdGtMYXVuY2hlcl9DRkxBR1MgPSBcCiBQcm9ncmFtc19HdGtMYXVuY2hl cl9MREFERCA9IFwKIAlsaWJ3ZWJraXRndGstQFdFQktJVEdUS19BUElfTUFKT1JfVkVSU0lPTkAu QFdFQktJVEdUS19BUElfTUlOT1JfVkVSU0lPTkAubGEgXAogCSQoR1RLX0xJQlMpIFwKLQkkKEdM SUJfTElCUykKKwkkKEdMSUJfTElCUykgXAorCSQoV0lOTU1fTElCUykKIAogUHJvZ3JhbXNfR3Rr TGF1bmNoZXJfTERGTEFHUyA9IFwKIAktbm8tZmFzdC1pbnN0YWxsIFwKQEAgLTEwMCw3ICsxMDEs OCBAQCBQcm9ncmFtc19EdW1wUmVuZGVyVHJlZV9MREFERCA9IFwKIAkkKEdUS19MSUJTKSBcCiAJ JChHTElCX0xJQlMpIFwKIAkkKExJQlNPVVBfTElCUykgXAotCSQoRlJFRVRZUEVfTElCUykKKwkk KEZSRUVUWVBFX0xJQlMpIFwKKwkkKFdJTk1NX0xJQlMpCiAKIFByb2dyYW1zX0R1bXBSZW5kZXJU cmVlX0xERkxBR1MgPSBcCiAJLW5vLWZhc3QtaW5zdGFsbCBcCg==