4584 2005-08-22 04:31:51 -0700 run-webkit-tests should not print "actual expected diffs" when there are no diffs 2005-08-22 11:41:44 -0700 1 1 1 Unclassified WebKit Tools / Tests 420+ Mac OS X 10.4 RESOLVED FIXED P4 Normal --- 1 eric hyatt ben.lamonica oldest_to_newest 17114 0 eric 2005-08-22 04:31:51 -0700 run-webkit-tests should not print "actual expected diffs" when there are no diffs Sometimes when using the --pixel tests, there are failures only on the pixel side of things, which still causes the resulting failure to print "actual expected diffs" and link to the render dump, even though they are all empty. Furthermore, run-webkit-tests could differentiate between a render tree dump failure and a pixel dump failure when printing the -> failed messages (-> failed (pixel) ) , and also could include the percentage difference after ->failed (->failed (pixel: 15.5%), etc.) 17126 1 3516 tobiaslidskog 2005-08-22 08:50:36 -0700 Created attachment 3516 don't print layout diffs unless necessary This is a fix for the first part of this bug (run-webkit-tests should not print "actual expected diffs" when there are no diffs) 17128 2 tobiaslidskog 2005-08-22 08:53:17 -0700 Forgot to mention that the patch also assures that all rows in the result tables have the same number of td-cells. 17138 3 3516 darin 2005-08-22 11:14:17 -0700 Comment on attachment 3516 don't print layout diffs unless necessary Looks like this patch results in two extra cells when $pixelTests is 0. Should fix that. Otherwise, seems great. 17139 4 3519 tobiaslidskog 2005-08-22 11:24:44 -0700 Created attachment 3519 address darin's comments 17140 5 3519 darin 2005-08-22 11:31:06 -0700 Comment on attachment 3519 address darin's comments r=me 3516 2005-08-22 08:50:36 -0700 2005-08-22 11:24:44 -0700 don't print layout diffs unless necessary run-webkit-tests.diff text/plain 2203 tobiaslidskog SW5kZXg6IHJ1bi13ZWJraXQtdGVzdHMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dl YktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cyx2CnJldHJpZXZpbmcgcmV2aXNpb24g MS4xNQpkaWZmIC1wIC11IC1yMS4xNSBydW4td2Via2l0LXRlc3RzCi0tLSBydW4td2Via2l0LXRl c3RzCTIxIEF1ZyAyMDA1IDAwOjQ1OjA0IC0wMDAwCTEuMTUKKysrIHJ1bi13ZWJraXQtdGVzdHMJ MjIgQXVnIDIwMDUgMTU6NDY6MzUgLTAwMDAKQEAgLTQ0MywxNCArNDQzLDE4IEBAIGlmICgkY291 bnRze21hdGNofSAmJiAkY291bnRze21hdGNofSA9PSAKICAgICAgICAgICAgICRiYXNlID1+IHMv XC4oaHRtbHx4bWx8eGh0bWx8c3ZnKSQvLzsKICAgICAgICAgICAgIHByaW50IEhUTUwgIjx0cj5c biI7CiAgICAgICAgICAgICBwcmludCBIVE1MICI8dGQ+PGEgaHJlZj1cIiR0ZXN0RGlyZWN0b3J5 LyR0ZXN0XCI+JGJhc2U8L2E+PC90ZD5cbiI7Ci0gICAgICAgICAgICBwcmludCBIVE1MICI8dGQ+ PGEgaHJlZj1cIiR0ZXN0RGlyZWN0b3J5LyRiYXNlLWV4cGVjdGVkLnR4dFwiPmV4cGVjdGVkPC9h PjwvdGQ+XG4iOwotICAgICAgICAgICAgcHJpbnQgSFRNTCAiPHRkPjxhIGhyZWY9XCIkYmFzZS1h Y3R1YWwudHh0XCI+YWN0dWFsPC9hPjwvdGQ+XG4iOwotICAgICAgICAgICAgcHJpbnQgSFRNTCAi PHRkPjxhIGhyZWY9XCIkYmFzZS1kaWZmcy50eHRcIj5kaWZmczwvYT48L3RkPlxuIjsKLSAgICAg ICAgICAgIGlmICgkcGl4ZWxUZXN0cykgeworICAgICAgICAgICAgaWYgKC1zICIkdGVzdFJlc3Vs dHNEaXJlY3RvcnkvJGJhc2UtZGlmZnMudHh0IikgeworICAgICAgICAgICAgICAgIHByaW50IEhU TUwgIjx0ZD48YSBocmVmPVwiJHRlc3REaXJlY3RvcnkvJGJhc2UtZXhwZWN0ZWQudHh0XCI+ZXhw ZWN0ZWQ8L2E+PC90ZD5cbiI7CisgICAgICAgICAgICAgICAgcHJpbnQgSFRNTCAiPHRkPjxhIGhy ZWY9XCIkYmFzZS1hY3R1YWwudHh0XCI+YWN0dWFsPC9hPjwvdGQ+XG4iOworICAgICAgICAgICAg ICAgIHByaW50IEhUTUwgIjx0ZD48YSBocmVmPVwiJGJhc2UtZGlmZnMudHh0XCI+ZGlmZnM8L2E+ PC90ZD5cbiI7CisgICAgICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgICAgIHByaW50IEhU TUwgIjx0ZD48L3RkPjx0ZD48L3RkPjx0ZD48L3RkPlxuIjsKKyAgICAgICAgICAgIH0KKyAgICAg ICAgICAgIGlmICgkcGl4ZWxUZXN0cyAmJiAkaW1hZ2VzUHJlc2VudHskYmFzZX0pIHsKICAgICAg ICAgICAgICAgICBwcmludCBIVE1MICI8dGQ+PGEgaHJlZj1cIiR0ZXN0RGlyZWN0b3J5LyRiYXNl LWV4cGVjdGVkLnBuZ1wiPmV4cGVjdGVkIGltYWdlPC9hPjwvdGQ+XG4iOwotICAgICAgICAgICAg ICAgIGlmICgkaW1hZ2VzUHJlc2VudHskYmFzZX0pIHsKLSAgICAgICAgICAgICAgICAgICAgcHJp bnQgSFRNTCAiPHRkPjxhIGhyZWY9XCIkYmFzZS1kaWZmcy5odG1sXCI+aW1hZ2UgZGlmZnM8L2E+ PC90ZD5cbiI7Ci0gICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgIHByaW50IEhUTUwg Ijx0ZD48YSBocmVmPVwiJGJhc2UtZGlmZnMuaHRtbFwiPmltYWdlIGRpZmZzPC9hPjwvdGQ+XG4i OworICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICBwcmludCBIVE1MICI8dGQ+ PC90ZD48dGQ+PC90ZD5cbiI7CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBwcmludCBIVE1M ICI8L3RyPlxuIjsKICAgICAgICAgfQpAQCAtNDgxLDYgKzQ4NSw4IEBAIGlmICgkY291bnRze21h dGNofSAmJiAkY291bnRze21hdGNofSA9PSAKICAgICAgICAgICAgIHByaW50IEhUTUwgIjx0ZD48 YSBocmVmPVwiJHRlc3REaXJlY3RvcnkvJGJhc2UtZXhwZWN0ZWQudHh0XCI+cmVzdWx0czwvYT48 L3RkPlxuIjsKICAgICAgICAgICAgIGlmICgkcGl4ZWxUZXN0cykgewogICAgICAgICAgICAgICAg IHByaW50IEhUTUwgIjx0ZD48YSBocmVmPVwiJHRlc3REaXJlY3RvcnkvJGJhc2UtZXhwZWN0ZWQu cG5nXCI+aW1hZ2U8L2E+PC90ZD5cbiI7CisgICAgICAgICAgICB9IGVsc2UgeworICAgICAgICAg ICAgICAgIHByaW50IEhUTUwgIjx0ZD48L3RkPlxuIjsKICAgICAgICAgICAgIH0KICAgICAgICAg ICAgIHByaW50IEhUTUwgIjwvdHI+XG4iOwogICAgICAgICB9Cg== 3519 2005-08-22 11:24:44 -0700 2005-08-22 11:31:06 -0700 address darin's comments run-webkit-tests.diff text/plain 1796 tobiaslidskog SW5kZXg6IHJ1bi13ZWJraXQtdGVzdHMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dl YktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cyx2CnJldHJpZXZpbmcgcmV2aXNpb24g MS4xNQpkaWZmIC1wIC11IC1yMS4xNSBydW4td2Via2l0LXRlc3RzCi0tLSBydW4td2Via2l0LXRl c3RzCTIxIEF1ZyAyMDA1IDAwOjQ1OjA0IC0wMDAwCTEuMTUKKysrIHJ1bi13ZWJraXQtdGVzdHMJ MjIgQXVnIDIwMDUgMTg6MjQ6NDYgLTAwMDAKQEAgLTQ0MywxNCArNDQzLDIwIEBAIGlmICgkY291 bnRze21hdGNofSAmJiAkY291bnRze21hdGNofSA9PSAKICAgICAgICAgICAgICRiYXNlID1+IHMv XC4oaHRtbHx4bWx8eGh0bWx8c3ZnKSQvLzsKICAgICAgICAgICAgIHByaW50IEhUTUwgIjx0cj5c biI7CiAgICAgICAgICAgICBwcmludCBIVE1MICI8dGQ+PGEgaHJlZj1cIiR0ZXN0RGlyZWN0b3J5 LyR0ZXN0XCI+JGJhc2U8L2E+PC90ZD5cbiI7Ci0gICAgICAgICAgICBwcmludCBIVE1MICI8dGQ+ PGEgaHJlZj1cIiR0ZXN0RGlyZWN0b3J5LyRiYXNlLWV4cGVjdGVkLnR4dFwiPmV4cGVjdGVkPC9h PjwvdGQ+XG4iOwotICAgICAgICAgICAgcHJpbnQgSFRNTCAiPHRkPjxhIGhyZWY9XCIkYmFzZS1h Y3R1YWwudHh0XCI+YWN0dWFsPC9hPjwvdGQ+XG4iOwotICAgICAgICAgICAgcHJpbnQgSFRNTCAi PHRkPjxhIGhyZWY9XCIkYmFzZS1kaWZmcy50eHRcIj5kaWZmczwvYT48L3RkPlxuIjsKKyAgICAg ICAgICAgIGlmICgtcyAiJHRlc3RSZXN1bHRzRGlyZWN0b3J5LyRiYXNlLWRpZmZzLnR4dCIpIHsK KyAgICAgICAgICAgICAgICBwcmludCBIVE1MICI8dGQ+PGEgaHJlZj1cIiR0ZXN0RGlyZWN0b3J5 LyRiYXNlLWV4cGVjdGVkLnR4dFwiPmV4cGVjdGVkPC9hPjwvdGQ+XG4iOworICAgICAgICAgICAg ICAgIHByaW50IEhUTUwgIjx0ZD48YSBocmVmPVwiJGJhc2UtYWN0dWFsLnR4dFwiPmFjdHVhbDwv YT48L3RkPlxuIjsKKyAgICAgICAgICAgICAgICBwcmludCBIVE1MICI8dGQ+PGEgaHJlZj1cIiRi YXNlLWRpZmZzLnR4dFwiPmRpZmZzPC9hPjwvdGQ+XG4iOworICAgICAgICAgICAgfSBlbHNlIHsK KyAgICAgICAgICAgICAgICBwcmludCBIVE1MICI8dGQ+PC90ZD48dGQ+PC90ZD48dGQ+PC90ZD5c biI7CisgICAgICAgICAgICB9CiAgICAgICAgICAgICBpZiAoJHBpeGVsVGVzdHMpIHsKLSAgICAg ICAgICAgICAgICBwcmludCBIVE1MICI8dGQ+PGEgaHJlZj1cIiR0ZXN0RGlyZWN0b3J5LyRiYXNl LWV4cGVjdGVkLnBuZ1wiPmV4cGVjdGVkIGltYWdlPC9hPjwvdGQ+XG4iOwogICAgICAgICAgICAg ICAgIGlmICgkaW1hZ2VzUHJlc2VudHskYmFzZX0pIHsKKyAgICAgICAgICAgICAgICAgICAgcHJp bnQgSFRNTCAiPHRkPjxhIGhyZWY9XCIkdGVzdERpcmVjdG9yeS8kYmFzZS1leHBlY3RlZC5wbmdc Ij5leHBlY3RlZCBpbWFnZTwvYT48L3RkPlxuIjsKICAgICAgICAgICAgICAgICAgICAgcHJpbnQg SFRNTCAiPHRkPjxhIGhyZWY9XCIkYmFzZS1kaWZmcy5odG1sXCI+aW1hZ2UgZGlmZnM8L2E+PC90 ZD5cbiI7Ci0gICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgIH0gZWxzZSB7CisgICAg ICAgICAgICAgICAgICAgIHByaW50IEhUTUwgIjx0ZD48L3RkPjx0ZD48L3RkPlxuIjsKKyAgICAg ICAgICAgICAgICB9ICAgICAgICAgICAgCiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBwcmlu dCBIVE1MICI8L3RyPlxuIjsKICAgICAgICAgfQo=