45835 2010-09-15 14:03:40 -0700 Fix incorrect usage of dissolveDragImageToFraction 2010-09-16 11:07:03 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 dcheng webkit-unassigned commit-queue oldest_to_newest 279698 0 dcheng 2010-09-15 14:03:40 -0700 createDragImageForSelection() was ignoring the return value of dissolveDragImageToFraction(). This didn't happen to crash on most platforms, since most implementations simply modified the image that was passed in. However, Chromium Mac's implementation actually creates a new image and returns that instead. This caused us to crash when copying the image from the renderer to the browser process, since the memory had already been freed. 279703 1 67711 dcheng 2010-09-15 14:09:17 -0700 Created attachment 67711 Patch 279706 2 67711 tony 2010-09-15 14:14:32 -0700 Comment on attachment 67711 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67711&action=prettypatch Can you add a manual test in WebCore/manual-tests/chromium for this? 279730 3 67717 dcheng 2010-09-15 14:34:16 -0700 Created attachment 67717 Patch 279760 4 67728 dcheng 2010-09-15 15:18:30 -0700 Created attachment 67728 Patch 279775 5 67728 tony 2010-09-15 15:39:35 -0700 Comment on attachment 67728 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67728&action=prettypatch > WebCore/ChangeLog:16 > + * manual-tests/selection-drag-crash.html: Added. Please add a comment saying why this doesn't repro in DRT or test_shell. > WebCore/manual-tests/selection-drag-crash.html:6 > +function selectText() { > + window.getSelection().selectAllChildren(document.body); > +}; Nit: The semi-colon at the end of the test is not needed. 279785 6 67735 dcheng 2010-09-15 15:47:47 -0700 Created attachment 67735 Patch for landing 279795 7 67735 commit-queue 2010-09-15 16:03:55 -0700 Comment on attachment 67735 Patch for landing Rejecting patch 67735 from commit-queue. dcheng@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 279797 8 67735 tony 2010-09-15 16:06:23 -0700 Comment on attachment 67735 Patch for landing thought that might happen. let's try that again. 280085 9 67735 commit-queue 2010-09-16 07:48:18 -0700 Comment on attachment 67735 Patch for landing Rejecting patch 67735 from commit-queue. Unexpected failure when processing patch! Please file a bug against webkit-patch. Failed to run "['WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--non-interactive', '--ignore-builders', '--quiet', '--parent-command=commit-queue', 67735]" exit_code: 1 Last 500 characters of output: .cgi?id=67735&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=45835&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Updating working directory Processing patch 67735 from bug 45835. NOBODY (OOPS!) found in /Projects/CommitQueue/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /Projects/CommitQueue/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 280212 10 67735 commit-queue 2010-09-16 11:06:58 -0700 Comment on attachment 67735 Patch for landing Clearing flags on attachment: 67735 Committed r67641: <http://trac.webkit.org/changeset/67641> 280213 11 commit-queue 2010-09-16 11:07:03 -0700 All reviewed patches have been landed. Closing bug. 67711 2010-09-15 14:09:17 -0700 2010-09-15 14:34:13 -0700 Patch bug-45835-20100915140915.patch text/plain 1682 dcheng ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTJmYTJhYWUyNjNkMzAwNzRkMjI0Njc1MWE0MDVlMmQ1MTM3OGM3Ny4uMTQyOTJlNjc4NzQxY2Iw ODBmYzYxN2ZjZDcwMzY3YWYyZGQwZTZiZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0wOS0xNSAgRGFu aWVsIENoZW5nICA8ZGNoZW5nQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggaW5jb3JyZWN0IHVzYWdlIG9mIGRpc3NvbHZl RHJhZ0ltYWdlVG9GcmFjdGlvbigpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDU4MzUKKworICAgICAgICBjcmVhdGVEcmFnSW1hZ2VGb3JTZWxlY3Rp b24oKSB3YXMgaWdub3JpbmcgdGhlIHJldHVybiB2YWx1ZSBvZgorICAgICAgICBkaXNzb2x2ZURy YWdJbWFnZVRvRnJhY3Rpb24oKS4gVGhpcyBkaWRuJ3QgaGFwcGVuIHRvIGNyYXNoIG9uIG1vc3QK KyAgICAgICAgcGxhdGZvcm1zLCBzaW5jZSBtb3N0IGltcGxlbWVudGF0aW9ucyBzaW1wbHkgbW9k aWZpZWQgdGhlIGltYWdlIHRoYXQgd2FzCisgICAgICAgIHBhc3NlZCBpbi4gSG93ZXZlciwgQ2hy b21pdW0gTWFjJ3MgaW1wbGVtZW50YXRpb24gYWN0dWFsbHkgY3JlYXRlcyBhIG5ldworICAgICAg ICBpbWFnZSBhbmQgcmV0dXJucyB0aGF0IGluc3RlYWQuIFRoaXMgY2F1c2VkIHVzIHRvIGNyYXNo IHdoZW4gY29weWluZyB0aGUKKyAgICAgICAgaW1hZ2UgZnJvbSB0aGUgcmVuZGVyZXIgdG8gdGhl IGJyb3dzZXIgcHJvY2Vzcywgc2luY2UgdGhlIG1lbW9yeSBoYWQKKyAgICAgICAgYWxyZWFkeSBi ZWVuIGZyZWVkLgorCisgICAgICAgICogcGxhdGZvcm0vRHJhZ0ltYWdlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OmNyZWF0ZURyYWdJbWFnZUZvclNlbGVjdGlvbik6CisKIDIwMTAtMDktMTQgIFNp bW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgT2xpdmVyIEh1bnQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL0RyYWdJbWFnZS5j cHAgYi9XZWJDb3JlL3BsYXRmb3JtL0RyYWdJbWFnZS5jcHAKaW5kZXggYWZmNGFiYTY3ZmE0Mjcw ZTg4OTllMDU4NzA4MGZlYzM3MWUzNzBkYS4uNWZjYWZjMTYxOGZlOTRhYTQ4Y2I4OTM4MDM0ZDg3 NWE5M2FkYjZkZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9EcmFnSW1hZ2UuY3BwCisr KyBiL1dlYkNvcmUvcGxhdGZvcm0vRHJhZ0ltYWdlLmNwcApAQCAtNjksNyArNjksNyBAQCBEcmFn SW1hZ2VSZWYgY3JlYXRlRHJhZ0ltYWdlRm9yU2VsZWN0aW9uKEZyYW1lKiBmcmFtZSkKIHsKICAg ICBEcmFnSW1hZ2VSZWYgaW1hZ2UgPSBmcmFtZS0+ZHJhZ0ltYWdlRm9yU2VsZWN0aW9uKCk7CiAg ICAgaWYgKGltYWdlKQotICAgICAgICBkaXNzb2x2ZURyYWdJbWFnZVRvRnJhY3Rpb24oaW1hZ2Us IERyYWdDb250cm9sbGVyOjpEcmFnSW1hZ2VBbHBoYSk7CisgICAgICAgIGltYWdlID0gZGlzc29s dmVEcmFnSW1hZ2VUb0ZyYWN0aW9uKGltYWdlLCBEcmFnQ29udHJvbGxlcjo6RHJhZ0ltYWdlQWxw aGEpOwogICAgIHJldHVybiBpbWFnZTsKIH0KIAo= 67717 2010-09-15 14:34:16 -0700 2010-09-15 15:18:26 -0700 Patch bug-45835-20100915143415.patch text/plain 2343 dcheng ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTJmYTJhYWUyNjNkMzAwNzRkMjI0Njc1MWE0MDVlMmQ1MTM3OGM3Ny4uMTQ4YWEwMTc2MWQwZDgx ZDk2ODYxNDIzODUxZjU4ZmNiNzQ1NjFhYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0wOS0xNSAgRGFu aWVsIENoZW5nICA8ZGNoZW5nQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggaW5jb3JyZWN0IHVzYWdlIG9mIGRpc3NvbHZl RHJhZ0ltYWdlVG9GcmFjdGlvbigpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDU4MzUKKworICAgICAgICBjcmVhdGVEcmFnSW1hZ2VGb3JTZWxlY3Rp b24oKSB3YXMgaWdub3JpbmcgdGhlIHJldHVybiB2YWx1ZSBvZgorICAgICAgICBkaXNzb2x2ZURy YWdJbWFnZVRvRnJhY3Rpb24oKS4gVGhpcyBkaWRuJ3QgaGFwcGVuIHRvIGNyYXNoIG9uIG1vc3QK KyAgICAgICAgcGxhdGZvcm1zLCBzaW5jZSBtb3N0IGltcGxlbWVudGF0aW9ucyBzaW1wbHkgbW9k aWZpZWQgdGhlIGltYWdlIHRoYXQgd2FzCisgICAgICAgIHBhc3NlZCBpbi4gSG93ZXZlciwgQ2hy b21pdW0gTWFjJ3MgaW1wbGVtZW50YXRpb24gYWN0dWFsbHkgY3JlYXRlcyBhIG5ldworICAgICAg ICBpbWFnZSBhbmQgcmV0dXJucyB0aGF0IGluc3RlYWQuIFRoaXMgY2F1c2VkIHVzIHRvIGNyYXNo IHdoZW4gY29weWluZyB0aGUKKyAgICAgICAgaW1hZ2UgZnJvbSB0aGUgcmVuZGVyZXIgdG8gdGhl IGJyb3dzZXIgcHJvY2Vzcywgc2luY2UgdGhlIG1lbW9yeSBoYWQKKyAgICAgICAgYWxyZWFkeSBi ZWVuIGZyZWVkLgorCisgICAgICAgICogbWFudWFsLXRlc3RzL3NlbGVjdGlvbi1kcmFnLWNyYXNo Lmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL0RyYWdJbWFnZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpjcmVhdGVEcmFnSW1hZ2VGb3JTZWxlY3Rpb24pOgorCiAyMDEwLTA5LTE0ICBT aW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IE9saXZlciBIdW50LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9tYW51YWwtdGVzdHMvc2VsZWN0 aW9uLWRyYWctY3Jhc2guaHRtbCBiL1dlYkNvcmUvbWFudWFsLXRlc3RzL3NlbGVjdGlvbi1kcmFn LWNyYXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYWJmMDgwNzU4MTFkNmM0OTMzZGM0NTlhOWM2OWE2Zjdk NDUwZmZlOQotLS0gL2Rldi9udWxsCisrKyBiL1dlYkNvcmUvbWFudWFsLXRlc3RzL3NlbGVjdGlv bi1kcmFnLWNyYXNoLmh0bWwKQEAgLTAsMCArMSw1IEBACis8aHRtbD4KKzxib2R5PgorS2VlcCBz ZWxlY3RpbmcgdGV4dCBhbmQgZHJhZ2dpbmcgaXQuIEl0IHNob3VsZG4ndCBjcmFzaCwgdGhvdWdo IGl0IHVzZWQgdG8gb24gQ2hyb21pdW0gTWFjIHNpbmNlIGNyZWF0ZURyYWdJbWFnZUZvclNlbGVj dGlvbigpIGRpZG4ndCBwcm9wZXJseSB1c2UgdGhlIHJldHVybiB2YWx1ZSBmcm9tIGRpc3NvbHZl RHJhZ0ltYWdlVG9GcmFjdGlvbigpLCB3aGljaCByZXN1bHRlZCBpbiBhIHJhY2UgY29uZGl0aW9u IGZvciB0aGUgZHJhZyBpbWFnZSdzIHJlZmNvdW50LgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9EcmFnSW1hZ2UuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9E cmFnSW1hZ2UuY3BwCmluZGV4IGFmZjRhYmE2N2ZhNDI3MGU4ODk5ZTA1ODcwODBmZWMzNzFlMzcw ZGEuLjVmY2FmYzE2MThmZTk0YWE0OGNiODkzODAzNGQ4NzVhOTNhZGI2ZGQgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcGxhdGZvcm0vRHJhZ0ltYWdlLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL0Ry YWdJbWFnZS5jcHAKQEAgLTY5LDcgKzY5LDcgQEAgRHJhZ0ltYWdlUmVmIGNyZWF0ZURyYWdJbWFn ZUZvclNlbGVjdGlvbihGcmFtZSogZnJhbWUpCiB7CiAgICAgRHJhZ0ltYWdlUmVmIGltYWdlID0g ZnJhbWUtPmRyYWdJbWFnZUZvclNlbGVjdGlvbigpOwogICAgIGlmIChpbWFnZSkKLSAgICAgICAg ZGlzc29sdmVEcmFnSW1hZ2VUb0ZyYWN0aW9uKGltYWdlLCBEcmFnQ29udHJvbGxlcjo6RHJhZ0lt YWdlQWxwaGEpOworICAgICAgICBpbWFnZSA9IGRpc3NvbHZlRHJhZ0ltYWdlVG9GcmFjdGlvbihp bWFnZSwgRHJhZ0NvbnRyb2xsZXI6OkRyYWdJbWFnZUFscGhhKTsKICAgICByZXR1cm4gaW1hZ2U7 CiB9CiAK 67728 2010-09-15 15:18:30 -0700 2010-09-15 15:47:43 -0700 Patch bug-45835-20100915151828.patch text/plain 2492 dcheng ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTJmYTJhYWUyNjNkMzAwNzRkMjI0Njc1MWE0MDVlMmQ1MTM3OGM3Ny4uMTQ4YWEwMTc2MWQwZDgx ZDk2ODYxNDIzODUxZjU4ZmNiNzQ1NjFhYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0wOS0xNSAgRGFu aWVsIENoZW5nICA8ZGNoZW5nQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggaW5jb3JyZWN0IHVzYWdlIG9mIGRpc3NvbHZl RHJhZ0ltYWdlVG9GcmFjdGlvbigpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDU4MzUKKworICAgICAgICBjcmVhdGVEcmFnSW1hZ2VGb3JTZWxlY3Rp b24oKSB3YXMgaWdub3JpbmcgdGhlIHJldHVybiB2YWx1ZSBvZgorICAgICAgICBkaXNzb2x2ZURy YWdJbWFnZVRvRnJhY3Rpb24oKS4gVGhpcyBkaWRuJ3QgaGFwcGVuIHRvIGNyYXNoIG9uIG1vc3QK KyAgICAgICAgcGxhdGZvcm1zLCBzaW5jZSBtb3N0IGltcGxlbWVudGF0aW9ucyBzaW1wbHkgbW9k aWZpZWQgdGhlIGltYWdlIHRoYXQgd2FzCisgICAgICAgIHBhc3NlZCBpbi4gSG93ZXZlciwgQ2hy b21pdW0gTWFjJ3MgaW1wbGVtZW50YXRpb24gYWN0dWFsbHkgY3JlYXRlcyBhIG5ldworICAgICAg ICBpbWFnZSBhbmQgcmV0dXJucyB0aGF0IGluc3RlYWQuIFRoaXMgY2F1c2VkIHVzIHRvIGNyYXNo IHdoZW4gY29weWluZyB0aGUKKyAgICAgICAgaW1hZ2UgZnJvbSB0aGUgcmVuZGVyZXIgdG8gdGhl IGJyb3dzZXIgcHJvY2Vzcywgc2luY2UgdGhlIG1lbW9yeSBoYWQKKyAgICAgICAgYWxyZWFkeSBi ZWVuIGZyZWVkLgorCisgICAgICAgICogbWFudWFsLXRlc3RzL3NlbGVjdGlvbi1kcmFnLWNyYXNo Lmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL0RyYWdJbWFnZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpjcmVhdGVEcmFnSW1hZ2VGb3JTZWxlY3Rpb24pOgorCiAyMDEwLTA5LTE0ICBT aW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IE9saXZlciBIdW50LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9tYW51YWwtdGVzdHMvc2VsZWN0 aW9uLWRyYWctY3Jhc2guaHRtbCBiL1dlYkNvcmUvbWFudWFsLXRlc3RzL3NlbGVjdGlvbi1kcmFn LWNyYXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMWUwMGM4MzQ1OGE3YjE3ZTI1OTkxNTI2NzgxZTNhNTJk N2YwNzAxNwotLS0gL2Rldi9udWxsCisrKyBiL1dlYkNvcmUvbWFudWFsLXRlc3RzL3NlbGVjdGlv bi1kcmFnLWNyYXNoLmh0bWwKQEAgLTAsMCArMSwxNCBAQAorPGh0bWw+Cis8aGVhZD4KKzxzY3Jp cHQ+CitmdW5jdGlvbiBzZWxlY3RUZXh0KCkgeworICAgIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS5z ZWxlY3RBbGxDaGlsZHJlbihkb2N1bWVudC5ib2R5KTsKK307Cis8L3NjcmlwdD4KKzwvaGVhZD4K Kzxib2R5IG9ubG9hZD0ic2VsZWN0VGV4dCgpIj4KKzxwPgorRHJhZyB0aGUgc2VsZWN0ZWQgdGV4 dC4gSXQgc2hvdWxkbid0IGNyYXNoLCB0aG91Z2ggaXQgdXNlZCB0byBvbiBDaHJvbWl1bSBNYWMg c2luY2UgY3JlYXRlRHJhZ0ltYWdlRm9yU2VsZWN0aW9uKCkgZGlkbid0IHByb3Blcmx5IHVzZSB0 aGUgcmV0dXJuIHZhbHVlIGZyb20gZGlzc29sdmVEcmFnSW1hZ2VUb0ZyYWN0aW9uKCksIHdoaWNo IHJlc3VsdGVkIGluIGEgcmFjZSBjb25kaXRpb24gZm9yIHRoZSBkcmFnIGltYWdlJ3MgcmVmY291 bnQuCis8L3A+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3Jt L0RyYWdJbWFnZS5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL0RyYWdJbWFnZS5jcHAKaW5kZXggYWZm NGFiYTY3ZmE0MjcwZTg4OTllMDU4NzA4MGZlYzM3MWUzNzBkYS4uNWZjYWZjMTYxOGZlOTRhYTQ4 Y2I4OTM4MDM0ZDg3NWE5M2FkYjZkZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9EcmFn SW1hZ2UuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vRHJhZ0ltYWdlLmNwcApAQCAtNjksNyAr NjksNyBAQCBEcmFnSW1hZ2VSZWYgY3JlYXRlRHJhZ0ltYWdlRm9yU2VsZWN0aW9uKEZyYW1lKiBm cmFtZSkKIHsKICAgICBEcmFnSW1hZ2VSZWYgaW1hZ2UgPSBmcmFtZS0+ZHJhZ0ltYWdlRm9yU2Vs ZWN0aW9uKCk7CiAgICAgaWYgKGltYWdlKQotICAgICAgICBkaXNzb2x2ZURyYWdJbWFnZVRvRnJh Y3Rpb24oaW1hZ2UsIERyYWdDb250cm9sbGVyOjpEcmFnSW1hZ2VBbHBoYSk7CisgICAgICAgIGlt YWdlID0gZGlzc29sdmVEcmFnSW1hZ2VUb0ZyYWN0aW9uKGltYWdlLCBEcmFnQ29udHJvbGxlcjo6 RHJhZ0ltYWdlQWxwaGEpOwogICAgIHJldHVybiBpbWFnZTsKIH0KIAo= 67735 2010-09-15 15:47:47 -0700 2010-09-16 11:06:58 -0700 Patch for landing bug-45835-20100915154745.patch text/plain 2703 dcheng ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTJmYTJhYWUyNjNkMzAwNzRkMjI0Njc1MWE0MDVlMmQ1MTM3OGM3Ny4uMTQ4YWEwMTc2MWQwZDgx ZDk2ODYxNDIzODUxZjU4ZmNiNzQ1NjFhYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0wOS0xNSAgRGFu aWVsIENoZW5nICA8ZGNoZW5nQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggaW5jb3JyZWN0IHVzYWdlIG9mIGRpc3NvbHZl RHJhZ0ltYWdlVG9GcmFjdGlvbigpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDU4MzUKKworICAgICAgICBjcmVhdGVEcmFnSW1hZ2VGb3JTZWxlY3Rp b24oKSB3YXMgaWdub3JpbmcgdGhlIHJldHVybiB2YWx1ZSBvZgorICAgICAgICBkaXNzb2x2ZURy YWdJbWFnZVRvRnJhY3Rpb24oKS4gVGhpcyBkaWRuJ3QgaGFwcGVuIHRvIGNyYXNoIG9uIG1vc3QK KyAgICAgICAgcGxhdGZvcm1zLCBzaW5jZSBtb3N0IGltcGxlbWVudGF0aW9ucyBzaW1wbHkgbW9k aWZpZWQgdGhlIGltYWdlIHRoYXQgd2FzCisgICAgICAgIHBhc3NlZCBpbi4gSG93ZXZlciwgQ2hy b21pdW0gTWFjJ3MgaW1wbGVtZW50YXRpb24gYWN0dWFsbHkgY3JlYXRlcyBhIG5ldworICAgICAg ICBpbWFnZSBhbmQgcmV0dXJucyB0aGF0IGluc3RlYWQuIFRoaXMgY2F1c2VkIHVzIHRvIGNyYXNo IHdoZW4gY29weWluZyB0aGUKKyAgICAgICAgaW1hZ2UgZnJvbSB0aGUgcmVuZGVyZXIgdG8gdGhl IGJyb3dzZXIgcHJvY2Vzcywgc2luY2UgdGhlIG1lbW9yeSBoYWQKKyAgICAgICAgYWxyZWFkeSBi ZWVuIGZyZWVkLgorCisgICAgICAgICogbWFudWFsLXRlc3RzL3NlbGVjdGlvbi1kcmFnLWNyYXNo Lmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL0RyYWdJbWFnZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpjcmVhdGVEcmFnSW1hZ2VGb3JTZWxlY3Rpb24pOgorCiAyMDEwLTA5LTE0ICBT aW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IE9saXZlciBIdW50LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9tYW51YWwtdGVzdHMvc2VsZWN0 aW9uLWRyYWctY3Jhc2guaHRtbCBiL1dlYkNvcmUvbWFudWFsLXRlc3RzL3NlbGVjdGlvbi1kcmFn LWNyYXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNDJmZDc0MDE2ZTIyZTQ3MDhiMzA1MjY0NTM2MDRjMzg5 MjdkOGNiYgotLS0gL2Rldi9udWxsCisrKyBiL1dlYkNvcmUvbWFudWFsLXRlc3RzL3NlbGVjdGlv bi1kcmFnLWNyYXNoLmh0bWwKQEAgLTAsMCArMSwxNCBAQAorPGh0bWw+Cis8aGVhZD4KKzxzY3Jp cHQ+CitmdW5jdGlvbiBzZWxlY3RUZXh0KCkgeworICAgIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS5z ZWxlY3RBbGxDaGlsZHJlbihkb2N1bWVudC5ib2R5KTsKK30KKzwvc2NyaXB0PgorPC9oZWFkPgor PGJvZHkgb25sb2FkPSJzZWxlY3RUZXh0KCkiPgorPHA+CitEcmFnIHRoZSBzZWxlY3RlZCB0ZXh0 LiBJdCBzaG91bGRuJ3QgY3Jhc2gsIHRob3VnaCBpdCB1c2VkIHRvIG9uIENocm9taXVtIE1hYyBz aW5jZSBjcmVhdGVEcmFnSW1hZ2VGb3JTZWxlY3Rpb24oKSBkaWRuJ3QgcHJvcGVybHkgdXNlIHRo ZSByZXR1cm4gdmFsdWUgZnJvbSBkaXNzb2x2ZURyYWdJbWFnZVRvRnJhY3Rpb24oKSwgd2hpY2gg cmVzdWx0ZWQgaW4gYSByYWNlIGNvbmRpdGlvbiBmb3IgdGhlIGRyYWcgaW1hZ2UncyByZWZjb3Vu dC4gVGhpcyBpc3N1ZSBjYW4ndCBiZSB0ZXN0ZWQgaW4gYW4gYXV0b21hdGVkIG1hbm5lciwgZHVl IHRvIHRoZSBmYWN0IHRoYXQgdGhlIHJhY2UgY29uZGl0aW9uIGlzIGhhcmQgdG8gdHJpZ2dlciBk ZXRlcm1pbmlzdGljYWxseSBhbmQgdGhhdCB0ZXN0X3NoZWxsL0RSVCBzaW1wbHkgZG9uJ3QgdXNl IHRoZSAocG90ZW50aWFsbHkgaW52YWxpZCkgaW1hZ2UgcGFyYW1ldGVyLgorPC9wPgorPC9ib2R5 PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9EcmFnSW1hZ2UuY3BwIGIv V2ViQ29yZS9wbGF0Zm9ybS9EcmFnSW1hZ2UuY3BwCmluZGV4IGFmZjRhYmE2N2ZhNDI3MGU4ODk5 ZTA1ODcwODBmZWMzNzFlMzcwZGEuLjVmY2FmYzE2MThmZTk0YWE0OGNiODkzODAzNGQ4NzVhOTNh ZGI2ZGQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vRHJhZ0ltYWdlLmNwcAorKysgYi9X ZWJDb3JlL3BsYXRmb3JtL0RyYWdJbWFnZS5jcHAKQEAgLTY5LDcgKzY5LDcgQEAgRHJhZ0ltYWdl UmVmIGNyZWF0ZURyYWdJbWFnZUZvclNlbGVjdGlvbihGcmFtZSogZnJhbWUpCiB7CiAgICAgRHJh Z0ltYWdlUmVmIGltYWdlID0gZnJhbWUtPmRyYWdJbWFnZUZvclNlbGVjdGlvbigpOwogICAgIGlm IChpbWFnZSkKLSAgICAgICAgZGlzc29sdmVEcmFnSW1hZ2VUb0ZyYWN0aW9uKGltYWdlLCBEcmFn Q29udHJvbGxlcjo6RHJhZ0ltYWdlQWxwaGEpOworICAgICAgICBpbWFnZSA9IGRpc3NvbHZlRHJh Z0ltYWdlVG9GcmFjdGlvbihpbWFnZSwgRHJhZ0NvbnRyb2xsZXI6OkRyYWdJbWFnZUFscGhhKTsK ICAgICByZXR1cm4gaW1hZ2U7CiB9CiAK