45829 2010-09-15 13:24:13 -0700 [Chromium] Change WebHTTPBody::appendFileRange() to take a modification time instead of a WebFileInfo instance 2010-09-30 13:02:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dumi dumi dglazkov fishd webkit.review.bot oldest_to_newest 279670 0 dumi 2010-09-15 13:24:13 -0700 More data will be added to WebFileInfo (such as last access time, file size, etc.), which is not needed by WebHTTPBody::appendFileRange(), because that method only needs to know the last time a file was modified. We should change it to take a 'double modificationTime' argument directly, instead of taking a WebFileInfo instance. 279716 1 67714 dumi 2010-09-15 14:23:11 -0700 Created attachment 67714 patch #1: overload WebHTTPBody::appendFileRange() 279718 2 webkit.review.bot 2010-09-15 14:24:55 -0700 Attachment 67714 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/chromium/src/WebHTTPBody.cpp:137: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 279931 3 67767 dumi 2010-09-15 21:03:18 -0700 Created attachment 67767 patch #1: overload WebHTTPBody::appendFileRange() Fixed the style error. 279944 4 dumi 2010-09-15 22:47:50 -0700 patch #1 landed: r67598. 279947 5 67773 dumi 2010-09-15 22:53:25 -0700 Created attachment 67773 patch #2: remove WebHTTPBody::appendFileRange(..., const WebFileInfo&) 279950 6 webkit.review.bot 2010-09-15 23:06:30 -0700 Attachment 67773 did not build on chromium: Build output: http://queues.webkit.org/results/4026026 279952 7 dumi 2010-09-15 23:09:59 -0700 (In reply to comment #6) > Attachment 67773 [details] did not build on chromium: > Build output: http://queues.webkit.org/results/4026026 this is expected. the patch won't build until http://codereview.chromium.org/3405010 is submitted. 280534 8 dumi 2010-09-16 21:59:46 -0700 patch #2 landed: r67693. 280542 9 dumi 2010-09-16 22:28:38 -0700 Need to wait on WebKit to pick up a newer Chromium version that includes r59767 before re-landing patch #2... 280543 10 67885 dumi 2010-09-16 22:29:56 -0700 Created attachment 67885 patch #2: remove WebHTTPBody::appendFileRange(..., const WebFileInfo&) same patch. 281113 11 67773 eric 2010-09-18 03:21:29 -0700 Comment on attachment 67773 patch #2: remove WebHTTPBody::appendFileRange(..., const WebFileInfo&) Cleared Darin Fisher's review+ from obsolete attachment 67773 so that this bug does not appear in http://webkit.org/pending-commit. 287759 12 dumi 2010-09-30 13:02:32 -0700 re-landed: r68818. 67714 2010-09-15 14:23:11 -0700 2010-09-15 21:03:18 -0700 patch #1: overload WebHTTPBody::appendFileRange() patch text/plain 3739 dumi SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjc1NjcpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDktMTUgIER1bWl0 cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPdmVybG9hZCBXZWJIVFRQQm9keTo6YXBwZW5kRmls ZVJhbmdlKCkgdG8gdGFrZSBhIGRvdWJsZSBtb2RpZmljYXRpb24gdGltZSBhcmd1bWVudC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1ODI5CisKKyAg ICAgICAgVGhlIHBsYW4gaXMgdG8gY2hhbmdlIGFsbCBjYWxsZXJzIG9mCisgICAgICAgIFdlYkhU VFBCb2R5OjphcHBlbmRGaWxlUmFuZ2UoLi4uLCBjb25zdCBXZWJGaWxlSW5mbyYpIHRvIHVzZSB0 aGUKKyAgICAgICAgbmV3IG1ldGhvZCwgYW5kIHRoZW4gcmVtb3ZlIGl0LgorCisgICAgICAgICog cHVibGljL1dlYkhUVFBCb2R5Lmg6CisgICAgICAgICogc3JjL1dlYkhUVFBCb2R5LmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViSFRUUEJvZHk6OmVsZW1lbnRBdCk6CisgICAgICAgIChXZWJLaXQ6 OldlYkhUVFBCb2R5OjphcHBlbmRGaWxlUmFuZ2UpOgorCiAyMDEwLTA5LTE0ICBQYXZlbCBGZWxk bWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFl1cnkg U2VtaWtoYXRza3kuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkhUVFBCb2R5LmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJIVFRQQm9keS5oCShyZXZp c2lvbiA2NzU2NykKKysrIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSFRUUEJvZHkuaAkod29y a2luZyBjb3B5KQpAQCAtNTQsNyArNTQsOSBAQCBwdWJsaWM6CiAgICAgICAgIFdlYlN0cmluZyBm aWxlUGF0aDsKICAgICAgICAgbG9uZyBsb25nIGZpbGVTdGFydDsKICAgICAgICAgbG9uZyBsb25n IGZpbGVMZW5ndGg7IC8vIC0xIG1lYW5zIHRvIHRoZSBlbmQgb2YgdGhlIGZpbGUuCisgICAgICAg IC8vIEZJWE1FOiByZW1vdmUgdGhpcyBmaWVsZCBvbmNlIGFsbCB1c2VycyBvZiBFbGVtZW50IGhh dmUgYmVlbiBzd2l0Y2hlZCB0byB1c2UgJ21vZGlmaWNhdGlvblRpbWUnLgogICAgICAgICBXZWJG aWxlSW5mbyBmaWxlSW5mbzsKKyAgICAgICAgZG91YmxlIG1vZGlmaWNhdGlvblRpbWU7CiAgICAg ICAgIFdlYlVSTCBibG9iVVJMOwogICAgIH07CiAKQEAgLTg1LDYgKzg3LDggQEAgcHVibGljOgog ICAgIFdFQktJVF9BUEkgdm9pZCBhcHBlbmREYXRhKGNvbnN0IFdlYkRhdGEmKTsKICAgICBXRUJL SVRfQVBJIHZvaWQgYXBwZW5kRmlsZShjb25zdCBXZWJTdHJpbmcmKTsKICAgICAvLyBQYXNzaW5n IC0xIHRvIGZpbGVMZW5ndGggbWVhbnMgdG8gdGhlIGVuZCBvZiB0aGUgZmlsZS4KKyAgICBXRUJL SVRfQVBJIHZvaWQgYXBwZW5kRmlsZVJhbmdlKGNvbnN0IFdlYlN0cmluZyYsIGxvbmcgbG9uZyBm aWxlU3RhcnQsIGxvbmcgbG9uZyBmaWxlTGVuZ3RoLCBkb3VibGUgbW9kaWZpY2F0aW9uVGltZSk7 CisgICAgLy8gRklYTUU6IFJlbW92ZSB0aGlzIG1ldGhvZCBvbmNlIGFsbCBjYWxsZXJzIGhhdmUg YmVlbiBzd2l0Y2hlZCB0byB1c2UgdGhlIG1ldGhvZCBhYm92ZS4KICAgICBXRUJLSVRfQVBJIHZv aWQgYXBwZW5kRmlsZVJhbmdlKGNvbnN0IFdlYlN0cmluZyYsIGxvbmcgbG9uZyBmaWxlU3RhcnQs IGxvbmcgbG9uZyBmaWxlTGVuZ3RoLCBjb25zdCBXZWJGaWxlSW5mbyYpOwogICAgIFdFQktJVF9B UEkgdm9pZCBhcHBlbmRCbG9iKGNvbnN0IFdlYlVSTCYpOwogCkluZGV4OiBXZWJLaXQvY2hyb21p dW0vc3JjL1dlYkhUVFBCb2R5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3Jj L1dlYkhUVFBCb2R5LmNwcAkocmV2aXNpb24gNjc1NjcpCisrKyBXZWJLaXQvY2hyb21pdW0vc3Jj L1dlYkhUVFBCb2R5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTIsNyArOTIsOSBAQCBib29sIFdl YkhUVFBCb2R5OjplbGVtZW50QXQoc2l6ZV90IGluZGV4CiAjaWYgRU5BQkxFKEJMT0IpCiAgICAg ICAgIHJlc3VsdC5maWxlU3RhcnQgPSBlbGVtZW50Lm1fZmlsZVN0YXJ0OwogICAgICAgICByZXN1 bHQuZmlsZUxlbmd0aCA9IGVsZW1lbnQubV9maWxlTGVuZ3RoOworICAgICAgICAvLyBGSVhNRTog cmVtb3ZlIHRoaXMgbGluZSBvbmNlIGFsbCB1c2VycyBvZiBFbGVtZW50IGhhdmUgYmVlbiBzd2l0 Y2hlZCB0byB1c2UgJ21vZGlmaWNhdGlvblRpbWUnLgogICAgICAgICByZXN1bHQuZmlsZUluZm8u bW9kaWZpY2F0aW9uVGltZSA9IGVsZW1lbnQubV9leHBlY3RlZEZpbGVNb2RpZmljYXRpb25UaW1l OworICAgICAgICByZXN1bHQubW9kaWZpY2F0aW9uVGltZSA9IGVsZW1lbnQubV9leHBlY3RlZEZp bGVNb2RpZmljYXRpb25UaW1lOwogI2VuZGlmCiAgICAgICAgIGJyZWFrOwogI2lmIEVOQUJMRShC TE9CKQpAQCAtMTIzLDE0ICsxMjUsMTkgQEAgdm9pZCBXZWJIVFRQQm9keTo6YXBwZW5kRmlsZShj b25zdCBXZWJTdAogICAgIG1fcHJpdmF0ZS0+YXBwZW5kRmlsZShmaWxlUGF0aCk7CiB9CiAKLXZv aWQgV2ViSFRUUEJvZHk6OmFwcGVuZEZpbGVSYW5nZShjb25zdCBXZWJTdHJpbmcmIGZpbGVQYXRo LCBsb25nIGxvbmcgZmlsZVN0YXJ0LCBsb25nIGxvbmcgZmlsZUxlbmd0aCwgY29uc3QgV2ViRmls ZUluZm8mIGZpbGVJbmZvKQordm9pZCBXZWJIVFRQQm9keTo6YXBwZW5kRmlsZVJhbmdlKGNvbnN0 IFdlYlN0cmluZyYgZmlsZVBhdGgsIGxvbmcgbG9uZyBmaWxlU3RhcnQsIGxvbmcgbG9uZyBmaWxl TGVuZ3RoLCBkb3VibGUgbW9kaWZpY2F0aW9uVGltZSkKIHsKICNpZiBFTkFCTEUoQkxPQikKICAg ICBlbnN1cmVNdXRhYmxlKCk7Ci0gICAgbV9wcml2YXRlLT5hcHBlbmRGaWxlUmFuZ2UoZmlsZVBh dGgsIGZpbGVTdGFydCwgZmlsZUxlbmd0aCwgZmlsZUluZm8ubW9kaWZpY2F0aW9uVGltZSk7Cisg ICAgbV9wcml2YXRlLT5hcHBlbmRGaWxlUmFuZ2UoZmlsZVBhdGgsIGZpbGVTdGFydCwgZmlsZUxl bmd0aCwgbW9kaWZpY2F0aW9uVGltZSk7CiAjZW5kaWYKIH0KIAorLy8gRklYTUU6IFJlbW92ZSB0 aGlzIG1ldGhvZCBvbmNlIGFsbCBjYWxsZXJzIGhhdmUgYmVlbiBzd2l0Y2hlZCB0byB1c2UgdGhl IG1ldGhvZCBhYm92ZS4KK3ZvaWQgV2ViSFRUUEJvZHk6OmFwcGVuZEZpbGVSYW5nZShjb25zdCBX ZWJTdHJpbmcmIGZpbGVQYXRoLCBsb25nIGxvbmcgZmlsZVN0YXJ0LCBsb25nIGxvbmcgZmlsZUxl bmd0aCwgY29uc3QgV2ViRmlsZUluZm8mIGZpbGVJbmZvKSB7CisgICAgcmV0dXJuIGFwcGVuZEZp bGVSYW5nZShmaWxlUGF0aCwgZmlsZVN0YXJ0LCBmaWxlTGVuZ3RoLCBmaWxlSW5mby5tb2RpZmlj YXRpb25UaW1lKTsKK30KKwogdm9pZCBXZWJIVFRQQm9keTo6YXBwZW5kQmxvYihjb25zdCBXZWJV UkwmIGJsb2JVUkwpCiB7CiAjaWYgRU5BQkxFKEJMT0IpCg== 67767 2010-09-15 21:03:18 -0700 2010-09-15 22:32:40 -0700 patch #1: overload WebHTTPBody::appendFileRange() patch text/plain 4132 dumi SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjc1OTcpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDktMTUgIER1bWl0 cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPdmVybG9hZCBXZWJIVFRQQm9keTo6YXBwZW5kRmls ZVJhbmdlKCkgdG8gdGFrZSBhIGRvdWJsZSBtb2RpZmljYXRpb24gdGltZSBhcmd1bWVudC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1ODI5CisKKyAg ICAgICAgVGhlIHBsYW4gaXMgdG8gY2hhbmdlIGFsbCBjYWxsZXJzIG9mCisgICAgICAgIFdlYkhU VFBCb2R5OjphcHBlbmRGaWxlUmFuZ2UoLi4uLCBjb25zdCBXZWJGaWxlSW5mbyYpIHRvIHVzZSB0 aGUKKyAgICAgICAgbmV3IG1ldGhvZCwgYW5kIHRoZW4gcmVtb3ZlIGl0LgorCisgICAgICAgICog cHVibGljL1dlYkhUVFBCb2R5Lmg6CisgICAgICAgICogc3JjL1dlYkhUVFBCb2R5LmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViSFRUUEJvZHk6OmVsZW1lbnRBdCk6CisgICAgICAgIChXZWJLaXQ6 OldlYkhUVFBCb2R5OjphcHBlbmRGaWxlUmFuZ2UpOgorCiAyMDEwLTA5LTE0ICBQYXZlbCBGZWxk bWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFl1cnkg U2VtaWtoYXRza3kuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkhUVFBCb2R5LmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJIVFRQQm9keS5oCShyZXZp c2lvbiA2NzU5NykKKysrIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSFRUUEJvZHkuaAkod29y a2luZyBjb3B5KQpAQCAtNTQsNyArNTQsOSBAQCBwdWJsaWM6CiAgICAgICAgIFdlYlN0cmluZyBm aWxlUGF0aDsKICAgICAgICAgbG9uZyBsb25nIGZpbGVTdGFydDsKICAgICAgICAgbG9uZyBsb25n IGZpbGVMZW5ndGg7IC8vIC0xIG1lYW5zIHRvIHRoZSBlbmQgb2YgdGhlIGZpbGUuCisgICAgICAg IC8vIEZJWE1FOiByZW1vdmUgdGhpcyBmaWVsZCBvbmNlIGFsbCB1c2VycyBvZiBFbGVtZW50IGhh dmUgYmVlbiBzd2l0Y2hlZCB0byB1c2UgJ21vZGlmaWNhdGlvblRpbWUnLgogICAgICAgICBXZWJG aWxlSW5mbyBmaWxlSW5mbzsKKyAgICAgICAgZG91YmxlIG1vZGlmaWNhdGlvblRpbWU7CiAgICAg ICAgIFdlYlVSTCBibG9iVVJMOwogICAgIH07CiAKQEAgLTg1LDYgKzg3LDggQEAgcHVibGljOgog ICAgIFdFQktJVF9BUEkgdm9pZCBhcHBlbmREYXRhKGNvbnN0IFdlYkRhdGEmKTsKICAgICBXRUJL SVRfQVBJIHZvaWQgYXBwZW5kRmlsZShjb25zdCBXZWJTdHJpbmcmKTsKICAgICAvLyBQYXNzaW5n IC0xIHRvIGZpbGVMZW5ndGggbWVhbnMgdG8gdGhlIGVuZCBvZiB0aGUgZmlsZS4KKyAgICBXRUJL SVRfQVBJIHZvaWQgYXBwZW5kRmlsZVJhbmdlKGNvbnN0IFdlYlN0cmluZyYsIGxvbmcgbG9uZyBm aWxlU3RhcnQsIGxvbmcgbG9uZyBmaWxlTGVuZ3RoLCBkb3VibGUgbW9kaWZpY2F0aW9uVGltZSk7 CisgICAgLy8gRklYTUU6IFJlbW92ZSB0aGlzIG1ldGhvZCBvbmNlIGFsbCBjYWxsZXJzIGhhdmUg YmVlbiBzd2l0Y2hlZCB0byB1c2UgdGhlIG1ldGhvZCBhYm92ZS4KICAgICBXRUJLSVRfQVBJIHZv aWQgYXBwZW5kRmlsZVJhbmdlKGNvbnN0IFdlYlN0cmluZyYsIGxvbmcgbG9uZyBmaWxlU3RhcnQs IGxvbmcgbG9uZyBmaWxlTGVuZ3RoLCBjb25zdCBXZWJGaWxlSW5mbyYpOwogICAgIFdFQktJVF9B UEkgdm9pZCBhcHBlbmRCbG9iKGNvbnN0IFdlYlVSTCYpOwogCkluZGV4OiBXZWJLaXQvY2hyb21p dW0vc3JjL1dlYkhUVFBCb2R5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3Jj L1dlYkhUVFBCb2R5LmNwcAkocmV2aXNpb24gNjc1OTcpCisrKyBXZWJLaXQvY2hyb21pdW0vc3Jj L1dlYkhUVFBCb2R5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzgsNyArNzgsOSBAQCBib29sIFdl YkhUVFBCb2R5OjplbGVtZW50QXQoc2l6ZV90IGluZGV4CiAgICAgcmVzdWx0LmZpbGVQYXRoLnJl c2V0KCk7CiAgICAgcmVzdWx0LmZpbGVTdGFydCA9IDA7CiAgICAgcmVzdWx0LmZpbGVMZW5ndGgg PSAwOworICAgIC8vIEZJWE1FOiByZW1vdmUgdGhpcyBsaW5lIG9uY2UgYWxsIHVzZXJzIG9mIEVs ZW1lbnQgaGF2ZSBiZWVuIHN3aXRjaGVkIHRvIHVzZSAnbW9kaWZpY2F0aW9uVGltZScuCiAgICAg cmVzdWx0LmZpbGVJbmZvLm1vZGlmaWNhdGlvblRpbWUgPSAwLjA7CisgICAgcmVzdWx0Lm1vZGlm aWNhdGlvblRpbWUgPSAwLjA7CiAgICAgcmVzdWx0LmJsb2JVUkwgPSBLVVJMKCk7CiAKICAgICBz d2l0Y2ggKGVsZW1lbnQubV90eXBlKSB7CkBAIC05Miw3ICs5NCw5IEBAIGJvb2wgV2ViSFRUUEJv ZHk6OmVsZW1lbnRBdChzaXplX3QgaW5kZXgKICNpZiBFTkFCTEUoQkxPQikKICAgICAgICAgcmVz dWx0LmZpbGVTdGFydCA9IGVsZW1lbnQubV9maWxlU3RhcnQ7CiAgICAgICAgIHJlc3VsdC5maWxl TGVuZ3RoID0gZWxlbWVudC5tX2ZpbGVMZW5ndGg7CisgICAgICAgIC8vIEZJWE1FOiByZW1vdmUg dGhpcyBsaW5lIG9uY2UgYWxsIHVzZXJzIG9mIEVsZW1lbnQgaGF2ZSBiZWVuIHN3aXRjaGVkIHRv IHVzZSAnbW9kaWZpY2F0aW9uVGltZScuCiAgICAgICAgIHJlc3VsdC5maWxlSW5mby5tb2RpZmlj YXRpb25UaW1lID0gZWxlbWVudC5tX2V4cGVjdGVkRmlsZU1vZGlmaWNhdGlvblRpbWU7CisgICAg ICAgIHJlc3VsdC5tb2RpZmljYXRpb25UaW1lID0gZWxlbWVudC5tX2V4cGVjdGVkRmlsZU1vZGlm aWNhdGlvblRpbWU7CiAjZW5kaWYKICAgICAgICAgYnJlYWs7CiAjaWYgRU5BQkxFKEJMT0IpCkBA IC0xMjMsMTQgKzEyNywyMCBAQCB2b2lkIFdlYkhUVFBCb2R5OjphcHBlbmRGaWxlKGNvbnN0IFdl YlN0CiAgICAgbV9wcml2YXRlLT5hcHBlbmRGaWxlKGZpbGVQYXRoKTsKIH0KIAotdm9pZCBXZWJI VFRQQm9keTo6YXBwZW5kRmlsZVJhbmdlKGNvbnN0IFdlYlN0cmluZyYgZmlsZVBhdGgsIGxvbmcg bG9uZyBmaWxlU3RhcnQsIGxvbmcgbG9uZyBmaWxlTGVuZ3RoLCBjb25zdCBXZWJGaWxlSW5mbyYg ZmlsZUluZm8pCit2b2lkIFdlYkhUVFBCb2R5OjphcHBlbmRGaWxlUmFuZ2UoY29uc3QgV2ViU3Ry aW5nJiBmaWxlUGF0aCwgbG9uZyBsb25nIGZpbGVTdGFydCwgbG9uZyBsb25nIGZpbGVMZW5ndGgs IGRvdWJsZSBtb2RpZmljYXRpb25UaW1lKQogewogI2lmIEVOQUJMRShCTE9CKQogICAgIGVuc3Vy ZU11dGFibGUoKTsKLSAgICBtX3ByaXZhdGUtPmFwcGVuZEZpbGVSYW5nZShmaWxlUGF0aCwgZmls ZVN0YXJ0LCBmaWxlTGVuZ3RoLCBmaWxlSW5mby5tb2RpZmljYXRpb25UaW1lKTsKKyAgICBtX3By aXZhdGUtPmFwcGVuZEZpbGVSYW5nZShmaWxlUGF0aCwgZmlsZVN0YXJ0LCBmaWxlTGVuZ3RoLCBt b2RpZmljYXRpb25UaW1lKTsKICNlbmRpZgogfQogCisvLyBGSVhNRTogUmVtb3ZlIHRoaXMgbWV0 aG9kIG9uY2UgYWxsIGNhbGxlcnMgaGF2ZSBiZWVuIHN3aXRjaGVkIHRvIHVzZSB0aGUgbWV0aG9k IGFib3ZlLgordm9pZCBXZWJIVFRQQm9keTo6YXBwZW5kRmlsZVJhbmdlKGNvbnN0IFdlYlN0cmlu ZyYgZmlsZVBhdGgsIGxvbmcgbG9uZyBmaWxlU3RhcnQsIGxvbmcgbG9uZyBmaWxlTGVuZ3RoLCBj b25zdCBXZWJGaWxlSW5mbyYgZmlsZUluZm8pCit7CisgICAgcmV0dXJuIGFwcGVuZEZpbGVSYW5n ZShmaWxlUGF0aCwgZmlsZVN0YXJ0LCBmaWxlTGVuZ3RoLCBmaWxlSW5mby5tb2RpZmljYXRpb25U aW1lKTsKK30KKwogdm9pZCBXZWJIVFRQQm9keTo6YXBwZW5kQmxvYihjb25zdCBXZWJVUkwmIGJs b2JVUkwpCiB7CiAjaWYgRU5BQkxFKEJMT0IpCg== 67773 2010-09-15 22:53:25 -0700 2010-09-18 03:21:29 -0700 patch #2: remove WebHTTPBody::appendFileRange(..., const WebFileInfo&) patch text/plain 3574 dumi SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjc1OTgpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDktMTUgIER1bWl0 cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgV2ViSFRUUEJvZHk6OmFwcGVuZEZpbGVS YW5nZSguLi4sIGNvbnN0IFdlYkZpbGVJbmZvJikuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViSFRU UEJvZHkuaDoKKyAgICAgICAgKiBzcmMvV2ViSFRUUEJvZHkuY3BwOgorICAgICAgICAoV2ViS2l0 OjpXZWJIVFRQQm9keTo6ZWxlbWVudEF0KToKKwogMjAxMC0wOS0xNSAgRHVtaXRydSBEYW5pbGl1 YyAgPGR1bWlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hl ci4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSFRUUEJvZHkuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkhUVFBCb2R5LmgJKHJldmlzaW9uIDY3NTk4 KQorKysgV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJIVFRQQm9keS5oCSh3b3JraW5nIGNvcHkp CkBAIC0zMiw3ICszMiw2IEBACiAjZGVmaW5lIFdlYkhUVFBCb2R5X2gKIAogI2luY2x1ZGUgIldl YkRhdGEuaCIKLSNpbmNsdWRlICJXZWJGaWxlSW5mby5oIgogI2luY2x1ZGUgIldlYk5vbkNvcHlh YmxlLmgiCiAjaW5jbHVkZSAiV2ViU3RyaW5nLmgiCiAjaW5jbHVkZSAiV2ViVVJMLmgiCkBAIC01 NCw4ICs1Myw2IEBAIHB1YmxpYzoKICAgICAgICAgV2ViU3RyaW5nIGZpbGVQYXRoOwogICAgICAg ICBsb25nIGxvbmcgZmlsZVN0YXJ0OwogICAgICAgICBsb25nIGxvbmcgZmlsZUxlbmd0aDsgLy8g LTEgbWVhbnMgdG8gdGhlIGVuZCBvZiB0aGUgZmlsZS4KLSAgICAgICAgLy8gRklYTUU6IHJlbW92 ZSB0aGlzIGZpZWxkIG9uY2UgYWxsIHVzZXJzIG9mIEVsZW1lbnQgaGF2ZSBiZWVuIHN3aXRjaGVk IHRvIHVzZSAnbW9kaWZpY2F0aW9uVGltZScuCi0gICAgICAgIFdlYkZpbGVJbmZvIGZpbGVJbmZv OwogICAgICAgICBkb3VibGUgbW9kaWZpY2F0aW9uVGltZTsKICAgICAgICAgV2ViVVJMIGJsb2JV Ukw7CiAgICAgfTsKQEAgLTg4LDggKzg1LDYgQEAgcHVibGljOgogICAgIFdFQktJVF9BUEkgdm9p ZCBhcHBlbmRGaWxlKGNvbnN0IFdlYlN0cmluZyYpOwogICAgIC8vIFBhc3NpbmcgLTEgdG8gZmls ZUxlbmd0aCBtZWFucyB0byB0aGUgZW5kIG9mIHRoZSBmaWxlLgogICAgIFdFQktJVF9BUEkgdm9p ZCBhcHBlbmRGaWxlUmFuZ2UoY29uc3QgV2ViU3RyaW5nJiwgbG9uZyBsb25nIGZpbGVTdGFydCwg bG9uZyBsb25nIGZpbGVMZW5ndGgsIGRvdWJsZSBtb2RpZmljYXRpb25UaW1lKTsKLSAgICAvLyBG SVhNRTogUmVtb3ZlIHRoaXMgbWV0aG9kIG9uY2UgYWxsIGNhbGxlcnMgaGF2ZSBiZWVuIHN3aXRj aGVkIHRvIHVzZSB0aGUgbWV0aG9kIGFib3ZlLgotICAgIFdFQktJVF9BUEkgdm9pZCBhcHBlbmRG aWxlUmFuZ2UoY29uc3QgV2ViU3RyaW5nJiwgbG9uZyBsb25nIGZpbGVTdGFydCwgbG9uZyBsb25n IGZpbGVMZW5ndGgsIGNvbnN0IFdlYkZpbGVJbmZvJik7CiAgICAgV0VCS0lUX0FQSSB2b2lkIGFw cGVuZEJsb2IoY29uc3QgV2ViVVJMJik7CiAKICAgICAvLyBJZGVudGlmaWVzIGEgcGFydGljdWxh ciBmb3JtIHN1Ym1pc3Npb24gaW5zdGFuY2UuICBBIHZhbHVlIG9mIDAgaXMKSW5kZXg6IFdlYktp dC9jaHJvbWl1bS9zcmMvV2ViSFRUUEJvZHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJv bWl1bS9zcmMvV2ViSFRUUEJvZHkuY3BwCShyZXZpc2lvbiA2NzU5OCkKKysrIFdlYktpdC9jaHJv bWl1bS9zcmMvV2ViSFRUUEJvZHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw3ICszMiw2IEBA CiAjaW5jbHVkZSAiV2ViSFRUUEJvZHkuaCIKIAogI2luY2x1ZGUgIkZvcm1EYXRhLmgiCi0jaW5j bHVkZSAiV2ViRmlsZUluZm8uaCIKIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKQEAgLTc4 LDggKzc3LDYgQEAgYm9vbCBXZWJIVFRQQm9keTo6ZWxlbWVudEF0KHNpemVfdCBpbmRleAogICAg IHJlc3VsdC5maWxlUGF0aC5yZXNldCgpOwogICAgIHJlc3VsdC5maWxlU3RhcnQgPSAwOwogICAg IHJlc3VsdC5maWxlTGVuZ3RoID0gMDsKLSAgICAvLyBGSVhNRTogcmVtb3ZlIHRoaXMgbGluZSBv bmNlIGFsbCB1c2VycyBvZiBFbGVtZW50IGhhdmUgYmVlbiBzd2l0Y2hlZCB0byB1c2UgJ21vZGlm aWNhdGlvblRpbWUnLgotICAgIHJlc3VsdC5maWxlSW5mby5tb2RpZmljYXRpb25UaW1lID0gMC4w OwogICAgIHJlc3VsdC5tb2RpZmljYXRpb25UaW1lID0gMC4wOwogICAgIHJlc3VsdC5ibG9iVVJM ID0gS1VSTCgpOwogCkBAIC05NCw4ICs5MSw2IEBAIGJvb2wgV2ViSFRUUEJvZHk6OmVsZW1lbnRB dChzaXplX3QgaW5kZXgKICNpZiBFTkFCTEUoQkxPQikKICAgICAgICAgcmVzdWx0LmZpbGVTdGFy dCA9IGVsZW1lbnQubV9maWxlU3RhcnQ7CiAgICAgICAgIHJlc3VsdC5maWxlTGVuZ3RoID0gZWxl bWVudC5tX2ZpbGVMZW5ndGg7Ci0gICAgICAgIC8vIEZJWE1FOiByZW1vdmUgdGhpcyBsaW5lIG9u Y2UgYWxsIHVzZXJzIG9mIEVsZW1lbnQgaGF2ZSBiZWVuIHN3aXRjaGVkIHRvIHVzZSAnbW9kaWZp Y2F0aW9uVGltZScuCi0gICAgICAgIHJlc3VsdC5maWxlSW5mby5tb2RpZmljYXRpb25UaW1lID0g ZWxlbWVudC5tX2V4cGVjdGVkRmlsZU1vZGlmaWNhdGlvblRpbWU7CiAgICAgICAgIHJlc3VsdC5t b2RpZmljYXRpb25UaW1lID0gZWxlbWVudC5tX2V4cGVjdGVkRmlsZU1vZGlmaWNhdGlvblRpbWU7 CiAjZW5kaWYKICAgICAgICAgYnJlYWs7CkBAIC0xMzUsMTIgKzEzMCw2IEBAIHZvaWQgV2ViSFRU UEJvZHk6OmFwcGVuZEZpbGVSYW5nZShjb25zdCAKICNlbmRpZgogfQogCi0vLyBGSVhNRTogUmVt b3ZlIHRoaXMgbWV0aG9kIG9uY2UgYWxsIGNhbGxlcnMgaGF2ZSBiZWVuIHN3aXRjaGVkIHRvIHVz ZSB0aGUgbWV0aG9kIGFib3ZlLgotdm9pZCBXZWJIVFRQQm9keTo6YXBwZW5kRmlsZVJhbmdlKGNv bnN0IFdlYlN0cmluZyYgZmlsZVBhdGgsIGxvbmcgbG9uZyBmaWxlU3RhcnQsIGxvbmcgbG9uZyBm aWxlTGVuZ3RoLCBjb25zdCBXZWJGaWxlSW5mbyYgZmlsZUluZm8pCi17Ci0gICAgcmV0dXJuIGFw cGVuZEZpbGVSYW5nZShmaWxlUGF0aCwgZmlsZVN0YXJ0LCBmaWxlTGVuZ3RoLCBmaWxlSW5mby5t b2RpZmljYXRpb25UaW1lKTsKLX0KLQogdm9pZCBXZWJIVFRQQm9keTo6YXBwZW5kQmxvYihjb25z dCBXZWJVUkwmIGJsb2JVUkwpCiB7CiAjaWYgRU5BQkxFKEJMT0IpCg== 67885 2010-09-16 22:29:56 -0700 2010-09-16 22:54:29 -0700 patch #2: remove WebHTTPBody::appendFileRange(..., const WebFileInfo&) patch text/plain 3574 dumi SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjc1OTgpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDktMTUgIER1bWl0 cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgV2ViSFRUUEJvZHk6OmFwcGVuZEZpbGVS YW5nZSguLi4sIGNvbnN0IFdlYkZpbGVJbmZvJikuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViSFRU UEJvZHkuaDoKKyAgICAgICAgKiBzcmMvV2ViSFRUUEJvZHkuY3BwOgorICAgICAgICAoV2ViS2l0 OjpXZWJIVFRQQm9keTo6ZWxlbWVudEF0KToKKwogMjAxMC0wOS0xNSAgRHVtaXRydSBEYW5pbGl1 YyAgPGR1bWlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hl ci4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSFRUUEJvZHkuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkhUVFBCb2R5LmgJKHJldmlzaW9uIDY3NTk4 KQorKysgV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJIVFRQQm9keS5oCSh3b3JraW5nIGNvcHkp CkBAIC0zMiw3ICszMiw2IEBACiAjZGVmaW5lIFdlYkhUVFBCb2R5X2gKIAogI2luY2x1ZGUgIldl YkRhdGEuaCIKLSNpbmNsdWRlICJXZWJGaWxlSW5mby5oIgogI2luY2x1ZGUgIldlYk5vbkNvcHlh YmxlLmgiCiAjaW5jbHVkZSAiV2ViU3RyaW5nLmgiCiAjaW5jbHVkZSAiV2ViVVJMLmgiCkBAIC01 NCw4ICs1Myw2IEBAIHB1YmxpYzoKICAgICAgICAgV2ViU3RyaW5nIGZpbGVQYXRoOwogICAgICAg ICBsb25nIGxvbmcgZmlsZVN0YXJ0OwogICAgICAgICBsb25nIGxvbmcgZmlsZUxlbmd0aDsgLy8g LTEgbWVhbnMgdG8gdGhlIGVuZCBvZiB0aGUgZmlsZS4KLSAgICAgICAgLy8gRklYTUU6IHJlbW92 ZSB0aGlzIGZpZWxkIG9uY2UgYWxsIHVzZXJzIG9mIEVsZW1lbnQgaGF2ZSBiZWVuIHN3aXRjaGVk IHRvIHVzZSAnbW9kaWZpY2F0aW9uVGltZScuCi0gICAgICAgIFdlYkZpbGVJbmZvIGZpbGVJbmZv OwogICAgICAgICBkb3VibGUgbW9kaWZpY2F0aW9uVGltZTsKICAgICAgICAgV2ViVVJMIGJsb2JV Ukw7CiAgICAgfTsKQEAgLTg4LDggKzg1LDYgQEAgcHVibGljOgogICAgIFdFQktJVF9BUEkgdm9p ZCBhcHBlbmRGaWxlKGNvbnN0IFdlYlN0cmluZyYpOwogICAgIC8vIFBhc3NpbmcgLTEgdG8gZmls ZUxlbmd0aCBtZWFucyB0byB0aGUgZW5kIG9mIHRoZSBmaWxlLgogICAgIFdFQktJVF9BUEkgdm9p ZCBhcHBlbmRGaWxlUmFuZ2UoY29uc3QgV2ViU3RyaW5nJiwgbG9uZyBsb25nIGZpbGVTdGFydCwg bG9uZyBsb25nIGZpbGVMZW5ndGgsIGRvdWJsZSBtb2RpZmljYXRpb25UaW1lKTsKLSAgICAvLyBG SVhNRTogUmVtb3ZlIHRoaXMgbWV0aG9kIG9uY2UgYWxsIGNhbGxlcnMgaGF2ZSBiZWVuIHN3aXRj aGVkIHRvIHVzZSB0aGUgbWV0aG9kIGFib3ZlLgotICAgIFdFQktJVF9BUEkgdm9pZCBhcHBlbmRG aWxlUmFuZ2UoY29uc3QgV2ViU3RyaW5nJiwgbG9uZyBsb25nIGZpbGVTdGFydCwgbG9uZyBsb25n IGZpbGVMZW5ndGgsIGNvbnN0IFdlYkZpbGVJbmZvJik7CiAgICAgV0VCS0lUX0FQSSB2b2lkIGFw cGVuZEJsb2IoY29uc3QgV2ViVVJMJik7CiAKICAgICAvLyBJZGVudGlmaWVzIGEgcGFydGljdWxh ciBmb3JtIHN1Ym1pc3Npb24gaW5zdGFuY2UuICBBIHZhbHVlIG9mIDAgaXMKSW5kZXg6IFdlYktp dC9jaHJvbWl1bS9zcmMvV2ViSFRUUEJvZHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJv bWl1bS9zcmMvV2ViSFRUUEJvZHkuY3BwCShyZXZpc2lvbiA2NzU5OCkKKysrIFdlYktpdC9jaHJv bWl1bS9zcmMvV2ViSFRUUEJvZHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw3ICszMiw2IEBA CiAjaW5jbHVkZSAiV2ViSFRUUEJvZHkuaCIKIAogI2luY2x1ZGUgIkZvcm1EYXRhLmgiCi0jaW5j bHVkZSAiV2ViRmlsZUluZm8uaCIKIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKQEAgLTc4 LDggKzc3LDYgQEAgYm9vbCBXZWJIVFRQQm9keTo6ZWxlbWVudEF0KHNpemVfdCBpbmRleAogICAg IHJlc3VsdC5maWxlUGF0aC5yZXNldCgpOwogICAgIHJlc3VsdC5maWxlU3RhcnQgPSAwOwogICAg IHJlc3VsdC5maWxlTGVuZ3RoID0gMDsKLSAgICAvLyBGSVhNRTogcmVtb3ZlIHRoaXMgbGluZSBv bmNlIGFsbCB1c2VycyBvZiBFbGVtZW50IGhhdmUgYmVlbiBzd2l0Y2hlZCB0byB1c2UgJ21vZGlm aWNhdGlvblRpbWUnLgotICAgIHJlc3VsdC5maWxlSW5mby5tb2RpZmljYXRpb25UaW1lID0gMC4w OwogICAgIHJlc3VsdC5tb2RpZmljYXRpb25UaW1lID0gMC4wOwogICAgIHJlc3VsdC5ibG9iVVJM ID0gS1VSTCgpOwogCkBAIC05NCw4ICs5MSw2IEBAIGJvb2wgV2ViSFRUUEJvZHk6OmVsZW1lbnRB dChzaXplX3QgaW5kZXgKICNpZiBFTkFCTEUoQkxPQikKICAgICAgICAgcmVzdWx0LmZpbGVTdGFy dCA9IGVsZW1lbnQubV9maWxlU3RhcnQ7CiAgICAgICAgIHJlc3VsdC5maWxlTGVuZ3RoID0gZWxl bWVudC5tX2ZpbGVMZW5ndGg7Ci0gICAgICAgIC8vIEZJWE1FOiByZW1vdmUgdGhpcyBsaW5lIG9u Y2UgYWxsIHVzZXJzIG9mIEVsZW1lbnQgaGF2ZSBiZWVuIHN3aXRjaGVkIHRvIHVzZSAnbW9kaWZp Y2F0aW9uVGltZScuCi0gICAgICAgIHJlc3VsdC5maWxlSW5mby5tb2RpZmljYXRpb25UaW1lID0g ZWxlbWVudC5tX2V4cGVjdGVkRmlsZU1vZGlmaWNhdGlvblRpbWU7CiAgICAgICAgIHJlc3VsdC5t b2RpZmljYXRpb25UaW1lID0gZWxlbWVudC5tX2V4cGVjdGVkRmlsZU1vZGlmaWNhdGlvblRpbWU7 CiAjZW5kaWYKICAgICAgICAgYnJlYWs7CkBAIC0xMzUsMTIgKzEzMCw2IEBAIHZvaWQgV2ViSFRU UEJvZHk6OmFwcGVuZEZpbGVSYW5nZShjb25zdCAKICNlbmRpZgogfQogCi0vLyBGSVhNRTogUmVt b3ZlIHRoaXMgbWV0aG9kIG9uY2UgYWxsIGNhbGxlcnMgaGF2ZSBiZWVuIHN3aXRjaGVkIHRvIHVz ZSB0aGUgbWV0aG9kIGFib3ZlLgotdm9pZCBXZWJIVFRQQm9keTo6YXBwZW5kRmlsZVJhbmdlKGNv bnN0IFdlYlN0cmluZyYgZmlsZVBhdGgsIGxvbmcgbG9uZyBmaWxlU3RhcnQsIGxvbmcgbG9uZyBm aWxlTGVuZ3RoLCBjb25zdCBXZWJGaWxlSW5mbyYgZmlsZUluZm8pCi17Ci0gICAgcmV0dXJuIGFw cGVuZEZpbGVSYW5nZShmaWxlUGF0aCwgZmlsZVN0YXJ0LCBmaWxlTGVuZ3RoLCBmaWxlSW5mby5t b2RpZmljYXRpb25UaW1lKTsKLX0KLQogdm9pZCBXZWJIVFRQQm9keTo6YXBwZW5kQmxvYihjb25z dCBXZWJVUkwmIGJsb2JVUkwpCiB7CiAjaWYgRU5BQkxFKEJMT0IpCg==