45821 2010-09-15 09:21:28 -0700 Remove extraneous RenderObject traversal. 2010-09-17 09:14:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dglazkov dglazkov abarth aroben mjs oldest_to_newest 279575 0 dglazkov 2010-09-15 09:21:28 -0700 Remove extraneous RenderObject traversal. 279578 1 67683 dglazkov 2010-09-15 09:29:08 -0700 Created attachment 67683 Patch 279579 2 dglazkov 2010-09-15 09:31:53 -0700 The code being removed always exits in the first iteration of the loop, because in the context of this call, node->renderer()->node() != 0 is always true. Ran tests to make sure there are no regressions. 280159 3 67683 hyatt 2010-09-16 09:54:21 -0700 Comment on attachment 67683 Patch r=me... wish I knew what the original code was trying to do, but it's definitely just equivalent to node->dispatchEvent. 280673 4 67683 dglazkov 2010-09-17 09:14:11 -0700 Comment on attachment 67683 Patch Clearing flags on attachment: 67683 Committed r67710: <http://trac.webkit.org/changeset/67710> 280674 5 dglazkov 2010-09-17 09:14:15 -0700 All reviewed patches have been landed. Closing bug. 67683 2010-09-15 09:29:08 -0700 2010-09-17 09:14:10 -0700 Patch bug-45821-20100915092907.patch text/plain 2206 dglazkov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTU5ODI3NzNhYTQxYTA0ZjFiZjRjYzQxNWE2M2UwYjcxMDM5ZmQxMy4uMTlkODE1OGZlZWYxNzI1 ZjQ1MzljMTA0ZmEzNTJmMmE2ZDRjZDBmYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wOS0xNSAgRGlt aXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBleHRyYW5lb3VzIFJlbmRlck9i amVjdCB0cmF2ZXJzYWwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00NTgyMQorCisgICAgICAgIFRoaXMgY29kZSBhbHdheXMgZXhpdHMgaW4gdGhlIGZp cnN0IGl0ZXJhdGlvbiBvZiB0aGUgbG9vcCwKKyAgICAgICAgYmVjYXVzZSBpbiB0aGUgY29udGV4 dCBvZiB0aGlzIGNhbGwsIG5vZGUtPnJlbmRlcmVyKCktPm5vZGUoKSAhPSAwCisgICAgICAgIGlz IGFsd2F5cyB0cnVlLgorCisgICAgICAgIE5vIGJlaGF2aW9yIGNoYW5nZSwgY292ZXJlZCBieSBl eGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6Y2FuTW91c2VEb3duU3RhcnRTZWxlY3QpOiBSZW1v dmVkIHRoZSBsb29wLgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpjYW5Nb3VzZURy YWdFeHRlbmRTZWxlY3QpOiBEaXR0by4KKwogMjAxMC0wOS0xNCAgUGF2ZWwgRmVsZG1hbiAgPHBm ZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0 c2t5LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9XZWJDb3Jl L3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAppbmRleCBiZWM1NWRlOWMwNmI1ZWIzODM4YWY5NmY1MjZh ZGMxZjkzNjUzZmQ1Li4xZTg0NTkwYjRkYmY1YzU0MmRmZjk2MzJkNDgyYzE1NDljMmYxNmUzIDEw MDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAorKysgYi9XZWJDb3JlL3Bh Z2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtMjE1MCwxMiArMjE1MCw3IEBAIGJvb2wgRXZlbnRIYW5k bGVyOjpjYW5Nb3VzZURvd25TdGFydFNlbGVjdChOb2RlKiBub2RlKQogICAgIGlmICghbm9kZS0+ Y2FuU3RhcnRTZWxlY3Rpb24oKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICAgICAg Ci0gICAgZm9yIChSZW5kZXJPYmplY3QqIGN1cnIgPSBub2RlLT5yZW5kZXJlcigpOyBjdXJyOyBj dXJyID0gY3Vyci0+cGFyZW50KCkpIHsKLSAgICAgICAgaWYgKE5vZGUqIG5vZGUgPSBjdXJyLT5u b2RlKCkpCi0gICAgICAgICAgICByZXR1cm4gbm9kZS0+ZGlzcGF0Y2hFdmVudChFdmVudDo6Y3Jl YXRlKGV2ZW50TmFtZXMoKS5zZWxlY3RzdGFydEV2ZW50LCB0cnVlLCB0cnVlKSk7Ci0gICAgfQot Ci0gICAgcmV0dXJuIHRydWU7CisgICAgcmV0dXJuIG5vZGUtPmRpc3BhdGNoRXZlbnQoRXZlbnQ6 OmNyZWF0ZShldmVudE5hbWVzKCkuc2VsZWN0c3RhcnRFdmVudCwgdHJ1ZSwgdHJ1ZSkpOwogfQog CiAjaWYgRU5BQkxFKERSQUdfU1VQUE9SVCkKQEAgLTIxNjQsMTIgKzIxNTksNyBAQCBib29sIEV2 ZW50SGFuZGxlcjo6Y2FuTW91c2VEcmFnRXh0ZW5kU2VsZWN0KE5vZGUqIG5vZGUpCiAgICAgaWYg KCFub2RlIHx8ICFub2RlLT5yZW5kZXJlcigpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAg ICAgICAgIAotICAgIGZvciAoUmVuZGVyT2JqZWN0KiBjdXJyID0gbm9kZS0+cmVuZGVyZXIoKTsg Y3VycjsgY3VyciA9IGN1cnItPnBhcmVudCgpKSB7Ci0gICAgICAgIGlmIChOb2RlKiBub2RlID0g Y3Vyci0+bm9kZSgpKQotICAgICAgICAgICAgcmV0dXJuIG5vZGUtPmRpc3BhdGNoRXZlbnQoRXZl bnQ6OmNyZWF0ZShldmVudE5hbWVzKCkuc2VsZWN0c3RhcnRFdmVudCwgdHJ1ZSwgdHJ1ZSkpOwot ICAgIH0KLQotICAgIHJldHVybiB0cnVlOworICAgIHJldHVybiBub2RlLT5kaXNwYXRjaEV2ZW50 KEV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygpLnNlbGVjdHN0YXJ0RXZlbnQsIHRydWUsIHRydWUp KTsKIH0KICNlbmRpZiAvLyBFTkFCTEUoRFJBR19TVVBQT1JUKQogCg==