45807 2010-09-14 23:46:31 -0700 Web Inspector: Multiline console does not work on Windows / Linux 2010-11-05 07:27:25 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman andyearnshaw bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 279409 0 pfeldman 2010-09-14 23:46:31 -0700 Reason: Alt+Enter is handled before it gets to the inspected page. I'll add Ctrl+Enter handler and make it work on all platforms. As a result, Mac users get Alt | Ctrl, Linux and Windows users get Ctrl+Enter. 279411 1 67648 pfeldman 2010-09-14 23:49:11 -0700 Created attachment 67648 [PATCH] Proposed fix. 279478 2 67648 commit-queue 2010-09-15 02:44:47 -0700 Comment on attachment 67648 [PATCH] Proposed fix. Clearing flags on attachment: 67648 Committed r67545: <http://trac.webkit.org/changeset/67545> 279479 3 commit-queue 2010-09-15 02:44:51 -0700 All reviewed patches have been landed. Closing bug. 305239 4 andyearnshaw 2010-11-05 06:00:02 -0700 Why isn't it Shift + Enter? Most instant messaging apps use Shift+Enter for multi-line messages and Firefox's console uses the same combination. Shift+Enter would feel more natural for most Windows users, please change this. 305268 5 pfeldman 2010-11-05 07:27:25 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ConsoleView.js M WebCore/inspector/front-end/NetworkPanel.js M WebCore/inspector/front-end/StoragePanel.js M WebCore/inspector/front-end/inspector.js Committed r71413 (added shift+Enter modifier as a drive-by) 67648 2010-09-14 23:49:11 -0700 2010-09-15 02:44:47 -0700 [PATCH] Proposed fix. ml_console text/plain 951 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzFkY2NlZi4uZjEzMTE2MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wOS0xNCAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBNdWx0aWxpbmUgY29uc29sZSBkb2Vz IG5vdCB3b3JrIG9uIFdpbmRvd3MgLyBMaW51eC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1ODA3CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQt ZW5kL0NvbnNvbGVWaWV3LmpzOgorCiAyMDEwLTA5LTE0ICBEYW4gQmVybnN0ZWluICA8bWl0ekBh cHBsZS5jb20+CiAKICAgICAgICAgQnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL0NvbnNvbGVWaWV3LmpzCmluZGV4IDk3ODVjZDAuLmRmYjFlMjYgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5qcworKysgYi9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMKQEAgLTUxOCw3ICs1MTgsNyBAQCBXZWJJ bnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90eXBlID0gewogCiAgICAgX2VudGVyS2V5UHJlc3Nl ZDogZnVuY3Rpb24oZXZlbnQpCiAgICAgewotICAgICAgICBpZiAoZXZlbnQuYWx0S2V5KQorICAg ICAgICBpZiAoZXZlbnQuYWx0S2V5IHx8IGV2ZW50LmN0cmxLZXkpCiAgICAgICAgICAgICByZXR1 cm47CiAKICAgICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsK