4580 2005-08-22 01:37:18 -0700 WebCore+SVG asserts when running JavaScript 2005-08-22 11:18:39 -0700 1 1 1 Unclassified WebKit SVG 420+ Mac OS X 10.4 RESOLVED FIXED P4 Normal --- 1 eric eric oldest_to_newest 17095 0 eric 2005-08-22 01:37:18 -0700 As part of recent changes in JSC, more Interpreter::lockCount() asserts were added, thus causing WebCore +SVG to fail in more places. Attached is an example SVG which asserts. 17097 1 3505 eric 2005-08-22 01:38:03 -0700 Created attachment 3505 A simple javascript SVG which asserts 17100 2 3507 eric 2005-08-22 02:01:58 -0700 Created attachment 3507 Adds necessary Interpreter::lock()/unlock() calls. 17122 3 3507 darin 2005-08-22 08:18:36 -0700 Comment on attachment 3507 Adds necessary Interpreter::lock()/unlock() calls. Looks fine. The APPLE_CHANGES should not be necessary, because the lock/unlock functions should be empty inlines when locking is not necessary, but I guess that's not how JavaScriptCore is right now. r=me 3505 2005-08-22 01:38:03 -0700 2005-08-22 01:38:03 -0700 A simple javascript SVG which asserts Simple Clock (JavaScript).svg image/svg+xml 2377 eric PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4NCjxzdmcgdmVyc2lvbj0iMS4w IiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdpZHRoPSIyMDBweCIgaGVpZ2h0 PSIyODBweCI+DQoJPGcgdHJhbnNmb3JtPSJ0cmFuc2xhdGUoMTAwLDEwMCkgcm90YXRlKC05MCki Pg0KCQk8Y2lyY2xlIHI9IjEwMCIgZmlsbD0id2hpdGUiIHN0cm9rPSJibGFjayIgc3Ryb2tlLXdp ZHRoPSIycHgiLz4NCg0KCQk8ZyBzdHlsZT0ic3Ryb2tlLWxpbmVjYXA6IHJvdW5kOyBzdHJva2U6 IGJsYWNrOyBzdHJva2Utd2lkdGg6IDJweDsiPg0KCQk8bGluZSB4MT0iMTAwIiAgeTE9IjAiICAg IHgyPSI5MCIgICB5Mj0iMCIgIC8+DQoJCTxsaW5lIHgxPSI4NyIgICB5MT0iNTAiICAgeDI9Ijc4 IiAgIHkyPSI0NSIgLz4NCgkJPGxpbmUgeDE9IjUwIiAgIHkxPSI4NyIgICB4Mj0iNDUiICAgeTI9 Ijc4IiAvPg0KCQk8bGluZSB4MT0iMCIgICAgeTE9IjEwMCIgIHgyPSIwIiAgICB5Mj0iOTAiIC8+ DQoJCTxsaW5lIHgxPSItNTAiICB5MT0iODciICAgeDI9Ii00NSIgIHkyPSI3OCIgLz4NCgkJPGxp bmUgeDE9Ii04NyIgIHkxPSI1MCIgICB4Mj0iLTc4IiAgeTI9IjQ1IiAvPg0KCQk8bGluZSB4MT0i LTEwMCIgeTE9IjAiICAgIHgyPSItOTAiICB5Mj0iMCIgIC8+DQoJCTxsaW5lIHgxPSItODciICB5 MT0iLTUwIiAgeDI9Ii03OCIgIHkyPSItNDUiLz4NCgkJPGxpbmUgeDE9Ii01MCIgIHkxPSItODci ICB4Mj0iLTQ1IiAgeTI9Ii03OCIvPg0KCQk8bGluZSB4MT0iMCIgICAgeTE9Ii0xMDAiIHgyPSIw IiAgICB5Mj0iLTkwIi8+DQoJCTxsaW5lIHgxPSI1MCIgICB5MT0iLTg3IiAgeDI9IjQ1IiAgIHky PSItNzgiLz4NCgkJPGxpbmUgeDE9Ijg3IiAgIHkxPSItNTAiICB4Mj0iNzgiICAgeTI9Ii00NSIv Pg0KCQk8bGluZSBpZD0iaG91cmhhbmQiIHN0cm9rZS13aWR0aD0iOHB4IiBzdHJva2U9ImJsdWUi ICAgeDE9IjAiIHkxPSIwIiB4Mj0iMCIgeTI9IjQwIi8+DQoJCTxsaW5lIGlkPSJtaW51dGVoYW5k IiBzdHJva2Utd2lkdGg9IjVweCIgc3Ryb2tlPSJncmVlbiIgeDE9IjAiIHkxPSIwIiB4Mj0iMCIg eTI9IjY1Ii8+DQoJCTxsaW5lIGlkPSJzZWNvbmRoYW5kIiBzdHJva2Utd2lkdGg9IjJweCIgc3Ry b2tlPSJyZWQiIHgxPSIwIiB5MT0iMCIgeDI9IjAiIHkyPSI5MCIvPg0KCQk8L2c+DQoJPC9nPg0K ICA8dGV4dCBpZD0iZGF0ZXRleHQiIHg9IjEwIiB5PSIyNTAiPnRlc3Q8L3RleHQ+DQoNCgk8c2Ny aXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+DQoJCXZhciBzSGFuZCA9IGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCdzZWNvbmRoYW5kJyk7DQoJCXZhciBtSGFuZCA9IGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCdtaW51dGVoYW5kJyk7DQoJCXZhciBoSGFuZCA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCdob3VyaGFuZCcpOw0KCQl2YXIgZGlnaXRhbCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCdkYXRldGV4dCcpOw0KCQkNCgkJZnVuY3Rpb24gdXBkYXRlU2Vjb25kcygpIHsNCgkJCXZhciBh bmdsZSA9IChuZXcgRGF0ZSgpKS5nZXRTZWNvbmRzKCkgKiBNYXRoLlBJLzMwOw0KDQoJCQlpZiAo YW5nbGUgPT0gMCkNCgkJCQl1cGRhdGVNaW51dGVzKCk7DQoNCgkJCXNIYW5kLnNldEF0dHJpYnV0 ZSgneDInLCA5MCAqIE1hdGguY29zKGFuZ2xlKSk7DQoJCQlzSGFuZC5zZXRBdHRyaWJ1dGUoJ3ky JywgOTAgKiBNYXRoLnNpbihhbmdsZSkpOw0KDQoJCQl2YXIgZCA9IChuZXcgRGF0ZSgpKS50b1VU Q1N0cmluZygpOw0KCSAgICAgICAgZGlnaXRhbC5maXJzdENoaWxkLmRhdGEgPSBkOw0KCQl9DQoN CgkJZnVuY3Rpb24gdXBkYXRlTWludXRlcygpIHsNCgkJCXZhciBhbmdsZSA9IChuZXcgRGF0ZSgp KS5nZXRNaW51dGVzKCkgKiBNYXRoLlBJLzMwOw0KDQoJCQlpZiAoYW5nbGUgPT0gMCkNCgkJCQl1 cGRhdGVIb3VycygpOw0KDQoJCQltSGFuZC5zZXRBdHRyaWJ1dGUoJ3gyJywgNjUgKiBNYXRoLmNv cyhhbmdsZSkpOw0KCQkJbUhhbmQuc2V0QXR0cmlidXRlKCd5MicsIDY1ICogTWF0aC5zaW4oYW5n bGUpKTsNCgkJfQ0KDQoJCWZ1bmN0aW9uIHVwZGF0ZUhvdXJzKCkgew0KCQkJdmFyIGFuZ2xlID0g KG5ldyBEYXRlKCkpLmdldEhvdXJzKCkgKiBNYXRoLlBJLzY7DQoJCQloSGFuZC5zZXRBdHRyaWJ1 dGUoJ3gyJywgNDAgKiBNYXRoLmNvcyhhbmdsZSkpOw0KCQkJaEhhbmQuc2V0QXR0cmlidXRlKCd5 MicsIDQwICogTWF0aC5zaW4oYW5nbGUpKTsNCgkJfQ0KCQl1cGRhdGVTZWNvbmRzKCk7DQoJCXVw ZGF0ZU1pbnV0ZXMoKTsNCgkJdXBkYXRlSG91cnMoKTsNCgkJc2V0SW50ZXJ2YWwoJ3VwZGF0ZVNl Y29uZHMoKScsIDEwMDApOw0KDQoJPC9zY3JpcHQ+DQo8L3N2Zz4NCg== 3507 2005-08-22 02:01:58 -0700 2005-08-22 08:18:36 -0700 Adds necessary Interpreter::lock()/unlock() calls. javascript_fix.patch text/plain 1089 eric SW5kZXg6IGltcGwvU1ZHU2NyaXB0RWxlbWVudEltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6 IC9jdnMvcm9vdC9TVkdTdXBwb3J0L2tzdmcyL2ltcGwvU1ZHU2NyaXB0RWxlbWVudEltcGwuY3Bw LHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjMKZGlmZiAtcCAtdSAtcjEuMyBpbXBsL1NWR1Njcmlw dEVsZW1lbnRJbXBsLmNwcAotLS0gaW1wbC9TVkdTY3JpcHRFbGVtZW50SW1wbC5jcHAJMTEgQXVn IDIwMDUgMTE6MzU6MjEgLTAwMDAJMS4zCisrKyBpbXBsL1NWR1NjcmlwdEVsZW1lbnRJbXBsLmNw cAkyMiBBdWcgMjAwNSAwOTowMzo1MiAtMDAwMApAQCAtODMsNiArODMsMTAgQEAgdm9pZCBTVkdT Y3JpcHRFbGVtZW50SW1wbDo6ZXhlY3V0ZVNjcmlwdAogCUtET006OkVjbWEgKmVjbWFFbmdpbmUg PSBkb2N1bWVudC0+ZWNtYUVuZ2luZSgpOwogCWlmKCFlY21hRW5naW5lKQogCQlyZXR1cm47Cisg ICAgICAgICAgICAgICAgCisjaWZkZWYgQVBQTEVfQ0hBTkdFUworICAgIEtKUzo6SW50ZXJwcmV0 ZXI6OmxvY2soKTsKKyNlbmRpZgogCiAJLy8gUnVuIHNjcmlwdAogCUtKUzo6Q29tcGxldGlvbiBj b21wID0gZWNtYUVuZ2luZS0+ZXZhbHVhdGUoanNDb2RlLnN0cmluZygpLCBlY21hRW5naW5lLT5n bG9iYWxPYmplY3QoKSk7CkBAIC0xMTgsNiArMTIyLDEwIEBAIHZvaWQgU1ZHU2NyaXB0RWxlbWVu dEltcGw6OmV4ZWN1dGVTY3JpcHQKIAkJa2REZWJ1ZygpIDw8ICJbU1ZHU2NyaXB0RWxlbWVudF0g UmV0dXJuIHZhbHVlOiAiIDw8IGNvbXAudmFsdWUoKS0+dG9TdHJpbmcoZWNtYUVuZ2luZS0+Z2xv YmFsRXhlYygpKS5xc3RyaW5nKCkgPDwgZW5kbDsKIAllbHNlIGlmKGNvbXAuY29tcGxUeXBlKCkg PT0gS0pTOjpOb3JtYWwpCiAJCWtkRGVidWcoKSA8PCAiW1NWR1NjcmlwdEVsZW1lbnRdIEV2YWx1 YXRlZCBlY21hIHNjcmlwdCEiIDw8IGVuZGw7CisgICAgCisjaWZkZWYgQVBQTEVfQ0hBTkdFUwor ICAgIEtKUzo6SW50ZXJwcmV0ZXI6OnVubG9jaygpOworI2VuZGlmCiB9CiAKIC8vIHZpbTp0cz00 Om5vZXQK