45792 2010-09-14 17:34:31 -0700 Drawing an image outside the bounds of a canvas still causes repaints 2010-09-14 18:55:29 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED http://www.phoboslab.org/biolab/ P2 Normal --- 1 simon.fraser simon.fraser kling oldest_to_newest 279268 0 simon.fraser 2010-09-14 17:34:31 -0700 http://www.phoboslab.org/biolab/ seems to draw all the tiles in the game on every frame, even ones that are far outside the bounds of the canvas. Stupidly, we still turn these into repaints. 279294 1 simon.fraser 2010-09-14 18:11:13 -0700 diff --git a/WebCore/html/HTMLCanvasElement.cpp b/WebCore/html/HTMLCanvasElement.cpp index 3838f14..6f46ab4 100644 --- a/WebCore/html/HTMLCanvasElement.cpp +++ b/WebCore/html/HTMLCanvasElement.cpp @@ -193,7 +193,7 @@ void HTMLCanvasElement::didDraw(const FloatRect& rect) FloatRect destRect = ro->contentBoxRect(); FloatRect r = mapRect(rect, FloatRect(0, 0, size().width(), size().height()), destRect); r.intersect(destRect); - if (m_dirtyRect.contains(r)) + if (r.isEmpty() || m_dirtyRect.contains(r)) return; m_dirtyRect.unite(r); I'll make some tests. 279305 2 67630 simon.fraser 2010-09-14 18:38:38 -0700 Created attachment 67630 Patch 279311 3 67630 oliver 2010-09-14 18:46:07 -0700 Comment on attachment 67630 Patch r=me 279317 4 simon.fraser 2010-09-14 18:55:29 -0700 http://trac.webkit.org/changeset/67526 67630 2010-09-14 18:38:38 -0700 2010-09-14 18:46:07 -0700 Patch bug-45792-20100914183837.patch text/plain 1931 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZGQwZjZmNzU2ODY2ZmYxNWJmNTEwYzExMDBjOTgwNjA5NjQ1ZTZiMi4uYmI5YmQ0ZmUyNjNmOTVi ODU4MTczMGNhNTUwNDBjYzhlYTY3MmI3NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxMC0wOS0xNCAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEcmF3aW5nIGFuIGltYWdlIG91dHNpZGUgdGhl IGJvdW5kcyBvZiBhIGNhbnZhcyBzdGlsbCBjYXVzZXMgcmVwYWludHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1NzkyCisgICAgICAgIAorICAgICAg ICBTb21lIGNhbnZhcyBleGFtcGxlcywgc3VjaCBhcyBodHRwOi8vd3d3LnBob2Jvc2xhYi5vcmcv YmlvbGFiLywgZHJhdworICAgICAgICBpbWFnZXMgb3V0aWRlIHRoZSBib3VuZHMgb2YgdGhlIGNh bnZhcy4gSWYgdGhlIGNhbnZhcyBhbHJlYWR5IGhhZCBhCisgICAgICAgIG5vbi1lbXB0eSBtX2Rp cnR5UmVjdCwgc3VjaCBkcmF3cyB3b3VsZCBjYXVzZSB1cyB0byBkbyBhIHJlcGFpbnQgb2YKKyAg ICAgICAgbV9kaXJ0eVJlY3QgYWdhaW4gKHdoaWNoIGdvZXMgdGhyb3VnaCB0aGUgcGxhdGZvcm0t c3BlY2lmaWMgaW52YWxpZGF0aW9uCisgICAgICAgIG1hY2hpbmVyeSwgd2hpY2ggY2FuIGJlIHNs b3cpLgorICAgICAgICAKKyAgICAgICAgT3B0aW1pemUgdGhpcyBieSBhdm9pZGluZyBleHRyYSBp bnZhbGlkYXRpb24gd2hlbiB0aGUgZGlydHkgcmVjdAorICAgICAgICBkb2VzIG5vdCBpbnRlcnNl Y3QgdGhlIGNhbnZhcyBib3VuZHMuCisgICAgICAgIAorICAgICAgICBOb3QgdGVzdGFibGUgYmVj YXVzZSB0aGlzIGF2b2lkcyBhZGRpdGlvbmFsIHJlcGFpbnRzIG9mIG1fZGlydHlSZWN0LCBidXQK KyAgICAgICAgbV9kaXJ0eVJlY3QgaGFzIHRvIGJlIG5vbi1lbXB0eSBmb3IgdGhpcyB0byBiZW5l Zml0LgorCisgICAgICAgICogaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpIVE1MQ2FudmFzRWxlbWVudDo6ZGlkRHJhdyk6CisKIDIwMTAtMDktMTMgIE1hcnRp biBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFhhbiBMb3Blei4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5j cHAgYi9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwCmluZGV4IDM4MzhmMTRhZGNi NjkyOTljOTM4M2VmY2MyMWJhYjRmMjJlNWNmYTYuLjZmNDZhYjRhMDFmNmJjNDNkN2YwZDg3NDFk NjFhMzAwNTQ0ZjBlNmUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVu dC5jcHAKKysrIGIvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcApAQCAtMTkzLDcg KzE5Myw3IEBAIHZvaWQgSFRNTENhbnZhc0VsZW1lbnQ6OmRpZERyYXcoY29uc3QgRmxvYXRSZWN0 JiByZWN0KQogICAgICAgICBGbG9hdFJlY3QgZGVzdFJlY3QgPSByby0+Y29udGVudEJveFJlY3Qo KTsKICAgICAgICAgRmxvYXRSZWN0IHIgPSBtYXBSZWN0KHJlY3QsIEZsb2F0UmVjdCgwLCAwLCBz aXplKCkud2lkdGgoKSwgc2l6ZSgpLmhlaWdodCgpKSwgZGVzdFJlY3QpOwogICAgICAgICByLmlu dGVyc2VjdChkZXN0UmVjdCk7Ci0gICAgICAgIGlmIChtX2RpcnR5UmVjdC5jb250YWlucyhyKSkK KyAgICAgICAgaWYgKHIuaXNFbXB0eSgpIHx8IG1fZGlydHlSZWN0LmNvbnRhaW5zKHIpKQogICAg ICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIG1fZGlydHlSZWN0LnVuaXRlKHIpOwo=