<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>45789</bug_id>
          
          <creation_ts>2010-09-14 16:09:45 -0700</creation_ts>
          <short_desc>WebKit should use system wide spell checking preference when application specific one isn&apos;t set.</short_desc>
          <delta_ts>2010-09-17 06:41:44 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.6</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Jia Pu">jiapu.mail</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>commit-queue</cc>
    
    <cc>eric</cc>
    
    <cc>jiapu.mail</cc>
    
    <cc>mitz</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>279237</commentid>
    <comment_count>0</comment_count>
    <who name="Jia Pu">jiapu.mail</who>
    <bug_when>2010-09-14 16:09:45 -0700</bug_when>
    <thetext>On Mac OSX, we want WebKit to use the new global preferences for spelling correction and text replacement when user doesn&apos;t set application specific preference value.
&lt;rdar://problem/8416041&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279244</commentid>
    <comment_count>1</comment_count>
      <attachid>67618</attachid>
    <who name="Jia Pu">jiapu.mail</who>
    <bug_when>2010-09-14 16:19:12 -0700</bug_when>
    <thetext>Created attachment 67618
Proposed patch (v1)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279265</commentid>
    <comment_count>2</comment_count>
      <attachid>67618</attachid>
    <who name="">mitz</who>
    <bug_when>2010-09-14 17:27:24 -0700</bug_when>
    <thetext>Comment on attachment 67618
Proposed patch (v1)

Are there any notifications we should listen to for when the systemwide settings change? Also, please make sure to leave in the Reviewed by NOBODY (OOPS).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279278</commentid>
    <comment_count>3</comment_count>
      <attachid>67624</attachid>
    <who name="Jia Pu">jiapu.mail</who>
    <bug_when>2010-09-14 17:43:42 -0700</bug_when>
    <thetext>Created attachment 67624
Proposed patch (v2)

Added back &quot;Reviewed by NOBODY (OOPS!).&quot; line, so that build doesn&apos;t fail.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279280</commentid>
    <comment_count>4</comment_count>
    <who name="Jia Pu">jiapu.mail</who>
    <bug_when>2010-09-14 17:45:02 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 67618 [details])
&gt; Are there any notifications we should listen to for when the systemwide settings change? 

Eventually yes, we would post notification for setting changes. But we&apos;d like to get this in for now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279340</commentid>
    <comment_count>5</comment_count>
      <attachid>67624</attachid>
    <who name="Jia Pu">jiapu.mail</who>
    <bug_when>2010-09-14 19:39:49 -0700</bug_when>
    <thetext>Comment on attachment 67624
Proposed patch (v2)

I manually added &quot;Reviewed by NOBODY (OOPS).&quot; line without changing the line range. So the patch is malformed. I will submit another patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279346</commentid>
    <comment_count>6</comment_count>
      <attachid>67636</attachid>
    <who name="Jia Pu">jiapu.mail</who>
    <bug_when>2010-09-14 19:45:22 -0700</bug_when>
    <thetext>Created attachment 67636
Proposed patch (v3)

Updated ChangeLog with &quot;Reviewed by NOBODY (OOPS!).&quot; line.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279366</commentid>
    <comment_count>7</comment_count>
      <attachid>67636</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-09-14 21:09:53 -0700</bug_when>
    <thetext>Comment on attachment 67636
Proposed patch (v3)

Clearing flags on attachment: 67636

Committed r67533: &lt;http://trac.webkit.org/changeset/67533&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279367</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-09-14 21:09:58 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279396</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-09-14 22:45:59 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/67533 might have broken GTK Linux 32-bit Debug
The following changes are on the blame list:
http://trac.webkit.org/changeset/67531
http://trac.webkit.org/changeset/67532
http://trac.webkit.org/changeset/67533</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279430</commentid>
    <comment_count>10</comment_count>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2010-09-15 00:21:47 -0700</bug_when>
    <thetext>This broke the build.  Jia, see your email for details.  I rolled it out in r67539.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>280538</commentid>
    <comment_count>11</comment_count>
      <attachid>67884</attachid>
    <who name="Jia Pu">jiapu.mail</who>
    <bug_when>2010-09-16 22:22:25 -0700</bug_when>
    <thetext>Created attachment 67884
Proposed patch (v4)

Fixed build failure.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>280560</commentid>
    <comment_count>12</comment_count>
      <attachid>67884</attachid>
    <who name="">mitz</who>
    <bug_when>2010-09-17 00:14:24 -0700</bug_when>
    <thetext>Comment on attachment 67884
Proposed patch (v4)

View in context: https://bugs.webkit.org/attachment.cgi?id=67884&amp;action=prettypatch

&gt; WebKit/mac/WebView/WebView.mm:109
&gt; +#if !defined(BUILDING_ON_TIGER) &amp;&amp; !defined(BUILDING_ON_LEOPARD) &amp;&amp; !defined(BUILDING_ON_SNOW_LEOPARD)
&gt; +#import &lt;AppKit/NSTextChecker.h&gt;
&gt; +#endif

When an #import or #include directive is in an #if block, that block usually appears as a separate paragraph after the main #import paragraph. I will make this change when I land the patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>280563</commentid>
    <comment_count>13</comment_count>
    <who name="">mitz</who>
    <bug_when>2010-09-17 00:20:55 -0700</bug_when>
    <thetext>Fixed in &lt;http://trac.webkit.org/projects/webkit/changeset/67696&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>280634</commentid>
    <comment_count>14</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-09-17 06:41:44 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/67696 might have broken GTK Linux 32-bit Debug</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>67618</attachid>
            <date>2010-09-14 16:19:12 -0700</date>
            <delta_ts>2010-09-14 17:43:42 -0700</delta_ts>
            <desc>Proposed patch (v1)</desc>
            <filename>webkit_bug45789.patch</filename>
            <type>text/plain</type>
            <size>1758</size>
            <attacher name="Jia Pu">jiapu.mail</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh
bmdlTG9nCShyZXZpc2lvbiA2NzUwOCkKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n
IGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDktMTQgIEppYSBQdSAgPGpwdUBhcHBsZS5j
b20+CisKKyAgICAgICAgV2ViS2l0IHNob3VsZCB1c2Ugc3lzdGVtIHdpZGUgc3BlbGwgY2hlY2tp
bmcgcHJlZmVyZW5jZSB3aGVuIGFwcGxpY2F0aW9uIHNwZWNpZmljIG9uZSBpc24ndCBzZXQuCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTc4OQorCisg
ICAgICAgICogV2ViVmlldy9XZWJWaWV3Lm1tOgorICAgICAgICAoK1tXZWJWaWV3IGluaXRpYWxp
emVdKTogVXNlIHN5c3RlbSB3aWRlIGF1dG9jb3JyZWN0aW9uIGFuZCB0ZXh0IHN1YnN0aXR1dGlv
biBwcmVmZXJlbmNlcworICAgICAgICAgICB3aGVuIHRoZSBhcHBsaWNhdGlvbiBsZXZlbCBwcmVm
ZXJlbmNlcyBhcmUgbm90IHNldC4KKwogMjAxMC0wOS0xNCAgRXJpYyBTZWlkZWwgIDxlcmljQHdl
YmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIGNoYW5nZXMgcjY3NDUx
IGFuZCByNjc0NTEuCkluZGV4OiBXZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBXZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQkocmV2aXNpb24gNjc1MDgpCisr
KyBXZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjYzNiw2
ICsyNjM2LDEzIEBAICsgKHZvaWQpaW5pdGlhbGl6ZQogICAgIGF1dG9tYXRpY1RleHRSZXBsYWNl
bWVudEVuYWJsZWQgPSBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRzXSBib29s
Rm9yS2V5OldlYkF1dG9tYXRpY1RleHRSZXBsYWNlbWVudEVuYWJsZWRdOwogICAgIGF1dG9tYXRp
Y1NwZWxsaW5nQ29ycmVjdGlvbkVuYWJsZWQgPSBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNl
ckRlZmF1bHRzXSBib29sRm9yS2V5OldlYkF1dG9tYXRpY1NwZWxsaW5nQ29ycmVjdGlvbkVuYWJs
ZWRdOwogI2VuZGlmCisKKyNpZiAhZGVmaW5lZChCVUlMRElOR19PTl9USUdFUikgJiYgIWRlZmlu
ZWQoQlVJTERJTkdfT05fTEVPUEFSRCkgJiYgIWRlZmluZWQoQlVJTERJTkdfT05fU05PV19MRU9Q
QVJEKQorICAgIGlmICghW1tOU1VzZXJEZWZhdWx0cyBzdGFuZGFyZFVzZXJEZWZhdWx0c10gb2Jq
ZWN0Rm9yS2V5OldlYkF1dG9tYXRpY1RleHRSZXBsYWNlbWVudEVuYWJsZWRdKQorICAgICAgICBh
dXRvbWF0aWNUZXh0UmVwbGFjZW1lbnRFbmFibGVkID0gW05TU3BlbGxDaGVja2VyIGlzQXV0b21h
dGljVGV4dFJlcGxhY2VtZW50RW5hYmxlZF07CisgICAgaWYgKCFbW05TVXNlckRlZmF1bHRzIHN0
YW5kYXJkVXNlckRlZmF1bHRzXSBvYmplY3RGb3JLZXk6V2ViQXV0b21hdGljU3BlbGxpbmdDb3Jy
ZWN0aW9uRW5hYmxlZF0pCisgICAgICAgIGF1dG9tYXRpY1RleHRSZXBsYWNlbWVudEVuYWJsZWQg
PSBbTlNTcGVsbENoZWNrZXIgaXNBdXRvbWF0aWNTcGVsbGluZ0NvcnJlY3Rpb25FbmFibGVkXTsK
KyNlbmRpZgogfQogCiArICh2b2lkKV9hcHBsaWNhdGlvbldpbGxUZXJtaW5hdGUK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>67624</attachid>
            <date>2010-09-14 17:43:42 -0700</date>
            <delta_ts>2010-09-14 19:39:49 -0700</delta_ts>
            <desc>Proposed patch (v2)</desc>
            <filename>webkit_bug45789.patch</filename>
            <type>text/plain</type>
            <size>1797</size>
            <attacher name="Jia Pu">jiapu.mail</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh
bmdlTG9nCShyZXZpc2lvbiA2NzUwOCkKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n
IGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDktMTQgIEppYSBQdSAgPGpwdUBhcHBsZS5j
b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Vi
S2l0IHNob3VsZCB1c2Ugc3lzdGVtIHdpZGUgc3BlbGwgY2hlY2tpbmcgcHJlZmVyZW5jZSB3aGVu
IGFwcGxpY2F0aW9uIHNwZWNpZmljIG9uZSBpc24ndCBzZXQuCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTc4OQorCisgICAgICAgICogV2ViVmlldy9X
ZWJWaWV3Lm1tOgorICAgICAgICAoK1tXZWJWaWV3IGluaXRpYWxpemVdKTogVXNlIHN5c3RlbSB3
aWRlIGF1dG9jb3JyZWN0aW9uIGFuZCB0ZXh0IHN1YnN0aXR1dGlvbiBwcmVmZXJlbmNlcworICAg
ICAgICAgICB3aGVuIHRoZSBhcHBsaWNhdGlvbiBsZXZlbCBwcmVmZXJlbmNlcyBhcmUgbm90IHNl
dC4KKwogMjAxMC0wOS0xNCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAg
ICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIGNoYW5nZXMgcjY3NDUxIGFuZCByNjc0NTEuCkluZGV4
OiBXZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvbWFj
L1dlYlZpZXcvV2ViVmlldy5tbQkocmV2aXNpb24gNjc1MDgpCisrKyBXZWJLaXQvbWFjL1dlYlZp
ZXcvV2ViVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjYzNiw2ICsyNjM2LDEzIEBAICsgKHZv
aWQpaW5pdGlhbGl6ZQogICAgIGF1dG9tYXRpY1RleHRSZXBsYWNlbWVudEVuYWJsZWQgPSBbW05T
VXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRzXSBib29sRm9yS2V5OldlYkF1dG9tYXRp
Y1RleHRSZXBsYWNlbWVudEVuYWJsZWRdOwogICAgIGF1dG9tYXRpY1NwZWxsaW5nQ29ycmVjdGlv
bkVuYWJsZWQgPSBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRzXSBib29sRm9y
S2V5OldlYkF1dG9tYXRpY1NwZWxsaW5nQ29ycmVjdGlvbkVuYWJsZWRdOwogI2VuZGlmCisKKyNp
ZiAhZGVmaW5lZChCVUlMRElOR19PTl9USUdFUikgJiYgIWRlZmluZWQoQlVJTERJTkdfT05fTEVP
UEFSRCkgJiYgIWRlZmluZWQoQlVJTERJTkdfT05fU05PV19MRU9QQVJEKQorICAgIGlmICghW1tO
U1VzZXJEZWZhdWx0cyBzdGFuZGFyZFVzZXJEZWZhdWx0c10gb2JqZWN0Rm9yS2V5OldlYkF1dG9t
YXRpY1RleHRSZXBsYWNlbWVudEVuYWJsZWRdKQorICAgICAgICBhdXRvbWF0aWNUZXh0UmVwbGFj
ZW1lbnRFbmFibGVkID0gW05TU3BlbGxDaGVja2VyIGlzQXV0b21hdGljVGV4dFJlcGxhY2VtZW50
RW5hYmxlZF07CisgICAgaWYgKCFbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRz
XSBvYmplY3RGb3JLZXk6V2ViQXV0b21hdGljU3BlbGxpbmdDb3JyZWN0aW9uRW5hYmxlZF0pCisg
ICAgICAgIGF1dG9tYXRpY1RleHRSZXBsYWNlbWVudEVuYWJsZWQgPSBbTlNTcGVsbENoZWNrZXIg
aXNBdXRvbWF0aWNTcGVsbGluZ0NvcnJlY3Rpb25FbmFibGVkXTsKKyNlbmRpZgogfQogCiArICh2
b2lkKV9hcHBsaWNhdGlvbldpbGxUZXJtaW5hdGUK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>67636</attachid>
            <date>2010-09-14 19:45:22 -0700</date>
            <delta_ts>2010-09-16 22:22:25 -0700</delta_ts>
            <desc>Proposed patch (v3)</desc>
            <filename>webkit_bug45789.pitch</filename>
            <type>text/plain</type>
            <size>1797</size>
            <attacher name="Jia Pu">jiapu.mail</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh
bmdlTG9nCShyZXZpc2lvbiA2NzUwOCkKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n
IGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDktMTQgIEppYSBQdSAgPGpwdUBhcHBsZS5j
b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Vi
S2l0IHNob3VsZCB1c2Ugc3lzdGVtIHdpZGUgc3BlbGwgY2hlY2tpbmcgcHJlZmVyZW5jZSB3aGVu
IGFwcGxpY2F0aW9uIHNwZWNpZmljIG9uZSBpc24ndCBzZXQuCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTc4OQorCisgICAgICAgICogV2ViVmlldy9X
ZWJWaWV3Lm1tOgorICAgICAgICAoK1tXZWJWaWV3IGluaXRpYWxpemVdKTogVXNlIHN5c3RlbSB3
aWRlIGF1dG9jb3JyZWN0aW9uIGFuZCB0ZXh0IHN1YnN0aXR1dGlvbiBwcmVmZXJlbmNlcworICAg
ICAgICAgICB3aGVuIHRoZSBhcHBsaWNhdGlvbiBsZXZlbCBwcmVmZXJlbmNlcyBhcmUgbm90IHNl
dC4KKwogMjAxMC0wOS0xNCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAg
ICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIGNoYW5nZXMgcjY3NDUxIGFuZCByNjc0NTEuCkluZGV4
OiBXZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvbWFj
L1dlYlZpZXcvV2ViVmlldy5tbQkocmV2aXNpb24gNjc1MDgpCisrKyBXZWJLaXQvbWFjL1dlYlZp
ZXcvV2ViVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjYzNiw2ICsyNjM2LDEzIEBAICsgKHZv
aWQpaW5pdGlhbGl6ZQogICAgIGF1dG9tYXRpY1RleHRSZXBsYWNlbWVudEVuYWJsZWQgPSBbW05T
VXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRzXSBib29sRm9yS2V5OldlYkF1dG9tYXRp
Y1RleHRSZXBsYWNlbWVudEVuYWJsZWRdOwogICAgIGF1dG9tYXRpY1NwZWxsaW5nQ29ycmVjdGlv
bkVuYWJsZWQgPSBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRzXSBib29sRm9y
S2V5OldlYkF1dG9tYXRpY1NwZWxsaW5nQ29ycmVjdGlvbkVuYWJsZWRdOwogI2VuZGlmCisKKyNp
ZiAhZGVmaW5lZChCVUlMRElOR19PTl9USUdFUikgJiYgIWRlZmluZWQoQlVJTERJTkdfT05fTEVP
UEFSRCkgJiYgIWRlZmluZWQoQlVJTERJTkdfT05fU05PV19MRU9QQVJEKQorICAgIGlmICghW1tO
U1VzZXJEZWZhdWx0cyBzdGFuZGFyZFVzZXJEZWZhdWx0c10gb2JqZWN0Rm9yS2V5OldlYkF1dG9t
YXRpY1RleHRSZXBsYWNlbWVudEVuYWJsZWRdKQorICAgICAgICBhdXRvbWF0aWNUZXh0UmVwbGFj
ZW1lbnRFbmFibGVkID0gW05TU3BlbGxDaGVja2VyIGlzQXV0b21hdGljVGV4dFJlcGxhY2VtZW50
RW5hYmxlZF07CisgICAgaWYgKCFbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRz
XSBvYmplY3RGb3JLZXk6V2ViQXV0b21hdGljU3BlbGxpbmdDb3JyZWN0aW9uRW5hYmxlZF0pCisg
ICAgICAgIGF1dG9tYXRpY1RleHRSZXBsYWNlbWVudEVuYWJsZWQgPSBbTlNTcGVsbENoZWNrZXIg
aXNBdXRvbWF0aWNTcGVsbGluZ0NvcnJlY3Rpb25FbmFibGVkXTsKKyNlbmRpZgogfQogCiArICh2
b2lkKV9hcHBsaWNhdGlvbldpbGxUZXJtaW5hdGUK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>67884</attachid>
            <date>2010-09-16 22:22:25 -0700</date>
            <delta_ts>2010-09-17 00:14:23 -0700</delta_ts>
            <desc>Proposed patch (v4)</desc>
            <filename>webkit_bug45789.patch</filename>
            <type>text/plain</type>
            <size>2190</size>
            <attacher name="Jia Pu">jiapu.mail</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh
bmdlTG9nCShyZXZpc2lvbiA2NzY5MykKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n
IGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDktMTYgIEppYSBQdSAgPGpwdUBhcHBsZS5j
b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Vi
S2l0IHNob3VsZCB1c2Ugc3lzdGVtIHdpZGUgc3BlbGwgY2hlY2tpbmcgcHJlZmVyZW5jZSB3aGVu
IGFwcGxpY2F0aW9uIHNwZWNpZmljIG9uZSBpc24ndCBzZXQuCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTc4OQorICAgICAgICA8cmRhcjovL3Byb2Js
ZW0vODQxNjA0MT4KKworICAgICAgICAqIFdlYlZpZXcvV2ViVmlldy5tbToKKyAgICAgICAgKCtb
V2ViVmlldyBpbml0aWFsaXplXSk6IFVzZSBzeXN0ZW0gd2lkZSBhdXRvY29ycmVjdGlvbiBhbmQg
dGV4dCBzdWJzdGl0dXRpb24gcHJlZmVyZW5jZXMKKyAgICAgICAgICB3aGVuIHRoZSBhcHBsaWNh
dGlvbiBsZXZlbCBwcmVmZXJlbmNlcyBhcmUgbm90IHNldC4KKwogMjAxMC0wOS0xNiAgSm9obiBT
dWxsaXZhbiAgPHN1bGxpdmFuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJp
biBBZGxlci4KSW5kZXg6IFdlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCj09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K
LS0tIFdlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCShyZXZpc2lvbiA2NzY5MykKKysrIFdl
YktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMDQsNiArMTA0
LDkgQEAKICNpbXBvcnQgIldlYlVJRGVsZWdhdGUuaCIKICNpbXBvcnQgIldlYlVJRGVsZWdhdGVQ
cml2YXRlLmgiCiAjaW1wb3J0ICJXZWJWaWRlb0Z1bGxzY3JlZW5Db250cm9sbGVyLmgiCisjaWYg
IWRlZmluZWQoQlVJTERJTkdfT05fVElHRVIpICYmICFkZWZpbmVkKEJVSUxESU5HX09OX0xFT1BB
UkQpICYmICFkZWZpbmVkKEJVSUxESU5HX09OX1NOT1dfTEVPUEFSRCkKKyNpbXBvcnQgPEFwcEtp
dC9OU1RleHRDaGVja2VyLmg+CisjZW5kaWYKICNpbXBvcnQgPENvcmVGb3VuZGF0aW9uL0NGU2V0
Lmg+CiAjaW1wb3J0IDxGb3VuZGF0aW9uL05TVVJMQ29ubmVjdGlvbi5oPgogI2ltcG9ydCA8SmF2
YVNjcmlwdENvcmUvQVBJQ2FzdC5oPgpAQCAtMjYzNiw2ICsyNjM5LDEzIEBAICsgKHZvaWQpaW5p
dGlhbGl6ZQogICAgIGF1dG9tYXRpY1RleHRSZXBsYWNlbWVudEVuYWJsZWQgPSBbW05TVXNlckRl
ZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRzXSBib29sRm9yS2V5OldlYkF1dG9tYXRpY1RleHRS
ZXBsYWNlbWVudEVuYWJsZWRdOwogICAgIGF1dG9tYXRpY1NwZWxsaW5nQ29ycmVjdGlvbkVuYWJs
ZWQgPSBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRzXSBib29sRm9yS2V5Oldl
YkF1dG9tYXRpY1NwZWxsaW5nQ29ycmVjdGlvbkVuYWJsZWRdOwogI2VuZGlmCisKKyNpZiAhZGVm
aW5lZChCVUlMRElOR19PTl9USUdFUikgJiYgIWRlZmluZWQoQlVJTERJTkdfT05fTEVPUEFSRCkg
JiYgIWRlZmluZWQoQlVJTERJTkdfT05fU05PV19MRU9QQVJEKQorICAgIGlmICghW1tOU1VzZXJE
ZWZhdWx0cyBzdGFuZGFyZFVzZXJEZWZhdWx0c10gb2JqZWN0Rm9yS2V5OldlYkF1dG9tYXRpY1Rl
eHRSZXBsYWNlbWVudEVuYWJsZWRdKQorICAgICAgICBhdXRvbWF0aWNUZXh0UmVwbGFjZW1lbnRF
bmFibGVkID0gW05TU3BlbGxDaGVja2VyIGlzQXV0b21hdGljVGV4dFJlcGxhY2VtZW50RW5hYmxl
ZF07CisgICAgaWYgKCFbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRzXSBvYmpl
Y3RGb3JLZXk6V2ViQXV0b21hdGljU3BlbGxpbmdDb3JyZWN0aW9uRW5hYmxlZF0pCisgICAgICAg
IGF1dG9tYXRpY1RleHRSZXBsYWNlbWVudEVuYWJsZWQgPSBbTlNTcGVsbENoZWNrZXIgaXNBdXRv
bWF0aWNTcGVsbGluZ0NvcnJlY3Rpb25FbmFibGVkXTsKKyNlbmRpZgogfQogCiArICh2b2lkKV9h
cHBsaWNhdGlvbldpbGxUZXJtaW5hdGUK
</data>
<flag name="review"
          id="57309"
          type_id="1"
          status="+"
          setter="mitz"
    />
    <flag name="commit-queue"
          id="57314"
          type_id="3"
          status="-"
          setter="mitz"
    />
          </attachment>
      

    </bug>

</bugzilla>