45783 2010-09-14 14:39:18 -0700 LayoutTest fast/dom/Geolocation/clear-watch-invalid-id-crash.html is flaky 2010-09-15 03:06:25 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 steveblock webkit-unassigned commit-queue jorlow steveblock oldest_to_newest 279180 0 steveblock 2010-09-14 14:39:18 -0700 Fix LayoutTest fast/dom/Geolocation/clear-watch-invalid-id-crash.html contains a race condition so is flaky. This test synchronously navigates the page to a new URL from its main script file. This navigation causes WebView.onPageFinished() to be called for the test page. The problem is that this may occur before js-test-post.js, which is included by the test and calls layoutTestController.waitUntilDone(), is loaded and parsed. As a result, the test is incorrectly deemed to have finished as soon as the navigation is started and the output will therefore be incorrect. 279190 1 67610 steveblock 2010-09-14 14:53:30 -0700 Created attachment 67610 Patch 279487 2 67610 commit-queue 2010-09-15 03:06:20 -0700 Comment on attachment 67610 Patch Clearing flags on attachment: 67610 Committed r67546: <http://trac.webkit.org/changeset/67546> 279488 3 commit-queue 2010-09-15 03:06:25 -0700 All reviewed patches have been landed. Closing bug. 67610 2010-09-14 14:53:30 -0700 2010-09-15 03:06:20 -0700 Patch bug-45783-20100914225327.patch text/plain 2463 steveblock SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY3NDk5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTAtMDktMTQgIFN0ZXZlIEJsb2NrICA8c3Rl dmVibG9ja0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIExheW91dFRlc3QgZmFzdC9kb20vR2VvbG9jYXRpb24vY2xlYXItd2F0Y2gt aW52YWxpZC1pZC1jcmFzaC5odG1sIGlzIGZsYWt5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTc4MworCisgICAgICAgIFRoaXMgdGVzdCBzeW5jaHJv bm91c2x5IG5hdmlnYXRlcyB0aGUgcGFnZSB0byBhIG5ldyBVUkwgZnJvbSBpdHMgbWFpbiBzY3Jp cHQgZmlsZS4KKyAgICAgICAgVGhpcyBuYXZpZ2F0aW9uIGNhdXNlcyBXZWJWaWV3Lm9uUGFnZUZp bmlzaGVkKCkgdG8gYmUgY2FsbGVkIGZvciB0aGUgdGVzdCBwYWdlLgorICAgICAgICBUaGUgcHJv YmxlbSBpcyB0aGF0IHRoaXMgbWF5IG9jY3VyIGJlZm9yZSBqcy10ZXN0LXBvc3QuanMsIHdoaWNo IGlzIGluY2x1ZGVkIGJ5IHRoZQorICAgICAgICB0ZXN0IGFuZCBjYWxscyBsYXlvdXRUZXN0Q29u dHJvbGxlci53YWl0VW50aWxEb25lKCksIGlzIGxvYWRlZCBhbmQgcGFyc2VkLiBBcyBhCisgICAg ICAgIHJlc3VsdCwgdGhlIHRlc3QgaXMgaW5jb3JyZWN0bHkgZGVlbWVkIHRvIGhhdmUgZmluaXNo ZWQgYXMgc29vbiBhcyB0aGUgbmF2aWdhdGlvbgorICAgICAgICBpcyBzdGFydGVkIGFuZCB0aGUg b3V0cHV0IHdpbGwgdGhlcmVmb3JlIGJlIGluY29ycmVjdC4KKworICAgICAgICBUaGlzIHBhdGNo IGZpeGVzIHRoZSBwcm9ibGVtIGJ5IGluaXRpYXRpbmcgdGhlIHBhZ2UgbmF2aWdhdGlvbiBmcm9t CisgICAgICAgIHRoZSBvbmxvYWQgaGFuZGxlciwgd2hpY2ggaXMgbm90IGZpcmVkIHVudGlsIGFs bCByZXNvdXJjZXMgaGF2ZSBiZWVuCisgICAgICAgIGxvYWRlZCBhbmQgcGFyc2VkLiBUaGlzIGd1 YXJhbnRlZXMgdGhhdCBXZWJWaWV3Lm9uUGFnZUZpbmlzaGVkKCkgaXMKKyAgICAgICAgbm90IGNh bGxlZCB1bnRpbCBhZnRlciBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCkgaGFz IGJlZW4KKyAgICAgICAgY2FsbGVkLgorCisgICAgICAgICogZmFzdC9kb20vR2VvbG9jYXRpb24v c2NyaXB0LXRlc3RzL2NsZWFyLXdhdGNoLWludmFsaWQtaWQtY3Jhc2guanM6CisKIDIwMTAtMDkt MTQgIENocmlzIEd1aWxsb3J5ICAgPGNocmlzLmd1aWxsb3J5QGdvb2dsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgQ2hyaXMgRmxlaXphY2guCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Rv bS9HZW9sb2NhdGlvbi9zY3JpcHQtdGVzdHMvY2xlYXItd2F0Y2gtaW52YWxpZC1pZC1jcmFzaC5q cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9HZW9sb2NhdGlvbi9zY3JpcHQt dGVzdHMvY2xlYXItd2F0Y2gtaW52YWxpZC1pZC1jcmFzaC5qcwkocmV2aXNpb24gNjc0OTgpCisr KyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9HZW9sb2NhdGlvbi9zY3JpcHQtdGVzdHMvY2xlYXItd2F0 Y2gtaW52YWxpZC1pZC1jcmFzaC5qcwkod29ya2luZyBjb3B5KQpAQCAtNiw5ICs2LDExIEBAIGlm ICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKIH0gZWxzZQogICAgIGRlYnVnKCdUaGlz IHRlc3QgY2FuIG5vdCBiZSBydW4gd2l0aG91dCB0aGUgTGF5b3V0VGVzdENvbnRyb2xsZXInKTsK IAotbmF2aWdhdG9yLmdlb2xvY2F0aW9uLndhdGNoUG9zaXRpb24oZnVuY3Rpb24oKSB7fSk7Ci1u YXZpZ2F0b3IuZ2VvbG9jYXRpb24uY2xlYXJXYXRjaCgwKTsKLWxvY2F0aW9uID0gImRhdGE6dGV4 dC9odG1sLFRFU1QgQ09NUExFVEU8c2NyaXB0PmxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURv bmUoKTs8L3NjcmlwdD4iOworZG9jdW1lbnQuYm9keS5vbmxvYWQgPSBmdW5jdGlvbigpIHsKKyAg ICBuYXZpZ2F0b3IuZ2VvbG9jYXRpb24ud2F0Y2hQb3NpdGlvbihmdW5jdGlvbigpIHt9KTsKKyAg ICBuYXZpZ2F0b3IuZ2VvbG9jYXRpb24uY2xlYXJXYXRjaCgwKTsKKyAgICBsb2NhdGlvbiA9ICJk YXRhOnRleHQvaHRtbCxURVNUIENPTVBMRVRFPHNjcmlwdD5pZih3aW5kb3cubGF5b3V0VGVzdENv bnRyb2xsZXIpIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTs8L3NjcmlwdD4iOwor fQogCiB3aW5kb3cuanNUZXN0SXNBc3luYyA9IHRydWU7CiB3aW5kb3cuc3VjY2Vzc2Z1bGx5UGFy c2VkID0gdHJ1ZTsK