45782 2010-09-14 14:03:12 -0700 Provide an IWebFramePrivate API to load string as plain text into the WebFrame 2010-09-14 14:23:38 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 adachan adachan oldest_to_newest 279155 0 adachan 2010-09-14 14:03:12 -0700 Provide an IWebFramePrivate API to load string as plain text into the WebFrame. Currently IWebFrame has a loadData() method that takes in an IStream, and a loadHTMLString() method that takes in a string but only load it as HTML, but there's no API that will take in a string and load it as plain text. This new API, probably called IWebFramePrivate::loadPlainTextString() will do that. 279160 1 67603 adachan 2010-09-14 14:08:29 -0700 Created attachment 67603 Patch 279167 2 67603 aroben 2010-09-14 14:18:11 -0700 Comment on attachment 67603 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67603&action=prettypatch r=me > WebKit/win/Interfaces/IWebFramePrivate.idl:121 > + HRESULT loadPlainTextString([in] BSTR string, [in] BSTR url); "loadStringAsPlainText" might be clearer, but I'm not sure. 279168 3 adachan 2010-09-14 14:21:29 -0700 The reason I named it loadPlainTextString is to be consistent with IWebFrame::loadHTMLString. Thanks for reviewing! 279169 4 adachan 2010-09-14 14:23:38 -0700 Fixed in http://trac.webkit.org/changeset/67497 67603 2010-09-14 14:08:29 -0700 2010-09-14 14:18:11 -0700 Patch 45782.patch.txt text/plain 2939 adachan SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiA2NzQ5MykKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDktMTQgIEFkYSBDaGFuICA8YWRhY2hhbkBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkIGFuIElXZWJGcmFtZVByaXZhdGUgQVBJIHRvIGxvYWQgc3RyaW5nIGFzIHBsYWluIHRl eHQgaW50byB0aGUgV2ViRnJhbWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00NTc4MgorCisgICAgICAgICogSW50ZXJmYWNlcy9JV2ViRnJhbWVQcml2 YXRlLmlkbDoKKyAgICAgICAgKiBJbnRlcmZhY2VzL1dlYktpdC5pZGw6IFRvdWNoIHRoZSBmaWxl LgorICAgICAgICAqIFdlYkZyYW1lLmNwcDoKKyAgICAgICAgKFdlYkZyYW1lOjpsb2FkUGxhaW5U ZXh0U3RyaW5nKToKKyAgICAgICAgKiBXZWJGcmFtZS5oOgorCiAyMDEwLTA5LTEzICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdl aW5pZy4KSW5kZXg6IFdlYktpdC93aW4vV2ViRnJhbWUuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp dC93aW4vV2ViRnJhbWUuY3BwCShyZXZpc2lvbiA2NzQ4MikKKysrIFdlYktpdC93aW4vV2ViRnJh bWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MDIsNiArNjAyLDE3IEBAIEhSRVNVTFQgU1RETUVU SE9EQ0FMTFRZUEUgV2ViRnJhbWU6OmxvYWQKICAgICByZXR1cm4gU19PSzsKIH0KIAorSFJFU1VM VCBXZWJGcmFtZTo6bG9hZFBsYWluVGV4dFN0cmluZygKKyAgICAvKiBbaW5dICovIEJTVFIgc3Ry aW5nLAorICAgIC8qIFtpbl0gKi8gQlNUUiB1cmwpCit7CisgICAgUmVmUHRyPFNoYXJlZEJ1ZmZl cj4gc2hhcmVkQnVmZmVyID0gU2hhcmVkQnVmZmVyOjpjcmVhdGUocmVpbnRlcnByZXRfY2FzdDxj aGFyKj4oc3RyaW5nKSwgc2l6ZW9mKFVDaGFyKSAqIFN5c1N0cmluZ0xlbihzdHJpbmcpKTsKKyAg ICBCU3RyaW5nIHBsYWluVGV4dE1pbWVUeXBlKFRFWFQoInRleHQvcGxhaW4iKSwgMTApOworICAg IEJTdHJpbmcgdXRmMTZFbmNvZGluZyhURVhUKCJ1dGYtMTYiKSwgNik7CisgICAgbG9hZERhdGEo c2hhcmVkQnVmZmVyLnJlbGVhc2UoKSwgcGxhaW5UZXh0TWltZVR5cGUsIHV0ZjE2RW5jb2Rpbmcs IHVybCwgMCk7CisgICAgcmV0dXJuIFNfT0s7Cit9CisKIHZvaWQgV2ViRnJhbWU6OmxvYWRIVE1M U3RyaW5nKEJTVFIgc3RyaW5nLCBCU1RSIGJhc2VVUkwsIEJTVFIgdW5yZWFjaGFibGVVUkwpCiB7 CiAgICAgUmVmUHRyPFNoYXJlZEJ1ZmZlcj4gc2hhcmVkQnVmZmVyID0gU2hhcmVkQnVmZmVyOjpj cmVhdGUocmVpbnRlcnByZXRfY2FzdDxjaGFyKj4oc3RyaW5nKSwgc2l6ZW9mKFVDaGFyKSAqIFN5 c1N0cmluZ0xlbihzdHJpbmcpKTsKSW5kZXg6IFdlYktpdC93aW4vV2ViRnJhbWUuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXQvd2luL1dlYkZyYW1lLmgJKHJldmlzaW9uIDY3NDgyKQorKysgV2ViS2l0 L3dpbi9XZWJGcmFtZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNjAsNiArMjYwLDcgQEAgcHVibGlj OgogICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBudW1iZXJPZkFjdGl2ZUFu aW1hdGlvbnMoVUlOVCopOwogICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBz dXNwZW5kQW5pbWF0aW9ucygpOwogICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQ RSByZXN1bWVBbmltYXRpb25zKCk7CisgICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExU WVBFIGxvYWRQbGFpblRleHRTdHJpbmcoQlNUUiBzdHJpbmcsIEJTVFIgdXJsKTsKIAogICAgIHZp cnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBpc0Rpc3BsYXlpbmdTdGFuZGFsb25lSW1h Z2UoQk9PTCopOwogCkluZGV4OiBXZWJLaXQvd2luL0ludGVyZmFjZXMvSVdlYkZyYW1lUHJpdmF0 ZS5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3dpbi9JbnRlcmZhY2VzL0lXZWJGcmFtZVByaXZh dGUuaWRsCShyZXZpc2lvbiA2NzQ4MikKKysrIFdlYktpdC93aW4vSW50ZXJmYWNlcy9JV2ViRnJh bWVQcml2YXRlLmlkbAkod29ya2luZyBjb3B5KQpAQCAtMTE3LDQgKzExNyw2IEBAIGludGVyZmFj ZSBJV2ViRnJhbWVQcml2YXRlIDogSVVua25vd24KIAogICAgIEhSRVNVTFQgc3VzcGVuZEFuaW1h dGlvbnMoKTsKICAgICBIUkVTVUxUIHJlc3VtZUFuaW1hdGlvbnMoKTsKKworICAgIEhSRVNVTFQg bG9hZFBsYWluVGV4dFN0cmluZyhbaW5dIEJTVFIgc3RyaW5nLCBbaW5dIEJTVFIgdXJsKTsKIH0K SW5kZXg6IFdlYktpdC93aW4vSW50ZXJmYWNlcy9XZWJLaXQuaWRsCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YktpdC93aW4vSW50ZXJmYWNlcy9XZWJLaXQuaWRsCShyZXZpc2lvbiA2NzQ4MikKKysrIFdlYktp dC93aW4vSW50ZXJmYWNlcy9XZWJLaXQuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0zMDAsNCArMzAw LDMgQEAgbGlicmFyeSBXZWJLaXQKICAgICAgICAgW2RlZmF1bHRdIGludGVyZmFjZSBJV2ViVXNl ckNvbnRlbnRVUkxQYXR0ZXJuOwogICAgIH0KIH0KLQo=