45781 2010-09-14 13:54:29 -0700 Sort with non-numeric custom sort function fails on array with length but no values 2010-09-14 22:11:32 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 darin darin abarth eric webkit.review.bot oldest_to_newest 279143 0 darin 2010-09-14 13:54:29 -0700 Sort with non-numeric custom sort function fails on array with length but no values 279144 1 darin 2010-09-14 13:55:09 -0700 Someone ran into this at the FedEx website. 279147 2 67601 darin 2010-09-14 13:56:50 -0700 Created attachment 67601 Patch 279156 3 67601 ggaren 2010-09-14 14:03:26 -0700 Comment on attachment 67601 Patch r=me 279158 4 darin 2010-09-14 14:06:22 -0700 Committed r67494: <http://trac.webkit.org/changeset/67494> 279186 5 webkit.review.bot 2010-09-14 14:44:11 -0700 http://trac.webkit.org/changeset/67494 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/67496 http://trac.webkit.org/changeset/67494 http://trac.webkit.org/changeset/67495 279216 6 eric 2010-09-14 15:47:06 -0700 More builders need updated results: http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r67496%20(20160)/fast/css/visited-link-hang-pretty-diff.html 279217 7 eric 2010-09-14 15:47:22 -0700 webkit-patch rebaseline can pull down the results for failing builders for you. 279219 8 eric 2010-09-14 15:47:51 -0700 (webkit-patch rebaseline is super-alpha though, so it may not always do what you want!) 279383 9 darin 2010-09-14 22:11:32 -0700 I accidentally landed the wrong expected results, Geoff fixed them later. It’s a mystery to me why every builder didn’t fail! 67601 2010-09-14 13:56:50 -0700 2010-09-14 14:03:26 -0700 Patch bug-45781-20100914135648.patch text/plain 4729 darin SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY3NDkyKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDktMTQgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFNvcnQgd2l0aCBub24tbnVtZXJpYyBjdXN0b20gc29ydCBmdW5jdGlv biBmYWlscyBvbiBhcnJheSB3aXRoIGxlbmd0aCBidXQgbm8gdmFsdWVzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTc4MQorCisgICAgICAgICogcnVu dGltZS9KU0FycmF5LmNwcDoKKyAgICAgICAgKEpTQzo6SlNBcnJheTo6c29ydCk6IFJlcGxhY2Vk IGVhcmx5IGV4aXQgZm9yIGFuIGFycmF5IG9mIGxlbmd0aCB6ZXJvIHRvIGluc3RlYWQKKyAgICAg ICAgZXhpdCBmb3IgYW55IGFycmF5IHdpdGhvdXQgdmFsdWVzLCBldmVuIGlmIGl0IGhhcyBhIG5v bi0wIGxlbmd0aC4KKwogMjAxMC0wOS0xNCAgU3RldmUgRmFsa2VuYnVyZyAgPHNmYWxrZW5AYXBw bGUuY29tPgogCiAgICAgICAgIFdpbmRvd3MgcHJvZHVjdGlvbiBidWlsZCBmaXguCkluZGV4OiBK YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3Jp cHRDb3JlL3J1bnRpbWUvSlNBcnJheS5jcHAJKHJldmlzaW9uIDY3NDgwKQorKysgSmF2YVNjcmlw dENvcmUvcnVudGltZS9KU0FycmF5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA2MCwxMCArMTA2 MCwxMSBAQCB2b2lkIEpTQXJyYXk6OnNvcnQoRXhlY1N0YXRlKiBleGVjLCBKU1ZhCiAgICAgaWYg KHN0b3JhZ2UtPm1fbGVuZ3RoID4gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KHN0ZDo6bnVtZXJpY19s aW1pdHM8aW50Pjo6bWF4KCkpKQogICAgICAgICByZXR1cm47CiAKLSAgICBpZiAoIXN0b3JhZ2Ut Pm1fbGVuZ3RoKQotICAgICAgICByZXR1cm47Ci0KICAgICB1bnNpZ25lZCB1c2VkVmVjdG9yTGVu Z3RoID0gbWluKHN0b3JhZ2UtPm1fbGVuZ3RoLCBtX3ZlY3Rvckxlbmd0aCk7CisgICAgdW5zaWdu ZWQgbm9kZUNvdW50ID0gdXNlZFZlY3Rvckxlbmd0aCArIChzdG9yYWdlLT5tX3NwYXJzZVZhbHVl TWFwID8gc3RvcmFnZS0+bV9zcGFyc2VWYWx1ZU1hcC0+c2l6ZSgpIDogMCk7CisKKyAgICBpZiAo IW5vZGVDb3VudCkKKyAgICAgICAgcmV0dXJuOwogCiAgICAgQVZMVHJlZTxBVkxUcmVlQWJzdHJh Y3RvckZvckFycmF5Q29tcGFyZSwgNDQ+IHRyZWU7IC8vIERlcHRoIDQ0IGlzIGVub3VnaCBmb3Ig Ml4zMSBpdGVtcwogICAgIHRyZWUuYWJzdHJhY3RvcigpLm1fZXhlYyA9IGV4ZWM7CkBAIC0xMDcx LDcgKzEwNzIsNyBAQCB2b2lkIEpTQXJyYXk6OnNvcnQoRXhlY1N0YXRlKiBleGVjLCBKU1ZhCiAg ICAgdHJlZS5hYnN0cmFjdG9yKCkubV9jb21wYXJlQ2FsbFR5cGUgPSBjYWxsVHlwZTsKICAgICB0 cmVlLmFic3RyYWN0b3IoKS5tX2NvbXBhcmVDYWxsRGF0YSA9ICZjYWxsRGF0YTsKICAgICB0cmVl LmFic3RyYWN0b3IoKS5tX2dsb2JhbFRoaXNWYWx1ZSA9IGV4ZWMtPmdsb2JhbFRoaXNWYWx1ZSgp OwotICAgIHRyZWUuYWJzdHJhY3RvcigpLm1fbm9kZXMucmVzaXplKHVzZWRWZWN0b3JMZW5ndGgg KyAoc3RvcmFnZS0+bV9zcGFyc2VWYWx1ZU1hcCA/IHN0b3JhZ2UtPm1fc3BhcnNlVmFsdWVNYXAt PnNpemUoKSA6IDApKTsKKyAgICB0cmVlLmFic3RyYWN0b3IoKS5tX25vZGVzLmdyb3cobm9kZUNv dW50KTsKIAogICAgIGlmIChjYWxsVHlwZSA9PSBDYWxsVHlwZUpTKQogICAgICAgICB0cmVlLmFi c3RyYWN0b3IoKS5tX2NhY2hlZENhbGwgPSBhZG9wdFB0cihuZXcgQ2FjaGVkQ2FsbChleGVjLCBh c0Z1bmN0aW9uKGNvbXBhcmVGdW5jdGlvbiksIDIsIGV4ZWMtPmV4Y2VwdGlvblNsb3QoKSkpOwpJ bmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0No YW5nZUxvZwkocmV2aXNpb24gNjc0OTIpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wOS0xNCAgRGFyaW4gQWRsZXIgIDxkYXJp bkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgU29ydCB3aXRoIG5vbi1udW1lcmljIGN1c3RvbSBzb3J0IGZ1bmN0aW9uIGZhaWxzIG9u IGFycmF5IHdpdGggbGVuZ3RoIGJ1dCBubyB2YWx1ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1NzgxCisKKyAgICAgICAgKiBmYXN0L2pzL3Njcmlw dC10ZXN0cy9zb3J0LWxhcmdlLWFycmF5LmpzOiBBZGRlZCB0ZXN0IGNhc2VzLgorICAgICAgICAq IGZhc3QvanMvc29ydC1sYXJnZS1hcnJheS1leHBlY3RlZC50eHQ6IFVwZGF0ZWQuCisKIDIwMTAt MDktMTQgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgVG9ueSBDaGFuZy4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvanMvc29ydC1sYXJnZS1h cnJheS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9zb3J0 LWxhcmdlLWFycmF5LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gNjc0ODApCisrKyBMYXlvdXRUZXN0 cy9mYXN0L2pzL3NvcnQtbGFyZ2UtYXJyYXktZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBA IC04LDYgKzgsOSBAQCBQQVNTIHRlc3RbOTk5OV0gaXMgOTk5OQogUEFTUyB0ZXN0WzEwMDAwXSBp cyAxMDAwMAogUEFTUyB0ZXN0LnNsaWNlKDAsIDIwKS5qb2luKCcsICcpIGlzICcwLCAxLCAyLCAz LCA0LCA1LCA2LCA3LCA4LCA5LCAxMCwgMTEsIDEyLCAxMywgMTQsIDE1LCAxNiwgMTcsIDE4LCAx OScKIFBBU1MgdGVzdC5zbGljZSg5OTkwLCAxMDAxMCkuam9pbignLCAnKSBpcyAnOTk5MCwgOTk5 MSwgOTk5MiwgOTk5MywgOTk5NCwgOTk5NSwgOTk5NiwgOTk5NywgOTk5OCwgOTk5OSwgMTAwMDAs IDEwMDAxLCAxMDAwMiwgMTAwMDMsIDEwMDA0LCAxMDAwNSwgMTAwMDYsIDEwMDA3LCAxMDAwOCwg MTAwMDknCitQQVNTIHRlc3ROb1ZhbHVlcy5sZW5ndGggaXMgMTAxMTAKK1BBU1MgdGVzdE5vVmFs dWVzWzk5OTldIGlzIHVuZGVmaW5lZAorUEFTUyB0ZXN0Tm9WYWx1ZXNbMTAwMDBdIGlzIHVuZGVm aW5lZAogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCklu ZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9zb3J0LWxhcmdlLWFycmF5Lmpz Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0LXRlc3RzL3NvcnQtbGFy Z2UtYXJyYXkuanMJKHJldmlzaW9uIDY3NDgwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9qcy9zY3Jp cHQtdGVzdHMvc29ydC1sYXJnZS1hcnJheS5qcwkod29ya2luZyBjb3B5KQpAQCAtMyw3ICszLDcg QEAgZGVzY3JpcHRpb24oIlRoaXMgdGVzdHMgc29ydGluZyBhbiBhcnJheQogdmFyIHRlc3QgPSBb XTsKIGZvciAodmFyIGkgPSAwOyBpIDwgMTAwMTA7IGkrKykKICAgICB0ZXN0LnB1c2goMTAwMDkg LSBpKTsKLXRlc3Quc29ydChmdW5jdGlvbihhLGIpIHtyZXR1cm4gYSAtIGI7fSk7Cit0ZXN0LnNv cnQoZnVuY3Rpb24oYSwgYikge3JldHVybiBhIC0gYjt9KTsKIAogc2hvdWxkQmUoInRlc3QubGVu Z3RoIiwgIjEwMDEwIik7CiBzaG91bGRCZSgidGVzdFs5OTk5XSIsICI5OTk5Iik7CkBAIC0xMSw0 ICsxMSwxMiBAQCBzaG91bGRCZSgidGVzdFsxMDAwMF0iLCAiMTAwMDAiKTsKIHNob3VsZEJlKCJ0 ZXN0LnNsaWNlKDAsIDIwKS5qb2luKCcsICcpIiwgIicwLCAxLCAyLCAzLCA0LCA1LCA2LCA3LCA4 LCA5LCAxMCwgMTEsIDEyLCAxMywgMTQsIDE1LCAxNiwgMTcsIDE4LCAxOSciKTsKIHNob3VsZEJl KCJ0ZXN0LnNsaWNlKDk5OTAsIDEwMDEwKS5qb2luKCcsICcpIiwgIic5OTkwLCA5OTkxLCA5OTky LCA5OTkzLCA5OTk0LCA5OTk1LCA5OTk2LCA5OTk3LCA5OTk4LCA5OTk5LCAxMDAwMCwgMTAwMDEs IDEwMDAyLCAxMDAwMywgMTAwMDQsIDEwMDA1LCAxMDAwNiwgMTAwMDcsIDEwMDA4LCAxMDAwOSci KTsKIAordmFyIHRlc3ROb1ZhbHVlcyA9IFtdOwordGVzdE5vVmFsdWVzLmxlbmd0aCA9IDEwMTEw OwordGVzdE5vVmFsdWVzLnNvcnQoZnVuY3Rpb24oYSwgYikge3JldHVybiBhIDwgYjt9KTsKKwor c2hvdWxkQmUoInRlc3ROb1ZhbHVlcy5sZW5ndGgiLCAiMTAxMTAiKTsKK3Nob3VsZEJlKCJ0ZXN0 Tm9WYWx1ZXNbOTk5OV0iLCAidW5kZWZpbmVkIik7CitzaG91bGRCZSgidGVzdE5vVmFsdWVzWzEw MDAwXSIsICJ1bmRlZmluZWQiKTsKKwogdmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cg==