45779 2010-09-14 13:45:25 -0700 Exceptions are getting ignored on 64-bit Windows in the Web Process 2010-09-14 15:04:27 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All Windows 7 RESOLVED FIXED P2 Normal --- 1 jberlin jberlin aroben jberlin sfalken oldest_to_newest 279138 0 jberlin 2010-09-14 13:45:25 -0700 We should clear the PROCESS_CALLBACK_FILTER_ENABLED flag. Right now, it is not cleared, so exceptions thrown in callback routines are ignored, allowing the Web Process to enter into an inconsistent state and possibly resulting in a different exception. In order to make this effective, hotfix 976038 (http://support.microsoft.com/kb/976038) will need to be installed on the 64 bit machines in question, so we should add that information to the tools.html page as well. 279149 1 67602 jberlin 2010-09-14 14:01:05 -0700 Created attachment 67602 Clear the PROCESS_CALLBACK_FILTER_ENABLED flag 279166 2 67602 aroben 2010-09-14 14:15:29 -0700 Comment on attachment 67602 Clear the PROCESS_CALLBACK_FILTER_ENABLED flag View in context: https://bugs.webkit.org/attachment.cgi?id=67602&action=prettypatch > WebKit2/WebProcess/WebKitMain.cpp:82 > +static void disableProcessCallbackFilterForExceptions() I think disableUserModeCallbackExceptionFilter would be a clearer name. > WebKit2/WebProcess/WebKitMain.cpp:84 > + DWORD dwFlags; You should move this declaration to just before it's used. > WebKit2/WebProcess/WebKitMain.cpp:104 > + setPolicyPtr(dwFlags & ~0x1); I think you should make a named constant for 0x1. It would probably be useful to link to <http://blog.paulbetts.org/index.php/2010/07/20/the-case-of-the-disappearing-onload-exception-user-mode-callback-exceptions-in-x64/>, at least in your ChangeLog. > WebKitSite/building/tools.html:63 > +<li><p>Optional: Hotfix for 64-bit Windows to disable the process callback filter for exceptions</p> I'd say "user-mode" instead of "process" here. r=me 279177 3 jberlin 2010-09-14 14:34:13 -0700 (In reply to comment #2) > (From update of attachment 67602 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=67602&action=prettypatch > > > WebKit2/WebProcess/WebKitMain.cpp:82 > > +static void disableProcessCallbackFilterForExceptions() > I think disableUserModeCallbackExceptionFilter would be a clearer name. Changed. > > > WebKit2/WebProcess/WebKitMain.cpp:84 > > + DWORD dwFlags; > You should move this declaration to just before it's used. Moved to right above the if statement. > > > WebKit2/WebProcess/WebKitMain.cpp:104 > > + setPolicyPtr(dwFlags & ~0x1); > I think you should make a named constant for 0x1. Added a #define PROCESS_CALLBACK_FILTER_ENABLED 0x1 closer to the top of the file so that it matches the documentation. > > It would probably be useful to link to <http://blog.paulbetts.org/index.php/2010/07/20/the-case-of-the-disappearing-onload-exception-user-mode-callback-exceptions-in-x64/>, at least in your ChangeLog. > Put it both in the ChangeLog and in the comment in the function. > > WebKitSite/building/tools.html:63 > > +<li><p>Optional: Hotfix for 64-bit Windows to disable the process callback filter for exceptions</p> > I'd say "user-mode" instead of "process" here. Changed. > > r=me Thanks! 279198 4 67602 jberlin 2010-09-14 15:04:21 -0700 Comment on attachment 67602 Clear the PROCESS_CALLBACK_FILTER_ENABLED flag Committed in r67501 http://trac.webkit.org/changeset/67501 67602 2010-09-14 14:01:05 -0700 2010-09-14 15:04:21 -0700 Clear the PROCESS_CALLBACK_FILTER_ENABLED flag clearProcessCallbackFilterEnabledFlag.patch text/plain 4490 jberlin SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NzQ5MCkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDktMTQgIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBF eGNlcHRpb25zIGFyZSBnZXR0aW5nIGlnbm9yZWQgb24gNjQtYml0IFdpbmRvd3MgaW4gdGhlIFdl YiBQcm9jZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00NTc3OQorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJLaXRNYWluLmNwcDoKKyAgICAgICAg KGRpc2FibGVQcm9jZXNzQ2FsbGJhY2tGaWx0ZXJGb3JFeGNlcHRpb25zKToKKyAgICAgICAgQ2xl YXIgdGhlIFBST0NFU1NfQ0FMTEJBQ0tfRklMVEVSX0VOQUJMRUQgZmxhZyBzbyB0aGF0IGV4Y2Vw dGlvbnMgdGhyb3duIGluIGNhbGxiYWNrIHJvdXRpbmVzCisgICAgICAgIGFyZSBub3QgaWdub3Jl ZCwgYXMgZGVzY3JpYmVkIGluIGh0dHA6Ly9zdXBwb3J0Lm1pY3Jvc29mdC5jb20va2IvOTc2MDM4 CisgICAgICAgIChXZWJLaXRNYWluKToKKwogMjAxMC0wOS0xNCAgRXJpYyBTZWlkZWwgIDxlcmlj QHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIGNoYW5nZXMgcjY3 NDUxIGFuZCByNjc0NTEuCkluZGV4OiBXZWJLaXQyL1dlYlByb2Nlc3MvV2ViS2l0TWFpbi5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYktpdE1haW4uY3BwCShyZXZpc2lv biA2NzQ3MykKKysrIFdlYktpdDIvV2ViUHJvY2Vzcy9XZWJLaXRNYWluLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNzksNiArNzksMzMgQEAgc3RhdGljIHZvaWQgZW5hYmxlVGVybWluYXRpb25Pbkhl YXBDb3JydQogICAgIGhlYXBTZXRJbmZvcm1hdGlvbigwLCBoZWFwRW5hYmxlVGVybWluYXRpb25P bkNvcnJ1cHRpb24sIDAsIDApOwogfQogCitzdGF0aWMgdm9pZCBkaXNhYmxlUHJvY2Vzc0NhbGxi YWNrRmlsdGVyRm9yRXhjZXB0aW9ucygpCit7CisgICAgRFdPUkQgZHdGbGFnczsKKworICAgIHR5 cGVkZWYgQk9PTCAoTlRBUEkgKmdldFByb2Nlc3NVc2VyTW9kZUV4Y2VwdGlvblBvbGljeVB0ciko TFBEV09SRCBscEZsYWdzKTsKKyAgICB0eXBlZGVmIEJPT0wgKE5UQVBJICpzZXRQcm9jZXNzVXNl ck1vZGVFeGNlcHRpb25Qb2xpY3lQdHIpKERXT1JEIGR3RmxhZ3MpOworCisgICAgSE1PRFVMRSBs aWIgPSBMb2FkTGlicmFyeShURVhUKCJrZXJuZWwzMi5kbGwiKSk7CisgICAgQVNTRVJUKGxpYik7 CisKKyAgICBnZXRQcm9jZXNzVXNlck1vZGVFeGNlcHRpb25Qb2xpY3lQdHIgZ2V0UG9saWN5UHRy ID0gKGdldFByb2Nlc3NVc2VyTW9kZUV4Y2VwdGlvblBvbGljeVB0cilHZXRQcm9jQWRkcmVzcyhs aWIsICJHZXRQcm9jZXNzVXNlck1vZGVFeGNlcHRpb25Qb2xpY3kiKTsKKyAgICBzZXRQcm9jZXNz VXNlck1vZGVFeGNlcHRpb25Qb2xpY3lQdHIgc2V0UG9saWN5UHRyID0gKHNldFByb2Nlc3NVc2Vy TW9kZUV4Y2VwdGlvblBvbGljeVB0cilHZXRQcm9jQWRkcmVzcyhsaWIsICJTZXRQcm9jZXNzVXNl ck1vZGVFeGNlcHRpb25Qb2xpY3kiKTsKKworICAgIGlmICghZ2V0UG9saWN5UHRyIHx8ICFzZXRQ b2xpY3lQdHIgfHwgIWdldFBvbGljeVB0cigmZHdGbGFncykpIHsKKyAgICAgICAgRnJlZUxpYnJh cnkobGliKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKworICAgIC8vIElmIHRoaXMgZmxhZyBp c24ndCBjbGVhcmVkLCBleGNlcHRpb25zIHRoYXQgYXJlIHRocm93biB3aGVuIHJ1bm5pbmcgaW4g YSA2NC1iaXQgdmVyc2lvbiBvZgorICAgIC8vIFdpbmRvd3MgYXJlIGlnbm9yZWQsIHBvc3NpYmx5 IGxlYXZpbmcgU2FmYXJpIGluIGFuIGluY29uc2lzdGVudCBzdGF0ZSB0aGF0IGNvdWxkIGNhdXNl IGFuIAorICAgIC8vIHVucmVsYXRlZCBleGNlcHRpb24gdG8gYmUgdGhyb3duLgorICAgIC8vIGh0 dHA6Ly9zdXBwb3J0Lm1pY3Jvc29mdC5jb20va2IvOTc2MDM4CisgICAgc2V0UG9saWN5UHRyKGR3 RmxhZ3MgJiB+MHgxKTsKKworICAgIEZyZWVMaWJyYXJ5KGxpYik7Cit9CisKIGV4dGVybiAiQyIg X19kZWNsc3BlYyhkbGxleHBvcnQpIAogaW50IFdlYktpdE1haW4oSElOU1RBTkNFIGhJbnN0YW5j ZSwgSElOU1RBTkNFIGhQcmV2SW5zdGFuY2UsIExQVFNUUiBscHN0ckNtZExpbmUsIGludCBuQ21k U2hvdykKIHsKQEAgLTkyLDYgKzExOSw4IEBAIGludCBXZWJLaXRNYWluKEhJTlNUQU5DRSBoSW5z dGFuY2UsIEhJTlMKIAogICAgIGVuYWJsZVRlcm1pbmF0aW9uT25IZWFwQ29ycnVwdGlvbigpOwog CisgICAgZGlzYWJsZVByb2Nlc3NDYWxsYmFja0ZpbHRlckZvckV4Y2VwdGlvbnMoKTsKKwogICAg IENvbW1hbmRMaW5lIGNvbW1hbmRMaW5lOwogICAgIGlmICghY29tbWFuZExpbmUucGFyc2UobHBz dHJDbWRMaW5lKSkKICAgICAgICAgcmV0dXJuIEVYSVRfRkFJTFVSRTsKSW5kZXg6IFdlYktpdFNp dGUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFNpdGUvQ2hhbmdlTG9nCShyZXZpc2lv biA2NzQ5MCkKKysrIFdlYktpdFNpdGUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTAtMDktMTQgIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeGNlcHRp b25zIGFyZSBnZXR0aW5nIGlnbm9yZWQgb24gNjQtYml0IFdpbmRvd3MgaW4gdGhlIFdlYiBQcm9j ZXNzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU3 NzkKKworICAgICAgICAqIGJ1aWxkaW5nL3Rvb2xzLmh0bWw6CisgICAgICAgIEFkZCBpbnN0cnVj dGlvbnMgYWJvdXQgaG93IHRvIG9wdGlvbmFsbHkgZ2V0IGhvdGZpeCA5NzYwMzguCisKIDIwMTAt MDktMDYgIFJvYmluIFFpdSAgPHJvYmluLnFpdUB0b3JjaG1vYmlsZS5jb20uY24+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IFdlYktpdFNpdGUvYnVpbGRpbmcvdG9v bHMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRTaXRlL2J1aWxkaW5nL3Rvb2xzLmh0bWwJKHJl dmlzaW9uIDY3NDczKQorKysgV2ViS2l0U2l0ZS9idWlsZGluZy90b29scy5odG1sCSh3b3JraW5n IGNvcHkpCkBAIC02MCw2ICs2MCw4IEBAIEtlZXAgYWxsIHRoZSBkZWZhdWx0IG9wdGlvbnMgYW5k IGNsaWNrIDwKIAogPGxpPjxwPk9wdGlvbmFsOiBJbnN0YWxsIHRoZSAzMi1iaXQgdmVyc2lvbiBv ZiBEZWJ1Z2dpbmcgVG9vbHMgZm9yIFdpbmRvd3M8L3A+CiA8cD5EZWJ1Z2dpbmcgVG9vbHMgZm9y IFdpbmRvd3MgaW5jbHVkZXMgbWFueSB1c2VmdWwgZGVidWdnaW5nIHRvb2xzIHN1Y2ggYXMgV2lu RGJnIGFuZCBOVFNELiBTb21lIG9mIFdlYktpdCZyc3F1bztzIHRlc3RzIGFuZCBzY3JpcHRzIHVz ZSB0aGVzZSB0b29scy4gRm9sbG93IHRoZSA8YSB0YXJnZXQ9Imluc3RhbGx0b29scyIgaHJlZj0i aHR0cDovL3d3dy5taWNyb3NvZnQuY29tL3doZGMvZGV2dG9vbHMvZGVidWdnaW5nL2luc3RhbGx4 ODYubXNweCNiIj5pbnN0cnVjdGlvbnMgZm9yIGluc3RhbGxpbmcgdGhlIDMyLWJpdCB2ZXJzaW9u IG9mIERlYnVnZ2luZyBUb29scyBmb3IgV2luZG93czwvYT4uPC9wPgorPGxpPjxwPk9wdGlvbmFs OiBIb3RmaXggZm9yIDY0LWJpdCBXaW5kb3dzIHRvIGRpc2FibGUgdGhlIHByb2Nlc3MgY2FsbGJh Y2sgZmlsdGVyIGZvciBleGNlcHRpb25zPC9wPgorPHA+V2l0aG91dCB0aGUgPGEgaHJlZj0iaHR0 cDovL3N1cHBvcnQubWljcm9zb2Z0LmNvbS9rYi85NzYwMzgiPjk3NjAzOCBob3RmaXg8L2E+LCBl eGNlcHRpb25zIG1heSBiZSB0aHJvd24gaW4gY2FsbGJhY2sgcm91dGluZXMgdGhhdCBkbyBub3Qg Y2F1c2UgYSBjcmFzaCBidXQgbGVhdmUgdGhlIGFwcGxpY2F0aW9uIGluIGFuIGluY29uc2lzdGVu dCBzdGF0ZSB0aGF0IG1pZ2h0IGNhdXNlIGEgY3Jhc2ggbGF0ZXIuIFlvdSB3aWxsIG5lZWQgdG8g Y2xpY2sgb24gIlZpZXcgYW5kIHJlcXVlc3QgaG90Zml4IGRvd25sb2FkcyIgYW5kIGZpbGwgb3V0 IHRoZSBmb3JtLiBBIGxpbmsgdG8gZG93bmxvYWQgdGhlIGhvdGZpeCBhbmQgYSBwYXNzd29yZCB3 aWxsIGJlIGVtYWlsZWQgdG8geW91LjwvcD4KIDwvb2w+CiA8L2Rpdj4KIAo=