45776 2010-09-14 13:08:05 -0700 [Qt] Zoom factor for checkboxes and radios. 2010-09-16 00:33:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED Qt P3 Normal --- 41847 1 luiz luiz abarth commit-queue eric hausmann webkit.review.bot oldest_to_newest 279117 0 luiz 2010-09-14 13:08:05 -0700 RenderThemeQt does not consider RenderStyle::effectiveZoom when calculating sizes of checkboxes and radios. Even with this change the used QStyle must support different sizes for radios and checkboxes. QWindowStyle and QMacStyle, for example, do not. For testing I used Maemo5WebStyle class (WebCore/platform/qt/Maemo5WebStyle.h). This style may be put into use by passing CONFIG+=use_qt_mobile_theme to build-webkit. 279122 1 67595 luiz 2010-09-14 13:14:06 -0700 Created attachment 67595 patch 279123 2 67595 kenneth 2010-09-14 13:15:12 -0700 Comment on attachment 67595 patch I trust you on this, r=me. 279357 3 67595 commit-queue 2010-09-14 20:37:39 -0700 Comment on attachment 67595 patch Clearing flags on attachment: 67595 Committed r67531: <http://trac.webkit.org/changeset/67531> 279358 4 commit-queue 2010-09-14 20:37:44 -0700 All reviewed patches have been landed. Closing bug. 279394 5 webkit.review.bot 2010-09-14 22:45:42 -0700 http://trac.webkit.org/changeset/67531 might have broken GTK Linux 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/67531 http://trac.webkit.org/changeset/67532 http://trac.webkit.org/changeset/67533 279962 6 hausmann 2010-09-16 00:33:50 -0700 Revision r67531 cherry-picked into qtwebkit-2.1 with commit 94645f6b86d1fe64e7c39c8915b8aef244444270 67595 2010-09-14 13:14:06 -0700 2010-09-14 20:37:39 -0700 patch 0001-Qt-Zoom-factor-for-checkboxes-and-radios.patch text/plain 2676 luiz RnJvbSBmMTM4ZjliOGYzY2FjZTlmOTJkY2NhMDI2ZjZhYmUxZTEwODM4ZmQ5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMdWl6IEFnb3N0aW5pIDxsdWl6LmFnb3N0aW5pQG9wZW5ib3Nz YS5vcmc+CkRhdGU6IFR1ZSwgMTQgU2VwIDIwMTAgMTc6MTI6NTUgLTAzMDAKU3ViamVjdDogW1BB VENIXSBbUXRdIFpvb20gZmFjdG9yIGZvciBjaGVja2JveGVzIGFuZCByYWRpb3MuCiBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU3NzYKClJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgoKUmVuZGVyVGhlbWVRdCBkb2VzIG5vdCBjb25zaWRlciBSZW5kZXJTdHlsZTo6 ZWZmZWN0aXZlWm9vbSB3aGVuIGNhbGN1bGF0aW5nIHNpemVzIG9mCmNoZWNrYm94ZXMgYW5kIHJh ZGlvcy4KCkV2ZW4gd2l0aCB0aGlzIGNoYW5nZSB0aGUgdXNlZCBRU3R5bGUgbXVzdCBzdXBwb3J0 IGRpZmZlcmVudCBzaXplcyBmb3IgcmFkaW9zIGFuZCBjaGVja2JveGVzLgpRV2luZG93U3R5bGUg YW5kIFFNYWNTdHlsZSwgZm9yIGV4YW1wbGUsIGRvIG5vdC4KCiogcGxhdGZvcm0vcXQvUmVuZGVy VGhlbWVRdC5jcHA6CihXZWJDb3JlOjpSZW5kZXJUaGVtZVF0Ojpjb21wdXRlU2l6ZUJhc2VkT25T dHlsZSk6Ci0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICB8ICAgMTYg KysrKysrKysrKysrKysrKwogV2ViQ29yZS9wbGF0Zm9ybS9xdC9SZW5kZXJUaGVtZVF0LmNwcCB8 ICAgIDIgKysKIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmlu ZGV4IDE2MDg1NGMuLjBlNTI5YzEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDktMTQgIEx1aXogQWdv c3RpbmkgIDxsdWl6LmFnb3N0aW5pQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBab29tIGZhY3RvciBmb3IgY2hlY2ti b3hlcyBhbmQgcmFkaW9zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDU3NzYKKworICAgICAgICBSZW5kZXJUaGVtZVF0IGRvZXMgbm90IGNvbnNpZGVy IFJlbmRlclN0eWxlOjplZmZlY3RpdmVab29tIHdoZW4gY2FsY3VsYXRpbmcgc2l6ZXMgb2YKKyAg ICAgICAgY2hlY2tib3hlcyBhbmQgcmFkaW9zLgorCisgICAgICAgIEV2ZW4gd2l0aCB0aGlzIGNo YW5nZSB0aGUgdXNlZCBRU3R5bGUgbXVzdCBzdXBwb3J0IGRpZmZlcmVudCBzaXplcyBmb3IgcmFk aW9zIGFuZCBjaGVja2JveGVzLgorICAgICAgICBRV2luZG93U3R5bGUgYW5kIFFNYWNTdHlsZSwg Zm9yIGV4YW1wbGUsIGRvIG5vdC4KKworICAgICAgICAqIHBsYXRmb3JtL3F0L1JlbmRlclRoZW1l UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVRdDo6Y29tcHV0ZVNpemVCYXNl ZE9uU3R5bGUpOgorCiAyMDEwLTA5LTEwICBMdWl6IEFnb3N0aW5pICA8bHVpei5hZ29zdGluaUBv cGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9SZW5kZXJUaGVtZVF0LmNwcCBiL1dlYkNvcmUv cGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRdC5jcHAKaW5kZXggODcwZjBlYi4uNGE0NjFhYyAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9SZW5kZXJUaGVtZVF0LmNwcAorKysgYi9XZWJD b3JlL3BsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwCkBAIC0zODAsNiArMzgwLDcgQEAgdm9p ZCBSZW5kZXJUaGVtZVF0Ojpjb21wdXRlU2l6ZUJhc2VkT25TdHlsZShSZW5kZXJTdHlsZSogcmVu ZGVyU3R5bGUpIGNvbnN0CiAgICAgICAgIFFTdHlsZU9wdGlvbiBzdHlsZU9wdGlvbjsKICAgICAg ICAgc3R5bGVPcHRpb24uc3RhdGUgfD0gUVN0eWxlOjpTdGF0ZV9TbWFsbDsKICAgICAgICAgaW50 IGNoZWNrQm94V2lkdGggPSBzdHlsZS0+cGl4ZWxNZXRyaWMoUVN0eWxlOjpQTV9JbmRpY2F0b3JX aWR0aCwgJnN0eWxlT3B0aW9uKTsKKyAgICAgICAgY2hlY2tCb3hXaWR0aCAqPSByZW5kZXJTdHls ZS0+ZWZmZWN0aXZlWm9vbSgpOwogICAgICAgICBzaXplID0gUVNpemUoY2hlY2tCb3hXaWR0aCwg Y2hlY2tCb3hXaWR0aCk7CiAgICAgICAgIGJyZWFrOwogICAgIH0KQEAgLTM4Nyw2ICszODgsNyBA QCB2b2lkIFJlbmRlclRoZW1lUXQ6OmNvbXB1dGVTaXplQmFzZWRPblN0eWxlKFJlbmRlclN0eWxl KiByZW5kZXJTdHlsZSkgY29uc3QKICAgICAgICAgUVN0eWxlT3B0aW9uIHN0eWxlT3B0aW9uOwog ICAgICAgICBzdHlsZU9wdGlvbi5zdGF0ZSB8PSBRU3R5bGU6OlN0YXRlX1NtYWxsOwogICAgICAg ICBpbnQgcmFkaW9XaWR0aCA9IHN0eWxlLT5waXhlbE1ldHJpYyhRU3R5bGU6OlBNX0V4Y2x1c2l2 ZUluZGljYXRvcldpZHRoLCAmc3R5bGVPcHRpb24pOworICAgICAgICByYWRpb1dpZHRoICo9IHJl bmRlclN0eWxlLT5lZmZlY3RpdmVab29tKCk7CiAgICAgICAgIHNpemUgPSBRU2l6ZShyYWRpb1dp ZHRoLCByYWRpb1dpZHRoKTsKICAgICAgICAgYnJlYWs7CiAgICAgfQotLSAKMS43LjIuMgoK