<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>45771</bug_id>
          
          <creation_ts>2010-09-14 12:44:53 -0700</creation_ts>
          <short_desc>[Qt] V8 port: Get inspector up and running</short_desc>
          <delta_ts>2010-09-14 14:56:12 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt, QtTriaged</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Andreas Kling">kling</reporter>
          <assigned_to name="QtWebKit Unassigned">webkit-qt-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>eric</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>279094</commentid>
    <comment_count>0</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-09-14 12:44:53 -0700</bug_when>
    <thetext>For the inspector to function in the V8 port, we need to load WebCore/bindings/v8/DebuggerScript.js into ScriptDebugServer before firing up the inspector.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279100</commentid>
    <comment_count>1</comment_count>
      <attachid>67590</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-09-14 12:53:45 -0700</bug_when>
    <thetext>Created attachment 67590
Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279112</commentid>
    <comment_count>2</comment_count>
      <attachid>67590</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-09-14 13:03:22 -0700</bug_when>
    <thetext>Comment on attachment 67590
Proposed patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279118</commentid>
    <comment_count>3</comment_count>
      <attachid>67590</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-09-14 13:08:18 -0700</bug_when>
    <thetext>Comment on attachment 67590
Proposed patch

Clearing flags on attachment: 67590

Committed r67488: &lt;http://trac.webkit.org/changeset/67488&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279119</commentid>
    <comment_count>4</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-09-14 13:08:27 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279192</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-09-14 14:56:12 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/67488 might have broken GTK Linux 32-bit Debug
The following changes are on the blame list:
http://trac.webkit.org/changeset/67488
http://trac.webkit.org/changeset/67489
http://trac.webkit.org/changeset/67490
http://trac.webkit.org/changeset/67485
http://trac.webkit.org/changeset/67486
http://trac.webkit.org/changeset/67487</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>67590</attachid>
            <date>2010-09-14 12:53:45 -0700</date>
            <delta_ts>2010-09-14 13:08:18 -0700</delta_ts>
            <desc>Proposed patch</desc>
            <filename>bug-45771.diff</filename>
            <type>text/plain</type>
            <size>3429</size>
            <attacher name="Andreas Kling">kling</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
ODdiNzQ3Mi4uYzdkMDdjNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNCBAQAogMjAxMC0wOS0xNCAgQW5kcmVhcyBLbGlu
ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gVjggcG9ydDogR2V0IGluc3BlY3RvciB1cCBhbmQg
cnVubmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
NDU3NzEKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvV2ViS2l0LnFyYzogQWRkIERl
YnVnZ2VyU2NyaXB0LmpzCisKKzIwMTAtMDktMTQgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmts
aW5nQG5va2lhLmNvbT4KKwogICAgICAgICBSZXZpZXdlZCBieSBBbnRvbmlvIEdvbWVzLgogCiAg
ICAgICAgIFtRdF0gTnVtcGFkIEVudGVyIGtleSByZXR1cm5zIGtleUNvZGUgMCBpbnN0ZWFkIG9m
IDEzCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvV2ViS2l0LnFyYyBi
L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9XZWJLaXQucXJjCmluZGV4IGY5MGE5ZmUuLmMy
MjJmMGUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9XZWJLaXQucXJj
CisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9XZWJLaXQucXJjCkBAIC0yNjYsNSAr
MjY2LDYgQEAKICAgICA8ZmlsZT5JbWFnZXMvd2FybmluZ09yYW5nZURvdC5wbmc8L2ZpbGU+CiAg
ICAgPGZpbGU+SW1hZ2VzL3dhcm5pbmdzRXJyb3JzLnBuZzwvZmlsZT4KICAgICA8ZmlsZT5JbWFn
ZXMvd2hpdGVDb25uZWN0b3JQb2ludC5wbmc8L2ZpbGU+CisgICAgPGZpbGUgYWxpYXM9IkRlYnVn
Z2VyU2NyaXB0LmpzIj4uLi8uLi9iaW5kaW5ncy92OC9EZWJ1Z2dlclNjcmlwdC5qczwvZmlsZT4K
IDwvcXJlc291cmNlPgogPC9SQ0M+CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIv
V2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCAwMmI3M2ZlLi5lZWRiNWMzIDEwMDY0NAotLS0gYS9X
ZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx
NSBAQAorMjAxMC0wOS0xNCAgQW5kcmVhcyBLbGluZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29t
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0g
VjggcG9ydDogR2V0IGluc3BlY3RvciB1cCBhbmQgcnVubmluZworICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU3NzEKKworICAgICAgICAqIFdlYkNvcmVT
dXBwb3J0L0luc3BlY3RvckNsaWVudFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmVuc3VyZURl
YnVnZ2VyU2NyaXB0TG9hZGVkKTogQWRkZWQsIGxvYWRzIERlYnVnZ2VyU2NyaXB0LmpzIGludG8g
U2NyaXB0RGVidWdTZXJ2ZXIuCisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDbGllbnRRdDo6
b3Blbkluc3BlY3RvckZyb250ZW5kKTogRW5zdXJlIHRoYXQgRGVidWdnZXJTY3JpcHQuanMgaXMg
bG9hZGVkCisgICAgICAgIGJlZm9yZSBvcGVuaW5nIGFuIGluc3BlY3Rvci4KKwogMjAxMC0wOS0x
NCAgRW5yaWNvIFJvcyAgPGVyb3NAY29kZWF1cm9yYS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg
YnkgQW5kcmVhcyBLbGluZy4KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9J
bnNwZWN0b3JDbGllbnRRdC5jcHAgYi9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9y
Q2xpZW50UXQuY3BwCmluZGV4IDU1YWNhN2YuLmU2ZTZmZGUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9x
dC9XZWJDb3JlU3VwcG9ydC9JbnNwZWN0b3JDbGllbnRRdC5jcHAKKysrIGIvV2ViS2l0L3F0L1dl
YkNvcmVTdXBwb3J0L0luc3BlY3RvckNsaWVudFF0LmNwcApAQCAtMzcsMTIgKzM3LDE0IEBACiAj
aW5jbHVkZSAiUGFnZS5oIgogI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCiAjaW5jbHVkZSAi
U2NyaXB0Q29udHJvbGxlci5oIgorI2luY2x1ZGUgIlNjcmlwdERlYnVnU2VydmVyLmgiCiAjaW5j
bHVkZSAicXdlYmluc3BlY3Rvci5oIgogI2luY2x1ZGUgInF3ZWJpbnNwZWN0b3JfcC5oIgogI2lu
Y2x1ZGUgInF3ZWJwYWdlLmgiCiAjaW5jbHVkZSAicXdlYnBhZ2VfcC5oIgogI2luY2x1ZGUgInF3
ZWJ2aWV3LmgiCiAjaW5jbHVkZSA8UXRDb3JlL1FDb3JlQXBwbGljYXRpb24+CisjaW5jbHVkZSA8
UXRDb3JlL1FGaWxlPgogI2luY2x1ZGUgPFF0Q29yZS9RU2V0dGluZ3M+CiAjaW5jbHVkZSA8UXRD
b3JlL1FWYXJpYW50PgogCkBAIC05Myw2ICs5NSwyMiBAQCBwdWJsaWMgc2xvdHM6CiAgICAgfQog
fTsKIAorI2lmIFVTRShWOCkKK3N0YXRpYyB2b2lkIGVuc3VyZURlYnVnZ2VyU2NyaXB0TG9hZGVk
KCkKK3sKKyAgICBzdGF0aWMgYm9vbCBzY3JpcHRMb2FkZWQgPSBmYWxzZTsKKyAgICBpZiAoc2Ny
aXB0TG9hZGVkKQorICAgICAgICByZXR1cm47CisKKyAgICBRRmlsZSBkZWJ1Z2dlclNjcmlwdEZp
bGUoIjovd2Via2l0L2luc3BlY3Rvci9EZWJ1Z2dlclNjcmlwdC5qcyIpOworICAgIGlmIChkZWJ1
Z2dlclNjcmlwdEZpbGUub3BlbihRSU9EZXZpY2U6OlJlYWRPbmx5KSkgeworICAgICAgICBRQnl0
ZUFycmF5IGJhID0gZGVidWdnZXJTY3JpcHRGaWxlLnJlYWRBbGwoKTsKKyAgICAgICAgU2NyaXB0
RGVidWdTZXJ2ZXI6OnNoYXJlZCgpLnNldERlYnVnZ2VyU2NyaXB0U291cmNlKFN0cmluZyhiYS5j
b25zdERhdGEoKSwgYmEubGVuZ3RoKCkpKTsKKyAgICAgICAgc2NyaXB0TG9hZGVkID0gdHJ1ZTsK
KyAgICB9Cit9CisjZW5kaWYKKwogSW5zcGVjdG9yQ2xpZW50UXQ6Okluc3BlY3RvckNsaWVudFF0
KFFXZWJQYWdlKiBwYWdlKQogICAgIDogbV9pbnNwZWN0ZWRXZWJQYWdlKHBhZ2UpCiAgICAgLCBt
X2Zyb250ZW5kV2ViUGFnZSgwKQpAQCAtMTA5LDYgKzEyNywxMCBAQCB2b2lkIEluc3BlY3RvckNs
aWVudFF0OjppbnNwZWN0b3JEZXN0cm95ZWQoKQogICAgIAogdm9pZCBJbnNwZWN0b3JDbGllbnRR
dDo6b3Blbkluc3BlY3RvckZyb250ZW5kKFdlYkNvcmU6Okluc3BlY3RvckNvbnRyb2xsZXIqKQog
eworI2lmIFVTRShWOCkKKyAgICBlbnN1cmVEZWJ1Z2dlclNjcmlwdExvYWRlZCgpOworI2VuZGlm
CisKICAgICBRV2ViVmlldyogaW5zcGVjdG9yVmlldyA9IG5ldyBRV2ViVmlldzsKICAgICBJbnNw
ZWN0b3JDbGllbnRXZWJQYWdlKiBpbnNwZWN0b3JQYWdlID0gbmV3IEluc3BlY3RvckNsaWVudFdl
YlBhZ2UoaW5zcGVjdG9yVmlldyk7CiAgICAgaW5zcGVjdG9yVmlldy0+c2V0UGFnZShpbnNwZWN0
b3JQYWdlKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>