45747 2010-09-14 06:54:52 -0700 [Qt] qmake doesn't generate correct dependencies for rcc resource files 2010-09-14 09:13:58 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 abecsi webkit-unassigned abarth eric ossy webkit.review.bot oldest_to_newest 278863 0 abecsi 2010-09-14 06:54:52 -0700 Due to a bug of qmake it didn't generate a correct Makefile for WebCore and the rcc resource files miss the dependencies to js, css and png files which are needed by WebInspector, and this caused incremental build issues in QtWebKit. Hitherto the bots had a local workaround for this issue, but b139e7e96e5c47b412c4f0bbc4ae11d5cca99e61 (http://qt.gitorious.org/qt) - QTBUG-1918 fixed the issue partially and WebCore.pri only needs a small change to get correct dependencies. 278866 1 67545 abecsi 2010-09-14 06:59:56 -0700 Created attachment 67545 proposed patch 278867 2 67545 ossy 2010-09-14 07:00:37 -0700 Comment on attachment 67545 proposed patch LGTM, r=me. Thx for the fix. 278868 3 67545 abecsi 2010-09-14 07:05:02 -0700 Comment on attachment 67545 proposed patch Clearing flags on attachment: 67545 Committed r67465: <http://trac.webkit.org/changeset/67465> 278869 4 abecsi 2010-09-14 07:05:09 -0700 All reviewed patches have been landed. Closing bug. 278951 5 webkit.review.bot 2010-09-14 09:13:58 -0700 http://trac.webkit.org/changeset/67465 might have broken GTK Linux 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/67465 http://trac.webkit.org/changeset/67466 http://trac.webkit.org/changeset/67467 http://trac.webkit.org/changeset/67468 67545 2010-09-14 06:59:56 -0700 2010-09-14 07:05:01 -0700 proposed patch patch.diff text/plain 824 abecsi ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAwZjY2MTI5Li5mYjJiMGJh IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMDktMTQgIEFuZHJhcyBCZWNzaSAgPGFiZWNzaUB3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gcW1ha2UgZG9lc24n dCBnZW5lcmF0ZSBjb3JyZWN0IGRlcGVuZGVuY2llcyBmb3IgcmNjIHJlc291cmNlIGZpbGVzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTc0NworCisg ICAgICAgICogV2ViS2l0LnByaTogYWRkIE9VVF9QV0QgdG8gREVQRU5EUEFUSAorCiAyMDEwLTA5 LTExICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpkaWZmIC0tZ2l0IGEvV2ViS2l0LnByaSBiL1dl YktpdC5wcmkKaW5kZXggNDI3MjVkMi4uOTZkZDZjNSAxMDA2NDQKLS0tIGEvV2ViS2l0LnByaQor KysgYi9XZWJLaXQucHJpCkBAIC03LDYgKzcsNyBAQCBDT05GSUcoUVRESVJfYnVpbGQpOiBDT05G SUcgKz0gc3RhbmRhbG9uZV9wYWNrYWdlCiBlbHNlOmV4aXN0cygkJFBXRC9XZWJDb3JlL2dlbmVy YXRlZCk6IENPTkZJRyArPSBzdGFuZGFsb25lX3BhY2thZ2UKIAogQ09ORklHICs9IGRlcGVuZF9p bmNsdWRlcGF0aAorREVQRU5EUEFUSCArPSAkJE9VVF9QV0QKIAogREVGSU5FUyArPSBCVUlMRElO R19RVF9fPTEKIGJ1aWxkaW5nLWxpYnMgewo=