45745 2010-09-14 05:03:55 -0700 [Qt] Cookie operations should use NetworkingContext 2010-09-14 06:18:15 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 kbalazs webkit-unassigned abecsi oldest_to_newest 278826 0 kbalazs 2010-09-14 05:03:55 -0700 Like we changed ResourceHandle in http://trac.webkit.org/changeset/67291 to get the QNetworkAccessManager from the NetworkingContext we should change the cookie operations in CookieJarQt.cpp. Currently we are crashing with WebKit2. 278833 1 67541 kbalazs 2010-09-14 05:12:09 -0700 Created attachment 67541 proposed patch 278842 2 67543 kbalazs 2010-09-14 05:53:07 -0700 Created attachment 67543 proposed patch v2 Corrected the NetworkingContext usage: use the loader to obtaining it. 278843 3 67543 kling 2010-09-14 05:58:40 -0700 Comment on attachment 67543 proposed patch v2 > + No new functionality so new tests. Missing "no" r=me 278846 4 abecsi 2010-09-14 06:17:05 -0700 Committed r67461: <http://trac.webkit.org/changeset/67461> 278847 5 67543 abecsi 2010-09-14 06:18:15 -0700 Comment on attachment 67543 proposed patch v2 Clearing flags. 67541 2010-09-14 05:12:09 -0700 2010-09-14 05:53:07 -0700 proposed patch land_cookiefix.diff text/plain 1628 kbalazs ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2I4NDhkYi4uMzMyM2EzNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOS0xNCAgQmFsYXpzIEtlbGVt ZW4gIDxrYkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW1F0XSBDb29raWUgb3BlcmF0aW9ucyBzaG91bGQgdXNlIE5ldHdv cmtpbmdDb250ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00NTc0NQorICAgICAgICBObyBuZXcgZnVuY3Rpb25hbGl0eSBzbyBuZXcgdGVzdHMuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Db29raWVKYXJRdC5jcHA6CisgICAgICAgIChXZWJDb3Jl Ojpjb29raWVKYXIpOiBVc2UgdGhlIE5ldHdvcmtpbmdDb250ZXh0IGZvciBvYnRhaW5pbmcgdGhl IFFOZXR3b3JrQWNjZXNzTWFuYWdlcgorICAgICAgICBpbnN0ZWFkIG9mIGRpcmVjdGx5IGFjY2Vz c2luZyB0aGUgRnJhbWVMb2FkZXJDbGllbnQuCisKIDIwMTAtMDktMTMgIEFkYW0gQmFydGggIDxh YmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vcXQvQ29va2llSmFyUXQuY3BwIGIvV2ViQ29yZS9w bGF0Zm9ybS9xdC9Db29raWVKYXJRdC5jcHAKaW5kZXggMTUwNTNlYi4uYTFiZmQyZiAxMDA2NDQK LS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9Db29raWVKYXJRdC5jcHAKKysrIGIvV2ViQ29yZS9w bGF0Zm9ybS9xdC9Db29raWVKYXJRdC5jcHAKQEAgLTMwLDYgKzMwLDcgQEAKIAogI2luY2x1ZGUg IkNvb2tpZS5oIgogI2luY2x1ZGUgIkRvY3VtZW50LmgiCisjaW5jbHVkZSAiRnJhbWVOZXR3b3Jr aW5nQ29udGV4dC5oIgogI2luY2x1ZGUgIktVUkwuaCIKICNpbmNsdWRlICJQbGF0Zm9ybVN0cmlu Zy5oIgogCkBAIC01MSw5ICs1Miw4IEBAIHN0YXRpYyBRTmV0d29ya0Nvb2tpZUphciAqY29va2ll SmFyKGNvbnN0IERvY3VtZW50ICpkb2N1bWVudCkKICAgICBGcmFtZUxvYWRlciAqbG9hZGVyID0g ZnJhbWUtPmxvYWRlcigpOwogICAgIGlmICghbG9hZGVyKQogICAgICAgICByZXR1cm4gMDsKLSAg ICBRV2ViRnJhbWUqIHdlYkZyYW1lID0gc3RhdGljX2Nhc3Q8RnJhbWVMb2FkZXJDbGllbnRRdCo+ KGxvYWRlci0+Y2xpZW50KCkpLT53ZWJGcmFtZSgpOwotICAgIFFXZWJQYWdlKiBwYWdlID0gd2Vi RnJhbWUtPnBhZ2UoKTsKLSAgICBRTmV0d29ya0FjY2Vzc01hbmFnZXIqIG1hbmFnZXIgPSBwYWdl LT5uZXR3b3JrQWNjZXNzTWFuYWdlcigpOworICAgIFJlZlB0cjxGcmFtZU5ldHdvcmtpbmdDb250 ZXh0PiBjb250ZXh0ID0gbG9hZGVyLT5jbGllbnQoKS0+Y3JlYXRlTmV0d29ya2luZ0NvbnRleHQo KTsKKyAgICBRTmV0d29ya0FjY2Vzc01hbmFnZXIqIG1hbmFnZXIgPSBjb250ZXh0LT5uZXR3b3Jr QWNjZXNzTWFuYWdlcigpOwogICAgIFFOZXR3b3JrQ29va2llSmFyKiBqYXIgPSBtYW5hZ2VyLT5j b29raWVKYXIoKTsKICAgICByZXR1cm4gamFyOwogfQo= 67543 2010-09-14 05:53:07 -0700 2010-09-14 06:18:15 -0700 proposed patch v2 land_cookiefix.diff text/plain 1573 kbalazs ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2I4NDhkYi4uMzMyM2EzNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOS0xNCAgQmFsYXpzIEtlbGVt ZW4gIDxrYkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW1F0XSBDb29raWUgb3BlcmF0aW9ucyBzaG91bGQgdXNlIE5ldHdv cmtpbmdDb250ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00NTc0NQorICAgICAgICBObyBuZXcgZnVuY3Rpb25hbGl0eSBzbyBuZXcgdGVzdHMuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Db29raWVKYXJRdC5jcHA6CisgICAgICAgIChXZWJDb3Jl Ojpjb29raWVKYXIpOiBVc2UgdGhlIE5ldHdvcmtpbmdDb250ZXh0IGZvciBvYnRhaW5pbmcgdGhl IFFOZXR3b3JrQWNjZXNzTWFuYWdlcgorICAgICAgICBpbnN0ZWFkIG9mIGRpcmVjdGx5IGFjY2Vz c2luZyB0aGUgRnJhbWVMb2FkZXJDbGllbnQuCisKIDIwMTAtMDktMTMgIEFkYW0gQmFydGggIDxh YmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vcXQvQ29va2llSmFyUXQuY3BwIGIvV2ViQ29yZS9w bGF0Zm9ybS9xdC9Db29raWVKYXJRdC5jcHAKaW5kZXggMTUwNTNlYi4uNGUxZGUyMyAxMDA2NDQK LS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9Db29raWVKYXJRdC5jcHAKKysrIGIvV2ViQ29yZS9w bGF0Zm9ybS9xdC9Db29raWVKYXJRdC5jcHAKQEAgLTMxLDYgKzMxLDcgQEAKICNpbmNsdWRlICJD b29raWUuaCIKICNpbmNsdWRlICJEb2N1bWVudC5oIgogI2luY2x1ZGUgIktVUkwuaCIKKyNpbmNs dWRlICJOZXR3b3JraW5nQ29udGV4dC5oIgogI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCiAK ICNpbmNsdWRlICJxd2VicGFnZS5oIgpAQCAtNTEsOSArNTIsNyBAQCBzdGF0aWMgUU5ldHdvcmtD b29raWVKYXIgKmNvb2tpZUphcihjb25zdCBEb2N1bWVudCAqZG9jdW1lbnQpCiAgICAgRnJhbWVM b2FkZXIgKmxvYWRlciA9IGZyYW1lLT5sb2FkZXIoKTsKICAgICBpZiAoIWxvYWRlcikKICAgICAg ICAgcmV0dXJuIDA7Ci0gICAgUVdlYkZyYW1lKiB3ZWJGcmFtZSA9IHN0YXRpY19jYXN0PEZyYW1l TG9hZGVyQ2xpZW50UXQqPihsb2FkZXItPmNsaWVudCgpKS0+d2ViRnJhbWUoKTsKLSAgICBRV2Vi UGFnZSogcGFnZSA9IHdlYkZyYW1lLT5wYWdlKCk7Ci0gICAgUU5ldHdvcmtBY2Nlc3NNYW5hZ2Vy KiBtYW5hZ2VyID0gcGFnZS0+bmV0d29ya0FjY2Vzc01hbmFnZXIoKTsKKyAgICBRTmV0d29ya0Fj Y2Vzc01hbmFnZXIqIG1hbmFnZXIgPSBsb2FkZXItPm5ldHdvcmtpbmdDb250ZXh0KCktPm5ldHdv cmtBY2Nlc3NNYW5hZ2VyKCk7CiAgICAgUU5ldHdvcmtDb29raWVKYXIqIGphciA9IG1hbmFnZXIt PmNvb2tpZUphcigpOwogICAgIHJldHVybiBqYXI7CiB9Cg==