<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>45743</bug_id>
          
          <creation_ts>2010-09-14 04:43:30 -0700</creation_ts>
          <short_desc>Make WebDeviceOrientationClientMock constructor private.</short_desc>
          <delta_ts>2010-09-14 06:20:34 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Hans Wennborg">hans</reporter>
          <assigned_to name="Hans Wennborg">hans</assigned_to>
          <cc>jorlow</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>278816</commentid>
    <comment_count>0</comment_count>
    <who name="Hans Wennborg">hans</who>
    <bug_when>2010-09-14 04:43:30 -0700</bug_when>
    <thetext>Make WebDeviceOrientationClientMock constructor private.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>278817</commentid>
    <comment_count>1</comment_count>
      <attachid>67536</attachid>
    <who name="Hans Wennborg">hans</who>
    <bug_when>2010-09-14 04:47:36 -0700</bug_when>
    <thetext>Created attachment 67536
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>278819</commentid>
    <comment_count>2</comment_count>
      <attachid>67536</attachid>
    <who name="Jeremy Orlow">jorlow</who>
    <bug_when>2010-09-14 04:50:12 -0700</bug_when>
    <thetext>Comment on attachment 67536
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>278848</commentid>
    <comment_count>3</comment_count>
      <attachid>67536</attachid>
    <who name="Hans Wennborg">hans</who>
    <bug_when>2010-09-14 06:20:26 -0700</bug_when>
    <thetext>Comment on attachment 67536
Patch

Clearing flags on attachment: 67536

Committed r67462: &lt;http://trac.webkit.org/changeset/67462&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>278849</commentid>
    <comment_count>4</comment_count>
    <who name="Hans Wennborg">hans</who>
    <bug_when>2010-09-14 06:20:34 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>67536</attachid>
            <date>2010-09-14 04:47:36 -0700</date>
            <delta_ts>2010-09-14 06:20:26 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-45743-20100914124734.patch</filename>
            <type>text/plain</type>
            <size>1839</size>
            <attacher name="Hans Wennborg">hans</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v
Q2hhbmdlTG9nCmluZGV4IDk3MmFmMjgyMDNlNmUzNjJhMWQwOTA3ZDkwNTg5YjViOGU0YWI0NmEu
LjRmYTM4YzI0YTMyNjI2YjdjYzE1OGQ1NjBkZTFkODVhNjIyMjRmNzAgMTAwNjQ0Ci0tLSBhL1dl
YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA
QCAtMSwzICsxLDE2IEBACisyMDEwLTA5LTE0ICBIYW5zIFdlbm5ib3JnICA8aGFuc0BjaHJvbWl1
bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
TWFrZSBXZWJEZXZpY2VPcmllbnRhdGlvbkNsaWVudE1vY2sgY29uc3RydWN0b3IgcHJpdmF0ZS4K
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1NzQzCisK
KyAgICAgICAgQ2xpZW50cyBzaG91bGQgdXNlIHRoZSBjcmVhdGUgbWVtYmVyIGZ1bmN0aW9uIGlu
c3RlYWQuIER1bXBSZW5kZXJUcmVlCisgICAgICAgIGFuZCB0aGUgQ2hyb21pdW0gdGVzdF9zaGVs
bCBoYXZlIHByZXZpb3VzbHkgYmVlbiB1cGRhdGVkIHRvIGNhbGwgY3JlYXRlLgorCisgICAgICAg
ICogcHVibGljL1dlYkRldmljZU9yaWVudGF0aW9uQ2xpZW50TW9jay5oOgorICAgICAgICAoV2Vi
S2l0OjpXZWJEZXZpY2VPcmllbnRhdGlvbkNsaWVudE1vY2s6OldlYkRldmljZU9yaWVudGF0aW9u
Q2xpZW50TW9jayk6CisKIDIwMTAtMDktMTMgIEVyaWMgVWhyaGFuZSAgPGVyaWN1QGNocm9taXVt
Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYS9X
ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRldmljZU9yaWVudGF0aW9uQ2xpZW50TW9jay5oIGIv
V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEZXZpY2VPcmllbnRhdGlvbkNsaWVudE1vY2suaApp
bmRleCA0YjRmZmU5Mjc4ZTJhY2Q1NTFhM2Q4Zjc2ODIyMGM0ZGZmYTdkMmViLi43ZmFlNzkyNWNi
YWZkZTVmZjM4N2ZmMDU5OTZlMmZiNGU3MTY5MzA3IDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21p
dW0vcHVibGljL1dlYkRldmljZU9yaWVudGF0aW9uQ2xpZW50TW9jay5oCisrKyBiL1dlYktpdC9j
aHJvbWl1bS9wdWJsaWMvV2ViRGV2aWNlT3JpZW50YXRpb25DbGllbnRNb2NrLmgKQEAgLTM3LDcg
KzM3LDYgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiBjbGFzcyBXZWJEZXZpY2VPcmllbnRhdGlvbkNs
aWVudE1vY2sgOiBwdWJsaWMgV2ViRGV2aWNlT3JpZW50YXRpb25DbGllbnQgewogcHVibGljOgog
ICAgIFdFQktJVF9BUEkgc3RhdGljIFdlYkRldmljZU9yaWVudGF0aW9uQ2xpZW50TW9jayogY3Jl
YXRlKCk7Ci0gICAgV2ViRGV2aWNlT3JpZW50YXRpb25DbGllbnRNb2NrKCkgeyBpbml0aWFsaXpl
KCk7IH0gLy8gRklYTUU6IE1ha2UgY29uc3RydWN0b3IgcHJpdmF0ZSBvbmNlIGRvd25zdHJlYW0g
aGFzIGJlZW4gZml4ZWQuCiAgICAgfldlYkRldmljZU9yaWVudGF0aW9uQ2xpZW50TW9jaygpIHsg
cmVzZXQoKTsgfQogCiAgICAgdmlydHVhbCB2b2lkIHNldENvbnRyb2xsZXIoV2ViRGV2aWNlT3Jp
ZW50YXRpb25Db250cm9sbGVyKik7CkBAIC00OCw2ICs0Nyw3IEBAIHB1YmxpYzoKICAgICBXRUJL
SVRfQVBJIHZvaWQgc2V0T3JpZW50YXRpb24oV2ViRGV2aWNlT3JpZW50YXRpb24mKTsKIAogcHJp
dmF0ZToKKyAgICBXZWJEZXZpY2VPcmllbnRhdGlvbkNsaWVudE1vY2soKSB7IGluaXRpYWxpemUo
KTsgfQogICAgIFdFQktJVF9BUEkgdm9pZCBpbml0aWFsaXplKCk7CiAgICAgV0VCS0lUX0FQSSB2
b2lkIHJlc2V0KCk7CiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>