45741 2010-09-14 04:15:03 -0700 [EFL] ewk_frame_view_create_for_view set null as theme. 2010-09-14 17:35:14 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 ryuan.choi webkit-unassigned antognolli+webkit commit-queue leandro lucas.de.marchi tonikitoo oldest_to_newest 278808 0 ryuan.choi 2010-09-14 04:15:03 -0700 I traced below message and I found that ewk_fram_view_create_for_view calls setEdjeTheme with null argument. ERR: /workspace/webkit/WebCore/platform/efl/ScrollbarEfl.cpp:119 setParent() Could not load theme 'scrollbar.vertical': no theme path set. ERR: /workspace/webkit/WebCore/platform/efl/ScrollbarEfl.cpp:119 setParent() Could not load theme 'scrollbar.horizontal': no theme path set. 278811 1 67535 ryuan.choi 2010-09-14 04:25:01 -0700 Created attachment 67535 Patch 278818 2 67535 lucas.de.marchi 2010-09-14 04:48:27 -0700 Comment on attachment 67535 Patch > Index: WebKit/efl/ewk/ewk_frame.cpp > =================================================================== > --- WebKit/efl/ewk/ewk_frame.cpp (revision 67458) > +++ WebKit/efl/ewk/ewk_frame.cpp (working copy) > @@ -1962,7 +1962,9 @@ void ewk_frame_view_create_for_view(Evas > sd->frame->createView(size, bg, !a, WebCore::IntSize(), false); > if (!sd->frame->view()) > return; > - sd->frame->view()->setEdjeTheme(sd->theme); > + > + const char * theme = ewk_view_theme_get(view); `---- Extra space here. Otherwise, it looks good. 278821 3 67537 ryuan.choi 2010-09-14 04:56:01 -0700 Created attachment 67537 Patch 278881 4 67537 kenneth 2010-09-14 07:30:38 -0700 Comment on attachment 67537 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67537&action=prettypatch When you upload a new patch, please say what you changed. Like "fixed above comments". 279270 5 67537 commit-queue 2010-09-14 17:35:08 -0700 Comment on attachment 67537 Patch Clearing flags on attachment: 67537 Committed r67519: <http://trac.webkit.org/changeset/67519> 279271 6 commit-queue 2010-09-14 17:35:14 -0700 All reviewed patches have been landed. Closing bug. 67535 2010-09-14 04:25:01 -0700 2010-09-14 04:55:55 -0700 Patch bug-45741-20100914202457.patch text/plain 2500 ryuan.choi SW5kZXg6IFdlYktpdC9lZmwvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9lZmwvQ2hh bmdlTG9nCShyZXZpc2lvbiA2NzQ1OCkKKysrIFdlYktpdC9lZmwvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDktMTQgIFJ5dWFuIENob2kgIDxyeXVhbi5j aG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtFRkxdIGV3a19mcmFtZV92aWV3X2NyZWF0ZV9mb3JfdmlldyBzZXQgbnVsbCBh cyB0aGVtZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ1NzQxCisKKyAgICAgICAgQWRkIHRoZW1lIGluIGV3a192aWV3IHRvIHVzZSBpbnN0ZWFkIG9m IGZyYW1lJ3MgdGhlbWUgd2hpY2ggaXMgbnVsbCBpbgorICAgICAgICBld2tfZnJhbWVfdmlld19j cmVhdGVfZm9yX3ZpZXcuCisKKyAgICAgICAgKiBld2svZXdrX2ZyYW1lLmNwcDoKKyAgICAgICAg KGV3a19mcmFtZV92aWV3X2NyZWF0ZV9mb3Jfdmlldyk6CisgICAgICAgICogZXdrL2V3a192aWV3 LmNwcDoKKyAgICAgICAgKGV3a192aWV3X3RoZW1lX3NldCk6CisgICAgICAgIChld2tfdmlld190 aGVtZV9nZXQpOgorCiAyMDEwLTA5LTEzICBSYWZhZWwgQW50b2dub2xsaSAgPGFudG9nbm9sbGlA cHJvZnVzaW9uLm1vYmk+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguCkluZGV4OiBX ZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9lZmwvZXdr L2V3a19mcmFtZS5jcHAJKHJldmlzaW9uIDY3NDU4KQorKysgV2ViS2l0L2VmbC9ld2svZXdrX2Zy YW1lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTk2Miw3ICsxOTYyLDkgQEAgdm9pZCBld2tfZnJh bWVfdmlld19jcmVhdGVfZm9yX3ZpZXcoRXZhcwogICAgIHNkLT5mcmFtZS0+Y3JlYXRlVmlldyhz aXplLCBiZywgIWEsIFdlYkNvcmU6OkludFNpemUoKSwgZmFsc2UpOwogICAgIGlmICghc2QtPmZy YW1lLT52aWV3KCkpCiAgICAgICAgIHJldHVybjsKLSAgICBzZC0+ZnJhbWUtPnZpZXcoKS0+c2V0 RWRqZVRoZW1lKHNkLT50aGVtZSk7CisKKyAgICBjb25zdCBjaGFyICogdGhlbWUgPSBld2tfdmll d190aGVtZV9nZXQodmlldyk7CisgICAgc2QtPmZyYW1lLT52aWV3KCktPnNldEVkamVUaGVtZSh0 aGVtZSk7CiAgICAgc2QtPmZyYW1lLT52aWV3KCktPnNldEV2YXNPYmplY3Qobyk7CiB9CiAKSW5k ZXg6IFdlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvZWZs L2V3ay9ld2tfdmlldy5jcHAJKHJldmlzaW9uIDY3NDU4KQorKysgV2ViS2l0L2VmbC9ld2svZXdr X3ZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05MCw2ICs5MCw3IEBAIHN0cnVjdCBfRXdrX1Zp ZXdfUHJpdmF0ZV9EYXRhIHsKICAgICAgICAgY29uc3QgY2hhciogZW5jb2RpbmdfZGVmYXVsdDsK ICAgICAgICAgY29uc3QgY2hhciogZW5jb2RpbmdfY3VzdG9tOwogICAgICAgICBjb25zdCBjaGFy KiBjYWNoZV9kaXJlY3Rvcnk7CisgICAgICAgIGNvbnN0IGNoYXIqIHRoZW1lOwogICAgICAgICBp bnQgZm9udF9taW5pbXVtX3NpemU7CiAgICAgICAgIGludCBmb250X21pbmltdW1fbG9naWNhbF9z aXplOwogICAgICAgICBpbnQgZm9udF9kZWZhdWx0X3NpemU7CkBAIC0xMTEzLDYgKzExMTQsOSBA QCB2b2lkIGV3a192aWV3X2ZpeGVkX2xheW91dF9zaXplX2dldChFdmFzCiB2b2lkIGV3a192aWV3 X3RoZW1lX3NldChFdmFzX09iamVjdCogbywgY29uc3QgY2hhciogcGF0aCkKIHsKICAgICBFV0tf VklFV19TRF9HRVRfT1JfUkVUVVJOKG8sIHNkKTsKKyAgICBFV0tfVklFV19QUklWX0dFVF9PUl9S RVRVUk4oc2QsIHByaXYpOworICAgIGlmICghZWluYV9zdHJpbmdzaGFyZV9yZXBsYWNlKCZwcml2 LT5zZXR0aW5ncy50aGVtZSwgcGF0aCkpCisgICAgICAgIHJldHVybjsKICAgICBld2tfZnJhbWVf dGhlbWVfc2V0KHNkLT5tYWluX2ZyYW1lLCBwYXRoKTsKIH0KIApAQCAtMTEyOCw3ICsxMTMyLDgg QEAgdm9pZCBld2tfdmlld190aGVtZV9zZXQoRXZhc19PYmplY3QqIG8sIAogY29uc3QgY2hhciog ZXdrX3ZpZXdfdGhlbWVfZ2V0KEV2YXNfT2JqZWN0KiBvKQogewogICAgIEVXS19WSUVXX1NEX0dF VF9PUl9SRVRVUk4obywgc2QsIDApOwotICAgIHJldHVybiBld2tfZnJhbWVfdGhlbWVfZ2V0KHNk LT5tYWluX2ZyYW1lKTsKKyAgICBFV0tfVklFV19QUklWX0dFVF9PUl9SRVRVUk4oc2QsIHByaXYs IDApOworICAgIHJldHVybiBwcml2LT5zZXR0aW5ncy50aGVtZTsKIH0KIAogLyoqCg== 67537 2010-09-14 04:56:01 -0700 2010-09-14 17:35:08 -0700 Patch bug-45741-20100914205557.patch text/plain 2499 ryuan.choi SW5kZXg6IFdlYktpdC9lZmwvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9lZmwvQ2hh bmdlTG9nCShyZXZpc2lvbiA2NzQ1OCkKKysrIFdlYktpdC9lZmwvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDktMTQgIFJ5dWFuIENob2kgIDxyeXVhbi5j aG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtFRkxdIGV3a19mcmFtZV92aWV3X2NyZWF0ZV9mb3JfdmlldyBzZXQgbnVsbCBh cyB0aGVtZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ1NzQxCisKKyAgICAgICAgQWRkIHRoZW1lIGluIGV3a192aWV3IHRvIHVzZSBpbnN0ZWFkIG9m IGZyYW1lJ3MgdGhlbWUgd2hpY2ggaXMgbnVsbCBpbgorICAgICAgICBld2tfZnJhbWVfdmlld19j cmVhdGVfZm9yX3ZpZXcuCisKKyAgICAgICAgKiBld2svZXdrX2ZyYW1lLmNwcDoKKyAgICAgICAg KGV3a19mcmFtZV92aWV3X2NyZWF0ZV9mb3Jfdmlldyk6CisgICAgICAgICogZXdrL2V3a192aWV3 LmNwcDoKKyAgICAgICAgKGV3a192aWV3X3RoZW1lX3NldCk6CisgICAgICAgIChld2tfdmlld190 aGVtZV9nZXQpOgorCiAyMDEwLTA5LTEzICBSYWZhZWwgQW50b2dub2xsaSAgPGFudG9nbm9sbGlA cHJvZnVzaW9uLm1vYmk+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguCkluZGV4OiBX ZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9lZmwvZXdr L2V3a19mcmFtZS5jcHAJKHJldmlzaW9uIDY3NDU4KQorKysgV2ViS2l0L2VmbC9ld2svZXdrX2Zy YW1lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTk2Miw3ICsxOTYyLDkgQEAgdm9pZCBld2tfZnJh bWVfdmlld19jcmVhdGVfZm9yX3ZpZXcoRXZhcwogICAgIHNkLT5mcmFtZS0+Y3JlYXRlVmlldyhz aXplLCBiZywgIWEsIFdlYkNvcmU6OkludFNpemUoKSwgZmFsc2UpOwogICAgIGlmICghc2QtPmZy YW1lLT52aWV3KCkpCiAgICAgICAgIHJldHVybjsKLSAgICBzZC0+ZnJhbWUtPnZpZXcoKS0+c2V0 RWRqZVRoZW1lKHNkLT50aGVtZSk7CisKKyAgICBjb25zdCBjaGFyKiB0aGVtZSA9IGV3a192aWV3 X3RoZW1lX2dldCh2aWV3KTsKKyAgICBzZC0+ZnJhbWUtPnZpZXcoKS0+c2V0RWRqZVRoZW1lKHRo ZW1lKTsKICAgICBzZC0+ZnJhbWUtPnZpZXcoKS0+c2V0RXZhc09iamVjdChvKTsKIH0KIApJbmRl eDogV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9lZmwv ZXdrL2V3a192aWV3LmNwcAkocmV2aXNpb24gNjc0NTgpCisrKyBXZWJLaXQvZWZsL2V3ay9ld2tf dmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTkwLDYgKzkwLDcgQEAgc3RydWN0IF9Fd2tfVmll d19Qcml2YXRlX0RhdGEgewogICAgICAgICBjb25zdCBjaGFyKiBlbmNvZGluZ19kZWZhdWx0Owog ICAgICAgICBjb25zdCBjaGFyKiBlbmNvZGluZ19jdXN0b207CiAgICAgICAgIGNvbnN0IGNoYXIq IGNhY2hlX2RpcmVjdG9yeTsKKyAgICAgICAgY29uc3QgY2hhciogdGhlbWU7CiAgICAgICAgIGlu dCBmb250X21pbmltdW1fc2l6ZTsKICAgICAgICAgaW50IGZvbnRfbWluaW11bV9sb2dpY2FsX3Np emU7CiAgICAgICAgIGludCBmb250X2RlZmF1bHRfc2l6ZTsKQEAgLTExMTMsNiArMTExNCw5IEBA IHZvaWQgZXdrX3ZpZXdfZml4ZWRfbGF5b3V0X3NpemVfZ2V0KEV2YXMKIHZvaWQgZXdrX3ZpZXdf dGhlbWVfc2V0KEV2YXNfT2JqZWN0KiBvLCBjb25zdCBjaGFyKiBwYXRoKQogewogICAgIEVXS19W SUVXX1NEX0dFVF9PUl9SRVRVUk4obywgc2QpOworICAgIEVXS19WSUVXX1BSSVZfR0VUX09SX1JF VFVSTihzZCwgcHJpdik7CisgICAgaWYgKCFlaW5hX3N0cmluZ3NoYXJlX3JlcGxhY2UoJnByaXYt PnNldHRpbmdzLnRoZW1lLCBwYXRoKSkKKyAgICAgICAgcmV0dXJuOwogICAgIGV3a19mcmFtZV90 aGVtZV9zZXQoc2QtPm1haW5fZnJhbWUsIHBhdGgpOwogfQogCkBAIC0xMTI4LDcgKzExMzIsOCBA QCB2b2lkIGV3a192aWV3X3RoZW1lX3NldChFdmFzX09iamVjdCogbywgCiBjb25zdCBjaGFyKiBl d2tfdmlld190aGVtZV9nZXQoRXZhc19PYmplY3QqIG8pCiB7CiAgICAgRVdLX1ZJRVdfU0RfR0VU X09SX1JFVFVSTihvLCBzZCwgMCk7Ci0gICAgcmV0dXJuIGV3a19mcmFtZV90aGVtZV9nZXQoc2Qt Pm1haW5fZnJhbWUpOworICAgIEVXS19WSUVXX1BSSVZfR0VUX09SX1JFVFVSTihzZCwgcHJpdiwg MCk7CisgICAgcmV0dXJuIHByaXYtPnNldHRpbmdzLnRoZW1lOwogfQogCiAvKioK