4574 2005-08-21 18:21:13 -0700 HTML parser does not put attributes on the <isindex> element 2005-09-04 13:05:54 -0700 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 4565 1 darin darin andersca oldest_to_newest 17077 0 darin 2005-08-21 18:21:13 -0700 The hack in the HTML parser that implements the <isindex> element does not put the attributes specified onto the element it creates. 17078 1 3497 darin 2005-08-21 18:25:19 -0700 Created attachment 3497 patch to put attributes on <isindex> This patch fixes the problem by putting the attributes on the <isindex> element rather than on top level element, but the hack of using the DOM to implement <isindex> is going to create other problems anyway, so we probably need to do a better fix. For example, <isindex> doesn't work at all in XHTML. It seems such a waste to spend any time at all on <isindex>. But this does fix 3 of the W3C tests. 17439 2 darin 2005-08-25 10:47:26 -0700 Obviously the real fix is to add <isindex> support rather than hacking it in the HTML parser. 17729 3 3497 darin 2005-08-26 19:56:48 -0700 Comment on attachment 3497 patch to put attributes on <isindex> Maybe we should land this even though it's not the "right" fix. 17830 4 3497 mjs 2005-08-28 23:35:52 -0700 Comment on attachment 3497 patch to put attributes on <isindex> Seems fine to do this - the better fix can maybe wait until we have XBL. 17992 5 darin 2005-08-30 21:37:16 -0700 Funny you should say that -- I was thinking Dave would say the same thing. 3497 2005-08-21 18:25:19 -0700 2005-08-28 23:35:52 -0700 patch to put attributes on <isindex> IsIndexPatch.txt text/plain 4493 darin SW5kZXg6IGtodG1sL2h0bWwvaHRtbHBhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2 cy9yb290L1dlYkNvcmUva2h0bWwvaHRtbC9odG1scGFyc2VyLmNwcCx2CnJldHJpZXZpbmcgcmV2 aXNpb24gMS4xMDMKZGlmZiAtcCAtdSAtcjEuMTAzIGtodG1sL2h0bWwvaHRtbHBhcnNlci5jcHAK LS0tIGtodG1sL2h0bWwvaHRtbHBhcnNlci5jcHAJMTkgQXVnIDIwMDUgMjM6NTg6MjcgLTAwMDAJ MS4xMDMKKysrIGtodG1sL2h0bWwvaHRtbHBhcnNlci5jcHAJMjIgQXVnIDIwMDUgMDE6Mjc6MDgg LTAwMDAKQEAgLTEzMjIsMjggKzEzMjIsMzQgQEAgTm9kZUltcGwgKkhUTUxQYXJzZXI6OmhhbmRs ZUlzaW5kZXgoIFRvawogewogICAgIE5vZGVJbXBsICpuOwogICAgIEhUTUxGb3JtRWxlbWVudElt cGwgKm15Zm9ybSA9IGZvcm07Ci0gICAgaWYgKCAhbXlmb3JtICkgeworICAgIGlmICghbXlmb3Jt KSB7CiAgICAgICAgIG15Zm9ybSA9IG5ldyBIVE1MRm9ybUVsZW1lbnRJbXBsKGRvY3VtZW50KTsK ICAgICAgICAgbiA9IG15Zm9ybTsKICAgICB9IGVsc2UKLSAgICAgICAgbiA9IG5ldyBIVE1MRGl2 RWxlbWVudEltcGwoIGRvY3VtZW50ICk7Ci0gICAgTm9kZUltcGwgKmNoaWxkID0gbmV3IEhUTUxI UkVsZW1lbnRJbXBsKCBkb2N1bWVudCApOwotICAgIG4tPmFkZENoaWxkKCBjaGlsZCApOwotICAg IEF0dHJpYnV0ZUltcGwqIGEgPSB0LT5hdHRycyA/IHQtPmF0dHJzLT5nZXRBdHRyaWJ1dGVJdGVt KHByb21wdEF0dHIpIDogMDsKKyAgICAgICAgbiA9IG5ldyBIVE1MRGl2RWxlbWVudEltcGwoZG9j dW1lbnQpOworCisgICAgTmFtZWRNYXBwZWRBdHRyTWFwSW1wbCAqYXR0cnMgPSB0LT5hdHRyczsK KyAgICB0LT5hdHRycyA9IE5VTEw7CisKKyAgICBIVE1MSXNJbmRleEVsZW1lbnRJbXBsICppc0lu ZGV4ID0gbmV3IEhUTUxJc0luZGV4RWxlbWVudEltcGwoZG9jdW1lbnQsIG15Zm9ybSk7CisgICAg aXNJbmRleC0+c2V0QXR0cmlidXRlTWFwKGF0dHJzKTsKKyAgICBpc0luZGV4LT5zZXRBdHRyaWJ1 dGUodHlwZUF0dHIsICJraHRtbF9pc2luZGV4Iik7CisKICNpZiBBUFBMRV9DSEFOR0VTCiAgICAg RE9NU3RyaW5nIHRleHQgPSBzZWFyY2hhYmxlSW5kZXhJbnRyb2R1Y3Rpb24oKTsKICNlbHNlCiAg ICAgRE9NU3RyaW5nIHRleHQgPSBpMThuKCJUaGlzIGlzIGEgc2VhcmNoYWJsZSBpbmRleC4gRW50 ZXIgc2VhcmNoIGtleXdvcmRzOiAiKTsKICNlbmRpZgotICAgIGlmIChhKQotICAgICAgICB0ZXh0 ID0gRE9NU3RyaW5nKGEtPnZhbHVlKCkpICsgIiAiOwotICAgIGNoaWxkID0gbmV3IFRleHRJbXBs KGRvY3VtZW50LCB0ZXh0KTsKLSAgICBuLT5hZGRDaGlsZCggY2hpbGQgKTsKLSAgICBjaGlsZCA9 IG5ldyBIVE1MSXNJbmRleEVsZW1lbnRJbXBsKGRvY3VtZW50LCBteWZvcm0pOwotICAgIHN0YXRp Y19jYXN0PEVsZW1lbnRJbXBsICo+KGNoaWxkKS0+c2V0QXR0cmlidXRlKHR5cGVBdHRyLCAia2h0 bWxfaXNpbmRleCIpOwotICAgIG4tPmFkZENoaWxkKCBjaGlsZCApOwotICAgIGNoaWxkID0gbmV3 IEhUTUxIUkVsZW1lbnRJbXBsKCBkb2N1bWVudCApOwotICAgIG4tPmFkZENoaWxkKCBjaGlsZCAp OworICAgIGlmIChhdHRycykKKyAgICAgICAgaWYgKEF0dHJpYnV0ZUltcGwgKmEgPSBhdHRycy0+ Z2V0QXR0cmlidXRlSXRlbShwcm9tcHRBdHRyKSkKKyAgICAgICAgICAgIHRleHQgPSBhLT52YWx1 ZSgpLmRvbVN0cmluZygpICsgIiAiOworCisgICAgYXR0cnMtPmRlcmVmKCk7CisKKyAgICBuLT5h ZGRDaGlsZChuZXcgSFRNTEhSRWxlbWVudEltcGwoZG9jdW1lbnQpKTsKKyAgICBuLT5hZGRDaGls ZChuZXcgVGV4dEltcGwoZG9jdW1lbnQsIHRleHQpKTsKKyAgICBuLT5hZGRDaGlsZChpc0luZGV4 KTsKKyAgICBuLT5hZGRDaGlsZChuZXcgSFRNTEhSRWxlbWVudEltcGwoZG9jdW1lbnQpKTsKIAog ICAgIHJldHVybiBuOwogfQpJbmRleDogbGF5b3V0LXRlc3RzL2RvbS9odG1sL2xldmVsMi9odG1s L0hUTUxJc0luZGV4RWxlbWVudDAxLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAv Y3ZzL3Jvb3QvV2ViQ29yZS9sYXlvdXQtdGVzdHMvZG9tL2h0bWwvbGV2ZWwyL2h0bWwvSFRNTElz SW5kZXhFbGVtZW50MDEtZXhwZWN0ZWQudHh0LHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjEKZGlm ZiAtcCAtdSAtcjEuMSBsYXlvdXQtdGVzdHMvZG9tL2h0bWwvbGV2ZWwyL2h0bWwvSFRNTElzSW5k ZXhFbGVtZW50MDEtZXhwZWN0ZWQudHh0Ci0tLSBsYXlvdXQtdGVzdHMvZG9tL2h0bWwvbGV2ZWwy L2h0bWwvSFRNTElzSW5kZXhFbGVtZW50MDEtZXhwZWN0ZWQudHh0CTI2IEp1bCAyMDA1IDA4OjM1 OjQyIC0wMDAwCTEuMQorKysgbGF5b3V0LXRlc3RzL2RvbS9odG1sL2xldmVsMi9odG1sL0hUTUxJ c0luZGV4RWxlbWVudDAxLWV4cGVjdGVkLnR4dAkyMiBBdWcgMjAwNSAwMToyNzoxMyAtMDAwMApA QCAtMSwzICsxLDIgQEAKLVRlc3Q6CWh0dHA6Ly93d3cudzMub3JnLzIwMDEvRE9NLVRlc3QtU3Vp dGUvbGV2ZWwyL2h0bWwvSFRNTElzSW5kZXhFbGVtZW50MDEJCi1TdGF0dXM6CWZhaWx1cmUKLURl dGFpbDoJSXNJbmRleC5Qcm9tcHQ6IGFzc2VydEVxdWFscyBmYWlsZWQsIGFjdHVhbCAsIGV4cGVj dGVkIE5ldyBFbXBsb3llZTogLgorVGVzdDoJaHR0cDovL3d3dy53My5vcmcvMjAwMS9ET00tVGVz dC1TdWl0ZS9sZXZlbDIvaHRtbC9IVE1MSXNJbmRleEVsZW1lbnQwMQorU3RhdHVzOglTdWNjZXNz CkluZGV4OiBsYXlvdXQtdGVzdHMvZG9tL2h0bWwvbGV2ZWwyL2h0bWwvSFRNTElzSW5kZXhFbGVt ZW50MDItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3Jl L2xheW91dC10ZXN0cy9kb20vaHRtbC9sZXZlbDIvaHRtbC9IVE1MSXNJbmRleEVsZW1lbnQwMi1l eHBlY3RlZC50eHQsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMQpkaWZmIC1wIC11IC1yMS4xIGxh eW91dC10ZXN0cy9kb20vaHRtbC9sZXZlbDIvaHRtbC9IVE1MSXNJbmRleEVsZW1lbnQwMi1leHBl Y3RlZC50eHQKLS0tIGxheW91dC10ZXN0cy9kb20vaHRtbC9sZXZlbDIvaHRtbC9IVE1MSXNJbmRl eEVsZW1lbnQwMi1leHBlY3RlZC50eHQJMjYgSnVsIDIwMDUgMDg6MzU6NDIgLTAwMDAJMS4xCisr KyBsYXlvdXQtdGVzdHMvZG9tL2h0bWwvbGV2ZWwyL2h0bWwvSFRNTElzSW5kZXhFbGVtZW50MDIt ZXhwZWN0ZWQudHh0CTIyIEF1ZyAyMDA1IDAxOjI3OjEzIC0wMDAwCkBAIC0xLDMgKzEsMyBAQAog VGVzdDoJaHR0cDovL3d3dy53My5vcmcvMjAwMS9ET00tVGVzdC1TdWl0ZS9sZXZlbDIvaHRtbC9I VE1MSXNJbmRleEVsZW1lbnQwMgkKIFN0YXR1czoJZmFpbHVyZQotRGV0YWlsOglJc0luZGV4LlBy b21wdDogYXNzZXJ0RXF1YWxzIGZhaWxlZCwgYWN0dWFsICwgZXhwZWN0ZWQgT2xkIEVtcGxveWVl OiAuCitEZXRhaWw6CWZvcm1OdWxsTGluazogYXNzZXJ0TnVsbCBmYWlsZWQsIGFjdHVhbCBbb2Jq ZWN0IEZPUk1dCkluZGV4OiBsYXlvdXQtdGVzdHMvZG9tL2h0bWwvbGV2ZWwyL2h0bWwvSFRNTElz SW5kZXhFbGVtZW50MDMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9v dC9XZWJDb3JlL2xheW91dC10ZXN0cy9kb20vaHRtbC9sZXZlbDIvaHRtbC9IVE1MSXNJbmRleEVs ZW1lbnQwMy1leHBlY3RlZC50eHQsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMQpkaWZmIC1wIC11 IC1yMS4xIGxheW91dC10ZXN0cy9kb20vaHRtbC9sZXZlbDIvaHRtbC9IVE1MSXNJbmRleEVsZW1l bnQwMy1leHBlY3RlZC50eHQKLS0tIGxheW91dC10ZXN0cy9kb20vaHRtbC9sZXZlbDIvaHRtbC9I VE1MSXNJbmRleEVsZW1lbnQwMy1leHBlY3RlZC50eHQJMjYgSnVsIDIwMDUgMDg6MzU6NDIgLTAw MDAJMS4xCisrKyBsYXlvdXQtdGVzdHMvZG9tL2h0bWwvbGV2ZWwyL2h0bWwvSFRNTElzSW5kZXhF bGVtZW50MDMtZXhwZWN0ZWQudHh0CTIyIEF1ZyAyMDA1IDAxOjI3OjEzIC0wMDAwCkBAIC0xLDMg KzEsMiBAQAotVGVzdDoJaHR0cDovL3d3dy53My5vcmcvMjAwMS9ET00tVGVzdC1TdWl0ZS9sZXZl bDIvaHRtbC9IVE1MSXNJbmRleEVsZW1lbnQwMwkKLVN0YXR1czoJZmFpbHVyZQotRGV0YWlsOglw cm9tcHRMaW5rOiBhc3NlcnRFcXVhbHMgZmFpbGVkLCBhY3R1YWwgLCBleHBlY3RlZCBOZXcgRW1w bG95ZWU6IC4KK1Rlc3Q6CWh0dHA6Ly93d3cudzMub3JnLzIwMDEvRE9NLVRlc3QtU3VpdGUvbGV2 ZWwyL2h0bWwvSFRNTElzSW5kZXhFbGVtZW50MDMKK1N0YXR1czoJU3VjY2Vzcwo=