45739 2010-09-14 03:05:39 -0700 Move DebuggerScript.js from WebKit/chromium to somewhere in WebCore 2010-09-14 08:41:29 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kling yurys loislo pfeldman podivilov yurys oldest_to_newest 278788 0 kling 2010-09-14 03:05:39 -0700 Since we need WebKit/chromium/src/js/DebuggerScript.js for QtWebKit when building against V8, it would make sense to move it to a non-port-specific directory in WebCore. 278875 1 yurys 2010-09-14 07:17:42 -0700 This should have been done from the very beginning. I'll move the script into WebCore/bindings/v8 which looks like an appropriate place as it's used by WebCore/bindings/v8/ScriptDebugServer 278912 2 67553 yurys 2010-09-14 08:09:25 -0700 Created attachment 67553 Patch 278930 3 67553 kling 2010-09-14 08:36:54 -0700 Comment on attachment 67553 Patch LGTM 278931 4 67553 yurys 2010-09-14 08:41:16 -0700 Comment on attachment 67553 Patch Clearing flags on attachment: 67553 Committed r67472: <http://trac.webkit.org/changeset/67472> 278932 5 yurys 2010-09-14 08:41:29 -0700 All reviewed patches have been landed. Closing bug. 67553 2010-09-14 08:09:25 -0700 2010-09-14 08:41:16 -0700 Patch bug-45739-20100914190922.patch text/plain 6254 yurys ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODFhNWI4NzI5NjUzYTQzODhlYWNkM2Q0OTc0OWExNzE1M2VmZjRhNC4uOTg2N2RhN2QwMDhiZTJl YzZkMThmMGZiODkxNDM2NjQwMDgxNjZhNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wOS0xNCAgWXVy eSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb3ZlIERlYnVnZ2VyU2NyaXB0LmpzIGZyb20g V2ViS2l0L2Nocm9taXVtL3NyYy9qcyB0byBXZWJDb3JlL2JpbmRpbmdzL3Y4CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTczOQorCisgICAgICAgICog YmluZGluZ3MvdjgvRGVidWdnZXJTY3JpcHQuanM6IEFkZGVkLgorCiAyMDEwLTA5LTE0ICBQaWVy cmUtQW50b2luZSBMYUZheWV0dGUgIDxwbGFmYXlldEBjb2RlYXVyb3JhLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9z cmMvanMvRGVidWdnZXJTY3JpcHQuanMgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RlYnVnZ2VyU2Ny aXB0LmpzCnNpbWlsYXJpdHkgaW5kZXggOTklCnJlbmFtZSBmcm9tIFdlYktpdC9jaHJvbWl1bS9z cmMvanMvRGVidWdnZXJTY3JpcHQuanMKcmVuYW1lIHRvIFdlYkNvcmUvYmluZGluZ3MvdjgvRGVi dWdnZXJTY3JpcHQuanMKaW5kZXggNWViNDgyYmE3ZTY5YjViM2ZkY2RmM2E5MzdhNTNiY2NkNzE4 OGI4Ni4uMDIyMjI5NjJiZDkyNDdhOTdkNzM0NDYzMzdjZTYxOWZjNWUwNTc2NSAxMDA2NDQKLS0t IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9EZWJ1Z2dlclNjcmlwdC5qcworKysgYi9XZWJDb3Jl L2JpbmRpbmdzL3Y4L0RlYnVnZ2VyU2NyaXB0LmpzCkBAIC0xNDQsNyArMTQ0LDcgQEAgRGVidWdn ZXJTY3JpcHQuY3VycmVudENhbGxGcmFtZSA9IGZ1bmN0aW9uKGV4ZWNTdGF0ZSwgYXJncykKICAg ICB2YXIgZnJhbWVDb3VudCA9IGV4ZWNTdGF0ZS5mcmFtZUNvdW50KCk7CiAgICAgaWYgKGZyYW1l Q291bnQgPT09IDApCiAgICAgICAgIHJldHVybiB1bmRlZmluZWQ7Ci0gICAgCisKICAgICB2YXIg dG9wRnJhbWU7CiAgICAgZm9yICh2YXIgaSA9IGZyYW1lQ291bnQgLSAxOyBpID49IDA7IGktLSkg ewogICAgICAgICB2YXIgZnJhbWVNaXJyb3IgPSBleGVjU3RhdGUuZnJhbWUoaSk7CkBAIC0yMTEs MTQgKzIxMSwxNCBAQCBEZWJ1Z2dlclNjcmlwdC5fZnJhbWVNaXJyb3JUb0pTQ2FsbEZyYW1lID0g ZnVuY3Rpb24oZnJhbWVNaXJyb3IsIGNhbGxlckZyYW1lKQogICAgIHZhciBmdW5jdGlvbk5hbWU7 CiAgICAgaWYgKGZ1bmMpCiAgICAgICAgIGZ1bmN0aW9uTmFtZSA9IGZ1bmMubmFtZSgpIHx8IGZ1 bmMuaW5mZXJyZWROYW1lKCk7Ci0gICAgICAgIAorCiAgICAgLy8gR2V0IHNjcmlwdCBJRC4KICAg ICB2YXIgc2NyaXB0ID0gZnVuYy5zY3JpcHQoKTsKICAgICB2YXIgc291cmNlSUQgPSBzY3JpcHQg JiYgc2NyaXB0LmlkKCk7Ci0gICAgCisKICAgICAvLyBHZXQgbGluZSBudW1iZXIuCiAgICAgdmFy IGxpbmUgPSBEZWJ1Z2dlclNjcmlwdC5fdjhUb1dlYmtpdExpbmVOdW1iZXIoZnJhbWVNaXJyb3Iu c291cmNlTGluZSgpKTsKLSAgICAKKwogICAgIC8vIEdldCB0aGlzIG9iamVjdC4KICAgICB2YXIg dGhpc09iamVjdCA9IGZyYW1lTWlycm9yLmRldGFpbHNfLnJlY2VpdmVyKCk7CiAKQEAgLTI1Nywx MSArMjU3LDExIEBAIERlYnVnZ2VyU2NyaXB0Ll9mcmFtZU1pcnJvclRvSlNDYWxsRnJhbWUgPSBm dW5jdGlvbihmcmFtZU1pcnJvciwgY2FsbGVyRnJhbWUpCiAgICAgICAgIHNjb3BlVHlwZS5wdXNo KHNjb3BlTWlycm9yLnNjb3BlVHlwZSgpKTsKICAgICAgICAgc2NvcGVDaGFpbi5wdXNoKHNjb3Bl T2JqZWN0KTsKICAgICB9Ci0gICAgCisKICAgICBmdW5jdGlvbiBldmFsdWF0ZShleHByZXNzaW9u KSB7CiAgICAgICAgIHJldHVybiBmcmFtZU1pcnJvci5ldmFsdWF0ZShleHByZXNzaW9uLCBmYWxz ZSkudmFsdWUoKTsKICAgICB9Ci0gICAgCisKICAgICByZXR1cm4gewogICAgICAgICAic291cmNl SUQiOiBzb3VyY2VJRCwKICAgICAgICAgImxpbmUiOiBsaW5lLApkaWZmIC0tZ2l0IGEvV2ViS2l0 L2Nocm9taXVtL0NoYW5nZUxvZyBiL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggYzQ0 MGFiYjU2MWNhMDZkMjRiNDNkYzA0ZmJkMDI0MzQ5YTBkMmE0Ny4uOGI1OTI0ZjAyN2Y2M2FmOGUz ZTg4ZWU0OTYxODhhNzIzMDQyNGZkOSAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL0NoYW5n ZUxvZworKysgYi9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIw MTAtMDktMTQgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZSBEZWJ1Z2dlclNj cmlwdC5qcyBmcm9tIFdlYktpdC9jaHJvbWl1bS9zcmMvanMgdG8gV2ViQ29yZS9iaW5kaW5ncy92 OAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU3MzkK KworICAgICAgICAqIFdlYktpdC5ncmQ6CisgICAgICAgICogV2ViS2l0Lmd5cGk6CisgICAgICAg ICogc3JjL2pzL0RlYnVnZ2VyU2NyaXB0LmpzOiBSZW1vdmVkLgorICAgICAgICAqIHNyYy9qcy9E ZXZUb29sc0hvc3RTdHViLmpzOiBSZW1vdmVkLgorCiAyMDEwLTA5LTE0ICBIYW5zIFdlbm5ib3Jn ICA8aGFuc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmVyZW15IE9ybG93 LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5ncmQgYi9XZWJLaXQvY2hyb21p dW0vV2ViS2l0LmdyZAppbmRleCA5MmVlMDA4MTNiYzU2OGZmOGYwYWYxZTQyZTk4NmMzNTVlM2Fm N2I3Li4zYjcyMDlhOTdlMGNkMzAzZDUyMjk0ZGI5MzBlMmExZjMzNzZiZWVhIDEwMDY0NAotLS0g YS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0LmdyZAorKysgYi9XZWJLaXQvY2hyb21pdW0vV2ViS2l0 LmdyZApAQCAtOSw3ICs5LDcgQEAKICAgPC9vdXRwdXRzPgogICA8cmVsZWFzZSBzZXE9IjEiPgog ICAgIDxpbmNsdWRlcz4KLSAgICAgIDxpbmNsdWRlIG5hbWU9IklEUl9ERVZUT09MU19ERUJVR0dF Ul9TQ1JJUFRfSlMiIGZpbGU9InNyY1xqc1xEZWJ1Z2dlclNjcmlwdC5qcyIgdHlwZT0iQklOREFU QSIvPgorICAgICAgPGluY2x1ZGUgbmFtZT0iSURSX0RFVlRPT0xTX0RFQlVHR0VSX1NDUklQVF9K UyIgZmlsZT0iLi5cLi5cV2ViQ29yZVxiaW5kaW5nc1x2OFxEZWJ1Z2dlclNjcmlwdC5qcyIgdHlw ZT0iQklOREFUQSIvPgogICAgICAgPGluY2x1ZGUgbmFtZT0iSURSX0RFVlRPT0xTX0lOSkVDVF9X RUJLSVRfSlMiIGZpbGU9Ii4uXC4uXFdlYkNvcmVcaW5zcGVjdG9yXGZyb250LWVuZFxJbmplY3Rl ZFNjcmlwdC5qcyIgdHlwZT0iQklOREFUQSIvPgogICAgIDwvaW5jbHVkZXM+CiAgIDwvcmVsZWFz ZT4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwaSBiL1dlYktpdC9jaHJv bWl1bS9XZWJLaXQuZ3lwaQppbmRleCA0YzZhYzM3Y2I4YWFhMmM1MzQ5MmY1Y2VmZmI2ODRhN2Jh OGIyOTYyLi4wMzUwMTViMDI4MzFjZmZmY2M2MGJlZDg1NmU1Y2MyMjQ5ZTY4NDU4IDEwMDY0NAot LS0gYS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cGkKKysrIGIvV2ViS2l0L2Nocm9taXVtL1dl YktpdC5neXBpCkBAIC0zNCw3ICszNCw2IEBACiAgICAgICAgICMgZm9yIGNvcHlpbmcgdGhlbSB0 byByZXNvdXJjZSBkaXIsIGFuZCBmb3IgZ2VuZXJhdGluZyAnZGV2dG9vbHMuaHRtbCcgZmlsZS4K ICAgICAgICAgJ2RldnRvb2xzX2pzX2ZpbGVzJzogWwogICAgICAgICAgICAgJ3NyYy9qcy9EZXZU b29scy5qcycsCi0gICAgICAgICAgICAnc3JjL2pzL0RldlRvb2xzSG9zdFN0dWIuanMnLAogICAg ICAgICAgICAgJ3NyYy9qcy9UZXN0cy5qcycsCiAgICAgICAgIF0sCiAgICAgICAgICdkZXZ0b29s c19jc3NfZmlsZXMnOiBbCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL2pzL0RldlRv b2xzSG9zdFN0dWIuanMgYi9XZWJLaXQvY2hyb21pdW0vc3JjL2pzL0RldlRvb2xzSG9zdFN0dWIu anMKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IGQzMzMzZTJjNTI1NTAyOGNlZjVhODVk YWVmODdkMTk2NzEzZGRhMGEuLjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9EZXZUb29sc0hvc3RTdHViLmpzCisrKyAv ZGV2L251bGwKQEAgLTEsMzggKzAsMCBAQAotLyoKLSAqIENvcHlyaWdodCAoQykgMjAxMCBHb29n bGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgotICoKLSAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1 c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAotICogbW9kaWZp Y2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRp b25zIGFyZQotICogbWV0OgotICoKLSAqICAgICAqIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2Ug Y29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0Ci0gKiBub3RpY2UsIHRoaXMgbGlz dCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCi0gKiAgICAgKiBS ZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlCi0g KiBjb3B5cmlnaHQgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxv d2luZyBkaXNjbGFpbWVyCi0gKiBpbiB0aGUgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0 ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlCi0gKiBkaXN0cmlidXRpb24uCi0gKiAgICAgKiBOZWl0 aGVyIHRoZSBuYW1lIG9mIEdvb2dsZSBJbmMuIG5vciB0aGUgbmFtZXMgb2YgaXRzCi0gKiBjb250 cmlidXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5kb3JzZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2 ZWQgZnJvbQotICogdGhpcyBzb2Z0d2FyZSB3aXRob3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4g cGVybWlzc2lvbi4KLSAqCi0gKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIFRIRSBDT1BZ UklHSFQgSE9MREVSUyBBTkQgQ09OVFJJQlVUT1JTCi0gKiAiQVMgSVMiIEFORCBBTlkgRVhQUkVT UyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVAotICogTElNSVRFRCBU TywgVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1Mg Rk9SCi0gKiBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQg U0hBTEwgVEhFIENPUFlSSUdIVAotICogT1dORVIgT1IgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBG T1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsCi0gKiBTUEVDSUFMLCBFWEVNUExB UlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UCi0gKiBMSU1J VEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NT IE9GIFVTRSwKLSAqIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikg SE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWQotICogVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhF UiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAotICogKElOQ0xVRElORyBO RUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNF Ci0gKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZ IE9GIFNVQ0ggREFNQUdFLgotICovCi0KLS8qKgotICogQGZpbGVvdmVydmlldyBUaGVzZSBzdHVi cyBlbXVsYXRlIGJhY2tlbmQgZnVuY3Rpb25hbGl0eSBhbmQgYWxsb3dzCi0gKiBEZXZUb29scyBm cm9udGVuZCB0byBmdW5jdGlvbiBhcyBhIHN0YW5kYWxvbmUgd2ViIGFwcC4KLSAqLwotCi1pZiAo IXdpbmRvd1siUmVtb3RlRGVidWdnZXJDb21tYW5kRXhlY3V0b3IiXSkgewotICAgIHdpbmRvd1si UmVtb3RlRGVidWdnZXJDb21tYW5kRXhlY3V0b3IiXSA9IHt9OwotfQo=