45732 2010-09-13 20:56:32 -0700 [Qt] DumpRenderTreeSupportQt::suspendActiveDOMObjects needs a new parameter 2012-10-24 06:27:30 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED WONTFIX P2 Normal --- 1 eric.carlson eric.carlson dbates eric hausmann kenneth kling pierre.rossi tonikitoo yongjun.zhang oldest_to_newest 278687 0 eric.carlson 2010-09-13 20:56:32 -0700 http://trac.webkit.org/changeset/67432 added a parameter to suspendActiveDOMObjects so classes that derive from ActiveDOMObject can tell why suspend() is being called. See https://bugs.webkit.org/show_bug.cgi?id=45688. I broke DumpRenderTreeSupportQt with this change, but don't know enough about how it works to fix it correctly, so based on the comments in http://trac.webkit.org/changeset/52914 I am hard coding it to pass ActiveDOMObject::JavaScriptPaused for now. 278693 1 67517 eric.carlson 2010-09-13 21:06:26 -0700 Created attachment 67517 patch 278695 2 67517 dbates 2010-09-13 21:08:19 -0700 Comment on attachment 67517 patch LGTM. r=me 278697 3 dbates 2010-09-13 21:09:28 -0700 (In reply to comment #2) > (From update of attachment 67517 [details]) > LGTM. > r=me I am assuming WebCore/dom/ActiveDOMObject.h gets included by someone... 278700 4 eric.carlson 2010-09-13 21:18:29 -0700 Temporary fix landed in http://trac.webkit.org/changeset/67440 278705 5 dbates 2010-09-13 21:22:43 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 67517 [details] [details]) > > LGTM. > > r=me > > I am assuming WebCore/dom/ActiveDOMObject.h gets included by someone... So, it will get included by WorkerThread.h, which includes WorkerRunLoop.h which includes ScriptExecutionContext.h, which includes ActiveDOMObject.h I was a bit to quick when reviewing this. The enum value JavaScriptPaused was renamed to JavaScriptDebuggerPaused. I missed that in the review. My mistake. I will be more cautious. 278714 6 dbates 2010-09-13 21:32:19 -0700 Committed enum value fix up in changeset 67442 <http://trac.webkit.org/changeset/67442>. 293615 7 eric 2010-10-13 12:27:28 -0700 Attachment 67517 was posted by a committer and has review+, assigning to Eric Carlson for commit. 293628 8 eric.carlson 2010-10-13 12:34:22 -0700 I committed https://bugs.webkit.org/attachment.cgi?id=67517, and dbates fixed it in http://trac.webkit.org/changeset/67442 when my change didn't actually compile :-( This bug is about getting a real fix into DumpRenderTreeSupportQt::suspendActiveDOMObjects instead of the hack I added which hard codes the reason for suspension. 749605 9 pierre.rossi 2012-10-24 06:27:30 -0700 This actually looks like dead code by now. 67517 2010-09-13 21:06:26 -0700 2010-10-13 12:34:40 -0700 patch qt_drt_fix.txt text/plain 1477 eric.carlson SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNjc0MzgpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDktMTMgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2Fy bHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1F0XSBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6c3VzcGVuZEFjdGl2ZURPTU9i amVjdHMgbmVlZHMgYSBuZXcgcGFyYW1ldGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00NTczMgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRHVt cFJlbmRlclRyZWVTdXBwb3J0UXQuY3BwOgorICAgICAgICAoRHVtcFJlbmRlclRyZWVTdXBwb3J0 UXQ6OnN1c3BlbmRBY3RpdmVET01PYmplY3RzKTogUGFzcyBBY3RpdmVET01PYmplY3Q6OkphdmFT Y3JpcHRQYXVzZWQKKyAgICAgICAgdG8gc3VzcGVuZEFjdGl2ZURPTU9iamVjdHMuCisKIDIwMTAt MDktMTMgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBS ZW5kZXJUcmVlU3VwcG9ydFF0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvV2ViQ29yZVN1 cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuY3BwCShyZXZpc2lvbiA2NzE1NikKKysrIFdl YktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTM0Nyw3ICszNDcsOSBAQCB2b2lkIER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0 OjpzdXNwZW5kQWN0CiB7CiAgICAgRnJhbWUqIGNvcmVGcmFtZSA9IFFXZWJGcmFtZVByaXZhdGU6 OmNvcmUoZnJhbWUpOwogICAgIGlmIChjb3JlRnJhbWUtPmRvY3VtZW50KCkpCi0gICAgICAgIGNv cmVGcmFtZS0+ZG9jdW1lbnQoKS0+c3VzcGVuZEFjdGl2ZURPTU9iamVjdHMoKTsKKyAgICAgICAg Ly8gRklYTUU6IFRoaXMgZnVuY3Rpb24gc2hvdWxkIGJlIGNoYW5nZWQgdGFrZSBhIFJlYXNvbkZv clN1c3BlbnNpb24gcGFyYW1ldGVyIAorICAgICAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDU3MzIKKyAgICAgICAgY29yZUZyYW1lLT5kb2N1bWVudCgpLT5z dXNwZW5kQWN0aXZlRE9NT2JqZWN0cyhBY3RpdmVET01PYmplY3Q6OkphdmFTY3JpcHRQYXVzZWQp OwogfQogCiAvLyBSZXN1bWUgYWN0aXZlIERPTSBvYmplY3RzIGluIHRoaXMgZnJhbWUuCg==