45728 2010-09-13 19:20:45 -0700 [EFL] Fix a build break by Bug 45494 2010-09-16 19:30:10 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 gyuyoung.kim webkit-unassigned enrica kenneth lucas.de.marchi tonikitoo oldest_to_newest 278655 0 gyuyoung.kim 2010-09-13 19:20:45 -0700 There is a build break as below when WebKit EFL is built. /home/gyuyoung/webkit/WebKit-git/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:681: error: virtual outside class declaration 278658 1 67510 gyuyoung.kim 2010-09-13 19:24:19 -0700 Created attachment 67510 Patch I remove the "virtual" keyword in FrameLoaderClientEfl.cpp. 278673 2 67510 tonikitoo 2010-09-13 20:16:52 -0700 Comment on attachment 67510 Patch [23:13] <demarchi> see in WebCore/loader/EmptyClients.h [23:13] <demarchi> there's the following method: [23:13] <demarchi> + virtual bool canShowMIMETypeAsHTML(const String&) const { return false; } [23:13] <demarchi> without ifdefs [23:13] <demarchi> but in WebCore/loader/FrameLoaderClient.h, they added the definition using #if PLATFORM(MAC) [23:14] <tonikitoo> so it should just remove the whole method. is that it? [23:15] <demarchi> i think so ...[quote] 278694 3 gyuyoung.kim 2010-09-13 21:07:18 -0700 The "#if PLATFORM(MAC)" macro was removed in WebCore/loader/FrameLoaderClient.h. Reviewer wanted to remove the macro.(Bug 45494 Comment #6). So, I think we need to keep the function. 278814 4 lucas.de.marchi 2010-09-14 04:42:44 -0700 (In reply to comment #3) > The "#if PLATFORM(MAC)" macro was removed in WebCore/loader/FrameLoaderClient.h. Reviewer wanted to remove the macro.(Bug 45494 Comment #6). So, I think we need to keep the function. Antonio, as I told, that patch from MAC was wrong ;-). Closing this bug. 278815 5 67510 lucas.de.marchi 2010-09-14 04:43:09 -0700 Comment on attachment 67510 Patch Clearing flags. 278825 6 lucas.de.marchi 2010-09-14 05:01:47 -0700 Re-opening this bug since the #if PLATFORM(MAC) was not removed yet. Enrica, since the implementation of this method is just a NotImplemented() in EFL, do you think it's better to just remove it or you are going to remove the #if? 280508 7 gyuyoung.kim 2010-09-16 19:24:17 -0700 Leandro already fix this bug. So, I close this bug. 67510 2010-09-13 19:24:19 -0700 2010-09-14 04:43:25 -0700 Patch patch-efl-build-fix.txt text/plain 1304 gyuyoung.kim ZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvQ2hhbmdlTG9nIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK aW5kZXggMjdhYjVhMC4uMzdjYjQwZiAxMDA2NDQKLS0tIGEvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wOS0xMyAg R3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFVucmV2 aWV3ZWQgYnVpbGQgZml4LgorCisgICAgICAgIFtFRkxdIEZpeCBhIGJ1aWxkIGJyZWFrIGJ5IEJ1 ZyA0NTQ5NAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDU3MjgKKworICAgICAgICBUaGUgY2FuU2hvd01JTUVUeXBlQXNIVE1MIHdhcyBpbXBsZW1lbnRl ZCB3aXRoIHZpcnR1YWwga2V5d29yZCBpbiAKKyAgICAgICAgaW4gRnJhbWVMb2FkZXJDbGllbnRF ZmwuY3BwLiBTbywgd2UgbmVlZCB0byByZW1vdmUgdGhlIGtleXdvcmQuCisKKyAgICAgICAgKiBX ZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEVmbC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpGcmFtZUxvYWRlckNsaWVudEVmbDo6Y2FuU2hvd01JTUVUeXBlQXNIVE1MKToKKwogMjAxMC0w OS0xMyAgUmFmYWVsIEFudG9nbm9sbGkgIDxhbnRvZ25vbGxpQHByb2Z1c2lvbi5tb2JpPgogCiAg ICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2VmbC9XZWJD b3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEVmbC5jcHAgYi9XZWJLaXQvZWZsL1dlYkNvcmVT dXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50RWZsLmNwcAppbmRleCBhNjIzYThmLi4wNTY2ODdjIDEw MDY0NAotLS0gYS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50RWZs LmNwcAorKysgYi9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50RWZs LmNwcApAQCAtNjc4LDcgKzY3OCw3IEBAIGJvb2wgRnJhbWVMb2FkZXJDbGllbnRFZmw6OmNhbkhh bmRsZVJlcXVlc3QoY29uc3QgUmVzb3VyY2VSZXF1ZXN0JikgY29uc3QKICAgICByZXR1cm4gdHJ1 ZTsKIH0KIAotdmlydHVhbCBib29sIEZyYW1lTG9hZGVyQ2xpZW50RWZsOjpjYW5TaG93TUlNRVR5 cGVBc0hUTUwoY29uc3QgU3RyaW5nJiBNSU1FVHlwZSkgY29uc3QKK2Jvb2wgRnJhbWVMb2FkZXJD bGllbnRFZmw6OmNhblNob3dNSU1FVHlwZUFzSFRNTChjb25zdCBTdHJpbmcmIE1JTUVUeXBlKSBj b25zdAogewogICAgIG5vdEltcGxlbWVudGVkKCk7CiAgICAgcmV0dXJuIGZhbHNlOwo=