45725 2010-09-13 18:29:26 -0700 commit-queue should log when it's retrying due to checkout out of date error 2010-09-13 18:39:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric abarth dpranke oldest_to_newest 278626 0 eric 2010-09-13 18:29:26 -0700 commit-queue should log when it's retrying due to checkout out of date error 278627 1 67503 eric 2010-09-13 18:31:12 -0700 Created attachment 67503 Patch 278631 2 67503 abarth 2010-09-13 18:36:19 -0700 Comment on attachment 67503 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67503&action=prettypatch > WebKitTools/Scripts/webkitpy/layout_tests/port/base_unittest.py:69 > - return base.Port._open_configuration_file(self) > + raise IOError This could be in a separate patch... 278634 3 eric 2010-09-13 18:39:00 -0700 Committed r67429: <http://trac.webkit.org/changeset/67429> 278635 4 dpranke 2010-09-13 18:39:43 -0700 change to base_unittest.py looks good to me. Good catch; I thought I had that case covered but I was wrong. Changes to the other python files look pretty good but I'm not an expert on that code. 67503 2010-09-13 18:31:12 -0700 2010-09-13 18:36:19 -0700 Patch bug-45725-20100913183110.patch text/plain 4870 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2MTMwMmY3OThkZDM1ZGExYTcyYzJlNTQwNWU2YmEyNTllZWI1Yzc2Li42ZTdiYTEw NGVkOWQ4NGQ2Mjk1M2IzZjcxNGYxODE2ZmZiMzhhODdjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAK KzIwMTAtMDktMTMgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNvbW1pdC1xdWV1ZSBzaG91bGQg bG9nIHdoZW4gaXQncyByZXRyeWluZyBkdWUgdG8gY2hlY2tvdXQgb3V0IG9mIGRhdGUgZXJyb3IK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1NzI1CisK KyAgICAgICAgVGhpcyB3aWxsIGFsbG93IHVzIHRvIGJldHRlciB0cmFjayBob3cgb2Z0ZW4gd2Ug c2VlIHRoZXNlIGVycm9ycworICAgICAgICBhbmQgaG93IGxvbmcgaXQgdGFrZXMgdGhlIHF1ZXVl IHRvIHJlY292ZXIgZnJvbSB0aGVtLgorCisgICAgICAgIEluIG9yZGVyIHRvIHBhc3MgdGhlIHRl c3RzLCBJIGhhZCB0byBjb3JyZWN0IGFuIGVycm9yCisgICAgICAgIGZyb20gYSBwcmV2aW91cyBj aGFuZ2UuICBUaGUgVW5pdFRlc3RQb3J0IHNob3VsZCBub3QgaGF2ZQorICAgICAgICBldmVyIGJl ZW4gdXNpbmcgdGhlIGJhc2UgcG9ydCBtZXRob2QgYXMgdGhhdCB3aWxsIHJlYWQKKyAgICAgICAg YSBmaWxlIGZyb20gZGlzay4gIElmIHRoZSB1bml0IHRlc3RzIGhhdmVuJ3QgcGFzc2VkIHRoZSBj b250ZW50cworICAgICAgICBpdCBzaG91bGQgcmFpc2UgYW4gSU9FcnJvciBhcyB0aG91Z2ggdGhl IGZpbGUgZG9lc24ndCBleGlzdC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvYmFzZV91bml0dGVzdC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9v bC9jb21tYW5kcy9xdWV1ZXNfdW5pdHRlc3QucHk6CisKIDIwMTAtMDktMTMgIENocmlzIEZsZWl6 YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBL aWx6ZXIuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L2Jhc2VfdW5pdHRlc3QucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9wb3J0L2Jhc2VfdW5pdHRlc3QucHkKaW5kZXggMWNjNDI2Zjc4MTg3YmY5 ZDQzZWI0N2VjNDAzZTEzMmE4OWY5ZTc1YS4uMzkyNjgzODhlZjk3NDA3NGQ0MjcxMDdmYTdjOGFl MjAyNDA2ZjdmMSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC9iYXNlX3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZV91bml0dGVzdC5weQpAQCAtNjYsNyArNjYs NyBAQCBjbGFzcyBVbml0VGVzdFBvcnQoYmFzZS5Qb3J0KToKICAgICBkZWYgX29wZW5fY29uZmln dXJhdGlvbl9maWxlKHNlbGYpOgogICAgICAgICBpZiBzZWxmLl9jb25maWd1cmF0aW9uX2NvbnRl bnRzOgogICAgICAgICAgICAgcmV0dXJuIE5ld1N0cmluZ0lPKHNlbGYuX2NvbmZpZ3VyYXRpb25f Y29udGVudHMpCi0gICAgICAgIHJldHVybiBiYXNlLlBvcnQuX29wZW5fY29uZmlndXJhdGlvbl9m aWxlKHNlbGYpCisgICAgICAgIHJhaXNlIElPRXJyb3IKIAogCiBjbGFzcyBQb3J0VGVzdCh1bml0 dGVzdC5UZXN0Q2FzZSk6CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL2NvbW1hbmRzL3F1ZXVlcy5weQppbmRleCAyNDhkMWU1NmUwMzcwN2FhOTNmYmUzZjg3YmNm OWUxZjMzNDRjNmRiLi5hZTBiNTZlMDg2MjQyODhkNWEyZmI4ODQ3NjhkZmZkODI4NWMyMGRmIDEw MDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVl dWVzLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9x dWV1ZXMucHkKQEAgLTI5Miw2ICsyOTIsOCBAQCBjbGFzcyBDb21taXRRdWV1ZShBYnN0cmFjdFBh dGNoUXVldWUsIFN0ZXBTZXF1ZW5jZUVycm9ySGFuZGxlcik6CiAKICAgICBAY2xhc3NtZXRob2QK ICAgICBkZWYgaGFuZGxlX2NoZWNrb3V0X25lZWRzX3VwZGF0ZShjbHMsIHRvb2wsIHN0YXRlLCBv cHRpb25zLCBlcnJvcik6CisgICAgICAgIG1lc3NhZ2UgPSAiVGVzdHMgcGFzc2VkLCBidXQgY29t bWl0IGZhaWxlZCAoY2hlY2tvdXQgb3V0IG9mIGRhdGUpLiAgVXBkYXRpbmcsIHRoZW4gbGFuZGlu ZyB3aXRob3V0IGJ1aWxkaW5nIG9yIHJlLXJ1bm5pbmcgdGVzdHMuIgorICAgICAgICB0b29sLnN0 YXR1c19zZXJ2ZXIudXBkYXRlX3N0YXR1cyhjbHMubmFtZSwgbWVzc2FnZSwgc3RhdGVbInBhdGNo Il0pCiAgICAgICAgICMgVGhlIG9ubHkgdGltZSB3aGVuIHdlIGZpbmQgb3V0IHRoYXQgb3V0IGNo ZWNrb3V0IG5lZWRzIHVwZGF0ZSBpcwogICAgICAgICAjIHdoZW4gd2Ugd2VyZSByZWFkeSB0byBh Y3R1YWxseSBwdWxsIHRoZSB0cmlnZ2VyIGFuZCBsYW5kIHRoZSBwYXRjaC4KICAgICAgICAgIyBS YXRoZXIgdGhhbiBzcGlubmluZyBpbiB0aGUgbWFzdGVyIHByb2Nlc3MsIHdlIHJldHJ5IHdpdGhv dXQKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5k cy9xdWV1ZXNfdW5pdHRlc3QucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wv Y29tbWFuZHMvcXVldWVzX3VuaXR0ZXN0LnB5CmluZGV4IGZkNjU0M2M5YzZiNjVjMmNhODlhMzg4 ODg1YmRmMzEwOTFkYTU5ZmQuLmJiMjE2YTdmNzBmYmYzN2Y5ZDhiZTUzMTg5NjRjMDc2MTI1YTY5 OTggMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5k cy9xdWV1ZXNfdW5pdHRlc3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL2NvbW1hbmRzL3F1ZXVlc191bml0dGVzdC5weQpAQCAtMzYsNyArMzYsNyBAQCBmcm9tIHdl YmtpdHB5LnRvb2wuY29tbWFuZHMuY29tbWFuZHRlc3QgaW1wb3J0IENvbW1hbmRzVGVzdAogZnJv bSB3ZWJraXRweS50b29sLmNvbW1hbmRzLnF1ZXVlcyBpbXBvcnQgKgogZnJvbSB3ZWJraXRweS50 b29sLmNvbW1hbmRzLnF1ZXVlc3Rlc3QgaW1wb3J0IFF1ZXVlc1Rlc3QKIGZyb20gd2Via2l0cHku dG9vbC5jb21tYW5kcy5zdGVwc2VxdWVuY2UgaW1wb3J0IFN0ZXBTZXF1ZW5jZQotZnJvbSB3ZWJr aXRweS50b29sLm1vY2t0b29sIGltcG9ydCBNb2NrVG9vbCwgTW9ja1NDTQorZnJvbSB3ZWJraXRw eS50b29sLm1vY2t0b29sIGltcG9ydCBNb2NrVG9vbCwgTW9ja1NDTSwgTW9ja1N0YXR1c1NlcnZl cgogCiAKIGNsYXNzIFRlc3RRdWV1ZShBYnN0cmFjdFBhdGNoUXVldWUpOgpAQCAtMTQxLDYgKzE0 MSw5IEBAIGNsYXNzIE5lZWRzVXBkYXRlU2VxdWVuY2UoU3RlcFNlcXVlbmNlKToKIAogCiBjbGFz cyBBbHdheXNDb21taXRRdWV1ZVRvb2wob2JqZWN0KToKKyAgICBkZWYgX19pbml0X18oc2VsZik6 CisgICAgICAgIHNlbGYuc3RhdHVzX3NlcnZlciA9IE1vY2tTdGF0dXNTZXJ2ZXIoKQorCiAgICAg ZGVmIGNvbW1hbmRfYnlfbmFtZShzZWxmLCBuYW1lKToKICAgICAgICAgcmV0dXJuIENvbW1pdFF1 ZXVlCiAKQEAgLTI0NSw4ICsyNDgsOSBAQCBNT0NLOiB1cGRhdGVfd29ya19pdGVtczogY29tbWl0 LXF1ZXVlIFsxMDYsIDE5N10KICAgICAgICAgdG9vbCA9IEFsd2F5c0NvbW1pdFF1ZXVlVG9vbCgp CiAgICAgICAgIHNlcXVlbmNlID0gTmVlZHNVcGRhdGVTZXF1ZW5jZShOb25lKQogCi0gICAgICAg IGV4cGVjdGVkX3N0ZGVyciA9ICJDb21taXQgZmFpbGVkIGJlY2F1c2UgdGhlIGNoZWNrb3V0IGlz IG91dCBvZiBkYXRlLiAgUGxlYXNlIHVwZGF0ZSBhbmQgdHJ5IGFnYWluLlxuIgotICAgICAgICBP dXRwdXRDYXB0dXJlKCkuYXNzZXJ0X291dHB1dHMoc2VsZiwgc2VxdWVuY2UucnVuX2FuZF9oYW5k bGVfZXJyb3JzLCBbdG9vbCwgb3B0aW9uc10sIGV4cGVjdGVkX2V4Y2VwdGlvbj1UcnlBZ2Fpbiwg ZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVkX3N0ZGVycikKKyAgICAgICAgZXhwZWN0ZWRfc3RkZXJy ID0gIkNvbW1pdCBmYWlsZWQgYmVjYXVzZSB0aGUgY2hlY2tvdXQgaXMgb3V0IG9mIGRhdGUuICBQ bGVhc2UgdXBkYXRlIGFuZCB0cnkgYWdhaW4uXG5NT0NLOiB1cGRhdGVfc3RhdHVzOiBjb21taXQt cXVldWUgVGVzdHMgcGFzc2VkLCBidXQgY29tbWl0IGZhaWxlZCAoY2hlY2tvdXQgb3V0IG9mIGRh dGUpLiAgVXBkYXRpbmcsIHRoZW4gbGFuZGluZyB3aXRob3V0IGJ1aWxkaW5nIG9yIHJlLXJ1bm5p bmcgdGVzdHMuXG4iCisgICAgICAgIHN0YXRlID0geydwYXRjaCc6IE5vbmV9CisgICAgICAgIE91 dHB1dENhcHR1cmUoKS5hc3NlcnRfb3V0cHV0cyhzZWxmLCBzZXF1ZW5jZS5ydW5fYW5kX2hhbmRs ZV9lcnJvcnMsIFt0b29sLCBvcHRpb25zLCBzdGF0ZV0sIGV4cGVjdGVkX2V4Y2VwdGlvbj1UcnlB Z2FpbiwgZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVkX3N0ZGVycikKIAogICAgICAgICBzZWxmLmFz c2VydEVxdWFscyhvcHRpb25zLnVwZGF0ZSwgVHJ1ZSkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVh bHMob3B0aW9ucy5idWlsZCwgRmFsc2UpCg==