45714 2010-09-13 15:42:09 -0700 chromium/mac: crash less in compositor mode 2010-09-14 12:42:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 thakis thakis abarth commit-queue eric fishd jamesr tony vangelis webkit.review.bot oldest_to_newest 278535 0 thakis 2010-09-13 15:42:09 -0700 chromium/mac: crash less in compositor mode 278537 1 67481 thakis 2010-09-13 15:44:29 -0700 Created attachment 67481 Patch 278538 2 thakis 2010-09-13 15:46:55 -0700 I didn't do the skia part since NativeImageSkia only has an SkBitmap copy constructor, not a NativeImageSkia copy constructor, and I wasn't sure how important that "is complete?" stuff is. Also, I don't have a machine/build with skia set up, so maybe one of you could deal with the non-mac part? 278551 3 67481 jamesr 2010-09-13 16:06:13 -0700 Comment on attachment 67481 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67481&action=prettypatch I think the compiler-generated copy constructor for NativeImageSkia should work OK, but that would have to be checked. Could you just file another bug on the skia part? ChangeLog format is odd here - normally this would be something like "[chromium] Image layers crash on mac because ..." 278560 4 67487 thakis 2010-09-13 16:15:58 -0700 Created attachment 67487 Patch 278562 5 thakis 2010-09-13 16:18:10 -0700 Updated changelog, filed https://bugs.webkit.org/show_bug.cgi?id=45717 for skia. 278580 6 67487 fishd 2010-09-13 17:01:56 -0700 Comment on attachment 67487 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67487&action=prettypatch > WebCore/platform/graphics/chromium/ImageLayerChromium.h:61 > + // FIXME: This needs to be an owning type. In the Skia build, NativeImagePtr roughly corresponds to a SkBitmap, which is itself an owning (ref-counted internally) type. Perhaps you can just make this be a NativeImageSkia then? 278581 7 67487 fishd 2010-09-13 17:02:44 -0700 Comment on attachment 67487 Patch OK, I see that you guys already discussed NativeImageSkia. R=me 279002 8 67487 commit-queue 2010-09-14 10:17:45 -0700 Comment on attachment 67487 Patch Clearing flags on attachment: 67487 Committed r67477: <http://trac.webkit.org/changeset/67477> 279003 9 commit-queue 2010-09-14 10:17:50 -0700 All reviewed patches have been landed. Closing bug. 279090 10 webkit.review.bot 2010-09-14 12:40:13 -0700 http://trac.webkit.org/changeset/67477 might have broken Chromium Win Release The following changes are on the blame list: http://trac.webkit.org/changeset/67476 http://trac.webkit.org/changeset/67477 279091 11 thakis 2010-09-14 12:42:34 -0700 Yes, I broke this (I wrote #elif instead of #else). But tony^work fixed it already. 67481 2010-09-13 15:44:29 -0700 2010-09-13 16:15:55 -0700 Patch bug-45714-20100913154428.patch text/plain 2366 thakis ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmNmZjlhZGIwMTY5ZTg0ODIxMGI4OWUzNWMzYTc3ODc2OTgyNjU1ZS4uNmVmNjZkNjkzODI4ODZj MDU1NjRkMzAxZjUyYjU1MDI0YzNhMGM2MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wOS0xMyAgTmlj byBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgY2hyb21pdW0vbWFjOiBjcmFzaCBsZXNzIGluIGNvbXBv c2l0b3IgbW9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDU3MTQKKworICAgICAgICBUaGUgY29udGVudHMgaW1hZ2UgY2FuIGdvIGF3YXkgd2hlbiB0 aGUgZG9tIGlzIHVwZGF0ZWQuIFNpbmNlIHRoZQorICAgICAgICBsYXllciB0cmVlIGlzIHVwZGF0 ZWQgYXN5bmNocm9ub3VzbHksIGl0IG5lZWRzIHRvIHJlZiB0aGUgbmF0aXZlIGltYWdlLAorICAg ICAgICBlbHNlIGl0IHdpbGwgaG9sZCBvbiB0byBhIHN0YWxlIG9iamVjdC4KKworICAgICAgICBU aGlzIHN0aWxsIG5lZWRzIHRvIGJlIGRvbmUgZm9yIHNraWEsIHRvby4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ltYWdlTGF5ZXJDaHJvbWl1bS5oOgorCiAyMDEwLTA5 LTA4ICBQZXRlciBLYXN0aW5nICA8cGthc3RpbmdAZ29vZ2xlLmNvbT4KIAogICAgICAgICBOb3Qg cmV2aWV3ZWQsIGZhbGxvdXQgZnJvbSBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC82 NzAwMQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9JbWFn ZUxheWVyQ2hyb21pdW0uY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9J bWFnZUxheWVyQ2hyb21pdW0uY3BwCmluZGV4IDA5YjM4OGQ5ZjlkYjQ1YzI3ZDFjMjg3MWExOGMy NWFkZGIzMTg3ZTYuLjM3NDE3ZGE5NzlhZGUyOWVhZTMyOTlmYjk5MDcwMTM3ZDdlNGQxNWQgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vSW1hZ2VMYXllckNo cm9taXVtLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ltYWdl TGF5ZXJDaHJvbWl1bS5jcHAKQEAgLTk1LDcgKzk1LDcgQEAgdm9pZCBJbWFnZUxheWVyQ2hyb21p dW06OnVwZGF0ZUNvbnRlbnRzKCkKICAgICB9CiAjZWxpZiBQTEFURk9STShDRykKICAgICAvLyBO YXRpdmVJbWFnZVB0ciBpcyBhIENHSW1hZ2VSZWYgb24gTWFjIE9TIFguCi0gICAgQ0dJbWFnZVJl ZiBjZ0ltYWdlID0gbV9jb250ZW50czsKKyAgICBDR0ltYWdlUmVmIGNnSW1hZ2UgPSBtX2NvbnRl bnRzLmdldCgpOwogICAgIGludCB3aWR0aCA9IENHSW1hZ2VHZXRXaWR0aChjZ0ltYWdlKTsKICAg ICBpbnQgaGVpZ2h0ID0gQ0dJbWFnZUdldEhlaWdodChjZ0ltYWdlKTsKICAgICByZXF1aXJlZFRl eHR1cmVTaXplID0gSW50U2l6ZSh3aWR0aCwgaGVpZ2h0KTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vSW1hZ2VMYXllckNocm9taXVtLmggYi9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ltYWdlTGF5ZXJDaHJvbWl1bS5oCmluZGV4IGU5 NTI4NGM1ZWE2MjUxMTcxMzhiODZmNjAzODQ4ZGQ5OGQzMzYxNGUuLmE0OTdiNWM3MTYwNGYwNDE5 YjYxMTE3MjMzZDk0YTYwNGU4OGUzZmUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vSW1hZ2VMYXllckNocm9taXVtLmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9JbWFnZUxheWVyQ2hyb21pdW0uaApAQCAtMzYsNiArMzYsMTAg QEAKIAogI2luY2x1ZGUgIkNvbnRlbnRMYXllckNocm9taXVtLmgiCiAKKyNpZiBQTEFURk9STShD RykKKyNpbmNsdWRlIDx3dGYvUmV0YWluUHRyLmg+CisjZW5kaWYKKwogbmFtZXNwYWNlIFdlYkNv cmUgewogCiAvLyBBIExheWVyIHRoYXQgY29udGFpbnMgb25seSBhbiBJbWFnZSBlbGVtZW50LgpA QCAtNTAsNyArNTQsMTMgQEAgcHVibGljOgogCiBwcml2YXRlOgogICAgIEltYWdlTGF5ZXJDaHJv bWl1bShHcmFwaGljc0xheWVyQ2hyb21pdW0qIG93bmVyKTsKKworI2lmIFBMQVRGT1JNKENHKQor ICAgIFJldGFpblB0cjxDR0ltYWdlUmVmPiBtX2NvbnRlbnRzOworI2VsaWYgCisgICAgLy8gRklY TUU6IFRoaXMgbmVlZHMgdG8gYmUgYW4gb3duaW5nIHR5cGUuCiAgICAgTmF0aXZlSW1hZ2VQdHIg bV9jb250ZW50czsKKyNlbmRpZgogfTsKIAogfQo= 67487 2010-09-13 16:15:58 -0700 2010-09-14 10:17:45 -0700 Patch bug-45714-20100913161557.patch text/plain 2433 thakis ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmNmZjlhZGIwMTY5ZTg0ODIxMGI4OWUzNWMzYTc3ODc2OTgyNjU1ZS4uY2EzZmZlMjIwYWExNGU0 OWQ2Y2UyMjRjYTY3ZmE0ZjI0YmQyYjk3ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wOS0xMyAgTmlj byBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXTogY3Jhc2ggbGVzcyBpbiBjb21wb3Np dG9yIG1vZGUgb24gbWFjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00NTcxNAorCisgICAgICAgIFRoZSBjb250ZW50cyBpbWFnZSBjYW4gZ28gYXdheSB3 aGVuIHRoZSBkb20gaXMgdXBkYXRlZC4gU2luY2UgdGhlCisgICAgICAgIGxheWVyIHRyZWUgaXMg dXBkYXRlZCBhc3luY2hyb25vdXNseSwgaXQgbmVlZHMgdG8gcmVmIHRoZSBuYXRpdmUgaW1hZ2Us CisgICAgICAgIGVsc2UgaXQgd2lsbCBob2xkIG9uIHRvIGEgc3RhbGUgb2JqZWN0LgorCisgICAg ICAgIFRoaXMgc3RpbGwgbmVlZHMgdG8gYmUgZG9uZSBmb3Igc2tpYSwgdG9vLgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vSW1hZ2VMYXllckNocm9taXVtLmg6CisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vSW1hZ2VMYXllckNocm9taXVtLmNwcDoK KwogMjAxMC0wOS0wOCAgUGV0ZXIgS2FzdGluZyAgPHBrYXN0aW5nQGdvb2dsZS5jb20+CiAKICAg ICAgICAgTm90IHJldmlld2VkLCBmYWxsb3V0IGZyb20gaHR0cDovL3RyYWMud2Via2l0Lm9yZy9j aGFuZ2VzZXQvNjcwMDEKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vSW1hZ2VMYXllckNocm9taXVtLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vSW1hZ2VMYXllckNocm9taXVtLmNwcAppbmRleCAwOWIzODhkOWY5ZGI0NWMyN2Qx YzI4NzFhMThjMjVhZGRiMzE4N2U2Li4zNzQxN2RhOTc5YWRlMjllYWUzMjk5ZmI5OTA3MDEzN2Q3 ZTRkMTVkIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0lt YWdlTGF5ZXJDaHJvbWl1bS5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9JbWFnZUxheWVyQ2hyb21pdW0uY3BwCkBAIC05NSw3ICs5NSw3IEBAIHZvaWQgSW1hZ2VM YXllckNocm9taXVtOjp1cGRhdGVDb250ZW50cygpCiAgICAgfQogI2VsaWYgUExBVEZPUk0oQ0cp CiAgICAgLy8gTmF0aXZlSW1hZ2VQdHIgaXMgYSBDR0ltYWdlUmVmIG9uIE1hYyBPUyBYLgotICAg IENHSW1hZ2VSZWYgY2dJbWFnZSA9IG1fY29udGVudHM7CisgICAgQ0dJbWFnZVJlZiBjZ0ltYWdl ID0gbV9jb250ZW50cy5nZXQoKTsKICAgICBpbnQgd2lkdGggPSBDR0ltYWdlR2V0V2lkdGgoY2dJ bWFnZSk7CiAgICAgaW50IGhlaWdodCA9IENHSW1hZ2VHZXRIZWlnaHQoY2dJbWFnZSk7CiAgICAg cmVxdWlyZWRUZXh0dXJlU2l6ZSA9IEludFNpemUod2lkdGgsIGhlaWdodCk7CmRpZmYgLS1naXQg YS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ltYWdlTGF5ZXJDaHJvbWl1bS5o IGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9JbWFnZUxheWVyQ2hyb21pdW0u aAppbmRleCBlOTUyODRjNWVhNjI1MTE3MTM4Yjg2ZjYwMzg0OGRkOThkMzM2MTRlLi5hNDk3YjVj NzE2MDRmMDQxOWI2MTExNzIzM2Q5NGE2MDRlODhlM2ZlIDEwMDY0NAotLS0gYS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ltYWdlTGF5ZXJDaHJvbWl1bS5oCisrKyBiL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vSW1hZ2VMYXllckNocm9taXVtLmgKQEAgLTM2 LDYgKzM2LDEwIEBACiAKICNpbmNsdWRlICJDb250ZW50TGF5ZXJDaHJvbWl1bS5oIgogCisjaWYg UExBVEZPUk0oQ0cpCisjaW5jbHVkZSA8d3RmL1JldGFpblB0ci5oPgorI2VuZGlmCisKIG5hbWVz cGFjZSBXZWJDb3JlIHsKIAogLy8gQSBMYXllciB0aGF0IGNvbnRhaW5zIG9ubHkgYW4gSW1hZ2Ug ZWxlbWVudC4KQEAgLTUwLDcgKzU0LDEzIEBAIHB1YmxpYzoKIAogcHJpdmF0ZToKICAgICBJbWFn ZUxheWVyQ2hyb21pdW0oR3JhcGhpY3NMYXllckNocm9taXVtKiBvd25lcik7CisKKyNpZiBQTEFU Rk9STShDRykKKyAgICBSZXRhaW5QdHI8Q0dJbWFnZVJlZj4gbV9jb250ZW50czsKKyNlbGlmIAor ICAgIC8vIEZJWE1FOiBUaGlzIG5lZWRzIHRvIGJlIGFuIG93bmluZyB0eXBlLgogICAgIE5hdGl2 ZUltYWdlUHRyIG1fY29udGVudHM7CisjZW5kaWYKIH07CiAKIH0K