45708 2010-09-13 13:51:33 -0700 Rename GraphicsContext3D::WebGLEnumType 2011-02-08 17:47:04 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 1 kbr zmo cmarrin enne jamesr zmo oldest_to_newest 278450 0 kbr 2010-09-13 13:51:33 -0700 Since WebGL is no longer the sole consumer of GraphicsContext3D, the WebGLEnumType in GC3D should be renamed in the case where clients need to refer specifically to the enum values provided by GC3D. EnumType would be sufficient since it's scoped within the GC3D class. 301483 1 zmo 2010-10-28 17:24:23 -0700 Maybe GLEnumType? 302928 2 kbr 2010-11-01 14:18:56 -0700 (In reply to comment #1) > Maybe GLEnumType? No reason. Again, the type name is scoped within GraphicsContext3D. 347783 3 zmo 2011-02-08 16:19:15 -0800 I really enjoy grabbing easy-to-fix bugs from others :) 347788 4 81713 zmo 2011-02-08 16:21:27 -0800 Created attachment 81713 Patch 347795 5 zmo 2011-02-08 16:30:38 -0800 Actually now I think about it again, maybe we could just go with anonymous enums? Basically we want people to use GC3Denum type instead of GraphicsContext3D::EnumType. 347827 6 kbr 2011-02-08 17:15:10 -0800 (In reply to comment #5) > Actually now I think about it again, maybe we could just go with anonymous enums? Basically we want people to use GC3Denum type instead of GraphicsContext3D::EnumType. Sure, that sounds fine. It's impossible in the OpenGL API to have distinct enum types for different uses, because there's overloading of some of the enums in different entry points, so there really isn't any value in naming the enum. 347846 7 81724 zmo 2011-02-08 17:33:20 -0800 Created attachment 81724 Patch 347852 8 81724 kbr 2011-02-08 17:37:48 -0800 Comment on attachment 81724 Patch Looks fine. 347864 9 zmo 2011-02-08 17:47:04 -0800 Committed r77999: <http://trac.webkit.org/changeset/77999> 81713 2011-02-08 16:21:27 -0800 2011-02-08 17:33:18 -0800 Patch bug-45708-20110208162126.patch text/plain 2338 zmo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3OTg2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMDggIFpoZW55YW8g TW8gIDx6bW9AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZW5hbWUgR3JhcGhpY3NDb250ZXh0M0Q6OldlYkdMRW51bVR5cGUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1NzA4CisKKyAg ICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFByb2dyYW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6 V2ViR0xQcm9ncmFtOjpnZXRBdHRhY2hlZFNoYWRlcik6CisgICAgICAgICogaHRtbC9jYW52YXMv V2ViR0xQcm9ncmFtLmg6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250 ZXh0M0QuaDoKKwogMjAxMS0wMi0wOCAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9o dG1sL2NhbnZhcy9XZWJHTFByb2dyYW0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2h0bWwvY2FudmFzL1dlYkdMUHJvZ3JhbS5jcHAJKHJldmlzaW9uIDc3OTE1KQorKysgU291cmNl L1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xQcm9ncmFtLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTAzLDcgKzEwMyw3IEBAIGJvb2wgV2ViR0xQcm9ncmFtOjppc1VzaW5nVmVydGV4QXR0cmliMCgK ICAgICByZXR1cm4gZmFsc2U7CiB9CiAKLVdlYkdMU2hhZGVyKiBXZWJHTFByb2dyYW06OmdldEF0 dGFjaGVkU2hhZGVyKEdyYXBoaWNzQ29udGV4dDNEOjpXZWJHTEVudW1UeXBlIHR5cGUpCitXZWJH TFNoYWRlciogV2ViR0xQcm9ncmFtOjpnZXRBdHRhY2hlZFNoYWRlcihHQzNEZW51bSB0eXBlKQog ewogICAgIHN3aXRjaCAodHlwZSkgewogICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OlZFUlRF WF9TSEFERVI6CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFByb2dyYW0u aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFByb2dyYW0u aAkocmV2aXNpb24gNzc5MTUpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFBy b2dyYW0uaAkod29ya2luZyBjb3B5KQpAQCAtNjAsNyArNjAsNyBAQCBwdWJsaWM6CiAgICAgLy8g d2lsbCBuZXZlciBiZSBsaW5rZWQgc28gbWFueSB0aW1lcy4KICAgICB2b2lkIGluY3JlYXNlTGlu a0NvdW50KCkgeyArK21fbGlua0NvdW50OyB9CiAKLSAgICBXZWJHTFNoYWRlciogZ2V0QXR0YWNo ZWRTaGFkZXIoR3JhcGhpY3NDb250ZXh0M0Q6OldlYkdMRW51bVR5cGUpOworICAgIFdlYkdMU2hh ZGVyKiBnZXRBdHRhY2hlZFNoYWRlcihHQzNEZW51bSk7CiAgICAgYm9vbCBhdHRhY2hTaGFkZXIo V2ViR0xTaGFkZXIqKTsKICAgICBib29sIGRldGFjaFNoYWRlcihXZWJHTFNoYWRlciopOwogCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNz Q29udGV4dDNELmgJKHJldmlzaW9uIDc3OTE1KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaAkod29ya2luZyBjb3B5KQpAQCAtMTE5LDcgKzEx OSw3IEBAIGNsYXNzIEdyYXBoaWNzQ29udGV4dDNESW50ZXJuYWw7CiAKIGNsYXNzIEdyYXBoaWNz Q29udGV4dDNEIDogcHVibGljIFJlZkNvdW50ZWQ8R3JhcGhpY3NDb250ZXh0M0Q+IHsKIHB1Ymxp YzoKLSAgICBlbnVtIFdlYkdMRW51bVR5cGUgeworICAgIGVudW0gRW51bVR5cGUgewogICAgICAg ICBERVBUSF9CVUZGRVJfQklUID0gMHgwMDAwMDEwMCwKICAgICAgICAgU1RFTkNJTF9CVUZGRVJf QklUID0gMHgwMDAwMDQwMCwKICAgICAgICAgQ09MT1JfQlVGRkVSX0JJVCA9IDB4MDAwMDQwMDAs Cg== 81724 2011-02-08 17:33:20 -0800 2011-02-08 17:37:48 -0800 Patch bug-45708-20110208173319.patch text/plain 2329 zmo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3OTg2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMDggIFpoZW55YW8g TW8gIDx6bW9AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZW5hbWUgR3JhcGhpY3NDb250ZXh0M0Q6OldlYkdMRW51bVR5cGUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1NzA4CisKKyAg ICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFByb2dyYW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6 V2ViR0xQcm9ncmFtOjpnZXRBdHRhY2hlZFNoYWRlcik6CisgICAgICAgICogaHRtbC9jYW52YXMv V2ViR0xQcm9ncmFtLmg6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250 ZXh0M0QuaDoKKwogMjAxMS0wMi0wOCAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9o dG1sL2NhbnZhcy9XZWJHTFByb2dyYW0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2h0bWwvY2FudmFzL1dlYkdMUHJvZ3JhbS5jcHAJKHJldmlzaW9uIDc3OTE1KQorKysgU291cmNl L1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xQcm9ncmFtLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTAzLDcgKzEwMyw3IEBAIGJvb2wgV2ViR0xQcm9ncmFtOjppc1VzaW5nVmVydGV4QXR0cmliMCgK ICAgICByZXR1cm4gZmFsc2U7CiB9CiAKLVdlYkdMU2hhZGVyKiBXZWJHTFByb2dyYW06OmdldEF0 dGFjaGVkU2hhZGVyKEdyYXBoaWNzQ29udGV4dDNEOjpXZWJHTEVudW1UeXBlIHR5cGUpCitXZWJH TFNoYWRlciogV2ViR0xQcm9ncmFtOjpnZXRBdHRhY2hlZFNoYWRlcihHQzNEZW51bSB0eXBlKQog ewogICAgIHN3aXRjaCAodHlwZSkgewogICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OlZFUlRF WF9TSEFERVI6CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFByb2dyYW0u aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFByb2dyYW0u aAkocmV2aXNpb24gNzc5MTUpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFBy b2dyYW0uaAkod29ya2luZyBjb3B5KQpAQCAtNjAsNyArNjAsNyBAQCBwdWJsaWM6CiAgICAgLy8g d2lsbCBuZXZlciBiZSBsaW5rZWQgc28gbWFueSB0aW1lcy4KICAgICB2b2lkIGluY3JlYXNlTGlu a0NvdW50KCkgeyArK21fbGlua0NvdW50OyB9CiAKLSAgICBXZWJHTFNoYWRlciogZ2V0QXR0YWNo ZWRTaGFkZXIoR3JhcGhpY3NDb250ZXh0M0Q6OldlYkdMRW51bVR5cGUpOworICAgIFdlYkdMU2hh ZGVyKiBnZXRBdHRhY2hlZFNoYWRlcihHQzNEZW51bSk7CiAgICAgYm9vbCBhdHRhY2hTaGFkZXIo V2ViR0xTaGFkZXIqKTsKICAgICBib29sIGRldGFjaFNoYWRlcihXZWJHTFNoYWRlciopOwogCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNz Q29udGV4dDNELmgJKHJldmlzaW9uIDc3OTE1KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaAkod29ya2luZyBjb3B5KQpAQCAtMTE5LDcgKzEx OSw3IEBAIGNsYXNzIEdyYXBoaWNzQ29udGV4dDNESW50ZXJuYWw7CiAKIGNsYXNzIEdyYXBoaWNz Q29udGV4dDNEIDogcHVibGljIFJlZkNvdW50ZWQ8R3JhcGhpY3NDb250ZXh0M0Q+IHsKIHB1Ymxp YzoKLSAgICBlbnVtIFdlYkdMRW51bVR5cGUgeworICAgIGVudW0gewogICAgICAgICBERVBUSF9C VUZGRVJfQklUID0gMHgwMDAwMDEwMCwKICAgICAgICAgU1RFTkNJTF9CVUZGRVJfQklUID0gMHgw MDAwMDQwMCwKICAgICAgICAgQ09MT1JfQlVGRkVSX0JJVCA9IDB4MDAwMDQwMDAsCg==