45707 2010-09-13 13:51:22 -0700 webkit-patch should handle when buildbot goes down 2015-12-07 10:08:04 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 NEW P2 Normal --- 1 eric webkit-unassigned abarth oldest_to_newest 278449 0 eric 2010-09-13 13:51:22 -0700 webkit-path should handle when buildbot goes down An example failure which we should be handling: We should probably just log that buildbot was down and return that the builders are "green". I suspect that webkit-patch manual mode might want somethign different from the bots. $ webkit-patch land-attachment 67431 --force-clean Traceback (most recent call last): File "./WebKitTools/Scripts/webkit-patch", line 70, in <module> main() File "./WebKitTools/Scripts/webkit-patch", line 65, in main WebKitPatch(__file__).main() File "/Users/abarth/git/webkit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main result = command.check_arguments_and_execute(options, args, self) File "/Users/abarth/git/webkit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Users/abarth/git/webkit/WebKitTools/Scripts/webkitpy/tool/commands/download.py", line 128, in execute self._prepare_to_process(options, args, tool) File "/Users/abarth/git/webkit/WebKitTools/Scripts/webkitpy/tool/commands/download.py", line 151, in _prepare_to_process self._prepare_sequence.run_and_handle_errors(tool, options) File "/Users/abarth/git/webkit/WebKitTools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors self._run(tool, options, state) File "/Users/abarth/git/webkit/WebKitTools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/Users/abarth/git/webkit/WebKitTools/Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py", line 44, in run red_builders_names = self._tool.buildbot.red_core_builders_names() File "/Users/abarth/git/webkit/WebKitTools/Scripts/webkitpy/common/net/buildbot.py", line 393, in red_core_builders_names return [builder["name"] for builder in self.red_core_builders()] File "/Users/abarth/git/webkit/WebKitTools/Scripts/webkitpy/common/net/buildbot.py", line 390, in red_core_builders return [builder for builder in self.core_builder_statuses() if not builder["is_green"]] File "/Users/abarth/git/webkit/WebKitTools/Scripts/webkitpy/common/net/buildbot.py", line 446, in core_builder_statuses return [builder for builder in self.builder_statuses() if self._is_core_builder(builder["name"])] File "/Users/abarth/git/webkit/WebKitTools/Scripts/webkitpy/common/net/buildbot.py", line 442, in builder_statuses soup = BeautifulSoup(self._fetch_one_box_per_builder()) File "/Users/abarth/git/webkit/WebKitTools/Scripts/webkitpy/common/net/buildbot.py", line 415, in _fetch_one_box_per_builder return urllib2.urlopen(build_status_url) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 124, in urlopen return _opener.open(url, data, timeout) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 389, in open response = meth(req, response) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 502, in http_response 'http', request, response, code, msg, hdrs) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 427, in error return self._call_chain(*args) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 361, in _call_chain result = func(*args) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 510, in http_error_default raise HTTPError(req.get_full_url(), code, msg, hdrs, fp) urllib2.HTTPError: HTTP Error 403: Forbidden