45697 2010-09-13 12:46:43 -0700 CrashTracer: 874 crashes in Safari at com.apple.WebCore: WebCore::AccessibilityTable::isTableExposableThroughAccessibility + 663 2010-09-13 13:56:49 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach ddkilzer oldest_to_newest 278408 0 cfleizach 2010-09-13 12:46:43 -0700 Thread 0 Crashed ↩: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x7fff85834757 WebCore::AccessibilityTable::isTableExposableThroughAccessibility() + 663 (/SourceCache/WebCore/WebCore-7533.16/accessibility/AccessibilityTable.cpp:166) 1 com.apple.WebCore 0x7fff858344ae WebCore::AccessibilityTable::AccessibilityTable(WebCore::RenderObject*) + 94 (/SourceCache/WebCore/WebCore-7533.16/accessibility/AccessibilityTable.cpp:57) 2 com.apple.WebCore 0x7fff85834422 WebCore::AccessibilityTable::create(WebCore::RenderObject*) + 50 (/System/Library/Frameworks/JavaScriptCore.framework/PrivateHeaders/PassRefPtr.h:107) 3 com.apple.WebCore 0x7fff85827c7a WebCore::AXObjectCache::getOrCreate(WebCore::RenderObject*) + 1066 (/System/Library/Frameworks/JavaScriptCore.framework/PrivateHeaders/RefPtr.h:148) 4 com.apple.WebCore 0x7fff8583507d WebCore::AccessibilityTableRow::isTableRow() const + 13 (/SourceCache/WebCore/WebCore-7533.16/accessibility/AccessibilityTableRow.cpp:70) 5 com.apple.WebCore 0x7fff85835c95 WebCore::AccessibilityTableRow::roleValue() const + 21 (/SourceCache/WebCore/WebCore-7533.16/accessibility/AccessibilityTableRow.cpp:62) 6 com.apple.WebCore 0x7fff85833260 WebCore::AccessibilityRenderObject::ariaLiveRegionStatus() const + 96 (/SourceCache/WebCore/WebCore-7533.16/accessibility/AccessibilityRenderObject.cpp:3269) 7 com.apple.WebCore 0x7fff858331b2 WebCore::AccessibilityObject::supportsARIALiveRegion() const + 18 (/SourceCache/WebCore/WebCore-7533.16/accessibility/AccessibilityObject.cpp:980) 8 com.apple.WebCore 0x7fff8583bb48 WebCore::AccessibilityRenderObject::contentChanged() + 72 (/SourceCache/WebCore/WebCore-7533.16/accessibility/AccessibilityRenderObject.cpp:3131) 9 com.apple.WebCore 0x7fff854b610b WebCore::StyledElement::attributeChanged(WebCore::Attribute*, bool) + 331 (/SourceCache/WebCore/WebCore-7533.16/ 278409 1 cfleizach 2010-09-13 12:46:50 -0700 very similar to https://bugs.webkit.org/show_bug.cgi?id=42652 278413 2 67459 cfleizach 2010-09-13 12:55:27 -0700 Created attachment 67459 patch 278421 3 67459 darin 2010-09-13 13:14:13 -0700 Comment on attachment 67459 patch Are all the callers of parentTable prepared to get 0? Will this harm correctness by returning 0 just because there’s no existing accessibility wrapper? What’s the design here? 278451 4 cfleizach 2010-09-13 13:51:43 -0700 (In reply to comment #3) > (From update of attachment 67459 [details]) > Are all the callers of parentTable prepared to get 0? Will this harm correctness by returning 0 just because there’s no existing accessibility wrapper? What’s the design here? parentTable() is used to determine if the AccessibilityTableRow should be exposed an AXRow or just a regular object. That is, it checks to see if its parent is a table, and if so, it becomes a row. If 0 is returned, those cases are covered (just checked). 278454 5 cfleizach 2010-09-13 13:56:49 -0700 http://trac.webkit.org/changeset/67407 67459 2010-09-13 12:55:27 -0700 2010-09-13 13:14:13 -0700 patch patch.txt text/plain 5080 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NzQwNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDktMTMgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDcmFzaFRyYWNlcjogODc0IGNyYXNoZXMgaW4gU2FmYXJpIGF0IGNvbS5hcHBsZS5XZWJDb3Jl OiBXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5VGFibGU6OmlzVGFibGVFeHBvc2FibGVUaHJvdWdoQWNj ZXNzaWJpbGl0eSArIDY2MworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDU2OTcKKworICAgICAgICBJbnNpZGUgb2YgQWNjZXNzaWJpbGl0eVRhYmxlUm93 LCBwYXJlbnRUYWJsZSgpIHNob3VsZCBub3QgdXNlIGdldE9yQ3JlYXRlKCkgb24gdGhlIHBhcmVu dCB0YWJsZSwgYmVjYXVzZSB0aGUgcmVuZGVyIHRhYmxlIG1heQorICAgICAgICBiZSBpbiBhIGJh ZCBzdGF0ZSBhbmQgYWNjZXNzaW5nIGludGVybmFsIHZhcmlhYmxlcyBjYW4gbGVhZCB0byBhIGNy YXNoLgorCisgICAgICAgIFRlc3Q6IHBsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3VwZGF0aW5n LWF0dHJpYnV0ZS1pbi10YWJsZS1yb3ctY3Jhc2guaHRtbAorCisgICAgICAgICogYWNjZXNzaWJp bGl0eS9BY2Nlc3NpYmlsaXR5VGFibGVSb3cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNz aWJpbGl0eVRhYmxlUm93OjpwYXJlbnRUYWJsZSk6CisKIDIwMTAtMDktMTMgIEVucmljYSBDYXN1 Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2Vpbmlu Zy4KSW5kZXg6IFdlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5VGFibGVSb3cuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5VGFibGVS b3cuY3BwCShyZXZpc2lvbiA2NzQwMikKKysrIFdlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3Np YmlsaXR5VGFibGVSb3cuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05Myw3ICs5Myw4IEBACiAgICAg aWYgKCFtX3JlbmRlcmVyIHx8ICFtX3JlbmRlcmVyLT5pc1RhYmxlUm93KCkpCiAgICAgICAgIHJl dHVybiAwOwogICAgIAotICAgIHJldHVybiBheE9iamVjdENhY2hlKCktPmdldE9yQ3JlYXRlKHRv UmVuZGVyVGFibGVSb3cobV9yZW5kZXJlciktPnRhYmxlKCkpOworICAgIC8vIERvIG5vdCB1c2Ug Z2V0T3JDcmVhdGUuIHBhcmVudFRhYmxlKCkgY2FuIGJlIGNhbGxlZCB3aGlsZSB0aGUgcmVuZGVy IHRyZWUgaXMgYmVpbmcgbW9kaWZpZWQuCisgICAgcmV0dXJuIGF4T2JqZWN0Q2FjaGUoKS0+Z2V0 KHRvUmVuZGVyVGFibGVSb3cobV9yZW5kZXJlciktPnRhYmxlKCkpOwogfQogICAgIAogQWNjZXNz aWJpbGl0eU9iamVjdCogQWNjZXNzaWJpbGl0eVRhYmxlUm93OjpoZWFkZXJPYmplY3QoKQpJbmRl eDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvdXBkYXRpbmctYXR0cmli dXRlLWluLXRhYmxlLXJvdy1jcmFzaC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvdXBkYXRpbmctYXR0cmlidXRlLWluLXRh YmxlLXJvdy1jcmFzaC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS91cGRhdGluZy1hdHRyaWJ1dGUtaW4tdGFibGUtcm93 LWNyYXNoLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMSBAQAorMQkyCith c2RmCitUaGlzIHRlc3RzIGZvciBhIGNyYXNoIHRoYXQgY2FuIG9jY3VyIHdoaWxlIGFsdGVyaW5n IGFuIGF0dHJpYnV0ZSBvbiBhIHRhYmxlIHJvdyBiZWNhdXNlIGl0IGFjY2Vzc2VzIHRoZSB0YWJs ZSB3aGVuIGl0cyBpbiBhIGJhZCBzdGF0ZS4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEg c2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgor CisKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCklu ZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS91cGRhdGluZy1hdHRy aWJ1dGUtaW4tdGFibGUtcm93LWNyYXNoLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv cGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvdXBkYXRpbmctYXR0cmlidXRlLWluLXRhYmxlLXJv dy1jcmFzaC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Fj Y2Vzc2liaWxpdHkvdXBkYXRpbmctYXR0cmlidXRlLWluLXRhYmxlLXJvdy1jcmFzaC5odG1sCShy ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQyIEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lF VEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0 IiBocmVmPSIuLi8uLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8 c2NyaXB0PgorICAgIHZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSBmYWxzZTsKKzwvc2NyaXB0Pgor PHNjcmlwdCBzcmM9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48 L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IGlkPSJib2R5Ij4KKworPHRhYmxlIGlkPSJ0YWJsZSI+ Cis8dHIgaWQ9InJvdyI+PHRkIGlkPSJ0YWJsZWNlbGwiIHRhYmluZGV4PTA+MTwvdGQ+PHRkPjI8 L3RkPjwvdHI+Cis8dHIgaWQ9InJvdzIiPjx0ZCBpZD0idGFibGVjZWxsMiIgdGFiaW5kZXg9MD4x PC90ZD48dGQ+MjwvdGQ+PC90cj4KKzwvdGFibGU+CisKKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9w PgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisKKzxzY3JpcHQ+CisgICAgZGVzY3JpcHRpb24o IlRoaXMgdGVzdHMgZm9yIGEgY3Jhc2ggdGhhdCBjYW4gb2NjdXIgd2hpbGUgYWx0ZXJpbmcgYW4g YXR0cmlidXRlIG9uIGEgdGFibGUgcm93IGJlY2F1c2UgaXQgYWNjZXNzZXMgdGhlIHRhYmxlIHdo ZW4gaXRzIGluIGEgYmFkIHN0YXRlLiIpOworCisgICAgaWYgKHdpbmRvdy5hY2Nlc3NpYmlsaXR5 Q29udHJvbGxlcikgeworICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiYm9keSIpLmZv Y3VzKCk7CisgICAgICAgIHZhciBib2R5ID0gYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuZm9jdXNl ZEVsZW1lbnQ7CisgICAgICAgIHZhciB0ciA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInRyIik7 CisgICAgICAgIHZhciB0ZCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInRkIik7CisgICAgICAg IHRkLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKCJhc2RmIikpOworICAgICAg ICB0ci5hcHBlbmRDaGlsZCh0ZCk7CisKKyAgICAgICAgLy8gVG8gcmVwcm9kdWNlLCB3ZSBuZWVk IHRvIHJlbW92ZSBhIHJvdyBhbmQgcmVwbGFjZSB3aXRoIGFub3RoZXIgcm93LCB0aGVuIHNldCBh biBhdHRyaWJ1dGUgaW4gdGhlIG1lYW50aW1lLgorICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgidGFibGUiKS5nZXRFbGVtZW50c0J5VGFnTmFtZSgiVEJPRFkiKVswXS5yZW1vdmVDaGls ZChkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicm93MiIpKTsKKyAgICAgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoInRhYmxlIikuZ2V0RWxlbWVudHNCeVRhZ05hbWUoIlRCT0RZIilbMF0uYXBw ZW5kQ2hpbGQodHIpOworICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicm93Iikuc2V0 QXR0cmlidXRlKCJ0aXRsZSIsICJncmlkcm93Iik7CisgICAgfQorCisgICAgc3VjY2Vzc2Z1bGx5 UGFyc2VkID0gdHJ1ZTsKKzwvc2NyaXB0PgorCis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vZmFzdC9q cy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY3NDA0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDktMTMgIENocmlzIEZsZWl6YWNoICA8 Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBDcmFzaFRyYWNlcjogODc0IGNyYXNoZXMgaW4gU2FmYXJpIGF0IGNvbS5h cHBsZS5XZWJDb3JlOiBXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5VGFibGU6OmlzVGFibGVFeHBvc2Fi bGVUaHJvdWdoQWNjZXNzaWJpbGl0eSArIDY2MworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU2OTcKKworICAgICAgICAqIHBsYXRmb3JtL21hYy9hY2Nl c3NpYmlsaXR5L3VwZGF0aW5nLWF0dHJpYnV0ZS1pbi10YWJsZS1yb3ctY3Jhc2gtZXhwZWN0ZWQu dHh0OiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS91cGRhdGlu Zy1hdHRyaWJ1dGUtaW4tdGFibGUtcm93LWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDEwLTA5LTEz ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg cmVtb3ZpbmcgY2hyb21pdW0tbGludXggcmVzdWx0cyB0aGF0IGRlZHVwbGljYXRlLXRlc3RzIHNh eXMgYXJlCg==