45681 2010-09-13 10:10:16 -0700 Assertion failure: m_isValid == validity()->valid() after manipulating a detached element 2010-09-28 00:11:12 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Major --- 42959 1 ap tkent adele darin dglazkov tkent oldest_to_newest 278281 0 67422 ap 2010-09-13 10:10:16 -0700 Created attachment 67422 test case (may crash) See attached test case. 278594 1 67493 tkent 2010-09-13 17:37:13 -0700 Created attachment 67493 Patch 279839 2 67493 ap 2010-09-15 17:13:00 -0700 Comment on attachment 67493 Patch Why do we need to call setNeedsValidityCheck() in both functions? One of these always calls another. If we do need that, it may be worth a comment in code, or at the very least, in ChangeLog. 279878 3 tkent 2010-09-15 18:20:24 -0700 Thank you for the feedback. (In reply to comment #2) > (From update of attachment 67493 [details]) > Why do we need to call setNeedsValidityCheck() in both functions? One of these always calls another. > > If we do need that, it may be worth a comment in code, or at the very least, in ChangeLog. setNonDirtyValue() is called by other functions. We need to call setNeedsValidityCheck() in that case. I'll improve the code to reduce redundant calls of setNeedsValidityCheck(). 279880 4 67754 tkent 2010-09-15 18:24:25 -0700 Created attachment 67754 Patch 2 (resolve redundant setNeedsValidityCheck()) 280203 5 ap 2010-09-16 10:52:19 -0700 > setNonDirtyValue() is called by other functions. OK, but why wouldn't it be sufficient to only have setNeedsValidityCheck() in setNonDirtyValue()? Since setValue() calls it, it doesn't seem to also call the same function. Talking about the new patch - this is probably a related question, but why can't setNeedsValidityCheck() be in setValueCommon()? Does its behavior depend on m_isDirty value? It doesn't use it explicitly, and if an indirect use is the reason not to put this call in setValueCommon(), then a comment should explain that (and setNeedsValidityCheck() probably needs a better name, since it does something different than setting a "needsValidityCheck" boolean). Both these patches confuse me, but it seems that a larger refactoring may be needed. If so, the first one might actually be better as a targeted fix, as it's simpler and doesn't add a new method. 282055 6 tkent 2010-09-20 20:38:54 -0700 (In reply to comment #5) > > setNonDirtyValue() is called by other functions. > > OK, but why wouldn't it be sufficient to only have setNeedsValidityCheck() in setNonDirtyValue()? Since setValue() calls it, it doesn't seem to also call the same function. > > but why can't setNeedsValidityCheck() be in setValueCommon()? Does its behavior depend on m_isDirty value? Right. setNeedsValidityCheck() result depends on m_isDirty value. The name "setNeedsValidityCheck" doesn't represent the current behavior. The role of setNeedsValdityCheck was to set "needs to recalculate element validity", and the name followed "setNeedsStyleRecalc". But we need to calculate validity in setNeedsValidityCheck for some reasons. I don't think we'll have a large refactor for needsValidityCheck, but we should rename it. 283049 7 67754 ap 2010-09-22 10:46:31 -0700 Comment on attachment 67754 Patch 2 (resolve redundant setNeedsValidityCheck()) OK. So, do you prefer the old or the new patch yourself? Given that you kept the new one for review, I guess that's it, so I'll mark it r+. > ta.checkValidity(); // This made an assertion failure. "This made an assertion fail". 286100 8 tkent 2010-09-27 23:51:17 -0700 (In reply to comment #7) > (From update of attachment 67754 [details]) > OK. So, do you prefer the old or the new patch yourself? Given that you kept the new one for review, I guess that's it, so I'll mark it r+. Yeah, I prefer the second patch. Thanks for r+. > > ta.checkValidity(); // This made an assertion failure. > > "This made an assertion fail". I'll fix it before landing. 286108 9 tkent 2010-09-28 00:10:54 -0700 Landed as r68494. 67422 2010-09-13 10:10:16 -0700 2010-09-13 10:10:16 -0700 test case (may crash) ta.html text/html 182 ap PGJvZHk+CjxzY3JpcHQ+CnZhciB0YSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInRleHRhcmVh Iik7CnRhLnNldEF0dHJpYnV0ZSgibWF4bGVuZ3RoIiwgIjEiKTsKdGEudmFsdWUgPSAiYWJjIgpk b2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKHRhKTsKdGEuY2hlY2tWYWxpZGl0eSgpOwo8L3Njcmlw dD4KPC9ib2R5Pgo= 67493 2010-09-13 17:37:13 -0700 2010-09-15 18:24:18 -0700 Patch bug-45681-20100914093712.patch text/plain 4017 tkent ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlNWQ1MmMwMDY4MWYzMjAwMGNiMWJmYTk1OWEwMTE1NTZlNjA0MTQ1Li40YzgyNDdl ZGRlN2NmNjU2MTQ1OGYwZDU1YTAzMzYwNjAxYTE2YjZhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDktMTMgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhc3NlcnRpb24gZmFp bHVyZSB3aGVuIHRoZSBkaXJ0eSBmbGFnIG9mIGEgdGV4dGFyZWEgZWxlbWVudCBpcyBjaGFuZ2Vk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTY4MQor CisgICAgICAgICogZmFzdC9mb3Jtcy90ZXh0YXJlYS1jaGVja1ZhbGlkaXR5LWNyYXNoLWV4cGVj dGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mb3Jtcy90ZXh0YXJlYS1jaGVja1ZhbGlk aXR5LWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDEwLTA5LTEzICBEaXJrIFByYW5rZSAgPGRwcmFu a2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGV4cGVjdGF0aW9ucyBjaGFu Z2UuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3RleHRhcmVhLWNoZWNrVmFs aWRpdHktY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90ZXh0YXJl YS1jaGVja1ZhbGlkaXR5LWNyYXNoLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5jYmI0M2Q3Nzgy MGY0OGI4NjhmNGNjNGI5MjcwMjllMTIyOWM1ZWNkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC9mb3Jtcy90ZXh0YXJlYS1jaGVja1ZhbGlkaXR5LWNyYXNoLWV4cGVjdGVkLnR4 dApAQCAtMCwwICsxLDggQEAKK0J1ZyA0NTY4MTogQXNzZXJ0aW9uIGZhaWx1cmUgYWJvdXQgZGly dHkgZmxhZyBjaGFuZ2VzIG9mIHRleHRhcmVhIGVsZW1lbnRzLgorCitQQVNTIE5vdCBjcmFzaGVk LgorUEFTUyBOb3QgY3Jhc2hlZC4KK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKwor VEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3RleHRh cmVhLWNoZWNrVmFsaWRpdHktY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvdGV4 dGFyZWEtY2hlY2tWYWxpZGl0eS1jcmFzaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmJkZWE4MWUyOTU0MTM3 YjgyMGY5NTc2ZmJmNmQxYTI3ODk2ZWRiNTIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL3RleHRhcmVhLWNoZWNrVmFsaWRpdHktY3Jhc2guaHRtbApAQCAtMCwwICsx LDI1IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4v Li4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgor PGJvZHk+Cis8cCBpZD0iZGVzY3JpcHRpb24iPkJ1ZyA0NTY4MTogQXNzZXJ0aW9uIGZhaWx1cmUg YWJvdXQgZGlydHkgZmxhZyBjaGFuZ2VzIG9mIHRleHRhcmVhIGVsZW1lbnRzLjwvcD4KKzxkaXYg aWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdD4KK3ZhciB0YSA9IGRvY3VtZW50LmNyZWF0ZUVs ZW1lbnQoJ3RleHRhcmVhJyk7Cit0YS5zZXRBdHRyaWJ1dGUoJ21heGxlbmd0aCcsICcxJyk7Cit0 YS52YWx1ZSA9ICdhYmMnOyAvLyBNYWtlIGl0IGRpcnR5ICYmIGludmFsaWQuCit0YS5jaGVja1Zh bGlkaXR5KCk7IC8vIFRoaXMgbWFkZSBhbiBhc3NlcnRpb24gZmFpbHVyZS4KK3Rlc3RQYXNzZWQo J05vdCBjcmFzaGVkLicpOworCit0YS52YWx1ZSA9ICdhJzsgLy8gTWFrZSBpdCBkaXJ0eSAmJiB2 YWxpZC4KK3RhLmRlZmF1bHRWYWx1ZSA9ICdhYmMnOyAvLyBNYWtlIGl0IG5vbi1kaXJ0eSAmJiBp bnZhbGlkLgordGEuY2hlY2tWYWxpZGl0eSgpOyAvLyBUaGlzIG1hZGUgYW4gYXNzZXJ0aW9uIGZh aWx1cmUuCit0ZXN0UGFzc2VkKCdOb3QgY3Jhc2hlZC4nKTsKKwordmFyIHN1Y2Nlc3NmdWxseVBh cnNlZCA9IHRydWU7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pzL3Jlc291 cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2MmJiYjEy NDFiYzI0MjQzZjU0YjE4MWQzMTg3OGUxMTQwY2M5NjQ1Li40ODMwODVhM2M1NzVmNjUyNzM1ZWNh MTMwNjRhYzQ1ODI0OGYyNzUzIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEwLTA5LTEzICBLZW50IFRhbXVy YSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggYXNzZXJ0aW9uIGZhaWx1cmUgd2hlbiB0aGUgZGlydHkgZmxh ZyBvZiBhIHRleHRhcmVhIGVsZW1lbnQgaXMgY2hhbmdlZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU2ODEKKworICAgICAgICBXZSBuZWVkIHRvIGNh bGwgc2V0TmVlZHNWYWxpZGl0eUNoZWNrKCkgYWZ0ZXIgdXBkYXRpbmcgbV9pc0RpcnR5LgorCisg ICAgICAgIFRlc3Q6IGZhc3QvZm9ybXMvdGV4dGFyZWEtY2hlY2tWYWxpZGl0eS1jcmFzaC5odG1s CisKKyAgICAgICAgKiBodG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SFRNTFRleHRBcmVhRWxlbWVudDo6c2V0VmFsdWUpOgorICAgICAgICAoV2ViQ29yZTo6 SFRNTFRleHRBcmVhRWxlbWVudDo6c2V0Tm9uRGlydHlWYWx1ZSk6CisKIDIwMTAtMDktMTMgIEFk YW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJp biBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MVGV4dEFyZWFFbGVtZW50LmNw cCBiL1dlYkNvcmUvaHRtbC9IVE1MVGV4dEFyZWFFbGVtZW50LmNwcAppbmRleCA4MGUxMzBkMjBi OWY4NTIwYTE0YWViM2Q1YTllY2RmMDZjMTkzYzhkLi4zNDYwNTEyNWRiYWIzNDY2MDMzMzA3YmVh ZmQ5N2YxN2E4OTJhZWQzIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRNTFRleHRBcmVhRWxl bWVudC5jcHAKKysrIGIvV2ViQ29yZS9odG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuY3BwCkBAIC0y ODksNiArMjg5LDcgQEAgdm9pZCBIVE1MVGV4dEFyZWFFbGVtZW50OjpzZXRWYWx1ZShjb25zdCBT dHJpbmcmIHZhbHVlKQogewogICAgIHNldE5vbkRpcnR5VmFsdWUodmFsdWUpOwogICAgIG1faXNE aXJ0eSA9IHRydWU7CisgICAgc2V0TmVlZHNWYWxpZGl0eUNoZWNrKCk7CiB9CiAKIHZvaWQgSFRN TFRleHRBcmVhRWxlbWVudDo6c2V0Tm9uRGlydHlWYWx1ZShjb25zdCBTdHJpbmcmIHZhbHVlKQpA QCAtMzA3LDggKzMwOCw4IEBAIHZvaWQgSFRNTFRleHRBcmVhRWxlbWVudDo6c2V0Tm9uRGlydHlW YWx1ZShjb25zdCBTdHJpbmcmIHZhbHVlKQogICAgIG1fdmFsdWUgPSBub3JtYWxpemVkVmFsdWU7 CiAgICAgdXBkYXRlUGxhY2Vob2xkZXJWaXNpYmlsaXR5KGZhbHNlKTsKICAgICBzZXROZWVkc1N0 eWxlUmVjYWxjKCk7Ci0gICAgc2V0TmVlZHNWYWxpZGl0eUNoZWNrKCk7CiAgICAgbV9pc0RpcnR5 ID0gZmFsc2U7CisgICAgc2V0TmVlZHNWYWxpZGl0eUNoZWNrKCk7CiAgICAgc2V0Rm9ybUNvbnRy b2xWYWx1ZU1hdGNoZXNSZW5kZXJlcih0cnVlKTsKIAogICAgIC8vIFNldCB0aGUgY2FyZXQgdG8g dGhlIGVuZCBvZiB0aGUgdGV4dCB2YWx1ZS4K 67754 2010-09-15 18:24:25 -0700 2010-09-28 00:11:12 -0700 Patch 2 (resolve redundant setNeedsValidityCheck()) bug-45681-20100916102423.patch text/plain 5167 tkent ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlNWQ1MmMwMDY4MWYzMjAwMGNiMWJmYTk1OWEwMTE1NTZlNjA0MTQ1Li5hODQwYWRh YjRiNGZhNTgyYTExN2YwYzFiNTcxOGU5NTgzZDM4NjA5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDktMTMgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhc3NlcnRpb24gZmFp bHVyZSBpbiBhIGNhc2UgdGhhdCB0aGUgZGlydHkgZmxhZyBvZiBhIHRleHRhcmVhIGVsZW1lbnQg aXMgY2hhbmdlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDU2ODEKKworICAgICAgICAqIGZhc3QvZm9ybXMvdGV4dGFyZWEtY2hlY2tWYWxpZGl0eS1j cmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZm9ybXMvdGV4dGFyZWEt Y2hlY2tWYWxpZGl0eS1jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAxMC0wOS0xMyAgRGlyayBQcmFu a2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCBleHBlY3Rh dGlvbnMgY2hhbmdlLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90ZXh0YXJl YS1jaGVja1ZhbGlkaXR5LWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZm9y bXMvdGV4dGFyZWEtY2hlY2tWYWxpZGl0eS1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u Y2JiNDNkNzc4MjBmNDhiODY4ZjRjYzRiOTI3MDI5ZTEyMjljNWVjZAotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvdGV4dGFyZWEtY2hlY2tWYWxpZGl0eS1jcmFzaC1l eHBlY3RlZC50eHQKQEAgLTAsMCArMSw4IEBACitCdWcgNDU2ODE6IEFzc2VydGlvbiBmYWlsdXJl IGFib3V0IGRpcnR5IGZsYWcgY2hhbmdlcyBvZiB0ZXh0YXJlYSBlbGVtZW50cy4KKworUEFTUyBO b3QgY3Jhc2hlZC4KK1BBU1MgTm90IGNyYXNoZWQuCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBp cyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9m b3Jtcy90ZXh0YXJlYS1jaGVja1ZhbGlkaXR5LWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0 L2Zvcm1zL3RleHRhcmVhLWNoZWNrVmFsaWRpdHktY3Jhc2guaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iZGVh ODFlMjk1NDEzN2I4MjBmOTU3NmZiZjZkMWEyNzg5NmVkYjUyCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90ZXh0YXJlYS1jaGVja1ZhbGlkaXR5LWNyYXNoLmh0bWwK QEAgLTAsMCArMSwyNSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlw dCBzcmM9Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4K KzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj5CdWcgNDU2ODE6IEFzc2VydGlv biBmYWlsdXJlIGFib3V0IGRpcnR5IGZsYWcgY2hhbmdlcyBvZiB0ZXh0YXJlYSBlbGVtZW50cy48 L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQ+Cit2YXIgdGEgPSBkb2N1bWVu dC5jcmVhdGVFbGVtZW50KCd0ZXh0YXJlYScpOwordGEuc2V0QXR0cmlidXRlKCdtYXhsZW5ndGgn LCAnMScpOwordGEudmFsdWUgPSAnYWJjJzsgLy8gTWFrZSBpdCBkaXJ0eSAmJiBpbnZhbGlkLgor dGEuY2hlY2tWYWxpZGl0eSgpOyAvLyBUaGlzIG1hZGUgYW4gYXNzZXJ0aW9uIGZhaWx1cmUuCit0 ZXN0UGFzc2VkKCdOb3QgY3Jhc2hlZC4nKTsKKwordGEudmFsdWUgPSAnYSc7IC8vIE1ha2UgaXQg ZGlydHkgJiYgdmFsaWQuCit0YS5kZWZhdWx0VmFsdWUgPSAnYWJjJzsgLy8gTWFrZSBpdCBub24t ZGlydHkgJiYgaW52YWxpZC4KK3RhLmNoZWNrVmFsaWRpdHkoKTsgLy8gVGhpcyBtYWRlIGFuIGFz c2VydGlvbiBmYWlsdXJlLgordGVzdFBhc3NlZCgnTm90IGNyYXNoZWQuJyk7CisKK3ZhciBzdWNj ZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vZmFz dC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRt bD4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggNjJiYmIxMjQxYmMyNDI0M2Y1NGIxODFkMzE4NzhlMTE0MGNjOTY0NS4uNzcxNjc5NDQ4OTll ZDZhMDc2MzUzOWY3YTg2NTFiNGQ5YjI3YjdiMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VM b2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wOS0xMyAg S2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGFzc2VydGlvbiBmYWlsdXJlIGluIGEgY2Fz ZSB0aGF0IHRoZSBkaXJ0eSBmbGFnIG9mIGEgdGV4dGFyZWEgZWxlbWVudCBpcyBjaGFuZ2VkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTY4MQorCisg ICAgICAgIFdlIG5lZWQgdG8gY2FsbCBzZXROZWVkc1ZhbGlkaXR5Q2hlY2soKSBhZnRlciB1cGRh dGluZyBtX2lzRGlydHkuCisKKyAgICAgICAgVGVzdDogZmFzdC9mb3Jtcy90ZXh0YXJlYS1jaGVj a1ZhbGlkaXR5LWNyYXNoLmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTFRleHRBcmVhRWxlbWVu dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVGV4dEFyZWFFbGVtZW50OjpzZXRWYWx1ZSk6 CisgICAgICAgIChXZWJDb3JlOjpIVE1MVGV4dEFyZWFFbGVtZW50OjpzZXROb25EaXJ0eVZhbHVl KToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUZXh0QXJlYUVsZW1lbnQ6OnNldFZhbHVlQ29tbW9u KToKKyAgICAgICAgKiBodG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuaDoKKwogMjAxMC0wOS0xMyAg QWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh cmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQu Y3BwIGIvV2ViQ29yZS9odG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuY3BwCmluZGV4IDgwZTEzMGQy MGI5Zjg1MjBhMTRhZWIzZDVhOWVjZGYwNmMxOTNjOGQuLmVhMWY2MmI4NjlhMDk2ZTIwMzAzYzk1 NDBlYmU5NDFjNGNhZjQ2YWQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MVGV4dEFyZWFF bGVtZW50LmNwcAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTFRleHRBcmVhRWxlbWVudC5jcHAKQEAg LTI4NywxMiArMjg3LDIwIEBAIFN0cmluZyBIVE1MVGV4dEFyZWFFbGVtZW50Ojp2YWx1ZSgpIGNv bnN0CiAKIHZvaWQgSFRNTFRleHRBcmVhRWxlbWVudDo6c2V0VmFsdWUoY29uc3QgU3RyaW5nJiB2 YWx1ZSkKIHsKLSAgICBzZXROb25EaXJ0eVZhbHVlKHZhbHVlKTsKKyAgICBzZXRWYWx1ZUNvbW1v bih2YWx1ZSk7CiAgICAgbV9pc0RpcnR5ID0gdHJ1ZTsKKyAgICBzZXROZWVkc1ZhbGlkaXR5Q2hl Y2soKTsKIH0KIAogdm9pZCBIVE1MVGV4dEFyZWFFbGVtZW50OjpzZXROb25EaXJ0eVZhbHVlKGNv bnN0IFN0cmluZyYgdmFsdWUpCiB7CisgICAgc2V0VmFsdWVDb21tb24odmFsdWUpOworICAgIG1f aXNEaXJ0eSA9IGZhbHNlOworICAgIHNldE5lZWRzVmFsaWRpdHlDaGVjaygpOworfQorCit2b2lk IEhUTUxUZXh0QXJlYUVsZW1lbnQ6OnNldFZhbHVlQ29tbW9uKGNvbnN0IFN0cmluZyYgdmFsdWUp Cit7CiAgICAgLy8gQ29kZSBlbHNld2hlcmUgbm9ybWFsaXplcyBsaW5lIGVuZGluZ3MgYWRkZWQg YnkgdGhlIHVzZXIgdmlhIHRoZSBrZXlib2FyZCBvciBwYXN0aW5nLgogICAgIC8vIFdlIG5vcm1h bGl6ZSBsaW5lIGVuZGluZ3MgY29taW5nIGZyb20gSmF2YVNjcmlwdCBoZXJlLgogICAgIFN0cmlu ZyBub3JtYWxpemVkVmFsdWUgPSB2YWx1ZS5pc051bGwoKSA/ICIiIDogdmFsdWU7CkBAIC0zMDcs OCArMzE1LDYgQEAgdm9pZCBIVE1MVGV4dEFyZWFFbGVtZW50OjpzZXROb25EaXJ0eVZhbHVlKGNv bnN0IFN0cmluZyYgdmFsdWUpCiAgICAgbV92YWx1ZSA9IG5vcm1hbGl6ZWRWYWx1ZTsKICAgICB1 cGRhdGVQbGFjZWhvbGRlclZpc2liaWxpdHkoZmFsc2UpOwogICAgIHNldE5lZWRzU3R5bGVSZWNh bGMoKTsKLSAgICBzZXROZWVkc1ZhbGlkaXR5Q2hlY2soKTsKLSAgICBtX2lzRGlydHkgPSBmYWxz ZTsKICAgICBzZXRGb3JtQ29udHJvbFZhbHVlTWF0Y2hlc1JlbmRlcmVyKHRydWUpOwogCiAgICAg Ly8gU2V0IHRoZSBjYXJldCB0byB0aGUgZW5kIG9mIHRoZSB0ZXh0IHZhbHVlLgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9odG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuaCBiL1dlYkNvcmUvaHRtbC9IVE1M VGV4dEFyZWFFbGVtZW50LmgKaW5kZXggMjhkMGI2MTVjZGY5ZGZjMWY3Njg2MmRhMmQwNzg3YjAx ZTNjMjczNS4uZDk1MWMwMmM1MDRiOTk3ZDk3NzViM2RjMmJlMzI3NzNjMjA0NGFlZCAxMDA2NDQK LS0tIGEvV2ViQ29yZS9odG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuaAorKysgYi9XZWJDb3JlL2h0 bWwvSFRNTFRleHRBcmVhRWxlbWVudC5oCkBAIC02Nyw2ICs2Nyw3IEBAIHByaXZhdGU6CiAgICAg c3RhdGljIFN0cmluZyBzYW5pdGl6ZVVzZXJJbnB1dFZhbHVlKGNvbnN0IFN0cmluZyYsIHVuc2ln bmVkIG1heExlbmd0aCk7CiAgICAgdm9pZCB1cGRhdGVWYWx1ZSgpIGNvbnN0OwogICAgIHZvaWQg c2V0Tm9uRGlydHlWYWx1ZShjb25zdCBTdHJpbmcmKTsKKyAgICB2b2lkIHNldFZhbHVlQ29tbW9u KGNvbnN0IFN0cmluZyYpOwogCiAgICAgdmlydHVhbCBib29sIHN1cHBvcnRzUGxhY2Vob2xkZXIo KSBjb25zdCB7IHJldHVybiB0cnVlOyB9CiAgICAgdmlydHVhbCBib29sIGlzRW1wdHlWYWx1ZSgp IGNvbnN0IHsgcmV0dXJuIHZhbHVlKCkuaXNFbXB0eSgpOyB9Cg==