45680 2010-09-13 09:58:12 -0700 [WINCE] Add FrameNetworkingContextWinCE::blockedError 2010-09-16 08:24:19 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 paroga webkit-unassigned aroben commit-queue oldest_to_newest 278269 0 paroga 2010-09-13 09:58:12 -0700 see patch 278273 1 67420 paroga 2010-09-13 10:00:57 -0700 Created attachment 67420 Patch 279414 2 67420 eric 2010-09-14 23:51:32 -0700 Comment on attachment 67420 Patch I'm confused. Is this to fix a compile error? What is this doing? Should this be calling notImplemented()? since this seems like a dummy implementation. Please update the ChangeLog to explain. 279465 3 67657 paroga 2010-09-15 01:46:27 -0700 Created attachment 67657 Patch 280083 4 67657 aroben 2010-09-16 07:46:07 -0700 Comment on attachment 67657 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67657&action=prettypatch > WebKit/wince/WebCoreSupport/FrameNetworkingContextWinCE.cpp:55 > +WebCore::ResourceError FrameNetworkingContextWinCE::blockedError(const WebCore::ResourceRequest&) const > +{ > + notImplemented(); > + return WebCore::ResourceError(); > +} There's no need for any of the "WebCore::"s here, since you have "using namespace WebCore;" near the top of the file. 280086 5 67657 paroga 2010-09-16 07:48:50 -0700 Comment on attachment 67657 Patch (In reply to comment #4) > There's no need for any of the "WebCore::"s here, since you have "using namespace WebCore;" near the top of the file. You're wrong. ;-) E.g: http://msdn.microsoft.com/en-us/library/ms919861.aspx 280088 6 paroga 2010-09-16 07:50:45 -0700 (In reply to comment #4) > (From update of attachment 67657 [details]) > > WebKit/wince/WebCoreSupport/FrameNetworkingContextWinCE.cpp:55 > > +WebCore::ResourceError FrameNetworkingContextWinCE::blockedError(const WebCore::ResourceRequest&) const > > +{ > > + notImplemented(); > > + return WebCore::ResourceError(); > > +} > > There's no need for any of the "WebCore::"s here, since you have "using namespace WebCore;" near the top of the file. I can remove it at WebCore::ResourceError, but it's strange to have it only on some places... 280090 7 aroben 2010-09-16 07:56:16 -0700 (In reply to comment #5) > (From update of attachment 67657 [details]) > (In reply to comment #4) > > There's no need for any of the "WebCore::"s here, since you have "using namespace WebCore;" near the top of the file. > You're wrong. ;-) E.g: http://msdn.microsoft.com/en-us/library/ms919861.aspx Oh my! I've never heard of that function. > I can remove it at WebCore::ResourceError, but it's strange to have it only on some places... OK. 280108 8 67657 commit-queue 2010-09-16 08:24:14 -0700 Comment on attachment 67657 Patch Clearing flags on attachment: 67657 Committed r67620: <http://trac.webkit.org/changeset/67620> 280109 9 commit-queue 2010-09-16 08:24:19 -0700 All reviewed patches have been landed. Closing bug. 67420 2010-09-13 10:00:57 -0700 2010-09-15 01:46:27 -0700 Patch 0001-blockedError.patch text/plain 2005 paroga ZGlmZiAtLWdpdCBhL1dlYktpdC93aW5jZS9DaGFuZ2VMb2cgYi9XZWJLaXQvd2luY2UvQ2hhbmdl TG9nCmluZGV4IDQ0ZmZiNDQuLjI5YzQ0NDAgMTAwNjQ0Ci0tLSBhL1dlYktpdC93aW5jZS9DaGFu Z2VMb2cKKysrIGIvV2ViS2l0L3dpbmNlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEw LTA5LTEzICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUBwYXJvZ2EuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtXSU5DRV0gQWRkIEZyYW1l TmV0d29ya2luZ0NvbnRleHRXaW5DRTo6YmxvY2tlZEVycm9yCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTY4MAorCisgICAgICAgICogV2ViQ29yZVN1 cHBvcnQvRnJhbWVOZXR3b3JraW5nQ29udGV4dFdpbkNFLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 RnJhbWVOZXR3b3JraW5nQ29udGV4dFdpbkNFOjpibG9ja2VkRXJyb3IpOgorICAgICAgICAqIFdl YkNvcmVTdXBwb3J0L0ZyYW1lTmV0d29ya2luZ0NvbnRleHRXaW5DRS5oOgorCiAyMDEwLTA5LTEz ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUBwYXJvZ2EuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3dp bmNlL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTmV0d29ya2luZ0NvbnRleHRXaW5DRS5jcHAgYi9XZWJL aXQvd2luY2UvV2ViQ29yZVN1cHBvcnQvRnJhbWVOZXR3b3JraW5nQ29udGV4dFdpbkNFLmNwcApp bmRleCBhZjllZmMyLi45NmZhYTRiIDEwMDY0NAotLS0gYS9XZWJLaXQvd2luY2UvV2ViQ29yZVN1 cHBvcnQvRnJhbWVOZXR3b3JraW5nQ29udGV4dFdpbkNFLmNwcAorKysgYi9XZWJLaXQvd2luY2Uv V2ViQ29yZVN1cHBvcnQvRnJhbWVOZXR3b3JraW5nQ29udGV4dFdpbkNFLmNwcApAQCAtMjUsNiAr MjUsOCBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkZyYW1lTmV0d29ya2luZ0Nv bnRleHRXaW5DRS5oIgogCisjaW5jbHVkZSAiUmVzb3VyY2VFcnJvci5oIgorCiB1c2luZyBuYW1l c3BhY2UgV2ViQ29yZTsKIAogbmFtZXNwYWNlIFdlYktpdCB7CkBAIC00NSw0ICs0Nyw5IEBAIFN0 cmluZyBGcmFtZU5ldHdvcmtpbmdDb250ZXh0V2luQ0U6OnJlZmVycmVyKCkgY29uc3QKICAgICBy ZXR1cm4gZnJhbWUoKS0+bG9hZGVyKCktPnJlZmVycmVyKCk7CiB9CiAKK1dlYkNvcmU6OlJlc291 cmNlRXJyb3IgRnJhbWVOZXR3b3JraW5nQ29udGV4dFdpbkNFOjpibG9ja2VkRXJyb3IoY29uc3Qg V2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JikgY29uc3QKK3sKKyAgICByZXR1cm4gV2ViQ29yZTo6 UmVzb3VyY2VFcnJvcigpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlmZiAtLWdpdCBh L1dlYktpdC93aW5jZS9XZWJDb3JlU3VwcG9ydC9GcmFtZU5ldHdvcmtpbmdDb250ZXh0V2luQ0Uu aCBiL1dlYktpdC93aW5jZS9XZWJDb3JlU3VwcG9ydC9GcmFtZU5ldHdvcmtpbmdDb250ZXh0V2lu Q0UuaAppbmRleCBhODI2YTM3Li40MzZhZmY3IDEwMDY0NAotLS0gYS9XZWJLaXQvd2luY2UvV2Vi Q29yZVN1cHBvcnQvRnJhbWVOZXR3b3JraW5nQ29udGV4dFdpbkNFLmgKKysrIGIvV2ViS2l0L3dp bmNlL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTmV0d29ya2luZ0NvbnRleHRXaW5DRS5oCkBAIC0zOCw2 ICszOCw3IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgV1RGOjpTdHJpbmcgdXNlckFnZW50KCkg Y29uc3Q7CiAgICAgdmlydHVhbCBXVEY6OlN0cmluZyByZWZlcnJlcigpIGNvbnN0OworICAgIHZp cnR1YWwgV2ViQ29yZTo6UmVzb3VyY2VFcnJvciBibG9ja2VkRXJyb3IoY29uc3QgV2ViQ29yZTo6 UmVzb3VyY2VSZXF1ZXN0JikgY29uc3Q7CiAKIHByaXZhdGU6CiAgICAgRnJhbWVOZXR3b3JraW5n Q29udGV4dFdpbkNFKFdlYkNvcmU6OkZyYW1lKiBmcmFtZSwgY29uc3QgV1RGOjpTdHJpbmcmIHVz ZXJBZ2VudCk7Cg== 67657 2010-09-15 01:46:27 -0700 2010-09-16 08:24:14 -0700 Patch 0001-blockedError2.patch text/plain 2066 paroga ZGlmZiAtLWdpdCBhL1dlYktpdC93aW5jZS9DaGFuZ2VMb2cgYi9XZWJLaXQvd2luY2UvQ2hhbmdl TG9nCmluZGV4IDQ0ZmZiNDQuLmQzZDY0NWEgMTAwNjQ0Ci0tLSBhL1dlYktpdC93aW5jZS9DaGFu Z2VMb2cKKysrIGIvV2ViS2l0L3dpbmNlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEw LTA5LTE1ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUBwYXJvZ2EuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtXSU5DRV0gQWRkIG1pc3Np bmcgRnJhbWVOZXR3b3JraW5nQ29udGV4dFdpbkNFOjpibG9ja2VkRXJyb3IKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1NjgwCisKKyAgICAgICAgKiBX ZWJDb3JlU3VwcG9ydC9GcmFtZU5ldHdvcmtpbmdDb250ZXh0V2luQ0UuY3BwOgorICAgICAgICAo V2ViS2l0OjpGcmFtZU5ldHdvcmtpbmdDb250ZXh0V2luQ0U6OmJsb2NrZWRFcnJvcik6CisgICAg ICAgICogV2ViQ29yZVN1cHBvcnQvRnJhbWVOZXR3b3JraW5nQ29udGV4dFdpbkNFLmg6CisKIDIw MTAtMDktMTMgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHBhcm9nYS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCmRpZmYgLS1naXQgYS9X ZWJLaXQvd2luY2UvV2ViQ29yZVN1cHBvcnQvRnJhbWVOZXR3b3JraW5nQ29udGV4dFdpbkNFLmNw cCBiL1dlYktpdC93aW5jZS9XZWJDb3JlU3VwcG9ydC9GcmFtZU5ldHdvcmtpbmdDb250ZXh0V2lu Q0UuY3BwCmluZGV4IGFmOWVmYzIuLjQ3N2ZlOTcgMTAwNjQ0Ci0tLSBhL1dlYktpdC93aW5jZS9X ZWJDb3JlU3VwcG9ydC9GcmFtZU5ldHdvcmtpbmdDb250ZXh0V2luQ0UuY3BwCisrKyBiL1dlYktp dC93aW5jZS9XZWJDb3JlU3VwcG9ydC9GcmFtZU5ldHdvcmtpbmdDb250ZXh0V2luQ0UuY3BwCkBA IC0yNSw2ICsyNSw5IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiRnJhbWVOZXR3 b3JraW5nQ29udGV4dFdpbkNFLmgiCiAKKyNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5oIgorI2lu Y2x1ZGUgIlJlc291cmNlRXJyb3IuaCIKKwogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKIG5h bWVzcGFjZSBXZWJLaXQgewpAQCAtNDUsNCArNDgsMTAgQEAgU3RyaW5nIEZyYW1lTmV0d29ya2lu Z0NvbnRleHRXaW5DRTo6cmVmZXJyZXIoKSBjb25zdAogICAgIHJldHVybiBmcmFtZSgpLT5sb2Fk ZXIoKS0+cmVmZXJyZXIoKTsKIH0KIAorV2ViQ29yZTo6UmVzb3VyY2VFcnJvciBGcmFtZU5ldHdv cmtpbmdDb250ZXh0V2luQ0U6OmJsb2NrZWRFcnJvcihjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJl cXVlc3QmKSBjb25zdAoreworICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgcmV0dXJuIFdlYkNv cmU6OlJlc291cmNlRXJyb3IoKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYgLS1n aXQgYS9XZWJLaXQvd2luY2UvV2ViQ29yZVN1cHBvcnQvRnJhbWVOZXR3b3JraW5nQ29udGV4dFdp bkNFLmggYi9XZWJLaXQvd2luY2UvV2ViQ29yZVN1cHBvcnQvRnJhbWVOZXR3b3JraW5nQ29udGV4 dFdpbkNFLmgKaW5kZXggYTgyNmEzNy4uNDM2YWZmNyAxMDA2NDQKLS0tIGEvV2ViS2l0L3dpbmNl L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTmV0d29ya2luZ0NvbnRleHRXaW5DRS5oCisrKyBiL1dlYktp dC93aW5jZS9XZWJDb3JlU3VwcG9ydC9GcmFtZU5ldHdvcmtpbmdDb250ZXh0V2luQ0UuaApAQCAt MzgsNiArMzgsNyBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIFdURjo6U3RyaW5nIHVzZXJBZ2Vu dCgpIGNvbnN0OwogICAgIHZpcnR1YWwgV1RGOjpTdHJpbmcgcmVmZXJyZXIoKSBjb25zdDsKKyAg ICB2aXJ0dWFsIFdlYkNvcmU6OlJlc291cmNlRXJyb3IgYmxvY2tlZEVycm9yKGNvbnN0IFdlYkNv cmU6OlJlc291cmNlUmVxdWVzdCYpIGNvbnN0OwogCiBwcml2YXRlOgogICAgIEZyYW1lTmV0d29y a2luZ0NvbnRleHRXaW5DRShXZWJDb3JlOjpGcmFtZSogZnJhbWUsIGNvbnN0IFdURjo6U3RyaW5n JiB1c2VyQWdlbnQpOwo=