45677 2010-09-13 09:14:23 -0700 [WebView canMarkAllTextMatches] can crash if called after [WebView close] 2010-09-13 09:33:47 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 sullivan sullivan oldest_to_newest 278240 0 sullivan 2010-09-13 09:14:23 -0700 This is in Radar as <rdar://problem/8404890>. [WebView canMarkAllTextMatches] calls through to WebCore frame-traversal code. This can crash if the webView has already been closed. This is the same basic problem as in bug 45175, but I missed this entry point when fixing that bug. 278246 1 67415 sullivan 2010-09-13 09:24:01 -0700 Created attachment 67415 One more early bail-out to complete the work that was begun in 45175. 278248 2 67415 aroben 2010-09-13 09:28:24 -0700 Comment on attachment 67415 One more early bail-out to complete the work that was begun in 45175. View in context: https://bugs.webkit.org/attachment.cgi?id=67415&action=prettypatch r=me 278250 3 sullivan 2010-09-13 09:33:47 -0700 Fixed in r67393. 67415 2010-09-13 09:24:01 -0700 2010-09-13 09:28:24 -0700 One more early bail-out to complete the work that was begun in 45175. canMarkAllTextMatches_patch.txt text/plain 1238 sullivan SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA2NzM5MCkKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDktMTMgIEpvaG4gU3VsbGl2YW4gIDxzdWxs aXZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1Njc3Cisg ICAgICAgIFtXZWJWaWV3IGNhbk1hcmtBbGxUZXh0TWF0Y2hlc10gY2FuIGNyYXNoIGlmIGNhbGxl ZCBhZnRlciBbV2ViVmlldyBjbG9zZV0KKyAgICAgICAgCisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS84NDA0ODkwPgorCisgICAgICAgICogV2ViVmlldy9XZWJWaWV3Lm1tOgorICAgICAgICAoLVtX ZWJWaWV3IGNhbk1hcmtBbGxUZXh0TWF0Y2hlc10pOgorICAgICAgICBSZXR1cm4gTk8gaW1tZWRp YXRlbHkgaWYgdGhlIHdlYnZpZXcgaGFzIGFscmVhZHkgYmVlbiBjbG9zZWQuIFRoaXMgd2FzIGFu IG92ZXJsb29rZWQKKyAgICAgICAgY2FzZSBmcm9tIHRoZSBmaXggZm9yIDQ1MTc1LgorCiAyMDEw LTA5LTEwICBNT1JJVEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IFRvbnkgQ2hhbmcuCkluZGV4OiBXZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5t bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQkocmV2aXNpb24g NjczNTQpCisrKyBXZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQkod29ya2luZyBjb3B5KQpA QCAtNDM5OSw2ICs0Mzk5LDkgQEAgLSAoTlNBcHBsZUV2ZW50RGVzY3JpcHRvciAqKWFlRGVzY0J5 RXZhbAogCiAtIChCT09MKWNhbk1hcmtBbGxUZXh0TWF0Y2hlcwogeworICAgIGlmIChfcHJpdmF0 ZS0+Y2xvc2VkKQorICAgICAgICByZXR1cm4gTk87CisKICAgICBXZWJGcmFtZSAqZnJhbWUgPSBb c2VsZiBtYWluRnJhbWVdOwogICAgIGRvIHsKICAgICAgICAgaWQgPFdlYkRvY3VtZW50Vmlldz4g dmlldyA9IFtbZnJhbWUgZnJhbWVWaWV3XSBkb2N1bWVudFZpZXddOwo=