45673 2010-09-13 07:51:45 -0700 Regression r65596 - Stack not 8 byte aligned 2010-09-21 04:59:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 dave+webkit webkit-unassigned barraclough commit-queue eric ggaren loki staikos webkit.review.bot oldest_to_newest 278209 0 dave+webkit 2010-09-13 07:51:45 -0700 r65596 adjusted ENABLE_PROFILER_REFERENCE_OFFSET so that it was no longer divisible by 8. ENABLE_PROFILER_REFERENCE_OFFSET is used to adjust the stack pointer in the cti methods and 65596 will cause the stack pointer to no longer be 8 byte aligned. According to the ABI 8 byte stack alignment should be preserved. 278219 1 67411 dave+webkit 2010-09-13 08:12:14 -0700 Created attachment 67411 Ensure ENABLE_PROFILER_REFERENCE_OFFSET is divisible by 8 This change adjusts the padding in the struct. In r65596 the padding that was there for JSVALUE32_64 was made useless because the object would be 8 byte aligned already so it can be removed. The additional padding that was essentially used for making sure the enabledProfilerReference offset was 8 byte aligned for JSVALUE32 was moved ahead so that we remove this padding for JSVALUE32_64 and have the correct field alignments for the rest. One benefit of this change (aside from fixing the bug) is that it reduces the JITStackFrame by 12 bytes by removing useless padding. 278220 2 webkit.review.bot 2010-09-13 08:15:17 -0700 Attachment 67411 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/jit/JITStubs.h:151: One space before end of line comments [whitespace/comments] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 278228 3 67414 dave+webkit 2010-09-13 08:29:59 -0700 Created attachment 67414 Fix style of previous patch - Ensure ENABLE_PROFILER_REFERENCE_OFFSET is divisible by 8 278729 4 barraclough 2010-09-13 22:34:02 -0700 Looks fine, but please allow me to test this patch on Darwin before landing. Will do so tomorrow, and review then. 278774 5 loki 2010-09-14 01:55:56 -0700 Works fine here. Thanks for the fix! 278855 6 dave+webkit 2010-09-14 06:29:30 -0700 (In reply to comment #5) > Works fine here. Thanks for the fix! So who can give me a r+ and a commit-queue+? 278967 7 loki 2010-09-14 09:28:17 -0700 > So who can give me a r+ and a commit-queue+? Please wait for Gavin to test your patch on Darwin! 279415 8 eric 2010-09-14 23:52:17 -0700 The commit-queue will "test" (run the layout tests and javascriptcore tests) on Darwin of course. :) Depends on what you need to test. 280454 9 67414 barraclough 2010-09-16 16:58:09 -0700 Comment on attachment 67414 Fix style of previous patch - Ensure ENABLE_PROFILER_REFERENCE_OFFSET is divisible by 8 Sorry for holding this up. My main dev machine has melted itself in a pretty catastrophic way today & will be unable to test for at least another day. I don't think it would be reasonable for me to delay you any further so I'll get out of the way & r+. If this does raise any issues we can sort this out afterwards. 280457 10 dave+webkit 2010-09-16 17:04:59 -0700 (In reply to comment #9) > (From update of attachment 67414 [details]) > Sorry for holding this up. My main dev machine has melted itself in a pretty catastrophic way today & will be unable to test for at least another day. I don't think it would be reasonable for me to delay you any further so I'll get out of the way & r+. > If this does raise any issues we can sort this out afterwards. I don't think I attached a changelog so it should probably be r- until I do that. 280474 11 67414 barraclough 2010-09-16 17:39:48 -0700 Comment on attachment 67414 Fix style of previous patch - Ensure ENABLE_PROFILER_REFERENCE_OFFSET is divisible by 8 Ooops, good point. :-) 281638 12 68108 dave+webkit 2010-09-20 10:23:39 -0700 Created attachment 68108 Same patch as 67414 but with prepare-ChangeLog run 282168 13 68108 ossy 2010-09-21 03:13:44 -0700 Comment on attachment 68108 Same patch as 67414 but with prepare-ChangeLog run This patch already contains the previously missing changelog, and doesn't make any other changes. 282219 14 68108 commit-queue 2010-09-21 04:59:46 -0700 Comment on attachment 68108 Same patch as 67414 but with prepare-ChangeLog run Clearing flags on attachment: 68108 Committed r67943: <http://trac.webkit.org/changeset/67943> 282220 15 commit-queue 2010-09-21 04:59:55 -0700 All reviewed patches have been landed. Closing bug. 67411 2010-09-13 08:12:14 -0700 2010-09-13 08:29:59 -0700 Ensure ENABLE_PROFILER_REFERENCE_OFFSET is divisible by 8 45673.txt text/plain 4349 dave+webkit Y29tbWl0IDZiOGI3ZjAwMTY0YWIzNjEwOTY4ZDM2Y2RhYzlhOTY4NWY4NGZlMmIKQXV0aG9yOiBE YXZlIFRhcHVza2EgPGR0YXB1c2thQHJpbS5jb20+CkRhdGU6ICAgRnJpIFNlcCAxMCAxNzoxNDoy NSAyMDEwIC0wNDAwCgogICAgMjAxMC0wOS0xMCAgRGF2ZSBUYXB1c2thICA8ZHRhcHVza2FAcmlt LmNvbT4KICAgIAogICAgICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KICAgIAog ICAgICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU2NzMK ICAgIAogICAgICAgICAgICByNjU1OTYgY2F1c2VkIEVOQUJMRV9QUk9GSUxFUl9SRUZFUkVOQ0Vf T0ZGU0VUIHRvIG5vdCBiZQogICAgICAgICAgICA4IGJ5dGUgYWxpZ25lZC4gQSBub24gOCBieXRl IGRpdmlzaWJsZSB2YWx1ZSBmb3IgdGhpcyB3aWxsCiAgICAgICAgICAgIGNhdXNlIHRoZSBzcCB0 byBiZWNvbWUgbm9uIDggYnl0ZSBhbGlnbmVkLgogICAgCiAgICAgICAgICAgIFZlcmlmeSBhbmQg Y29ycmVjdCBvZmZzZXQgdmFsdWVzIHRoYXQgcjY1NTk2IGVmZmVjdGVkIHRoYXQKICAgICAgICAg ICAgd2VyZW4ndCB1cGRhdGVkLgogICAgCiAgICAgICAgICAgICogSmF2YVNjcmlwdENvcmUvaml0 L0pJVFN0dWJzLmNwcDoKICAgICAgICAgICAgKiBKYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMu aDoKCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuY3BwIGIvSmF2YVNj cmlwdENvcmUvaml0L0pJVFN0dWJzLmNwcAppbmRleCBkNzE3ZWI3Li41NDQzYjg2IDEwMDY0NAot LS0gYS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuY3BwCisrKyBiL0phdmFTY3JpcHRDb3Jl L2ppdC9KSVRTdHVicy5jcHAKQEAgLTEsNiArMSw3IEBACiAvKgogICogQ29weXJpZ2h0IChDKSAy MDA4LCAyMDA5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqIENvcHlyaWdodCAo QykgMjAwOCBDYW1lcm9uIFp3YXJpY2ggPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisgKiBDb3B5 cmlnaHQgKEMpIFJlc2VhcmNoIEluIE1vdGlvbiBMaW1pdGVkIDIwMTAuIEFsbCByaWdodHMgcmVz ZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFy eSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQg cHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTIyOSwxNSArMjMwLDE1 IEBAIFNZTUJPTF9TVFJJTkcoY3RpT3BUaHJvd05vdENhdWdodCkgIjoiICJcbiIKIAogI2VsaWYg KENPTVBJTEVSKEdDQykgfHwgQ09NUElMRVIoUlZDVCkpICYmIENQVShBUk1fVEhVTUIyKQogCi0j ZGVmaW5lIFRIVU5LX1JFVFVSTl9BRERSRVNTX09GRlNFVCAgICAgIDB4NDAKLSNkZWZpbmUgUFJF U0VSVkVEX1JFVFVSTl9BRERSRVNTX09GRlNFVCAgMHg0NAotI2RlZmluZSBQUkVTRVJWRURfUjRf T0ZGU0VUICAgICAgICAgICAgICAweDQ4Ci0jZGVmaW5lIFBSRVNFUlZFRF9SNV9PRkZTRVQgICAg ICAgICAgICAgIDB4NEMKLSNkZWZpbmUgUFJFU0VSVkVEX1I2X09GRlNFVCAgICAgICAgICAgICAg MHg1MAotI2RlZmluZSBSRUdJU1RFUl9GSUxFX09GRlNFVCAgICAgICAgICAgICAweDU0Ci0jZGVm aW5lIENBTExGUkFNRV9PRkZTRVQgICAgICAgICAgICAgICAgIDB4NTgKLSNkZWZpbmUgRVhDRVBU SU9OX09GRlNFVCAgICAgICAgICAgICAgICAgMHg1QwotI2RlZmluZSBFTkFCTEVfUFJPRklMRVJf UkVGRVJFTkNFX09GRlNFVCAweDY0CisjZGVmaW5lIFRIVU5LX1JFVFVSTl9BRERSRVNTX09GRlNF VCAgICAgIDB4MzgKKyNkZWZpbmUgUFJFU0VSVkVEX1JFVFVSTl9BRERSRVNTX09GRlNFVCAgMHgz QworI2RlZmluZSBQUkVTRVJWRURfUjRfT0ZGU0VUICAgICAgICAgICAgICAweDQwCisjZGVmaW5l IFBSRVNFUlZFRF9SNV9PRkZTRVQgICAgICAgICAgICAgIDB4NDQKKyNkZWZpbmUgUFJFU0VSVkVE X1I2X09GRlNFVCAgICAgICAgICAgICAgMHg0OAorI2RlZmluZSBSRUdJU1RFUl9GSUxFX09GRlNF VCAgICAgICAgICAgICAweDRDCisjZGVmaW5lIENBTExGUkFNRV9PRkZTRVQgICAgICAgICAgICAg ICAgIDB4NTAKKyNkZWZpbmUgRVhDRVBUSU9OX09GRlNFVCAgICAgICAgICAgICAgICAgMHg1NAor I2RlZmluZSBFTkFCTEVfUFJPRklMRVJfUkVGRVJFTkNFX09GRlNFVCAweDU4CiAKICNlbGlmIChD T01QSUxFUihHQ0MpIHx8IENPTVBJTEVSKFJWQ1QpKSAmJiBDUFUoQVJNX1RSQURJVElPTkFMKQog CkBAIC00NDEsMTQgKzQ0MiwxNCBAQCBTWU1CT0xfU1RSSU5HKGN0aU9wVGhyb3dOb3RDYXVnaHQp ICI6IiAiXG4iCiAKICNlbGlmIENPTVBJTEVSKEdDQykgJiYgQ1BVKEFSTV9USFVNQjIpCiAKLSNk ZWZpbmUgVEhVTktfUkVUVVJOX0FERFJFU1NfT0ZGU0VUICAgICAgMHgxQwotI2RlZmluZSBQUkVT RVJWRURfUkVUVVJOX0FERFJFU1NfT0ZGU0VUICAweDIwCi0jZGVmaW5lIFBSRVNFUlZFRF9SNF9P RkZTRVQgICAgICAgICAgICAgIDB4MjQKLSNkZWZpbmUgUFJFU0VSVkVEX1I1X09GRlNFVCAgICAg ICAgICAgICAgMHgyOAotI2RlZmluZSBQUkVTRVJWRURfUjZfT0ZGU0VUICAgICAgICAgICAgICAw eDJDCi0jZGVmaW5lIFJFR0lTVEVSX0ZJTEVfT0ZGU0VUICAgICAgICAgICAgIDB4MzAKLSNkZWZp bmUgQ0FMTEZSQU1FX09GRlNFVCAgICAgICAgICAgICAgICAgMHgzNAotI2RlZmluZSBFWENFUFRJ T05fT0ZGU0VUICAgICAgICAgICAgICAgICAweDM4CisjZGVmaW5lIFRIVU5LX1JFVFVSTl9BRERS RVNTX09GRlNFVCAgICAgIDB4MjAKKyNkZWZpbmUgUFJFU0VSVkVEX1JFVFVSTl9BRERSRVNTX09G RlNFVCAgMHgyNAorI2RlZmluZSBQUkVTRVJWRURfUjRfT0ZGU0VUICAgICAgICAgICAgICAweDI4 CisjZGVmaW5lIFBSRVNFUlZFRF9SNV9PRkZTRVQgICAgICAgICAgICAgIDB4MkMKKyNkZWZpbmUg UFJFU0VSVkVEX1I2X09GRlNFVCAgICAgICAgICAgICAgMHgzMAorI2RlZmluZSBSRUdJU1RFUl9G SUxFX09GRlNFVCAgICAgICAgICAgICAweDM0CisjZGVmaW5lIENBTExGUkFNRV9PRkZTRVQgICAg ICAgICAgICAgICAgIDB4MzgKKyNkZWZpbmUgRVhDRVBUSU9OX09GRlNFVCAgICAgICAgICAgICAg ICAgMHgzQwogI2RlZmluZSBFTkFCTEVfUFJPRklMRVJfUkVGRVJFTkNFX09GRlNFVCAweDQwCiAK ICNlbGlmIChDT01QSUxFUihHQ0MpIHx8IENPTVBJTEVSKFJWQ1QpKSAmJiBDUFUoQVJNX1RSQURJ VElPTkFMKQpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzLmggYi9KYXZh U2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuaAppbmRleCBlZGU1YWY5Li4yNzY1NjRkIDEwMDY0NAot LS0gYS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuaAorKysgYi9KYXZhU2NyaXB0Q29yZS9q aXQvSklUU3R1YnMuaApAQCAtMSw1ICsxLDYgQEAKIC8qCiAgKiBDb3B5cmlnaHQgKEMpIDIwMDgg QXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSBSZXNlYXJj aCBJbiBNb3Rpb24gTGltaXRlZCAyMDEwLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJl ZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Ig d2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhl IGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0xNDYsOCArMTQ3LDggQEAgbmFtZXNwYWNlIEpTQyB7 CiAgICAgc3RydWN0IEpJVFN0YWNrRnJhbWUgewogICAgICAgICBKSVRTdHViQXJnIHJlc2VydmVk OyAvLyBVbnVzZWQKICAgICAgICAgSklUU3R1YkFyZyBhcmdzWzZdOwotI2lmIFVTRShKU1ZBTFVF MzJfNjQpCi0gICAgICAgIHZvaWQqIHBhZGRpbmdbMl07IC8vIE1haW50YWluIDE2LWJ5dGUgc3Rh Y2sgYWxpZ25tZW50LgorI2lmICFVU0UoSlNWQUxVRTMyXzY0KQorICAgICAgICB2b2lkKiBwYWRk aW5nOyAgICAgICAvLyBNYWludGFpbiAxNi1ieXRlIHN0YWNrIGFsaWdubWVudC4KICNlbmRpZgog CiAgICAgICAgIFJldHVybkFkZHJlc3NQdHIgdGh1bmtSZXR1cm5BZGRyZXNzOwpAQCAtMTYyLDgg KzE2Myw2IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICBDYWxsRnJhbWUqIGNhbGxGcmFtZTsK ICAgICAgICAgSlNWYWx1ZSogZXhjZXB0aW9uOwogCi0gICAgICAgIHZvaWQqIHBhZGRpbmcyOwot CiAgICAgICAgIC8vIFRoZXNlIGFyZ3VtZW50cyBwYXNzZWQgb24gdGhlIHN0YWNrLgogICAgICAg ICBQcm9maWxlcioqIGVuYWJsZWRQcm9maWxlclJlZmVyZW5jZTsKICAgICAgICAgSlNHbG9iYWxE YXRhKiBnbG9iYWxEYXRhOwo= 67414 2010-09-13 08:29:59 -0700 2010-09-20 10:23:39 -0700 Fix style of previous patch - Ensure ENABLE_PROFILER_REFERENCE_OFFSET is divisible by 8 45673.txt text/plain 4343 dave+webkit Y29tbWl0IGMxNDE2MTdlYjBjMzdkYmJlNDg1YTNhOTk0ODFiYzA5ZWI4NTYwMTIKQXV0aG9yOiBE YXZlIFRhcHVza2EgPGR0YXB1c2thQHJpbS5jb20+CkRhdGU6ICAgRnJpIFNlcCAxMCAxNzoxNDoy NSAyMDEwIC0wNDAwCgogICAgMjAxMC0wOS0xMCAgRGF2ZSBUYXB1c2thICA8ZHRhcHVza2FAcmlt LmNvbT4KICAgIAogICAgICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KICAgIAog ICAgICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU2NzMK ICAgIAogICAgICAgICAgICByNjU1OTYgY2F1c2VkIEVOQUJMRV9QUk9GSUxFUl9SRUZFUkVOQ0Vf T0ZGU0VUIHRvIG5vdCBiZQogICAgICAgICAgICA4IGJ5dGUgYWxpZ25lZC4gQSBub24gOCBieXRl IGRpdmlzaWJsZSB2YWx1ZSBmb3IgdGhpcyB3aWxsCiAgICAgICAgICAgIGNhdXNlIHRoZSBzcCB0 byBiZWNvbWUgbm9uIDggYnl0ZSBhbGlnbmVkLgogICAgCiAgICAgICAgICAgIFZlcmlmeSBhbmQg Y29ycmVjdCBvZmZzZXQgdmFsdWVzIHRoYXQgcjY1NTk2IGVmZmVjdGVkIHRoYXQKICAgICAgICAg ICAgd2VyZW4ndCB1cGRhdGVkLgogICAgCiAgICAgICAgICAgICogSmF2YVNjcmlwdENvcmUvaml0 L0pJVFN0dWJzLmNwcDoKICAgICAgICAgICAgKiBKYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMu aDoKCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuY3BwIGIvSmF2YVNj cmlwdENvcmUvaml0L0pJVFN0dWJzLmNwcAppbmRleCBkNzE3ZWI3Li41NDQzYjg2IDEwMDY0NAot LS0gYS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuY3BwCisrKyBiL0phdmFTY3JpcHRDb3Jl L2ppdC9KSVRTdHVicy5jcHAKQEAgLTEsNiArMSw3IEBACiAvKgogICogQ29weXJpZ2h0IChDKSAy MDA4LCAyMDA5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqIENvcHlyaWdodCAo QykgMjAwOCBDYW1lcm9uIFp3YXJpY2ggPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisgKiBDb3B5 cmlnaHQgKEMpIFJlc2VhcmNoIEluIE1vdGlvbiBMaW1pdGVkIDIwMTAuIEFsbCByaWdodHMgcmVz ZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFy eSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQg cHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTIyOSwxNSArMjMwLDE1 IEBAIFNZTUJPTF9TVFJJTkcoY3RpT3BUaHJvd05vdENhdWdodCkgIjoiICJcbiIKIAogI2VsaWYg KENPTVBJTEVSKEdDQykgfHwgQ09NUElMRVIoUlZDVCkpICYmIENQVShBUk1fVEhVTUIyKQogCi0j ZGVmaW5lIFRIVU5LX1JFVFVSTl9BRERSRVNTX09GRlNFVCAgICAgIDB4NDAKLSNkZWZpbmUgUFJF U0VSVkVEX1JFVFVSTl9BRERSRVNTX09GRlNFVCAgMHg0NAotI2RlZmluZSBQUkVTRVJWRURfUjRf T0ZGU0VUICAgICAgICAgICAgICAweDQ4Ci0jZGVmaW5lIFBSRVNFUlZFRF9SNV9PRkZTRVQgICAg ICAgICAgICAgIDB4NEMKLSNkZWZpbmUgUFJFU0VSVkVEX1I2X09GRlNFVCAgICAgICAgICAgICAg MHg1MAotI2RlZmluZSBSRUdJU1RFUl9GSUxFX09GRlNFVCAgICAgICAgICAgICAweDU0Ci0jZGVm aW5lIENBTExGUkFNRV9PRkZTRVQgICAgICAgICAgICAgICAgIDB4NTgKLSNkZWZpbmUgRVhDRVBU SU9OX09GRlNFVCAgICAgICAgICAgICAgICAgMHg1QwotI2RlZmluZSBFTkFCTEVfUFJPRklMRVJf UkVGRVJFTkNFX09GRlNFVCAweDY0CisjZGVmaW5lIFRIVU5LX1JFVFVSTl9BRERSRVNTX09GRlNF VCAgICAgIDB4MzgKKyNkZWZpbmUgUFJFU0VSVkVEX1JFVFVSTl9BRERSRVNTX09GRlNFVCAgMHgz QworI2RlZmluZSBQUkVTRVJWRURfUjRfT0ZGU0VUICAgICAgICAgICAgICAweDQwCisjZGVmaW5l IFBSRVNFUlZFRF9SNV9PRkZTRVQgICAgICAgICAgICAgIDB4NDQKKyNkZWZpbmUgUFJFU0VSVkVE X1I2X09GRlNFVCAgICAgICAgICAgICAgMHg0OAorI2RlZmluZSBSRUdJU1RFUl9GSUxFX09GRlNF VCAgICAgICAgICAgICAweDRDCisjZGVmaW5lIENBTExGUkFNRV9PRkZTRVQgICAgICAgICAgICAg ICAgIDB4NTAKKyNkZWZpbmUgRVhDRVBUSU9OX09GRlNFVCAgICAgICAgICAgICAgICAgMHg1NAor I2RlZmluZSBFTkFCTEVfUFJPRklMRVJfUkVGRVJFTkNFX09GRlNFVCAweDU4CiAKICNlbGlmIChD T01QSUxFUihHQ0MpIHx8IENPTVBJTEVSKFJWQ1QpKSAmJiBDUFUoQVJNX1RSQURJVElPTkFMKQog CkBAIC00NDEsMTQgKzQ0MiwxNCBAQCBTWU1CT0xfU1RSSU5HKGN0aU9wVGhyb3dOb3RDYXVnaHQp ICI6IiAiXG4iCiAKICNlbGlmIENPTVBJTEVSKEdDQykgJiYgQ1BVKEFSTV9USFVNQjIpCiAKLSNk ZWZpbmUgVEhVTktfUkVUVVJOX0FERFJFU1NfT0ZGU0VUICAgICAgMHgxQwotI2RlZmluZSBQUkVT RVJWRURfUkVUVVJOX0FERFJFU1NfT0ZGU0VUICAweDIwCi0jZGVmaW5lIFBSRVNFUlZFRF9SNF9P RkZTRVQgICAgICAgICAgICAgIDB4MjQKLSNkZWZpbmUgUFJFU0VSVkVEX1I1X09GRlNFVCAgICAg ICAgICAgICAgMHgyOAotI2RlZmluZSBQUkVTRVJWRURfUjZfT0ZGU0VUICAgICAgICAgICAgICAw eDJDCi0jZGVmaW5lIFJFR0lTVEVSX0ZJTEVfT0ZGU0VUICAgICAgICAgICAgIDB4MzAKLSNkZWZp bmUgQ0FMTEZSQU1FX09GRlNFVCAgICAgICAgICAgICAgICAgMHgzNAotI2RlZmluZSBFWENFUFRJ T05fT0ZGU0VUICAgICAgICAgICAgICAgICAweDM4CisjZGVmaW5lIFRIVU5LX1JFVFVSTl9BRERS RVNTX09GRlNFVCAgICAgIDB4MjAKKyNkZWZpbmUgUFJFU0VSVkVEX1JFVFVSTl9BRERSRVNTX09G RlNFVCAgMHgyNAorI2RlZmluZSBQUkVTRVJWRURfUjRfT0ZGU0VUICAgICAgICAgICAgICAweDI4 CisjZGVmaW5lIFBSRVNFUlZFRF9SNV9PRkZTRVQgICAgICAgICAgICAgIDB4MkMKKyNkZWZpbmUg UFJFU0VSVkVEX1I2X09GRlNFVCAgICAgICAgICAgICAgMHgzMAorI2RlZmluZSBSRUdJU1RFUl9G SUxFX09GRlNFVCAgICAgICAgICAgICAweDM0CisjZGVmaW5lIENBTExGUkFNRV9PRkZTRVQgICAg ICAgICAgICAgICAgIDB4MzgKKyNkZWZpbmUgRVhDRVBUSU9OX09GRlNFVCAgICAgICAgICAgICAg ICAgMHgzQwogI2RlZmluZSBFTkFCTEVfUFJPRklMRVJfUkVGRVJFTkNFX09GRlNFVCAweDQwCiAK ICNlbGlmIChDT01QSUxFUihHQ0MpIHx8IENPTVBJTEVSKFJWQ1QpKSAmJiBDUFUoQVJNX1RSQURJ VElPTkFMKQpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzLmggYi9KYXZh U2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuaAppbmRleCBlZGU1YWY5Li5lYzQ5NTY2IDEwMDY0NAot LS0gYS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuaAorKysgYi9KYXZhU2NyaXB0Q29yZS9q aXQvSklUU3R1YnMuaApAQCAtMSw1ICsxLDYgQEAKIC8qCiAgKiBDb3B5cmlnaHQgKEMpIDIwMDgg QXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSBSZXNlYXJj aCBJbiBNb3Rpb24gTGltaXRlZCAyMDEwLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJl ZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Ig d2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhl IGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0xNDYsOCArMTQ3LDggQEAgbmFtZXNwYWNlIEpTQyB7 CiAgICAgc3RydWN0IEpJVFN0YWNrRnJhbWUgewogICAgICAgICBKSVRTdHViQXJnIHJlc2VydmVk OyAvLyBVbnVzZWQKICAgICAgICAgSklUU3R1YkFyZyBhcmdzWzZdOwotI2lmIFVTRShKU1ZBTFVF MzJfNjQpCi0gICAgICAgIHZvaWQqIHBhZGRpbmdbMl07IC8vIE1haW50YWluIDE2LWJ5dGUgc3Rh Y2sgYWxpZ25tZW50LgorI2lmICFVU0UoSlNWQUxVRTMyXzY0KQorICAgICAgICB2b2lkKiBwYWRk aW5nOyAvLyBNYWludGFpbiAxNi1ieXRlIHN0YWNrIGFsaWdubWVudC4KICNlbmRpZgogCiAgICAg ICAgIFJldHVybkFkZHJlc3NQdHIgdGh1bmtSZXR1cm5BZGRyZXNzOwpAQCAtMTYyLDggKzE2Myw2 IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICBDYWxsRnJhbWUqIGNhbGxGcmFtZTsKICAgICAg ICAgSlNWYWx1ZSogZXhjZXB0aW9uOwogCi0gICAgICAgIHZvaWQqIHBhZGRpbmcyOwotCiAgICAg ICAgIC8vIFRoZXNlIGFyZ3VtZW50cyBwYXNzZWQgb24gdGhlIHN0YWNrLgogICAgICAgICBQcm9m aWxlcioqIGVuYWJsZWRQcm9maWxlclJlZmVyZW5jZTsKICAgICAgICAgSlNHbG9iYWxEYXRhKiBn bG9iYWxEYXRhOwo= 68108 2010-09-20 10:23:39 -0700 2010-09-21 04:59:46 -0700 Same patch as 67414 but with prepare-ChangeLog run 45673.txt text/plain 5039 dave+webkit Y29tbWl0IDk0NjQ1NDA1M2MyNDAxMDA5ODE3YzI5YTQ1MTZhNGQxY2I4ZjM3Y2MKQXV0aG9yOiBE YXZlIFRhcHVza2EgPGR0YXB1c2thQHJpbS5jb20+CkRhdGU6ICAgTW9uIFNlcCAyMCAxMzoyMDoy MSAyMDEwIC0wNDAwCgogICAgMjAxMC0wOS0yMCAgRGF2ZSBUYXB1c2thICA8ZHRhcHVza2FAcmlt LmNvbT4KICAgIAogICAgICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KICAgIAog ICAgICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU2NzMK ICAgIAogICAgICAgICAgICByNjU1OTYgY2F1c2VkIEVOQUJMRV9QUk9GSUxFUl9SRUZFUkVOQ0Vf T0ZGU0VUIHRvIG5vdCBiZQogICAgICAgICAgICA4IGJ5dGUgYWxpZ25lZC4gQSBub24gOCBieXRl IGRpdmlzaWJsZSB2YWx1ZSBmb3IgdGhpcyB3aWxsCiAgICAgICAgICAgIGNhdXNlIHRoZSBzcCB0 byBiZWNvbWUgbm9uIDggYnl0ZSBhbGlnbmVkLgogICAgCiAgICAgICAgICAgIFZlcmlmeSBhbmQg Y29ycmVjdCBvZmZzZXQgdmFsdWVzIHRoYXQgcjY1NTk2IGVmZmVjdGVkIHRoYXQKICAgICAgICAg ICAgd2VyZW4ndCB1cGRhdGVkLgogICAgCiAgICAgICAgICAgICogaml0L0pJVFN0dWJzLmNwcDoK ICAgICAgICAgICAgKiBqaXQvSklUU3R1YnMuaDoKCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggYzMyNGY0YS4uOGRk Mjg5MyAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL0phdmFTY3Jp cHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEwLTA5LTIwICBEYXZlIFRhcHVz a2EgIDxkdGFwdXNrYUByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 NTY3MworCisgICAgICAgIHI2NTU5NiBjYXVzZWQgRU5BQkxFX1BST0ZJTEVSX1JFRkVSRU5DRV9P RkZTRVQgdG8gbm90IGJlCisgICAgICAgIDggYnl0ZSBhbGlnbmVkLiBBIG5vbiA4IGJ5dGUgZGl2 aXNpYmxlIHZhbHVlIGZvciB0aGlzIHdpbGwKKyAgICAgICAgY2F1c2UgdGhlIHNwIHRvIGJlY29t ZSBub24gOCBieXRlIGFsaWduZWQuCisKKyAgICAgICAgVmVyaWZ5IGFuZCBjb3JyZWN0IG9mZnNl dCB2YWx1ZXMgdGhhdCByNjU1OTYgZWZmZWN0ZWQgdGhhdAorICAgICAgICB3ZXJlbid0IHVwZGF0 ZWQuCisKKyAgICAgICAgKiBqaXQvSklUU3R1YnMuY3BwOgorICAgICAgICAqIGppdC9KSVRTdHVi cy5oOgorCiAyMDEwLTA5LTIwICBEYXZpZCBUYXB1c2thICA8ZHRhcHVza2FAcmltLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL0phdmFTY3Jp cHRDb3JlL2ppdC9KSVRTdHVicy5jcHAgYi9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuY3Bw CmluZGV4IGQ1ZTU1YjQuLmYxZWMwNzkgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL2ppdC9K SVRTdHVicy5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzLmNwcApAQCAtMSw2 ICsxLDcgQEAKIC8qCiAgKiBDb3B5cmlnaHQgKEMpIDIwMDgsIDIwMDkgQXBwbGUgSW5jLiBBbGwg cmlnaHRzIHJlc2VydmVkLgogICogQ29weXJpZ2h0IChDKSAyMDA4IENhbWVyb24gWndhcmljaCA8 Y3d6d2FyaWNoQHV3YXRlcmxvby5jYT4KKyAqIENvcHlyaWdodCAoQykgUmVzZWFyY2ggSW4gTW90 aW9uIExpbWl0ZWQgMjAxMC4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1 dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQK ICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dp bmcgY29uZGl0aW9ucwpAQCAtMjM0LDE1ICsyMzUsMTUgQEAgU1lNQk9MX1NUUklORyhjdGlPcFRo cm93Tm90Q2F1Z2h0KSAiOiIgIlxuIgogCiAjZWxpZiBDT01QSUxFUihHQ0MpICYmIENQVShBUk1f VEhVTUIyKQogCi0jZGVmaW5lIFRIVU5LX1JFVFVSTl9BRERSRVNTX09GRlNFVCAgICAgIDB4NDAK LSNkZWZpbmUgUFJFU0VSVkVEX1JFVFVSTl9BRERSRVNTX09GRlNFVCAgMHg0NAotI2RlZmluZSBQ UkVTRVJWRURfUjRfT0ZGU0VUICAgICAgICAgICAgICAweDQ4Ci0jZGVmaW5lIFBSRVNFUlZFRF9S NV9PRkZTRVQgICAgICAgICAgICAgIDB4NEMKLSNkZWZpbmUgUFJFU0VSVkVEX1I2X09GRlNFVCAg ICAgICAgICAgICAgMHg1MAotI2RlZmluZSBSRUdJU1RFUl9GSUxFX09GRlNFVCAgICAgICAgICAg ICAweDU0Ci0jZGVmaW5lIENBTExGUkFNRV9PRkZTRVQgICAgICAgICAgICAgICAgIDB4NTgKLSNk ZWZpbmUgRVhDRVBUSU9OX09GRlNFVCAgICAgICAgICAgICAgICAgMHg1QwotI2RlZmluZSBFTkFC TEVfUFJPRklMRVJfUkVGRVJFTkNFX09GRlNFVCAweDY0CisjZGVmaW5lIFRIVU5LX1JFVFVSTl9B RERSRVNTX09GRlNFVCAgICAgIDB4MzgKKyNkZWZpbmUgUFJFU0VSVkVEX1JFVFVSTl9BRERSRVNT X09GRlNFVCAgMHgzQworI2RlZmluZSBQUkVTRVJWRURfUjRfT0ZGU0VUICAgICAgICAgICAgICAw eDQwCisjZGVmaW5lIFBSRVNFUlZFRF9SNV9PRkZTRVQgICAgICAgICAgICAgIDB4NDQKKyNkZWZp bmUgUFJFU0VSVkVEX1I2X09GRlNFVCAgICAgICAgICAgICAgMHg0OAorI2RlZmluZSBSRUdJU1RF Ul9GSUxFX09GRlNFVCAgICAgICAgICAgICAweDRDCisjZGVmaW5lIENBTExGUkFNRV9PRkZTRVQg ICAgICAgICAgICAgICAgIDB4NTAKKyNkZWZpbmUgRVhDRVBUSU9OX09GRlNFVCAgICAgICAgICAg ICAgICAgMHg1NAorI2RlZmluZSBFTkFCTEVfUFJPRklMRVJfUkVGRVJFTkNFX09GRlNFVCAweDU4 CiAKICNlbGlmIChDT01QSUxFUihHQ0MpIHx8IENPTVBJTEVSKFJWQ1QpKSAmJiBDUFUoQVJNX1RS QURJVElPTkFMKQogCkBAIC00NjcsMTQgKzQ2OCwxNCBAQCBTWU1CT0xfU1RSSU5HKGN0aU9wVGhy b3dOb3RDYXVnaHQpICI6IiAiXG4iCiAKICNlbGlmIENPTVBJTEVSKEdDQykgJiYgQ1BVKEFSTV9U SFVNQjIpCiAKLSNkZWZpbmUgVEhVTktfUkVUVVJOX0FERFJFU1NfT0ZGU0VUICAgICAgMHgxQwot I2RlZmluZSBQUkVTRVJWRURfUkVUVVJOX0FERFJFU1NfT0ZGU0VUICAweDIwCi0jZGVmaW5lIFBS RVNFUlZFRF9SNF9PRkZTRVQgICAgICAgICAgICAgIDB4MjQKLSNkZWZpbmUgUFJFU0VSVkVEX1I1 X09GRlNFVCAgICAgICAgICAgICAgMHgyOAotI2RlZmluZSBQUkVTRVJWRURfUjZfT0ZGU0VUICAg ICAgICAgICAgICAweDJDCi0jZGVmaW5lIFJFR0lTVEVSX0ZJTEVfT0ZGU0VUICAgICAgICAgICAg IDB4MzAKLSNkZWZpbmUgQ0FMTEZSQU1FX09GRlNFVCAgICAgICAgICAgICAgICAgMHgzNAotI2Rl ZmluZSBFWENFUFRJT05fT0ZGU0VUICAgICAgICAgICAgICAgICAweDM4CisjZGVmaW5lIFRIVU5L X1JFVFVSTl9BRERSRVNTX09GRlNFVCAgICAgIDB4MjAKKyNkZWZpbmUgUFJFU0VSVkVEX1JFVFVS Tl9BRERSRVNTX09GRlNFVCAgMHgyNAorI2RlZmluZSBQUkVTRVJWRURfUjRfT0ZGU0VUICAgICAg ICAgICAgICAweDI4CisjZGVmaW5lIFBSRVNFUlZFRF9SNV9PRkZTRVQgICAgICAgICAgICAgIDB4 MkMKKyNkZWZpbmUgUFJFU0VSVkVEX1I2X09GRlNFVCAgICAgICAgICAgICAgMHgzMAorI2RlZmlu ZSBSRUdJU1RFUl9GSUxFX09GRlNFVCAgICAgICAgICAgICAweDM0CisjZGVmaW5lIENBTExGUkFN RV9PRkZTRVQgICAgICAgICAgICAgICAgIDB4MzgKKyNkZWZpbmUgRVhDRVBUSU9OX09GRlNFVCAg ICAgICAgICAgICAgICAgMHgzQwogI2RlZmluZSBFTkFCTEVfUFJPRklMRVJfUkVGRVJFTkNFX09G RlNFVCAweDQwCiAKICNlbGlmIChDT01QSUxFUihHQ0MpIHx8IENPTVBJTEVSKFJWQ1QpKSAmJiBD UFUoQVJNX1RSQURJVElPTkFMKQpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0 dWJzLmggYi9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuaAppbmRleCBkM2Q3YzUzLi4yYjIy ZTZkIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuaAorKysgYi9KYXZh U2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuaApAQCAtMSw1ICsxLDYgQEAKIC8qCiAgKiBDb3B5cmln aHQgKEMpIDIwMDggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0 IChDKSBSZXNlYXJjaCBJbiBNb3Rpb24gTGltaXRlZCAyMDEwLiBBbGwgcmlnaHRzIHJlc2VydmVk LgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9y bXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3Zp ZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0xNDYsOCArMTQ3LDggQEAgbmFt ZXNwYWNlIEpTQyB7CiAgICAgc3RydWN0IEpJVFN0YWNrRnJhbWUgewogICAgICAgICBKSVRTdHVi QXJnIHJlc2VydmVkOyAvLyBVbnVzZWQKICAgICAgICAgSklUU3R1YkFyZyBhcmdzWzZdOwotI2lm IFVTRShKU1ZBTFVFMzJfNjQpCi0gICAgICAgIHZvaWQqIHBhZGRpbmdbMl07IC8vIE1haW50YWlu IDE2LWJ5dGUgc3RhY2sgYWxpZ25tZW50LgorI2lmICFVU0UoSlNWQUxVRTMyXzY0KQorICAgICAg ICB2b2lkKiBwYWRkaW5nOyAvLyBNYWludGFpbiAxNi1ieXRlIHN0YWNrIGFsaWdubWVudC4KICNl bmRpZgogCiAgICAgICAgIFJldHVybkFkZHJlc3NQdHIgdGh1bmtSZXR1cm5BZGRyZXNzOwpAQCAt MTYyLDggKzE2Myw2IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICBDYWxsRnJhbWUqIGNhbGxG cmFtZTsKICAgICAgICAgSlNWYWx1ZSogZXhjZXB0aW9uOwogCi0gICAgICAgIHZvaWQqIHBhZGRp bmcyOwotCiAgICAgICAgIC8vIFRoZXNlIGFyZ3VtZW50cyBwYXNzZWQgb24gdGhlIHN0YWNrLgog ICAgICAgICBQcm9maWxlcioqIGVuYWJsZWRQcm9maWxlclJlZmVyZW5jZTsKICAgICAgICAgSlNH bG9iYWxEYXRhKiBnbG9iYWxEYXRhOwo=