45671 2010-09-13 07:33:51 -0700 Web Inspector: provide support for opening external navigation for links within certain elements 2010-09-14 08:36:23 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 caseq webkit-unassigned bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 278201 0 caseq 2010-09-13 07:33:51 -0700 Currently, Web Inspector always opens resource panel when a link is clicked. Some extensions may need to override this behavior for certain links (e.g. documentation etc). The proposed patch enables default handling for links that have target="_blank" and are found within containers that have "allow-external-navigation" style. 278203 1 67407 caseq 2010-09-13 07:42:32 -0700 Created attachment 67407 patch 278213 2 67407 pfeldman 2010-09-13 08:03:38 -0700 Comment on attachment 67407 patch I'd much rather leave a single if (anchor.target === "_blank") check and would manually create <a hrefs in extensions subsystem. Rationale: WebInspector.linkify is too involved with resources panel. 278222 3 67412 caseq 2010-09-13 08:20:20 -0700 Created attachment 67412 patch - removed "allow-external-navigation", let all links with target="_blank" use default handling - removed adding target="_blank" in WebInspector.linkifyURL() 278929 4 caseq 2010-09-14 08:36:23 -0700 Manually committed as r67454: http://trac.webkit.org/changeset/67454 67407 2010-09-13 07:42:32 -0700 2010-09-13 08:20:20 -0700 patch external-navigation.diff text/plain 3686 caseq ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzY3YmMyZS4uY2FkNTQ5NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wOS0xMyAgQW5kcmV5IEtvc3lh a292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IHByb3ZpZGUgc3VwcG9ydCBmb3Igb3Bl bmluZyBleHRlcm5hbCBuYXZpZ2F0aW9uIGZvciBsaW5rcyB3aXRoaW4gY2VydGFpbiBlbGVtZW50 cworICAgICAgICBVc2UgZGVmYXVsdCBoYW5kbGluZyBmb3IgY2xpY2tzIG9uIGxpbmtzIHRoYXQg aGF2ZSB0YXJnZXQ9Il9ibGFuayIgYW5kIGFyZSBmb3VuZCB3aXRoaW4gZWxlbWVudHMgdGhhdCBo YXZlICJhbGxvdy1leHRlcm5hbC1uYXZpZ2F0aW9uIiBjbGFzcy4KKyAgICAgICAgU2V0IGFsbG93 LWV4dGVybmFsLW5hdmlnYXRpb24gZm9yIGF1ZGl0IHJlc3VsdHMgdmlldyBhbmQgZXh0ZW5zaW9u IHBhbmVscy4KKyAgICAgICAgQWRkIG9wdGlvbiBmb3IgZXh0ZXJuYWwgbmF2aWdhdGlvbiB0byBV UkwgYXVkaXQgZm9ybWF0dGVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDU2NzEKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvQXVkaXRG b3JtYXR0ZXJzLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkF1ZGl0Rm9ybWF0dGVycy51cmwp OgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvQXVkaXRSZXN1bHRWaWV3LmpzOgorICAg ICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9uUGFuZWwuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuRXh0ZW5zaW9uUGFuZWwpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1l bmQvaW5zcGVjdG9yLmpzOgorCiAyMDEwLTA5LTEzICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNh bmNoZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24u CmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQXVkaXRGb3JtYXR0ZXJz LmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0F1ZGl0Rm9ybWF0dGVycy5qcwppbmRl eCBkZTI3N2FkLi43ZWYxNmRkIDEwMDc1NQotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvQXVkaXRGb3JtYXR0ZXJzLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9B dWRpdEZvcm1hdHRlcnMuanMKQEAgLTc5LDggKzc5LDExIEBAIFdlYkluc3BlY3Rvci5BdWRpdEZv cm1hdHRlcnMgPSB7CiAgICAgICAgIHJldHVybiBwYXJlbnQ7CiAgICAgfSwKIAotICAgIHVybDog ZnVuY3Rpb24odXJsLCBkaXNwbGF5VGV4dCkKKyAgICB1cmw6IGZ1bmN0aW9uKHVybCwgZGlzcGxh eVRleHQsIGFsbG93RXh0ZXJuYWxOYXZpZ2F0aW9uKQogICAgIHsKLSAgICAgICAgcmV0dXJuIFdl Ykluc3BlY3Rvci5saW5raWZ5VVJMQXNOb2RlKHVybCwgZGlzcGxheVRleHQgfHwgdXJsLCBudWxs LCAodXJsIGluIFdlYkluc3BlY3Rvci5yZXNvdXJjZVVSTE1hcCkpOworICAgICAgICB2YXIgbm9k ZSA9IFdlYkluc3BlY3Rvci5saW5raWZ5VVJMQXNOb2RlKHVybCwgZGlzcGxheVRleHQgfHwgdXJs LCBudWxsLCAodXJsIGluIFdlYkluc3BlY3Rvci5yZXNvdXJjZVVSTE1hcCkpOworICAgICAgICBp ZiAoYWxsb3dFeHRlcm5hbE5hdmlnYXRpb24pCisgICAgICAgICAgICBub2RlLnRhcmdldCA9ICJf YmxhbmsiOworICAgICAgICByZXR1cm4gbm9kZTsKICAgICB9CiB9OwpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0F1ZGl0UmVzdWx0Vmlldy5qcyBiL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9BdWRpdFJlc3VsdFZpZXcuanMKaW5kZXggMjYzNjQ2My4uYmExMTVm YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0F1ZGl0UmVzdWx0Vmll dy5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQXVkaXRSZXN1bHRWaWV3Lmpz CkBAIC0zMSw3ICszMSw3IEBACiBXZWJJbnNwZWN0b3IuQXVkaXRSZXN1bHRWaWV3ID0gZnVuY3Rp b24oY2F0ZWdvcnlSZXN1bHRzKQogewogICAgIFdlYkluc3BlY3Rvci5WaWV3LmNhbGwodGhpcyk7 Ci0gICAgdGhpcy5lbGVtZW50LmNsYXNzTmFtZSA9ICJhdWRpdC1yZXN1bHQtdmlldyI7CisgICAg dGhpcy5lbGVtZW50LmNsYXNzTmFtZSA9ICJhdWRpdC1yZXN1bHQtdmlldyBhbGxvdy1leHRlcm5h bC1uYXZpZ2F0aW9uIjsKIAogICAgIGZ1bmN0aW9uIGNhdGVnb3J5U29ydGVyKGEsIGIpIHsKICAg ICAgICAgcmV0dXJuIChhLnRpdGxlIHx8ICIiKS5sb2NhbGVDb21wYXJlKGIudGl0bGUgfHwgIiIp OwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvblBhbmVs LmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvblBhbmVsLmpzCmluZGV4 IGJhNWZhOGUuLjY2OGI1M2UgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9FeHRlbnNpb25QYW5lbC5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRXh0 ZW5zaW9uUGFuZWwuanMKQEAgLTMzLDYgKzMzLDcgQEAgV2ViSW5zcGVjdG9yLkV4dGVuc2lvblBh bmVsID0gZnVuY3Rpb24oaWQsIGxhYmVsLCBpY29uVVJMLCBvcHRpb25zKQogICAgIHRoaXMudG9v bGJhckl0ZW1MYWJlbCA9IGxhYmVsOwogICAgIHRoaXMuX2FkZFN0eWxlUnVsZSgiLnRvb2xiYXIt aXRlbS4iICsgaWQgKyAiIC50b29sYmFyLWljb24iLCAiYmFja2dyb3VuZC1pbWFnZTogdXJsKCIg KyBpY29uVVJMICsgIik7Iik7CiAgICAgV2ViSW5zcGVjdG9yLlBhbmVsLmNhbGwodGhpcywgaWQp OworICAgIHRoaXMuZWxlbWVudC5hZGRTdHlsZUNsYXNzKCJhbGxvdy1leHRlcm5hbC1uYXZpZ2F0 aW9uIik7CiB9CiAKIFdlYkluc3BlY3Rvci5FeHRlbnNpb25QYW5lbC5wcm90b3R5cGUgPSB7CmRp ZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzIGIvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwppbmRleCA0YzM4YTVhLi44MzA5 NGZmIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpz CisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMKQEAgLTczOCw2 ICs3MzgsOSBAQCBXZWJJbnNwZWN0b3IuZG9jdW1lbnRDbGljayA9IGZ1bmN0aW9uKGV2ZW50KQog ICAgIGlmICghYW5jaG9yKQogICAgICAgICByZXR1cm47CiAKKyAgICBpZiAoYW5jaG9yLnRhcmdl dCA9PT0gIl9ibGFuayIgJiYgYW5jaG9yLmVuY2xvc2luZ05vZGVPclNlbGZXaXRoQ2xhc3MoImFs bG93LWV4dGVybmFsLW5hdmlnYXRpb24iKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgLy8gUHJl dmVudCB0aGUgbGluayBmcm9tIG5hdmlnYXRpbmcsIHNpbmNlIHdlIGRvbid0IGRvIGFueSBuYXZp Z2F0aW9uIGJ5IGZvbGxvd2luZyBsaW5rcyBub3JtYWxseS4KICAgICBldmVudC5wcmV2ZW50RGVm YXVsdCgpOwogICAgIGV2ZW50LnN0b3BQcm9wYWdhdGlvbigpOwo= 67412 2010-09-13 08:20:20 -0700 2010-09-13 09:06:46 -0700 patch external-navigation.diff text/plain 2477 caseq ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzY3YmMyZS4uZTJiOGE2NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wOS0xMyAgQW5kcmV5IEtvc3lh a292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IHByb3ZpZGUgc3VwcG9ydCBmb3Igb3Bl bmluZyBleHRlcm5hbCBuYXZpZ2F0aW9uIGZvciBsaW5rcyB3aXRoaW4gY2VydGFpbiBlbGVtZW50 cworICAgICAgICBVc2UgZGVmYXVsdCBoYW5kbGluZyBmb3IgY2xpY2tzIG9uIGxpbmtzIHRoYXQg aGF2ZSB0YXJnZXQ9Il9ibGFuayIuCisgICAgICAgIEFkZCBvcHRpb24gZm9yIGV4dGVybmFsIG5h dmlnYXRpb24gdG8gVVJMIGF1ZGl0IGZvcm1hdHRlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1NjcxCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJv bnQtZW5kL0F1ZGl0Rm9ybWF0dGVycy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5BdWRpdEZv cm1hdHRlcnMudXJsKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5q czoKKwogMjAxMC0wOS0xMyAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0F1ZGl0Rm9ybWF0dGVycy5qcyBiL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9BdWRpdEZvcm1hdHRlcnMuanMKaW5kZXggZGUyNzdhZC4uMWJj MTgwMyAxMDA3NTUKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0F1ZGl0Rm9ybWF0 dGVycy5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQXVkaXRGb3JtYXR0ZXJz LmpzCkBAIC03OSw4ICs3OSwxNCBAQCBXZWJJbnNwZWN0b3IuQXVkaXRGb3JtYXR0ZXJzID0gewog ICAgICAgICByZXR1cm4gcGFyZW50OwogICAgIH0sCiAKLSAgICB1cmw6IGZ1bmN0aW9uKHVybCwg ZGlzcGxheVRleHQpCisgICAgdXJsOiBmdW5jdGlvbih1cmwsIGRpc3BsYXlUZXh0LCBhbGxvd0V4 dGVybmFsTmF2aWdhdGlvbikKICAgICB7Ci0gICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IubGlu a2lmeVVSTEFzTm9kZSh1cmwsIGRpc3BsYXlUZXh0IHx8IHVybCwgbnVsbCwgKHVybCBpbiBXZWJJ bnNwZWN0b3IucmVzb3VyY2VVUkxNYXApKTsKKyAgICAgICAgdmFyIGEgPSBkb2N1bWVudC5jcmVh dGVFbGVtZW50KCJhIik7CisgICAgICAgIGEuaHJlZiA9IHVybDsKKyAgICAgICAgYS50aXRsZSA9 IHVybDsKKyAgICAgICAgYS50ZXh0Q29udGVudCA9IGRpc3BsYXlUZXh0IHx8IHVybDsKKyAgICAg ICAgaWYgKGFsbG93RXh0ZXJuYWxOYXZpZ2F0aW9uKQorICAgICAgICAgICAgYS50YXJnZXQgPSAi X2JsYW5rIjsKKyAgICAgICAgcmV0dXJuIGE7CiAgICAgfQogfTsKZGlmZiAtLWdpdCBhL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvaW5zcGVjdG9yLmpzCmluZGV4IDRjMzhhNWEuLjVkNjRmYTAgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMKKysrIGIvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwpAQCAtNzM1LDcgKzczNSw3IEBAIFdlYklu c3BlY3Rvci5kb2N1bWVudE1vdXNlT3ZlciA9IGZ1bmN0aW9uKGV2ZW50KQogV2ViSW5zcGVjdG9y LmRvY3VtZW50Q2xpY2sgPSBmdW5jdGlvbihldmVudCkKIHsKICAgICB2YXIgYW5jaG9yID0gZXZl bnQudGFyZ2V0LmVuY2xvc2luZ05vZGVPclNlbGZXaXRoTm9kZU5hbWUoImEiKTsKLSAgICBpZiAo IWFuY2hvcikKKyAgICBpZiAoIWFuY2hvciB8fCBhbmNob3IudGFyZ2V0ID09PSAiX2JsYW5rIikK ICAgICAgICAgcmV0dXJuOwogCiAgICAgLy8gUHJldmVudCB0aGUgbGluayBmcm9tIG5hdmlnYXRp bmcsIHNpbmNlIHdlIGRvbid0IGRvIGFueSBuYXZpZ2F0aW9uIGJ5IGZvbGxvd2luZyBsaW5rcyBu b3JtYWxseS4KQEAgLTE4MTQsNyArMTgxNCw2IEBAIFdlYkluc3BlY3Rvci5saW5raWZ5VVJMQXNO b2RlID0gZnVuY3Rpb24odXJsLCBsaW5rVGV4dCwgY2xhc3NlcywgaXNFeHRlcm5hbCwgdG9vCiAg ICAgICAgIGEudGl0bGUgPSB1cmw7CiAgICAgZWxzZSBpZiAodHlwZW9mIHRvb2x0aXBUZXh0ICE9 PSAic3RyaW5nIiB8fCB0b29sdGlwVGV4dC5sZW5ndGgpCiAgICAgICAgIGEudGl0bGUgPSB0b29s dGlwVGV4dDsKLSAgICBhLnRhcmdldCA9ICJfYmxhbmsiOwogICAgIGEudGV4dENvbnRlbnQgPSBs aW5rVGV4dDsKIAogICAgIHJldHVybiBhOwo=