45651 2010-09-13 03:56:58 -0700 jscPath() is incorrect in Windows' cmd.exe shell 2010-09-13 09:18:12 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Windows XP RESOLVED FIXED P2 Normal --- 1 ossy ossy ddkilzer kenneth kling oldest_to_newest 278107 0 ossy 2010-09-13 03:56:58 -0700 http://trac.webkit.org/changeset/63463 broke run-javascriptore-tests, run-sunspider, ... scripts with QtWebKit on Windows, because $productDir/$jscName isn't exist, but $productDir/$jscName.exe. exe suffix is neccessary when you test file existance, but unneccessary when you execute the binarty. http://trac.webkit.org/changeset/63463: - return "$productDir/$jscName"; + return "$productDir/$jscName" if -e "$productDir/$jscName"; + return "$productDir/JavaScriptCore.framework/Resources/$jscName"; 278109 1 67394 ossy 2010-09-13 03:59:46 -0700 Created attachment 67394 proposed fix 278148 2 67394 kling 2010-09-13 05:39:57 -0700 Comment on attachment 67394 proposed fix > + $jscName .= ".exe" if (isQt() && isWindows()); This doesn't strike me as a Qt-specific issue. 278178 3 ossy 2010-09-13 06:38:46 -0700 (In reply to comment #2) > (From update of attachment 67394 [details]) > > + $jscName .= ".exe" if (isQt() && isWindows()); > > This doesn't strike me as a Qt-specific issue. It shouldn't be Qt specific issue, but I'm not sure. On Apple Windows port run-javascriptcore-tests works correctly, it seems the file existance check works without "exe" suffix inside cygwin. I will check it ASAP. 278211 4 67394 ossy 2010-09-13 08:00:31 -0700 Comment on attachment 67394 proposed fix new patch is coming soon 278224 5 67413 ossy 2010-09-13 08:24:59 -0700 Created attachment 67413 proposed fix proposed fix: + $jscName .= ".exe" if (isWindows() || isCygwin()); The root of the problem was that ' if -e "executableBinary" ' is false with ActiveState perl on Windows in cmd.exe shell, but true in CygWin shell if executableBinary.exe exist, but executableBinary doesn't. It is a misleading perl feature what we should avoid, so I propose to add ".exe" suffix for Windows and CygWin platform too. 278233 6 67413 kling 2010-09-13 09:00:40 -0700 Comment on attachment 67413 proposed fix Nice detective work :) r=me 278242 7 67413 ossy 2010-09-13 09:18:03 -0700 Comment on attachment 67413 proposed fix Clearing flags on attachment: 67413 Committed r67391: <http://trac.webkit.org/changeset/67391> 278243 8 ossy 2010-09-13 09:18:12 -0700 All reviewed patches have been landed. Closing bug. 67394 2010-09-13 03:59:46 -0700 2010-09-13 08:24:59 -0700 proposed fix 1.patch text/plain 1148 ossy SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHJldmlzaW9uIDY3Mzc2KQorKysgV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCSh3b3JraW5nIGNvcHkpCkBAIC0yNTgsNiAr MjU4LDcgQEAKICAgICBteSAoJHByb2R1Y3REaXIpID0gQF87CiAgICAgbXkgJGpzY05hbWUgPSAi anNjIjsKICAgICAkanNjTmFtZSAuPSAiX2RlYnVnIiAgaWYgKGlzQ3lnd2luKCkgJiYgKCRjb25m aWd1cmF0aW9uIGVxICJEZWJ1ZyIpKTsKKyAgICAkanNjTmFtZSAuPSAiLmV4ZSIgIGlmIChpc1F0 KCkgJiYgaXNXaW5kb3dzKCkpOwogICAgIHJldHVybiAiJHByb2R1Y3REaXIvJGpzY05hbWUiIGlm IC1lICIkcHJvZHVjdERpci8kanNjTmFtZSI7CiAgICAgcmV0dXJuICIkcHJvZHVjdERpci9KYXZh U2NyaXB0Q29yZS5mcmFtZXdvcmsvUmVzb3VyY2VzLyRqc2NOYW1lIjsKIH0KSW5kZXg6IFdlYktp dFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDY3Mzc2KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTAtMDktMTMgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Vi a2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbUXRdIGpzY1BhdGgoKSBpcyBpbmNvcnJlY3Qgb24gV2luZG93cworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU2NTEKKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0ZGlycy5wbTogQWRkICIuZXhlIiBzdWZmaXggdG8gJGpzY05hbWUgb24gV2luZG93 cy4KKwogMjAxMC0wOC0yNyAgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4gIDxrZW5uZXRoLmNo cmlzdGlhbnNlbkBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFudHRpIEtv aXZpc3RvLgo= 67413 2010-09-13 08:24:59 -0700 2010-09-13 09:18:03 -0700 proposed fix 1.patch text/plain 1149 ossy SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY3Mzg3KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDktMTMgIENzYWJhIE9zenRyb2dvbsOh YyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBqc2NQYXRoKCkgaXMgaW5jb3JyZWN0IGluIFdpbmRvd3MnIGNtZC5leGUg c2hlbGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1 NjUxCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06IEFkZCAiLmV4ZSIgc3VmZml4 IHRvICRqc2NOYW1lIG9uIFdpbmRvd3MuCisKIDIwMTAtMDktMTMgIEFuZHJlYXMgS2xpbmcgIDxh bmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJv aGRlIENocmlzdGlhbnNlbi4KSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5w bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHJldmlz aW9uIDY3Mzg3KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCSh3b3JraW5n IGNvcHkpCkBAIC0yNTgsNiArMjU4LDcgQEAKICAgICBteSAoJHByb2R1Y3REaXIpID0gQF87CiAg ICAgbXkgJGpzY05hbWUgPSAianNjIjsKICAgICAkanNjTmFtZSAuPSAiX2RlYnVnIiAgaWYgKGlz Q3lnd2luKCkgJiYgKCRjb25maWd1cmF0aW9uIGVxICJEZWJ1ZyIpKTsKKyAgICAkanNjTmFtZSAu PSAiLmV4ZSIgaWYgKGlzV2luZG93cygpIHx8IGlzQ3lnd2luKCkpOwogICAgIHJldHVybiAiJHBy b2R1Y3REaXIvJGpzY05hbWUiIGlmIC1lICIkcHJvZHVjdERpci8kanNjTmFtZSI7CiAgICAgcmV0 dXJuICIkcHJvZHVjdERpci9KYXZhU2NyaXB0Q29yZS5mcmFtZXdvcmsvUmVzb3VyY2VzLyRqc2NO YW1lIjsKIH0K