45637 2010-09-12 23:53:21 -0700 Remove fixed FIXME 2010-09-13 00:23:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth commit-queue eric oldest_to_newest 278002 0 abarth 2010-09-12 23:53:21 -0700 Remove fixed FIXME 278003 1 67363 abarth 2010-09-12 23:54:25 -0700 Created attachment 67363 Patch 278005 2 67363 eric 2010-09-12 23:55:58 -0700 Comment on attachment 67363 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67363&action=prettypatch It's OK. We could leave the first ASSERT even though Hixie removed it from the spec. LGTM. 278026 3 67363 commit-queue 2010-09-13 00:23:29 -0700 Comment on attachment 67363 Patch Clearing flags on attachment: 67363 Committed r67367: <http://trac.webkit.org/changeset/67367> 278027 4 commit-queue 2010-09-13 00:23:35 -0700 All reviewed patches have been landed. Closing bug. 67363 2010-09-12 23:54:25 -0700 2010-09-13 00:23:29 -0700 Patch bug-45637-20100912235424.patch text/plain 1936 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NzM2NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDktMTIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1v dmUgZml4ZWQgRklYTUUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQ1NjM3CisKKyAgICAgICAgVGhlIHNwZWMgbWFkZSBhc3NlcnRpb25zIHRoYXQgd2Vy ZSBmYWxzZS4gIEhpeGllIGZpeGVkIHRoZSBzcGVjIGJ5CisgICAgICAgIHJlbW92aW5nIHRoZSBh c3NlcnRpb25zLiAgVGhlcmUncyBubyBuZWVkIHRvIGtlZXAgdGhlc2UgRklYTUVzIGluIHRoZQor ICAgICAgICBjb2RlLgorCisgICAgICAgICogaHRtbC9wYXJzZXIvSFRNTFRyZWVCdWlsZGVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUcmVlQnVpbGRlcjo6cHJvY2Vzc0VuZFRhZ0Zvcklu Q2VsbCk6CisKIDIwMTAtMDktMTIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFdlYkNvcmUvaHRtbC9wYXJz ZXIvSFRNTFRyZWVCdWlsZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvcGFyc2Vy L0hUTUxUcmVlQnVpbGRlci5jcHAJKHJldmlzaW9uIDY3MzY2KQorKysgV2ViQ29yZS9odG1sL3Bh cnNlci9IVE1MVHJlZUJ1aWxkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODgwLDkgKzE4ODAs NiBAQCB2b2lkIEhUTUxUcmVlQnVpbGRlcjo6cHJvY2Vzc0VuZFRhZ0ZvckluCiAgICAgICAgIG1f dHJlZS5vcGVuRWxlbWVudHMoKS0+cG9wVW50aWxQb3BwZWQodG9rZW4ubmFtZSgpKTsKICAgICAg ICAgbV90cmVlLmFjdGl2ZUZvcm1hdHRpbmdFbGVtZW50cygpLT5jbGVhclRvTGFzdE1hcmtlcigp OwogICAgICAgICBzZXRJbnNlcnRpb25Nb2RlKEluUm93TW9kZSk7Ci0gICAgICAgIC8vIEZJWE1F OiBUaGUgZnJhZ21lbnQgY2FzZSBvZiB0aGlzIEFTU0VSVCBpcyBhIHNwZWMgYnVnOgotICAgICAg ICAvLyBodHRwOi8vd3d3LnczLm9yZy9CdWdzL1B1YmxpYy9zaG93X2J1Zy5jZ2k/aWQ9MTAzMzgK LSAgICAgICAgQVNTRVJUKG1fdHJlZS5jdXJyZW50RWxlbWVudCgpLT5oYXNUYWdOYW1lKHRyVGFn KSB8fCAoaXNQYXJzaW5nRnJhZ21lbnQoKSAmJiBtX2ZyYWdtZW50Q29udGV4dC5jb250ZXh0RWxl bWVudCgpLT5oYXNUYWdOYW1lKHRyVGFnKSkpOwogICAgICAgICByZXR1cm47CiAgICAgfQogICAg IGlmICh0b2tlbi5uYW1lKCkgPT0gYm9keVRhZwpAQCAtMTg5Niw4ICsxODkzLDYgQEAgdm9pZCBI VE1MVHJlZUJ1aWxkZXI6OnByb2Nlc3NFbmRUYWdGb3JJbgogICAgICAgICB8fCBpc1RhYmxlQm9k eUNvbnRleHRUYWcodG9rZW4ubmFtZSgpKSkgewogICAgICAgICBpZiAoIW1fdHJlZS5vcGVuRWxl bWVudHMoKS0+aW5UYWJsZVNjb3BlKHRva2VuLm5hbWUoKSkpIHsKICAgICAgICAgICAgIEFTU0VS VChpc1BhcnNpbmdGcmFnbWVudCgpKTsKLSAgICAgICAgICAgIC8vIEZJWE1FOiBJdCBpcyB1bmNs ZWFyIHdoYXQgdGhlIGV4YWN0IEFTU0VSVCBzaG91bGQgYmUuCi0gICAgICAgICAgICAvLyBodHRw Oi8vd3d3LnczLm9yZy9CdWdzL1B1YmxpYy9zaG93X2J1Zy5jZ2k/aWQ9MTAwOTgKICAgICAgICAg ICAgIHBhcnNlRXJyb3IodG9rZW4pOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9Cg==