45628 2010-09-12 19:32:13 -0700 [WML] Fix build breaks when WML is enabled 2010-09-13 10:22:22 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 22382 0 gyuyoung.kim webkit-unassigned commit-queue darin krit pkasting oldest_to_newest 277948 0 gyuyoung.kim 2010-09-12 19:32:13 -0700 There are build breaks when WML is enabled. 277949 1 67354 gyuyoung.kim 2010-09-12 19:34:44 -0700 Created attachment 67354 Patch 277995 2 67354 krit 2010-09-12 23:41:55 -0700 Comment on attachment 67354 Patch How can r67355 be responsible for your build breakage? It's a qt only change in the patch. Give more details in the ChangeLog. What breaks the WML build, how do you fixed it and so on. 278034 3 67371 gyuyoung.kim 2010-09-13 00:40:00 -0700 Created attachment 67371 Patch Sorry for my poor expression in my patch. When wml is enabled, there are build breaks as below, ====================================================================================================== /home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLAElement.cpp: In member function ‘virtual void WebCore::WMLAElement::defaultEventHandler(WebCore::Event*)’: /home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLAElement.cpp:131: error: cannot convert ‘WebCore::Document*’ to ‘WebCore::Event*’ for argument ‘1’ to ‘void WebCore::handleLinkClick(WebCore::Event*, WebCore::Document*, const WTF::String&, const WTF::String&, bool)’ /home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLInputElement.cpp: In member function ‘virtual void WebCore::WMLInputElement::defaultEventHandler(WebCore::Event*)’: /home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLInputElement.cpp:277: error: ‘class WebCore::Frame’ has no member named ‘doTextFieldCommandFromEvent’ make[2]: *** [WebCore/CMakeFiles/webcore_efl.dir/wml/WMLAElement.cpp.o] Error 1 ====================================================================================================== So, I make a patch for this build breaks. I add more comments in Changelog. :) Thank you. 278043 4 67371 tkent 2010-09-13 01:19:26 -0700 Comment on attachment 67371 Patch > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > index 05912d0..5b61a98 100644 > --- a/WebCore/ChangeLog > +++ b/WebCore/ChangeLog > @@ -1,3 +1,19 @@ > +2010-09-12 Gyuyoung Kim <gyuyoung.kim@samsung.com> > + > + Reviewed by NOBODY (OOPS!). > + > + [WML] Fix a build break R67355 This description is confusing. This sounds like r67355 caused a WML build break. Actually http://trac.webkit.org/changeset/67262 caused it, right? 278050 5 67374 gyuyoung.kim 2010-09-13 01:32:10 -0700 Created attachment 67374 Patch Oops, my mistake. I modify Changelog again. If there are still wrong expression, please let me know. Thank you. 278290 6 67374 commit-queue 2010-09-13 10:22:17 -0700 Comment on attachment 67374 Patch Clearing flags on attachment: 67374 Committed r67395: <http://trac.webkit.org/changeset/67395> 278291 7 commit-queue 2010-09-13 10:22:22 -0700 All reviewed patches have been landed. Closing bug. 67354 2010-09-12 19:34:44 -0700 2010-09-13 00:40:00 -0700 Patch patch-wml-build-break.txt text/plain 1881 gyuyoung.kim ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDU5MTJkMC4uODA5MzRiOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wOS0xMiAgR3l1eW91bmcgS2lt ICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtXTUxdIEZpeCBhIGJ1aWxkIGJyZWFrIFI2NzM1NSAKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1NjI4CisKKyAg ICAgICAgVGhlcmUgYXJlIGJ1aWxkIGJyZWFrcyB3aGVuIFdNTCBpcyBlbmFibGVkLgorCisgICAg ICAgICogd21sL1dNTEFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldNTEFFbGVtZW50 OjpkZWZhdWx0RXZlbnRIYW5kbGVyKToKKyAgICAgICAgKiB3bWwvV01MSW5wdXRFbGVtZW50LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OldNTElucHV0RWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxl cik6CisKIDIwMTAtMDktMTIgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3dt bC9XTUxBRWxlbWVudC5jcHAgYi9XZWJDb3JlL3dtbC9XTUxBRWxlbWVudC5jcHAKaW5kZXggOGE0 ZGMwOS4uYzYwZGI1ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS93bWwvV01MQUVsZW1lbnQuY3BwCisr KyBiL1dlYkNvcmUvd21sL1dNTEFFbGVtZW50LmNwcApAQCAtMTI4LDcgKzEyOCw3IEBAIHZvaWQg V01MQUVsZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIoRXZlbnQqIGV2ZW50KQogICAgICAgICB9 CiAKICAgICAgICAgaWYgKGlzTGlua0NsaWNrKGV2ZW50KSkgewotICAgICAgICAgICAgaGFuZGxl TGlua0NsaWNrKGRvY3VtZW50KCksIGRlcHJlY2F0ZWRQYXJzZVVSTChnZXRBdHRyaWJ1dGUoSFRN TE5hbWVzOjpocmVmQXR0cikpLCB0YXJnZXQoKSwgZXZlbnQpOworICAgICAgICAgICAgaGFuZGxl TGlua0NsaWNrKGV2ZW50LCBkb2N1bWVudCgpLCBkZXByZWNhdGVkUGFyc2VVUkwoZ2V0QXR0cmli dXRlKEhUTUxOYW1lczo6aHJlZkF0dHIpKSwgdGFyZ2V0KCksIGV2ZW50KTsKICAgICAgICAgICAg IHJldHVybjsKICAgICAgICAgfQogICAgIH0KZGlmZiAtLWdpdCBhL1dlYkNvcmUvd21sL1dNTElu cHV0RWxlbWVudC5jcHAgYi9XZWJDb3JlL3dtbC9XTUxJbnB1dEVsZW1lbnQuY3BwCmluZGV4IDYz OTY1OGYuLjIxNjViZDQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvd21sL1dNTElucHV0RWxlbWVudC5j cHAKKysrIGIvV2ViQ29yZS93bWwvV01MSW5wdXRFbGVtZW50LmNwcApAQCAtMjc0LDcgKzI3NCw3 IEBAIHZvaWQgV01MSW5wdXRFbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50KiBldnQp CiAgICAgfQogCiAgICAgaWYgKGV2dC0+dHlwZSgpID09IGV2ZW50TmFtZXMoKS5rZXlkb3duRXZl bnQgJiYgZXZ0LT5pc0tleWJvYXJkRXZlbnQoKSAmJiBmb2N1c2VkKCkgJiYgZG9jdW1lbnQoKS0+ ZnJhbWUoKQotICAgICAgICAmJiBkb2N1bWVudCgpLT5mcmFtZSgpLT5kb1RleHRGaWVsZENvbW1h bmRGcm9tRXZlbnQodGhpcywgc3RhdGljX2Nhc3Q8S2V5Ym9hcmRFdmVudCo+KGV2dCkpKSB7Cisg ICAgICAgICYmIGRvY3VtZW50KCktPmZyYW1lKCktPmVkaXRvcigpLT5kb1RleHRGaWVsZENvbW1h bmRGcm9tRXZlbnQodGhpcywgc3RhdGljX2Nhc3Q8S2V5Ym9hcmRFdmVudCo+KGV2dCkpKSB7CiAg ICAgICAgIGV2dC0+c2V0RGVmYXVsdEhhbmRsZWQoKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0K 67371 2010-09-13 00:40:00 -0700 2010-09-13 01:32:10 -0700 Patch patch-wml-build-break.txt text/plain 2129 gyuyoung.kim ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDU5MTJkMC4uNWI2MWE5OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wOS0xMiAgR3l1eW91bmcgS2lt ICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtXTUxdIEZpeCBhIGJ1aWxkIGJyZWFrIFI2NzM1NSAKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1NjI4CisKKyAg ICAgICAgVGhlcmUgYXJlIGJ1aWxkIGJyZWFrcyB3aGVuIFdNTCBpcyBlbmFibGVkLiBUaGUgaGFu ZGxlTGlua0NsaWNrKCkgaGFzIGFuIGV2ZW50IHBhcmFtZXRlci4KKyAgICAgICAgU28sIHdlIG5l ZWQgdG8gc2V0IGFuIGV2ZW50IHdoZW4gd21sIGludm9rZSB0aGUgaGFuZGxlTGlua0NsaWNrKCku IEFuZCwgZG9UZXh0RmllbGRDb21tYW5kRnJvbUV2ZW50KCkKKyAgICAgICAgd2FzIG1vdmVkIHRv IGVkaXRvci4gU28sIHdlIG5lZWQgdG8gbW9maWR5IHRoZSBpbnZvY2F0aW9uIGluIFdNTElucHV0 RWxlbWVudC5jcHAgCisKKyAgICAgICAgKiB3bWwvV01MQUVsZW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6V01MQUVsZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIpOgorICAgICAgICAqIHdt bC9XTUxJbnB1dEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V01MSW5wdXRFbGVtZW50 OjpkZWZhdWx0RXZlbnRIYW5kbGVyKToKKwogMjAxMC0wOS0xMiAgUm9iZXJ0IEhvZ2FuICA8cm9i ZXJ0QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvd21sL1dNTEFFbGVtZW50LmNwcCBiL1dlYkNvcmUvd21sL1dNTEFF bGVtZW50LmNwcAppbmRleCA4YTRkYzA5Li5jNjBkYjVlIDEwMDY0NAotLS0gYS9XZWJDb3JlL3dt bC9XTUxBRWxlbWVudC5jcHAKKysrIGIvV2ViQ29yZS93bWwvV01MQUVsZW1lbnQuY3BwCkBAIC0x MjgsNyArMTI4LDcgQEAgdm9pZCBXTUxBRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVu dCogZXZlbnQpCiAgICAgICAgIH0KIAogICAgICAgICBpZiAoaXNMaW5rQ2xpY2soZXZlbnQpKSB7 Ci0gICAgICAgICAgICBoYW5kbGVMaW5rQ2xpY2soZG9jdW1lbnQoKSwgZGVwcmVjYXRlZFBhcnNl VVJMKGdldEF0dHJpYnV0ZShIVE1MTmFtZXM6OmhyZWZBdHRyKSksIHRhcmdldCgpLCBldmVudCk7 CisgICAgICAgICAgICBoYW5kbGVMaW5rQ2xpY2soZXZlbnQsIGRvY3VtZW50KCksIGRlcHJlY2F0 ZWRQYXJzZVVSTChnZXRBdHRyaWJ1dGUoSFRNTE5hbWVzOjpocmVmQXR0cikpLCB0YXJnZXQoKSwg ZXZlbnQpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAgICAgfQpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS93bWwvV01MSW5wdXRFbGVtZW50LmNwcCBiL1dlYkNvcmUvd21sL1dNTElucHV0 RWxlbWVudC5jcHAKaW5kZXggNjM5NjU4Zi4uMjE2NWJkNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS93 bWwvV01MSW5wdXRFbGVtZW50LmNwcAorKysgYi9XZWJDb3JlL3dtbC9XTUxJbnB1dEVsZW1lbnQu Y3BwCkBAIC0yNzQsNyArMjc0LDcgQEAgdm9pZCBXTUxJbnB1dEVsZW1lbnQ6OmRlZmF1bHRFdmVu dEhhbmRsZXIoRXZlbnQqIGV2dCkKICAgICB9CiAKICAgICBpZiAoZXZ0LT50eXBlKCkgPT0gZXZl bnROYW1lcygpLmtleWRvd25FdmVudCAmJiBldnQtPmlzS2V5Ym9hcmRFdmVudCgpICYmIGZvY3Vz ZWQoKSAmJiBkb2N1bWVudCgpLT5mcmFtZSgpCi0gICAgICAgICYmIGRvY3VtZW50KCktPmZyYW1l KCktPmRvVGV4dEZpZWxkQ29tbWFuZEZyb21FdmVudCh0aGlzLCBzdGF0aWNfY2FzdDxLZXlib2Fy ZEV2ZW50Kj4oZXZ0KSkpIHsKKyAgICAgICAgJiYgZG9jdW1lbnQoKS0+ZnJhbWUoKS0+ZWRpdG9y KCktPmRvVGV4dEZpZWxkQ29tbWFuZEZyb21FdmVudCh0aGlzLCBzdGF0aWNfY2FzdDxLZXlib2Fy ZEV2ZW50Kj4oZXZ0KSkpIHsKICAgICAgICAgZXZ0LT5zZXREZWZhdWx0SGFuZGxlZCgpOwogICAg ICAgICByZXR1cm47CiAgICAgfQo= 67374 2010-09-13 01:32:10 -0700 2010-09-13 10:22:17 -0700 Patch patch-wml-build-break.txt text/plain 2153 gyuyoung.kim ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDU5MTJkMC4uYzI5YjNlYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wOS0xMiAgR3l1eW91bmcgS2lt ICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtXTUxdIEZpeCBidWlsZCBicmVha3Mgd2hlbiBXTUwgaXMg ZW5hYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDU2MjgKKworICAgICAgICBUaGVyZSBhcmUgYnVpbGQgYnJlYWtzIGJ5IEJ1ZyAyMjM4MiB3aGVu IFdNTCBpcyBlbmFibGVkLiBUaGUgaGFuZGxlTGlua0NsaWNrKCkgaGFzIGFuIGV2ZW50IHBhcmFt ZXRlci4KKyAgICAgICAgU28sIHdlIG5lZWQgdG8gc2V0IGFuIGV2ZW50IHdoZW4gd21sIGludm9r ZSB0aGUgaGFuZGxlTGlua0NsaWNrKCkuIEFuZCwgZG9UZXh0RmllbGRDb21tYW5kRnJvbUV2ZW50 KCkKKyAgICAgICAgd2FzIG1vdmVkIHRvIGVkaXRvci4gU28sIHdlIG5lZWQgdG8gbW9maWR5IHRo ZSBpbnZvY2F0aW9uIGluIFdNTElucHV0RWxlbWVudC5jcHAgCisKKyAgICAgICAgKiB3bWwvV01M QUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V01MQUVsZW1lbnQ6OmRlZmF1bHRFdmVu dEhhbmRsZXIpOgorICAgICAgICAqIHdtbC9XTUxJbnB1dEVsZW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6V01MSW5wdXRFbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVyKToKKwogMjAxMC0w OS0xMiAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgQW5kcmVhcyBLbGluZy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvd21sL1dNTEFFbGVtZW50 LmNwcCBiL1dlYkNvcmUvd21sL1dNTEFFbGVtZW50LmNwcAppbmRleCA4YTRkYzA5Li5jNjBkYjVl IDEwMDY0NAotLS0gYS9XZWJDb3JlL3dtbC9XTUxBRWxlbWVudC5jcHAKKysrIGIvV2ViQ29yZS93 bWwvV01MQUVsZW1lbnQuY3BwCkBAIC0xMjgsNyArMTI4LDcgQEAgdm9pZCBXTUxBRWxlbWVudDo6 ZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVudCogZXZlbnQpCiAgICAgICAgIH0KIAogICAgICAgICBp ZiAoaXNMaW5rQ2xpY2soZXZlbnQpKSB7Ci0gICAgICAgICAgICBoYW5kbGVMaW5rQ2xpY2soZG9j dW1lbnQoKSwgZGVwcmVjYXRlZFBhcnNlVVJMKGdldEF0dHJpYnV0ZShIVE1MTmFtZXM6OmhyZWZB dHRyKSksIHRhcmdldCgpLCBldmVudCk7CisgICAgICAgICAgICBoYW5kbGVMaW5rQ2xpY2soZXZl bnQsIGRvY3VtZW50KCksIGRlcHJlY2F0ZWRQYXJzZVVSTChnZXRBdHRyaWJ1dGUoSFRNTE5hbWVz OjpocmVmQXR0cikpLCB0YXJnZXQoKSwgZXZlbnQpOwogICAgICAgICAgICAgcmV0dXJuOwogICAg ICAgICB9CiAgICAgfQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS93bWwvV01MSW5wdXRFbGVtZW50LmNw cCBiL1dlYkNvcmUvd21sL1dNTElucHV0RWxlbWVudC5jcHAKaW5kZXggNjM5NjU4Zi4uMjE2NWJk NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS93bWwvV01MSW5wdXRFbGVtZW50LmNwcAorKysgYi9XZWJD b3JlL3dtbC9XTUxJbnB1dEVsZW1lbnQuY3BwCkBAIC0yNzQsNyArMjc0LDcgQEAgdm9pZCBXTUxJ bnB1dEVsZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIoRXZlbnQqIGV2dCkKICAgICB9CiAKICAg ICBpZiAoZXZ0LT50eXBlKCkgPT0gZXZlbnROYW1lcygpLmtleWRvd25FdmVudCAmJiBldnQtPmlz S2V5Ym9hcmRFdmVudCgpICYmIGZvY3VzZWQoKSAmJiBkb2N1bWVudCgpLT5mcmFtZSgpCi0gICAg ICAgICYmIGRvY3VtZW50KCktPmZyYW1lKCktPmRvVGV4dEZpZWxkQ29tbWFuZEZyb21FdmVudCh0 aGlzLCBzdGF0aWNfY2FzdDxLZXlib2FyZEV2ZW50Kj4oZXZ0KSkpIHsKKyAgICAgICAgJiYgZG9j dW1lbnQoKS0+ZnJhbWUoKS0+ZWRpdG9yKCktPmRvVGV4dEZpZWxkQ29tbWFuZEZyb21FdmVudCh0 aGlzLCBzdGF0aWNfY2FzdDxLZXlib2FyZEV2ZW50Kj4oZXZ0KSkpIHsKICAgICAgICAgZXZ0LT5z ZXREZWZhdWx0SGFuZGxlZCgpOwogICAgICAgICByZXR1cm47CiAgICAgfQo=