45618 2010-09-12 11:22:14 -0700 [Qt] Remove Path::closeSubpath() workaround for broken miter joins 2010-09-12 11:36:15 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling webkit-qt-unassigned oldest_to_newest 277877 0 kling 2010-09-12 11:22:14 -0700 In <http://trac.webkit.org/changeset/66948> Path::closeCanvasSubpath() was added to fix around a problem that wasn't fully understood at the time. It turns out that the whole thing was a bug in Qt's SVG-compliant path stroker. It has been fixed for Qt 4.7.1 and we should remove the workaround kludge from WebKit. 277878 1 67339 kling 2010-09-12 11:25:56 -0700 Created attachment 67339 Proposed patch 277879 2 67339 kling 2010-09-12 11:36:05 -0700 Comment on attachment 67339 Proposed patch Clearing flags on attachment: 67339 Committed r67339: <http://trac.webkit.org/changeset/67339> 277880 3 kling 2010-09-12 11:36:15 -0700 All reviewed patches have been landed. Closing bug. 67339 2010-09-12 11:25:56 -0700 2010-09-12 11:36:05 -0700 Proposed patch bug-45618.diff text/plain 4344 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyM2JmZTY0Li4zMTQ1NjNkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDkt MTIgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFJlbW92ZSBQYXRoOjpj bG9zZVN1YnBhdGgoKSB3b3JrYXJvdW5kIGZvciBicm9rZW4gbWl0ZXIgam9pbnMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1NjE4CisKKyAgICAgICAg U2tpcCBmYXN0L2NhbnZhcy9jYW52YXMtY2xvc2VQYXRoLXNpbmdsZS1wb2ludC5odG1sIC0gaXQg Y2FuIGJlIHVuc2tpcHBlZCBhZ2FpbgorICAgICAgICBvbmNlIHRoZSBib3QgaXMgdXBncmFkZWQg dG8gUXQgNC43LjEuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDEwLTA5 LTEyICBNaWhhaSBQYXJwYXJpdGEgIDxtaWhhaXBAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL3F0L1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCmluZGV4IDM4 YzYyMzYuLjVhZTY1MDMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBw ZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZApAQCAtNTQzOSwzICs1NDM5 LDYgQEAgZnVsbHNjcmVlbi8KIAogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDUxOTQKIGZhc3QvdGV4dC9kZWNvbXBvc2VkLWFmdGVyLXN0YWNrZWQtZGlhY3JpdGlj cy5odG1sCisKKyMgRml4ZWQgaW4gUXQgNC43LjEgLSBVbnNraXAgd2hlbiBidWlsZGJvdCBpcyB1 cGdyYWRlZC4KK2Zhc3QvY2FudmFzL2NhbnZhcy1jbG9zZVBhdGgtc2luZ2xlLXBvaW50Lmh0bWwK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MmNiYWI0OC4uNTNjMjM4YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wOS0xMiAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUmVtb3ZlIFBhdGg6OmNsb3NlU3VicGF0aCgpIHdv cmthcm91bmQgZm9yIGJyb2tlbiBtaXRlciBqb2lucworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU2MTgKKworICAgICAgICBSZW1vdmVkIFBhdGg6OmNs b3NlQ2FudmFzU3VicGF0aCgpIGFuZCBzaGFyZSB0aGUgbG9naWMgYmV0d2VlbiBDYW52YXMgYW5k IFNWRworICAgICAgICBwYXRocy4gVGhlIHByb2JsZW0gd2FzIGFjdHVhbGx5IGluIFF0J3MgcGF0 aCBzdHJva2VyIGFuZCBoYXMgYmVlbiBmaXhlZCBmb3IgUXQgNC43LjEuCisKKyAgICAgICAgKiBo dG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Q2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpjbG9zZVBhdGgpOgorICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL1BhdGguaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9QYXRo UXQuY3BwOgorCiAyMDEwLTA5LTExICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgQ2FybHNvbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv aHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcCBiL1dlYkNvcmUvaHRtbC9j YW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAppbmRleCAzMzg5NjBjLi4wZmI3ZWQ1 IDEwMDc1NQotLS0gYS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQy RC5jcHAKKysrIGIvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQu Y3BwCkBAIC02NTksNyArNjU5LDcgQEAgdm9pZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OmNs b3NlUGF0aCgpCiAKICAgICBGbG9hdFJlY3QgYm91bmRSZWN0ID0gbV9wYXRoLmJvdW5kaW5nUmVj dCgpOwogICAgIGlmIChib3VuZFJlY3Qud2lkdGgoKSB8fCBib3VuZFJlY3QuaGVpZ2h0KCkpCi0g ICAgICAgIG1fcGF0aC5jbG9zZUNhbnZhc1N1YnBhdGgoKTsKKyAgICAgICAgbV9wYXRoLmNsb3Nl U3VicGF0aCgpOwogfQogCiB2b2lkIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6bW92ZVRvKGZs b2F0IHgsIGZsb2F0IHkpCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1Bh dGguaCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGF0aC5oCmluZGV4IDk4OTY3MTMuLjYx ZWEzMjggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGF0aC5oCisrKyBi L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGF0aC5oCkBAIC0xMzMsMTEgKzEzMyw2IEBAIG5h bWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdm9pZCBhZGRCZXppZXJDdXJ2ZVRvKGNvbnN0IEZs b2F0UG9pbnQmIGNvbnRyb2xQb2ludDEsIGNvbnN0IEZsb2F0UG9pbnQmIGNvbnRyb2xQb2ludDIs IGNvbnN0IEZsb2F0UG9pbnQmIGVuZFBvaW50KTsKICAgICAgICAgdm9pZCBhZGRBcmNUbyhjb25z dCBGbG9hdFBvaW50JiwgY29uc3QgRmxvYXRQb2ludCYsIGZsb2F0IHJhZGl1cyk7CiAgICAgICAg IHZvaWQgY2xvc2VTdWJwYXRoKCk7Ci0jaWYgUExBVEZPUk0oUVQpCi0gICAgICAgIHZvaWQgY2xv c2VDYW52YXNTdWJwYXRoKCk7Ci0jZWxzZQotICAgICAgICB2b2lkIGNsb3NlQ2FudmFzU3VicGF0 aCgpIHsgY2xvc2VTdWJwYXRoKCk7IH0KLSNlbmRpZgogCiAgICAgICAgIHZvaWQgYWRkQXJjKGNv bnN0IEZsb2F0UG9pbnQmLCBmbG9hdCByYWRpdXMsIGZsb2F0IHN0YXJ0QW5nbGUsIGZsb2F0IGVu ZEFuZ2xlLCBib29sIGFudGljbG9ja3dpc2UpOwogICAgICAgICB2b2lkIGFkZFJlY3QoY29uc3Qg RmxvYXRSZWN0Jik7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L1Bh dGhRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L1BhdGhRdC5jcHAKaW5kZXgg ZGY1NDY4NC4uNDhiNTJhMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9x dC9QYXRoUXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvUGF0aFF0LmNw cApAQCAtMjY3LDMwICsyNjcsNiBAQCB2b2lkIFBhdGg6OmNsb3NlU3VicGF0aCgpCiAgICAgbV9w YXRoLmNsb3NlU3VicGF0aCgpOwogfQogCi12b2lkIFBhdGg6OmNsb3NlQ2FudmFzU3VicGF0aCgp Ci17Ci0gICAgY29uc3QgaW50IGVsZW1lbnRDb3VudCA9IG1fcGF0aC5lbGVtZW50Q291bnQoKTsK LQotICAgIGlmICghZWxlbWVudENvdW50KQotICAgICAgICByZXR1cm47Ci0KLSAgICBRUG9pbnRG IGxhc3RNb3ZlVG9Qb2ludCA9IG1fcGF0aC5lbGVtZW50QXQobV9sYXN0TW92ZVRvSW5kZXgpOwot ICAgIGludCBlbGVtZW50c0luTGFzdFN1YnBhdGggPSAwOwotCi0gICAgZm9yIChpbnQgaSA9IG1f bGFzdE1vdmVUb0luZGV4OyBpIDwgZWxlbWVudENvdW50OyArK2kpIHsKLSAgICAgICAgUVBhaW50 ZXJQYXRoOjpFbGVtZW50IGVsZW1lbnQgPSBtX3BhdGguZWxlbWVudEF0KGkpOwotICAgICAgICBp ZiAoZWxlbWVudC5pc0xpbmVUbygpIHx8IGVsZW1lbnQuaXNDdXJ2ZVRvKCkpIHsKLSAgICAgICAg ICAgIC8vIEFsbCB3ZSBuZWVkIHRvIGtub3cgaXMgaWYgdGhlcmUgYXJlIDEgb3IgbW9yZSBlbGVt ZW50cyBpbiB0aGUgbGFzdCBzdWJwYXRoLgotICAgICAgICAgICAgaWYgKCsrZWxlbWVudHNJbkxh c3RTdWJwYXRoID09IDIpIHsKLSAgICAgICAgICAgICAgICBtX3BhdGgubGluZVRvKGxhc3RNb3Zl VG9Qb2ludCk7Ci0gICAgICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICAgICAgfQotICAgICAg ICB9Ci0gICAgfQotCi0gICAgbW92ZVRvKGxhc3RNb3ZlVG9Qb2ludCk7Ci19Ci0KICNkZWZpbmUg REVHUkVFUyh0KSAoKHQpICogMTgwLjAgLyBNX1BJKQogdm9pZCBQYXRoOjphZGRBcmMoY29uc3Qg RmxvYXRQb2ludCYgcCwgZmxvYXQgciwgZmxvYXQgc2FyLCBmbG9hdCBlYXIsIGJvb2wgYW50aWNs b2Nrd2lzZSkKIHsK