45617 2010-09-12 10:38:11 -0700 Consolidate WebCore/bridge/npruntime_internal.h and WebCore/bindings/v8/npruntime_internal.h 2011-11-05 08:03:30 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hausmann hausmann abarth commit-queue japhet kling webkit.review.bot oldest_to_newest 277871 0 hausmann 2010-09-12 10:38:11 -0700 These two files are currently duplicated. We should get rid of the copy in WebCore/bindings/v8 277873 1 67337 hausmann 2010-09-12 10:39:30 -0700 Created attachment 67337 Patch 285326 2 67337 abarth 2010-09-26 22:36:01 -0700 Comment on attachment 67337 Patch Woah. You're blowing my mind. 285332 3 67337 commit-queue 2010-09-26 23:00:24 -0700 Comment on attachment 67337 Patch Rejecting patch 67337 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 67337]" exit_code: 2 Cleaning working directory Updating working directory Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=67337&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=45617&ctype=xml Processing 1 patch from 1 bug. Processing patch 67337 from bug 45617. Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/4028157 321834 4 67337 eric 2010-12-14 01:56:53 -0800 Comment on attachment 67337 Patch Was this already landed? I wonder why they cq failed to apply? 496658 5 hausmann 2011-11-05 07:46:33 -0700 (In reply to comment #4) > (From update of attachment 67337 [details]) > Was this already landed? I wonder why they cq failed to apply? It never landed. Strange :). Uploading a rebased patch. 496659 6 113753 hausmann 2011-11-05 07:46:53 -0700 Created attachment 113753 Reviewed by NOBODY (OOPS!) 496660 7 hausmann 2011-11-05 08:03:30 -0700 Committed r99353: <http://trac.webkit.org/changeset/99353> 67337 2010-09-12 10:39:30 -0700 2011-11-05 07:46:48 -0700 Patch bug-45617-20100912193928.patch text/plain 3581 hausmann ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDAwYmEwZmNiMDdkOTRjMWZjNjhkOTI3YmRlNjEzYWNhN2Q3MTVmYi4uZTk4YTdlZWM0ZTJiMTA2 ZDFlZjY3MDdjNWJjNTczNDNhOGQ0ZWFkOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOSBAQAogMjAxMC0wOS0xMiAgU2lt b24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlZCBkdXBsaWNhdGVkIG5wcnVu dGltZV9pbnRlcm5hbC5oIGZyb20gYmluZGluZ3MvdjgKKyAgICAgICAgaW4gZmF2b3VyIG9mIHRo ZSBvbmUgZnJvbSBicmlkZ2UvLCB3aGljaCBoYXMgYSBmZXcgbW9yZQorICAgICAgICAjdW5kZWZz LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTYx NworCisgICAgICAgICogV2ViQ29yZS5neXAvV2ViQ29yZS5neXA6IEFkZCBicmlkZ2UvIHRvIHRo ZSBpbmNsdWRlIHBhdGhzLgorICAgICAgICAqIFdlYkNvcmUuZ3lwaTogUmVtb3ZlZCBvY3VycmVu Y2Ugb2YgYmluZGluZ3MvdjgvbnBydW50aW1lX2ludGVybmFsLmguCisgICAgICAgICogYmluZGlu Z3MvdjgvbnBydW50aW1lX2ludGVybmFsLmg6IFJlbW92ZWQuCisKKzIwMTAtMDktMTIgIFNpbW9u IEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgorCiAgICAgICAgIFJldmlld2Vk IGJ5IEFuZHJlYXMgS2xpbmcuCiAKICAgICAgICAgRml4IGNvbXBpbGF0aW9uIG9mIHRoZSBWOCBi aW5kaW5ncyBvbiBYMTEgd2l0aCBRdC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvV2ViQ29yZS5neXAv V2ViQ29yZS5neXAgYi9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCmluZGV4IDgzNzdm MmFhOTZkN2FjNTk1YzY4ODc2MGM1NzRmNjEyZmNmOGJhZjAuLjNmNmIxNzE5MzkxOThjYjJjZDk4 MWI4Y2FlMmFjYTEyNGQ0NTdhZDUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvV2ViQ29yZS5neXAvV2Vi Q29yZS5neXAKKysrIGIvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cApAQCAtMTE1LDYg KzExNSw3IEBACiAgICAgICAnLi4vYmluZGluZ3MvdjgnLAogICAgICAgJy4uL2JpbmRpbmdzL3Y4 L2N1c3RvbScsCiAgICAgICAnLi4vYmluZGluZ3Mvdjgvc3BlY2lhbGl6YXRpb24nLAorICAgICAg Jy4uL2JyaWRnZScsCiAgICAgICAnLi4vY3NzJywKICAgICAgICcuLi9kb20nLAogICAgICAgJy4u L2RvbS9kZWZhdWx0JywKZGlmZiAtLWdpdCBhL1dlYkNvcmUvV2ViQ29yZS5neXBpIGIvV2ViQ29y ZS9XZWJDb3JlLmd5cGkKaW5kZXggZmVkN2NlMzk3ODM4Njg4NTg5ZGU2OGQzYzZjOGI0OTZiZmY5 OGY4ZC4uMDZjYzVhYWJjNjgzMDc4YjA2MDMxZmQ4ZDVjZmY2NDk3ZGE5ODgwNiAxMDA2NDQKLS0t IGEvV2ViQ29yZS9XZWJDb3JlLmd5cGkKKysrIGIvV2ViQ29yZS9XZWJDb3JlLmd5cGkKQEAgLTk0 OCw3ICs5NDgsNiBAQAogICAgICAgICAgICAgJ2JpbmRpbmdzL3Y4L1dyYXBwZXJUeXBlSW5mby5o JywKICAgICAgICAgICAgICdiaW5kaW5ncy92OC9ucHJ1bnRpbWUuY3BwJywKICAgICAgICAgICAg ICdiaW5kaW5ncy92OC9ucHJ1bnRpbWVfaW1wbC5oJywKLSAgICAgICAgICAgICdiaW5kaW5ncy92 OC9ucHJ1bnRpbWVfaW50ZXJuYWwuaCcsCiAgICAgICAgICAgICAnYmluZGluZ3MvdjgvbnBydW50 aW1lX3ByaXYuaCcsCiAgICAgICAgICAgICAnY3NzL0NTU0JvcmRlckltYWdlVmFsdWUuY3BwJywK ICAgICAgICAgICAgICdjc3MvQ1NTQm9yZGVySW1hZ2VWYWx1ZS5oJywKZGlmZiAtLWdpdCBhL1dl YkNvcmUvYmluZGluZ3MvdjgvbnBydW50aW1lX2ludGVybmFsLmggYi9XZWJDb3JlL2JpbmRpbmdz L3Y4L25wcnVudGltZV9pbnRlcm5hbC5oCmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCA3 NWJmMmIwZmY3MGQwMDFiZDAzOWM4MDBiMzhkNTJkYTYxZGUxZTg1Li4wMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvbnBydW50 aW1lX2ludGVybmFsLmgKKysrIC9kZXYvbnVsbApAQCAtMSw0MSArMCwwIEBACi0vKgotICogQ29w eXJpZ2h0IChDKSAyMDA3IENvbGxhYm9yYSwgTHRkLiAgQWxsIHJpZ2h0cyByZXNlcnZlZC4KLSAq Ci0gKiBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUg aXQgYW5kL29yCi0gKiBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGVzc2Vy IEdlbmVyYWwgUHVibGljCi0gKiBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0 d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIKLSAqIHZlcnNpb24gMi4xIG9mIHRoZSBMaWNlbnNlLCBv ciAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLgotICoKLSAqIFRoaXMgbGlicmFy eSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAotICog YnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFu dHkgb2YKLSAqIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVS UE9TRS4gIFNlZSB0aGUgR05VCi0gKiBMZXNzZXIgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3Ig bW9yZSBkZXRhaWxzLgotICoKLSAqIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2Yg dGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKLSAqIExpY2Vuc2UgYWxvbmcgd2l0aCB0aGlz IGxpYnJhcnk7IGlmIG5vdCwgd3JpdGUgdG8gdGhlIEZyZWUKLSAqIFNvZnR3YXJlIEZvdW5kYXRp b24sIEluYy4sIDY3NSBNYXNzIEF2ZSwgQ2FtYnJpZGdlLCBNQSAwMjEzOSwgVVNBLgotICoKLSAq Ci0gKiBUaGlzIGlzIGEgaW50ZXJuYWwgaW5jbHVkZSBoZWFkZXIgZm9yIG5wYXBpLmgKLSAqCi0g KiBTb21lIG9mIHRoZSAjZGVmaW5lcyB3aGljaCBhcmUgaW4gWDExIGhlYWRlcnMgY29uZmxpY3Qg d2l0aCB0eXBlIGFuZCBlbnVtCi0gKiBuYW1lcyBpbiBKYXZhU2NyaXB0Q29yZSBhbmQgV2ViQ29y ZQotICogVGhpcyBoZWFkZXIgI3VuZGVmcyB0aG9zZSBkZWZpbmVzIHRvIGZpeCB0aGUgY29uZmxp Y3RzCi0gKiBJZiB5b3UgbmVlZCB0byBpbmNsdWRlIG5wYXBpLmggb3IgbnBydW50aW1lLmggd2hl biBidWlsZGluZyBvbiBYMTEsCi0gKiBpbmNsdWRlIHRoaXMgZmlsZSBpbnN0ZWFkIG9mIHRoZSBh Y3R1YWwgbnBhcGkuaCBvciBucHJ1bnRpbWUuaAotICovCi0KLSNpbmNsdWRlICJucGFwaS5oIgot I2luY2x1ZGUgIm5wcnVudGltZS5oIgotI2luY2x1ZGUgIm5wZnVuY3Rpb25zLmgiCi0KLSNpZmRl ZiBYUF9VTklYCi0gICAgI2luY2x1ZGUgPFgxMS9YcmVzb3VyY2UuaD4KLQotICAgICN1bmRlZiBO b25lCi0gICAgI3VuZGVmIEFib3ZlCi0gICAgI3VuZGVmIEJlbG93Ci0gICAgI3VuZGVmIEF1dG8K LSAgICAjdW5kZWYgQ29tcGxleAotICAgICN1bmRlZiBTdGF0dXMKLSNlbmRpZgo= 113753 2011-11-05 07:46:53 -0700 2011-11-05 07:48:42 -0700 Reviewed by NOBODY (OOPS!) bug-45617-20111105154651.patch text/plain 3390 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogOTkzNTIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkOGQ0NjM0MDA2Y2ZhNDdh MTBjNTkyNDBkZmQ4ZmQ2N2M0MTBiNmQ4Li4wZDY5OGY2MTNhN2FjODA1Yzg1MjFiODNjYzRmZDE0 YjBiOTIyYmVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTEtMTEtMDUgIFNpbW9u IEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgogCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpCisKKyAgICAgICAgUmVtb3ZlZCBkdXBsaWNhdGVkIG5wcnVudGlt ZV9pbnRlcm5hbC5oIGZyb20gYmluZGluZ3MvdjgKKyAgICAgICAgaW4gZmF2b3VyIG9mIHRoZSBv bmUgZnJvbSBicmlkZ2UvLCB3aGljaCBoYXMgYSBmZXcgbW9yZQorICAgICAgICAjdW5kZWZzLgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTYxNwor CisgICAgICAgICogYmluZGluZ3MvdjgvbnBydW50aW1lX2ludGVybmFsLmg6IFJlbW92ZWQuCisg ICAgICAgICogVGFyZ2V0LnByaTogUmVtb3ZlZCBzdHJhbmdlIG9jY3VyZW5jZSBoZXJlLgorCisy MDExLTExLTA1ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KKwog ICAgICAgICBSZW1vdmUgZW1wdHkgYW5kIHVudXNlZCBkb20vUG9zaXRpb25DcmVhdGlvbkZ1bmN0 aW9ucy5oIGhlYWRlciBmaWxlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03MTU1MgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9UYXJnZXQucHJp IGIvU291cmNlL1dlYkNvcmUvVGFyZ2V0LnByaQppbmRleCA0MTA3NTAyMDM4OTkzYmI4ZmUwMDJh MGJlNmNmZjRlZjIwNDUyMTVmLi44N2Q1NGEyY2YwNzcyNDVhMTk4NjNiODYyODFjYTdiY2EzMTAx YTQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9UYXJnZXQucHJpCisrKyBiL1NvdXJjZS9X ZWJDb3JlL1RhcmdldC5wcmkKQEAgLTEzNTYsNyArMTM1Niw2IEBAIHY4IHsKICAgICAgICAgYmlu ZGluZ3MvdjgvRE9NV3JhcHBlcldvcmxkLmggXAogICAgICAgICBiaW5kaW5ncy92OC9Jc29sYXRl ZFdvcmxkLmggXAogICAgICAgICBiaW5kaW5ncy92OC9ucHJ1bnRpbWVfaW1wbC5oIFwKLSAgICAg ICAgYmluZGluZ3MvdjgvbnBydW50aW1lX2ludGVybmFsLmggXAogICAgICAgICBiaW5kaW5ncy92 OC9ucHJ1bnRpbWVfcHJpdi5oIFwKICAgICAgICAgYmluZGluZ3MvdjgvTlBWOE9iamVjdC5oIFwK ICAgICAgICAgYmluZGluZ3MvdjgvT3duSGFuZGxlLmggXApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvbnBydW50aW1lX2ludGVybmFsLmggYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9ucHJ1bnRpbWVfaW50ZXJuYWwuaApkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggNDBkNjM5ZjA2NGYzNGIzMjA4NzQ1M2YzMTNmN2U4MzIwMDU3YTg2Ni4uMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9ucHJ1bnRpbWVfaW50ZXJuYWwuaAorKysgL2Rldi9udWxsCkBAIC0xLDUzICswLDAg QEAKLS8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDcgQ29sbGFib3JhLCBMdGQuICBBbGwgcmlnaHRz IHJlc2VydmVkLgotICoKLSAqIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2Fu IHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKLSAqIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2Yg dGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKLSAqIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5 IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlcgotICogdmVyc2lvbiAyLjEgb2Yg dGhlIExpY2Vuc2UsIG9yIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCi0gKgot ICogVGhpcyBsaWJyYXJ5IGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBi ZSB1c2VmdWwsCi0gKiBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUg aW1wbGllZCB3YXJyYW50eSBvZgotICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEg UEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZSBHTlUKLSAqIExlc3NlciBHZW5lcmFsIFB1Ymxp YyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCi0gKgotICogWW91IHNob3VsZCBoYXZlIHJlY2Vp dmVkIGEgY29weSBvZiB0aGUgR05VIExlc3NlciBHZW5lcmFsIFB1YmxpYwotICogTGljZW5zZSBh bG9uZyB3aXRoIHRoaXMgbGlicmFyeTsgaWYgbm90LCB3cml0ZSB0byB0aGUgRnJlZQotICogU29m dHdhcmUgRm91bmRhdGlvbiwgSW5jLiwgNjc1IE1hc3MgQXZlLCBDYW1icmlkZ2UsIE1BIDAyMTM5 LCBVU0EuCi0gKgotICoKLSAqIFRoaXMgaXMgYSBpbnRlcm5hbCBpbmNsdWRlIGhlYWRlciBmb3Ig bnBhcGkuaAotICoKLSAqIFNvbWUgb2YgdGhlICNkZWZpbmVzIHdoaWNoIGFyZSBpbiBYMTEgaGVh ZGVycyBjb25mbGljdCB3aXRoIHR5cGUgYW5kIGVudW0KLSAqIG5hbWVzIGluIEphdmFTY3JpcHRD b3JlIGFuZCBXZWJDb3JlCi0gKiBUaGlzIGhlYWRlciAjdW5kZWZzIHRob3NlIGRlZmluZXMgdG8g Zml4IHRoZSBjb25mbGljdHMKLSAqIElmIHlvdSBuZWVkIHRvIGluY2x1ZGUgbnBhcGkuaCBvciBu cHJ1bnRpbWUuaCB3aGVuIGJ1aWxkaW5nIG9uIFgxMSwKLSAqIGluY2x1ZGUgdGhpcyBmaWxlIGlu c3RlYWQgb2YgdGhlIGFjdHVhbCBucGFwaS5oIG9yIG5wcnVudGltZS5oCi0gKi8KLQotI2luY2x1 ZGUgIm5wYXBpLmgiCi0jaW5jbHVkZSAibnBydW50aW1lLmgiCi0jaW5jbHVkZSAibnBmdW5jdGlv bnMuaCIKLQotI2lmZGVmIFhQX1VOSVgKLSAgICAjaW5jbHVkZSA8WDExL1hyZXNvdXJjZS5oPgot Ci0gICAgI3VuZGVmIE5vbmUKLSAgICAjdW5kZWYgQWJvdmUKLSAgICAjdW5kZWYgQmVsb3cKLSAg ICAjdW5kZWYgQXV0bwotICAgICN1bmRlZiBDb21wbGV4Ci0gICAgI3VuZGVmIFN0YXR1cwotICAg ICN1bmRlZiBDdXJzb3JTaGFwZQotICAgICN1bmRlZiBGb2N1c0luCi0gICAgI3VuZGVmIEZvY3Vz T3V0Ci0gICAgI3VuZGVmIEtleVByZXNzCi0gICAgI3VuZGVmIEtleVJlbGVhc2UKLSAgICAjdW5k ZWYgVW5zb3J0ZWQKLSAgICAjdW5kZWYgQm9vbAotICAgICN1bmRlZiBGb250Q2hhbmdlCi0gICAg I3VuZGVmIEdyYXlTY2FsZQotICAgICN1bmRlZiBOb3JtYWxTdGF0ZQotICAgICN1bmRlZiBUcnVl Ci0gICAgI3VuZGVmIEZhbHNlCi0jZW5kaWYK