45606 2010-09-11 18:45:09 -0700 Neglect unlikely hyphenation opportunities 2010-09-12 16:04:59 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mitz mitz oldest_to_newest 277813 0 mitz 2010-09-11 18:45:09 -0700 Neglect unlikely hyphenation opportunities 277819 1 67324 mitz 2010-09-11 18:57:57 -0700 Created attachment 67324 Patch 277820 2 67325 mitz 2010-09-11 19:01:13 -0700 Created attachment 67325 Patch 277903 3 67325 adele 2010-09-12 15:12:44 -0700 Comment on attachment 67325 Patch > + // If the maximum width available for the prefix before the hyphen is small, then it is very unlikely > + // that an hyphenation opportunity exists, so do bother to look for it. Did you mean "don't bother"? 277906 4 mitz 2010-09-12 15:53:41 -0700 (In reply to comment #3) > (From update of attachment 67325 [details]) > > + // If the maximum width available for the prefix before the hyphen is small, then it is very unlikely > > + // that an hyphenation opportunity exists, so do bother to look for it. > Did you mean "don't bother"? Yes :) 277908 5 mitz 2010-09-12 16:04:59 -0700 Committed <http://trac.webkit.org/changeset/67350>. 67324 2010-09-11 18:57:57 -0700 2010-09-11 18:59:40 -0700 Patch bug-45606-20100911185756.patch text/plain 2073 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NzMxMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDktMTEgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOZWds ZWN0IHVubGlrZWx5IGh5cGhlbmF0aW9uIG9wcG9ydHVuaXRpZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1NjA2CisKKyAgICAgICAgQXZvaWQgbG9v a2luZyBmb3IgaHlwaGVuYXRpb24gcG9pbnRzIGluIGFib3V0IDQwJSBvZiB0aGUgY2FzZXMgYXQg dGhlIGNvc3Qgb2YgbWlzc2luZyBhYm91dAorICAgICAgICAzJSBvZiB0aGUgaHlwaGVuYXRpb24g b3Bwb3J0dW5pdGllcy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlv dXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6dHJ5SHlwaGVuYXRpbmcpOiBCYWlsIG91dCBpZiB0 aGUgd2lkZXN0IHRoZSBwcmVmaXggYmVmb3JlIHRoZSBoeXBoZW4gY2FuIGJlIGlzIG5vIG1vcmUK KyAgICAgICAgdGhhbiA0LzUgdGhlIGZvbnQgc2l6ZS4KKwogMjAxMC0wOS0xMSAgU2ltb24gSGF1 c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4K SW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcAkocmV2 aXNpb24gNjczMDkpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzI4LDcgKzEzMjgsMTMgQEAgc3RhdGljIHZvaWQgdHJ5 SHlwaGVuYXRpbmcoUmVuZGVyVGV4dCogdAogICAgIGNvbnN0IEF0b21pY1N0cmluZyYgaHlwaGVu U3RyaW5nID0gdGV4dC0+c3R5bGUoKS0+aHlwaGVuU3RyaW5nKCk7CiAgICAgaW50IGh5cGhlbldp ZHRoID0gZm9udC53aWR0aChUZXh0UnVuKGh5cGhlblN0cmluZy5jaGFyYWN0ZXJzKCksIGh5cGhl blN0cmluZy5sZW5ndGgoKSkpOwogCi0gICAgdW5zaWduZWQgcHJlZml4TGVuZ3RoID0gZm9udC5v ZmZzZXRGb3JQb3NpdGlvbihUZXh0UnVuKHRleHQtPmNoYXJhY3RlcnMoKSArIGxhc3RTcGFjZSwg cG9zIC0gbGFzdFNwYWNlLCAhY29sbGFwc2VXaGl0ZVNwYWNlLCB4UG9zICsgbGFzdFNwYWNlV29y ZFNwYWNpbmcpLCBhdmFpbGFibGVXaWR0aCAtIHhQb3MgLSBoeXBoZW5XaWR0aCAtIGxhc3RTcGFj ZVdvcmRTcGFjaW5nLCBmYWxzZSk7CisgICAgaW50IG1heFByZWZpeFdpZHRoID0gYXZhaWxhYmxl V2lkdGggLSB4UG9zIC0gaHlwaGVuV2lkdGggLSBsYXN0U3BhY2VXb3JkU3BhY2luZzsKKyAgICAv LyBJZiB0aGUgbWF4aW11bSB3aWR0aCBhdmFpbGFibGUgZm9yIHRoZSBwcmVmaXggYmVmb3JlIHRo ZSBoeXBoZW4gaXMgc21hbGwsIHRoZW4gaXQgaXMgdmVyeSB1bmxpa2VseQorICAgIC8vIHRoYXQg YW4gaHlwaGVuYXRpb24gb3Bwb3J0dW5pdHkgZXhpc3RzLCBzbyBkbyBib3RoZXIgdG8gbG9vayBm b3IgaXQuCisgICAgaWYgKG1heFByZWZpeFdpZHRoIDw9IGZvbnQucGl4ZWxTaXplKCkgKiA1IC8g NCkKKyAgICAgICAgcmV0dXJuOworCisgICAgdW5zaWduZWQgcHJlZml4TGVuZ3RoID0gZm9udC5v ZmZzZXRGb3JQb3NpdGlvbihUZXh0UnVuKHRleHQtPmNoYXJhY3RlcnMoKSArIGxhc3RTcGFjZSwg cG9zIC0gbGFzdFNwYWNlLCAhY29sbGFwc2VXaGl0ZVNwYWNlLCB4UG9zICsgbGFzdFNwYWNlV29y ZFNwYWNpbmcpLCBtYXhQcmVmaXhXaWR0aCwgZmFsc2UpOwogICAgIGlmICghcHJlZml4TGVuZ3Ro KQogICAgICAgICByZXR1cm47CiAK 67325 2010-09-11 19:01:13 -0700 2010-09-12 16:00:47 -0700 Patch 45606_r2.diff text/plain 2073 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NzMxMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDktMTEgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOZWds ZWN0IHVubGlrZWx5IGh5cGhlbmF0aW9uIG9wcG9ydHVuaXRpZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1NjA2CisKKyAgICAgICAgQXZvaWQgbG9v a2luZyBmb3IgaHlwaGVuYXRpb24gcG9pbnRzIGluIGFib3V0IDQwJSBvZiB0aGUgY2FzZXMgYXQg dGhlIGNvc3Qgb2YgbWlzc2luZyBhYm91dAorICAgICAgICAzJSBvZiB0aGUgaHlwaGVuYXRpb24g b3Bwb3J0dW5pdGllcy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlv dXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6dHJ5SHlwaGVuYXRpbmcpOiBCYWlsIG91dCBpZiB0 aGUgd2lkZXN0IHRoZSBwcmVmaXggYmVmb3JlIHRoZSBoeXBoZW4gY2FuIGJlIGlzIG5vIG1vcmUK KyAgICAgICAgdGhhbiA1LzQgdGhlIGZvbnQgc2l6ZS4KKwogMjAxMC0wOS0xMSAgU2ltb24gSGF1 c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4K SW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcAkocmV2 aXNpb24gNjczMDkpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzI4LDcgKzEzMjgsMTMgQEAgc3RhdGljIHZvaWQgdHJ5 SHlwaGVuYXRpbmcoUmVuZGVyVGV4dCogdAogICAgIGNvbnN0IEF0b21pY1N0cmluZyYgaHlwaGVu U3RyaW5nID0gdGV4dC0+c3R5bGUoKS0+aHlwaGVuU3RyaW5nKCk7CiAgICAgaW50IGh5cGhlbldp ZHRoID0gZm9udC53aWR0aChUZXh0UnVuKGh5cGhlblN0cmluZy5jaGFyYWN0ZXJzKCksIGh5cGhl blN0cmluZy5sZW5ndGgoKSkpOwogCi0gICAgdW5zaWduZWQgcHJlZml4TGVuZ3RoID0gZm9udC5v ZmZzZXRGb3JQb3NpdGlvbihUZXh0UnVuKHRleHQtPmNoYXJhY3RlcnMoKSArIGxhc3RTcGFjZSwg cG9zIC0gbGFzdFNwYWNlLCAhY29sbGFwc2VXaGl0ZVNwYWNlLCB4UG9zICsgbGFzdFNwYWNlV29y ZFNwYWNpbmcpLCBhdmFpbGFibGVXaWR0aCAtIHhQb3MgLSBoeXBoZW5XaWR0aCAtIGxhc3RTcGFj ZVdvcmRTcGFjaW5nLCBmYWxzZSk7CisgICAgaW50IG1heFByZWZpeFdpZHRoID0gYXZhaWxhYmxl V2lkdGggLSB4UG9zIC0gaHlwaGVuV2lkdGggLSBsYXN0U3BhY2VXb3JkU3BhY2luZzsKKyAgICAv LyBJZiB0aGUgbWF4aW11bSB3aWR0aCBhdmFpbGFibGUgZm9yIHRoZSBwcmVmaXggYmVmb3JlIHRo ZSBoeXBoZW4gaXMgc21hbGwsIHRoZW4gaXQgaXMgdmVyeSB1bmxpa2VseQorICAgIC8vIHRoYXQg YW4gaHlwaGVuYXRpb24gb3Bwb3J0dW5pdHkgZXhpc3RzLCBzbyBkbyBib3RoZXIgdG8gbG9vayBm b3IgaXQuCisgICAgaWYgKG1heFByZWZpeFdpZHRoIDw9IGZvbnQucGl4ZWxTaXplKCkgKiA1IC8g NCkKKyAgICAgICAgcmV0dXJuOworCisgICAgdW5zaWduZWQgcHJlZml4TGVuZ3RoID0gZm9udC5v ZmZzZXRGb3JQb3NpdGlvbihUZXh0UnVuKHRleHQtPmNoYXJhY3RlcnMoKSArIGxhc3RTcGFjZSwg cG9zIC0gbGFzdFNwYWNlLCAhY29sbGFwc2VXaGl0ZVNwYWNlLCB4UG9zICsgbGFzdFNwYWNlV29y ZFNwYWNpbmcpLCBtYXhQcmVmaXhXaWR0aCwgZmFsc2UpOwogICAgIGlmICghcHJlZml4TGVuZ3Ro KQogICAgICAgICByZXR1cm47CiAK