45602 2010-09-11 15:31:39 -0700 Remove unneeded Empty Queue messages 2010-09-11 16:25:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric abarth commit-queue mihaip oldest_to_newest 277782 0 eric 2010-09-11 15:31:39 -0700 Remove unneeded Empty Queue messages 277783 1 67316 eric 2010-09-11 15:35:53 -0700 Created attachment 67316 Patch 277784 2 eric 2010-09-11 15:37:14 -0700 We might have to make http://queues.webkit.org/queue-status/commit-queue show the "last_status_date" like / does. 277787 3 67316 mihaip 2010-09-11 15:51:50 -0700 Comment on attachment 67316 Patch BTW, /gc has been timing out based on the App Engine logs. 277788 4 67316 commit-queue 2010-09-11 15:53:27 -0700 Comment on attachment 67316 Patch Rejecting patch 67316 from review queue. mihaip@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 277789 5 67316 commit-queue 2010-09-11 15:55:33 -0700 Comment on attachment 67316 Patch Rejecting patch 67316 from commit-queue. mihaip@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 277791 6 67316 eric 2010-09-11 15:59:18 -0700 Comment on attachment 67316 Patch :) 277792 7 67316 abarth 2010-09-11 16:05:38 -0700 Comment on attachment 67316 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67316&action=prettypatch OMG 277798 8 67316 commit-queue 2010-09-11 16:25:41 -0700 Comment on attachment 67316 Patch Clearing flags on attachment: 67316 Committed r67310: <http://trac.webkit.org/changeset/67310> 277799 9 commit-queue 2010-09-11 16:25:49 -0700 All reviewed patches have been landed. Closing bug. 67316 2010-09-11 15:35:53 -0700 2010-09-11 16:25:41 -0700 Patch bug-45602-20100911153551.patch text/plain 2082 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA4OGQxMTJjNTUwMmJmZDk0MTc1OWE4YThlOWQ0ZTZiMzkyOTM4NzZlLi5hMDlkOGY2 ZmI2NWEwNmQ1MTNhNGI4OGI5YmUxOWJhMTRlNjhmMzBjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAK KzIwMTAtMDktMTEgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSB1bm5lZWRlZCBFbXB0 eSBRdWV1ZSBtZXNzYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDU2MDIKKworICAgICAgICBXZSBhbHJlYWR5IGhhdmUgYSAvZ2Mgam9iIHRvIGRl bGV0ZSB0aGVzZS4KKyAgICAgICAgcmVjZW50c3RhdHVzLnB5IGlzIGFscmVhZHkgc21hcnQgZW5v dWdoIHRvIHVzZSB0aGUKKyAgICAgICAgbW9zdCByZWNlbnQgb2YgdGhlIHdvcmtpdGVtcyBsYXN0 IHVwZGF0ZSBvciB0aGUgbW9zdCByZWNlbnQgc3RhdHVzLAorICAgICAgICBzbyByZW1vdmluZyB0 aGVzZSBzaG91bGQgbm90IGNoYW5nZSB0aGUgX2xhc3Rfc3RhdHVzX2RhdGUoKSByZXR1cm4KKyAg ICAgICAgdmFsdWUgbW9yZSB0aGFuIGEgZmV3IG1pbGxpc2Vjb25kcy4KKworICAgICAgICBUaGVz ZSBtZXNzYWdlcyBqdXN0IHNwYW0gdGhlIHJlY2VudCBzdGF0dXMgbG9nLgorCisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weToKKwogMjAxMC0wOS0xMSAg TWloYWkgUGFycGFyaXRhICA8bWloYWlwQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRw eS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv dG9vbC9jb21tYW5kcy9xdWV1ZXMucHkKaW5kZXggMTI3ZTdlZmQ2N2MwNjczNDIxNDcxZmYwODZk MTdiZjljMjk4N2IzNS4uMjQ4ZDFlNTZlMDM3MDdhYTkzZmJlM2Y4N2JjZjllMWYzMzQ0YzZkYiAx MDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1 ZXVlcy5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMv cXVldWVzLnB5CkBAIC0xOTQsNyArMTk0LDYgQEAgY2xhc3MgQ29tbWl0UXVldWUoQWJzdHJhY3RQ YXRjaFF1ZXVlLCBTdGVwU2VxdWVuY2VFcnJvckhhbmRsZXIpOgogICAgICAgICBwYXRjaGVzID0g c29ydGVkKHBhdGNoZXMsIHNlbGYuX3BhdGNoX2NtcCkKICAgICAgICAgc2VsZi5fdXBkYXRlX3dv cmtfaXRlbXMoW3BhdGNoLmlkKCkgZm9yIHBhdGNoIGluIHBhdGNoZXNdKQogICAgICAgICBpZiBu b3QgcGF0Y2hlczoKLSAgICAgICAgICAgIHNlbGYuX3VwZGF0ZV9zdGF0dXMoIkVtcHR5IHF1ZXVl IikKICAgICAgICAgICAgIHJldHVybiBOb25lCiAgICAgICAgICMgT25seSBib3RoZXIgbG9nZ2lu ZyBpZiB3ZSBoYXZlIHBhdGNoZXMgaW4gdGhlIHF1ZXVlLgogICAgICAgICBzZWxmLmxvZ19wcm9n cmVzcyhbcGF0Y2guaWQoKSBmb3IgcGF0Y2ggaW4gcGF0Y2hlc10pCkBAIC0zNzksNyArMzc4LDYg QEAgY2xhc3MgQWJzdHJhY3RSZXZpZXdRdWV1ZShBYnN0cmFjdFBhdGNoUXVldWUsIFBlcnNpc3Rl bnRQYXRjaENvbGxlY3Rpb25EZWxlZ2F0ZSwKICAgICAgICAgcGF0Y2hfaWQgPSBzZWxmLl9wYXRj aGVzLm5leHQoKQogICAgICAgICBpZiBwYXRjaF9pZDoKICAgICAgICAgICAgIHJldHVybiBzZWxm LnRvb2wuYnVncy5mZXRjaF9hdHRhY2htZW50KHBhdGNoX2lkKQotICAgICAgICBzZWxmLl91cGRh dGVfc3RhdHVzKCJFbXB0eSBxdWV1ZSIpCiAKICAgICBkZWYgc2hvdWxkX3Byb2NlZWRfd2l0aF93 b3JrX2l0ZW0oc2VsZiwgcGF0Y2gpOgogICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9y LCAic3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCIK