4560 2005-08-21 12:38:57 -0700 Markup in <title> prevents decoder from looking for a charset 2005-09-01 09:13:46 -0700 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac All VERIFIED FIXED P2 Normal --- 1 ap darin oldest_to_newest 17052 0 ap 2005-08-21 12:38:57 -0700 Currently, Decoder::decode() stops looking for a charset definition as soon as it sees a tag forbidden in <title>. However, it sometimes happens that HTML markup gets into <title>. Other parts of WebKit handle tags in <title> correctly, so it's only Decoder that doesn't like this. Firefox handles such pages just fine. 17053 1 3493 ap 2005-08-21 12:39:24 -0700 Created attachment 3493 Test case 17054 2 3494 ap 2005-08-21 12:44:04 -0700 Created attachment 3494 Proposed patch 17057 3 3494 darin 2005-08-21 15:20:52 -0700 Comment on attachment 3494 Proposed patch I would call the variable just "inTitle" rather than "areInTitle", but otherwise looks good. r=me 17087 4 ap 2005-08-21 21:43:27 -0700 The reason why I didn't call it "inTitle" is that "in", "out" and "io" are prefixes widely used in Mac OS APIs to distinguish input and output parameters. 18020 5 darin 2005-08-31 01:09:56 -0700 Understood, but I don't think that convention is relevant in a large cross-platform code base that never uses that convention at all. 18022 6 darin 2005-08-31 01:16:51 -0700 Maybe withinTitle would be best. (Sorry I didn't land this earlier. It was marked UNCONFIRMED so it was not showing up in my query.) 18023 7 ap 2005-08-31 01:19:59 -0700 Sure, I really have no problem with most coding conventions :) And withinTitle looks like the best variant. Would you like me to update the patch? 18117 8 darin 2005-08-31 10:25:13 -0700 It's would be fine, but I can also just update the name when landing the patch. 3493 2005-08-21 12:39:24 -0700 2005-08-21 12:39:24 -0700 Test case tagintitle.html text/html 494 ap PGh0bWw+CiA8aGVhZD4KIDx0aXRsZT703MfJIDxiPjxmb250IGNvbG9yPXJlZD5bUl08L2ZvbnQ+ PC9iPiDXICZsdDt0aXRsZSZndDs8L3RpdGxlPgogPGxpbmsgcmVsPSJzaG9ydGN1dCBpY29uIiBo cmVmPS9mYXZpY29uLmljbyB0eXBlPWltYWdlL3gtaWNvbj4KIDxtZXRhIGh0dHAtZXF1aXY9IkNv bnRlbnQtVHlwZSIgY29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PUtPSTgtUiI+CiA8L2hlYWQ+ Cgo8Ym9keT4KICA8cD5UaGlzIHRlc3QgY2hlY2tzIHRoYXQgV2ViS2l0IGRvZXNuJ3Qgc3RvcCBs b29raW5nIGZvciBhIGNoYXJzZXQgZGVmaW5lZCBpbiBhbiBIVFRQLUVRVUlWIG1ldGEgd2hlbiBp dCBlbmNvdW50ZXJzIGEgdGFnIHdpdGhpbiAmbHQ7dGl0bGUmZ3Q7LjwvcD4KICA8cD5UaGUgZmly c3QgbGV0dGVyIHNob3VsZCBsb29rIGxpa2UgYSBMYXRpbiAiSyIgaGVyZTo8L3A+CiAgPHA+CiAg 68HLwdEgx8HEz9PU2CEKICA8L3A+CjwvYm9keT4KPC9odG1sPgo= 3494 2005-08-21 12:44:04 -0700 2005-08-21 15:20:52 -0700 Proposed patch tagsintitle.diff text/plain 1811 ap SW5kZXg6IGRlY29kZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3Jl L2todG1sL21pc2MvZGVjb2Rlci5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNDAKZGlmZiAt cCAtdSAtcjEuNDAgZGVjb2Rlci5jcHAKLS0tIGRlY29kZXIuY3BwCTE0IEF1ZyAyMDA1IDA4OjQ3 OjEzIC0wMDAwCTEuNDAKKysrIGRlY29kZXIuY3BwCTIxIEF1ZyAyMDA1IDE5OjQzOjQ3IC0wMDAw CkBAIC00ODMsNiArNDgzLDExIEBAIFFTdHJpbmcgRGVjb2Rlcjo6ZGVjb2RlKGNvbnN0IGNoYXIg KmRhdGEKICAgICAgICAgICAgIC8vIGlzIHNlZW4sIHJhdGhlciB3aGVuIDwvaGVhZD4gaXMgc2Vl biwgYmVjYXVzZSB0aGF0IG1vcmUgY2xvc2VseQogICAgICAgICAgICAgLy8gbWF0Y2hlcyBiZWhh dmlvciBpbiBvdGhlciBicm93c2VyczsgbW9yZSBkZXRhaWxzIGluCiAgICAgICAgICAgICAvLyA8 aHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTkwPi4KKyAg ICAgICAgICAgIAorICAgICAgICAgICAgLy8gQWRkaXRpb25hbGx5LCB3ZSBwZXJtaXQgdGFncyBp biA8dGl0bGU+OyBzZWUKKyAgICAgICAgICAgIC8vIDxodHRwOi8vYnVnemlsbGEub3BlbmRhcndp bi5vcmcvc2hvd19idWcuY2dpP2lkPTQ1NjA+LgorICAgICAgICAgICAgCisgICAgICAgICAgICBi b29sIGFyZUluVGl0bGUgPSBmYWxzZTsKIAogI2lmIEFQUExFX0NIQU5HRVMKICAgICAgICAgICAg IGNvbnN0IGNoYXIgKnB0ciA9IGJ1ZmZlci5sYXRpbjEoKTsKQEAgLTUzNSw2ICs1NDAsMTAgQEAg UVN0cmluZyBEZWNvZGVyOjpkZWNvZGUoY29uc3QgY2hhciAqZGF0YQogICAgICAgICAgICAgICAg ICAgICB9CiAJCSAgICB0bXBbbGVuXSA9IDA7CiAgICAgICAgICAgICAgICAgICAgIEF0b21pY1N0 cmluZyB0YWcodG1wKTsKKyAgICAgICAgICAgICAgICAgICAgCisgICAgICAgICAgICAgICAgICAg IGlmICh0YWcgPT0gdGl0bGVUYWcpCisgICAgICAgICAgICAgICAgICAgICAgICBhcmVJblRpdGxl ID0gIWVuZDsKKyAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgIGlmICgh ZW5kICYmIHRhZyA9PSBtZXRhVGFnKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICAvLyBmb3Vu ZCBhIG1ldGEgdGFnLi4uCiAgICAgICAgICAgICAgICAgICAgICAgICAvL3B0ciArPSA1OwpAQCAt NTc3LDcgKzU4Niw3IEBAIFFTdHJpbmcgRGVjb2Rlcjo6ZGVjb2RlKGNvbnN0IGNoYXIgKmRhdGEK IAkJICAgIH0gZWxzZSBpZiAodGFnICE9IHNjcmlwdFRhZyAmJiB0YWcgIT0gbm9zY3JpcHRUYWcg JiYgdGFnICE9IHN0eWxlVGFnICYmCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdGFn ICE9IGxpbmtUYWcgJiYgdGFnICE9IG1ldGFUYWcgJiYgdGFnICE9IG9iamVjdFRhZyAmJgogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRhZyAhPSB0aXRsZVRhZyAmJiB0YWcgIT0gYmFz ZVRhZyAmJiAKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZW5kIHx8IHRhZyAhPSBo dG1sVGFnKSAmJgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChlbmQgfHwgdGFnICE9 IGh0bWxUYWcpICYmICFhcmVJblRpdGxlICYmCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgKHRhZyAhPSBoZWFkVGFnKSAmJiBpc2FscGhhKHRtcFswXSkpIHsKICAgICAgICAgICAgICAg ICAgICAgICAgIGJvZHkgPSB0cnVlOwogI2lmZGVmIERFQ09ERV9ERUJVRwo=