45591 2010-09-11 09:37:07 -0700 Add WTF::equal for StringImpl and char* with explicit length 2022-07-25 17:33:13 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) All All RESOLVED CONFIGURATION CHANGED P2 Normal --- 0 paroga webkit-unassigned ahmad.saleem792 ap bfulgham rniwa oldest_to_newest 277725 0 paroga 2010-09-11 09:37:07 -0700 see patch 277726 1 67300 paroga 2010-09-11 09:43:06 -0700 Created attachment 67300 Patch I'll use this function for performance improvements of XMLParser (bug 43085). 277859 2 67300 paroga 2010-09-12 05:28:18 -0700 Comment on attachment 67300 Patch Maybe I'll move the function into AtomicString for inlineing. 1886567 3 ahmad.saleem792 2022-07-25 13:33:17 -0700 Attached patch was modifying "equalIgnoringCase" - which was removed in below commit: https://github.com/WebKit/WebKit/commit/507aa34586fdcf0b9a5ea433c2402f295a717da8 Further - "createStrippingNullCharactersSlowCase" - it had only one commit below: https://github.com/WebKit/WebKit/commit/663efc5d78ea61ca1b418dbd67f3cd91676910a2 but even it was removed here: https://github.com/WebKit/WebKit/commit/539e5655d6da61859c0f9448691eea1892cae8bc So I don't think this patch can be applied to Github main / trunk / master branch since it has been changed drastically. Can someone comment whether it is something needed out of this or this can be marked as "RESOLVED WONTFIX"? Thanks! 1886634 4 ap 2022-07-25 17:33:13 -0700 We have such functions now. WTF_EXPORT_PRIVATE bool equal(const StringImpl*, const LChar*, unsigned); WTF_EXPORT_PRIVATE bool equal(const StringImpl*, const UChar*, unsigned); ALWAYS_INLINE bool equal(const StringImpl* a, ASCIILiteral b) { return equal(a, b.characters8(), b.length()); } inline bool equal(const StringImpl* a, const char* b, unsigned length) { return equal(a, reinterpret_cast<const LChar*>(b), length); } 67300 2010-09-11 09:43:06 -0700 2010-09-12 05:28:18 -0700 Patch 0001-WTF_equal.patch text/plain 3658 paroga ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBiMWQ3MWE4Li5iZTcyNDhiIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTAtMDktMTEgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHBhcm9nYS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIFdURjo6 ZXF1YWwgZm9yIFN0cmluZ0ltcGwgYW5kIGNoYXIqIHdpdGggZXhwbGljaXQgbGVuZ3RoCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTU5MQorCisgICAg ICAgIEFsc28gZml4IHN0eWxlIGlzc3VlcyBpbiBTdHJpbmdJbXBsLmNwcC4KKworICAgICAgICAq IHd0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwOgorICAgICAgICAoV1RGOjplcXVhbElnbm9yaW5nQ2Fz ZSk6CisgICAgICAgIChXVEY6OmVxdWFsKToKKyAgICAgICAgKFdURjo6U3RyaW5nSW1wbDo6Y3Jl YXRlU3RyaXBwaW5nTnVsbENoYXJhY3RlcnNTbG93Q2FzZSk6CisgICAgICAgIChXVEY6OlN0cmlu Z0ltcGw6OmFkb3B0KToKKyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdJbXBsLmg6CisKIDIwMTAt MDktMTEgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHBhcm9nYS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93 dGYvdGV4dC9TdHJpbmdJbXBsLmNwcCBiL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1N0cmluZ0lt cGwuY3BwCmluZGV4IGE2Njc1MjUuLmFmMjhiOGYgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3Jl L3d0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwCisrKyBiL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1N0 cmluZ0ltcGwuY3BwCkBAIC00NzQsNyArNDc0LDcgQEAgYm9vbCBlcXVhbElnbm9yaW5nQ2FzZShj b25zdCBVQ2hhciogYSwgY29uc3QgY2hhciogYiwgdW5zaWduZWQgbGVuZ3RoKQogc3RhdGljIGlu bGluZSBib29sIGVxdWFsSWdub3JpbmdDYXNlKGNvbnN0IFVDaGFyKiBhLCBjb25zdCBVQ2hhciog YiwgaW50IGxlbmd0aCkKIHsKICAgICBBU1NFUlQobGVuZ3RoID49IDApOwotICAgIHJldHVybiB1 bWVtY2FzZWNtcChhLCBiLCBsZW5ndGgpID09IDA7CisgICAgcmV0dXJuICF1bWVtY2FzZWNtcChh LCBiLCBsZW5ndGgpOwogfQogCiBpbnQgY29kZVBvaW50Q29tcGFyZShjb25zdCBTdHJpbmdJbXBs KiBzMSwgY29uc3QgU3RyaW5nSW1wbCogczIpCkBAIC05MTUsNyArOTE1LDcgQEAgYm9vbCBlcXVh bChjb25zdCBTdHJpbmdJbXBsKiBhLCBjb25zdCBjaGFyKiBiKQogICAgIGlmICghYSkKICAgICAg ICAgcmV0dXJuICFiOwogICAgIGlmICghYikKLSAgICAgICAgcmV0dXJuICFhOworICAgICAgICBy ZXR1cm4gZmFsc2U7CiAKICAgICB1bnNpZ25lZCBsZW5ndGggPSBhLT5sZW5ndGgoKTsKICAgICBj b25zdCBVQ2hhciogYXMgPSBhLT5jaGFyYWN0ZXJzKCk7CkBAIC05MzAsNiArOTMwLDIzIEBAIGJv b2wgZXF1YWwoY29uc3QgU3RyaW5nSW1wbCogYSwgY29uc3QgY2hhciogYikKICAgICByZXR1cm4g IWJbbGVuZ3RoXTsKIH0KIAorYm9vbCBlcXVhbChjb25zdCBTdHJpbmdJbXBsKiBhLCBjb25zdCBj aGFyKiBiLCB1bnNpZ25lZCBsZW5ndGgpCit7CisgICAgaWYgKCFhKQorICAgICAgICByZXR1cm4g IWI7CisgICAgaWYgKCFiKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgaWYgKGEtPmxlbmd0 aCgpICE9IGxlbmd0aCkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgY29uc3QgVUNoYXIq IGFzID0gYS0+Y2hhcmFjdGVycygpOworICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgIT0gbGVu Z3RoOyArK2kpCisgICAgICAgIGlmIChhc1tpXSAhPSBiW2ldKQorICAgICAgICAgICAgcmV0dXJu IGZhbHNlOworCisgICAgcmV0dXJuIHRydWU7Cit9CisKIGJvb2wgZXF1YWxJZ25vcmluZ0Nhc2Uo U3RyaW5nSW1wbCogYSwgU3RyaW5nSW1wbCogYikKIHsKICAgICByZXR1cm4gQ2FzZUZvbGRpbmdI YXNoOjplcXVhbChhLCBiKTsKQEAgLTk0MCw3ICs5NTcsNyBAQCBib29sIGVxdWFsSWdub3JpbmdD YXNlKFN0cmluZ0ltcGwqIGEsIGNvbnN0IGNoYXIqIGIpCiAgICAgaWYgKCFhKQogICAgICAgICBy ZXR1cm4gIWI7CiAgICAgaWYgKCFiKQotICAgICAgICByZXR1cm4gIWE7CisgICAgICAgIHJldHVy biBmYWxzZTsKIAogICAgIHVuc2lnbmVkIGxlbmd0aCA9IGEtPmxlbmd0aCgpOwogICAgIGNvbnN0 IFVDaGFyKiBhcyA9IGEtPmNoYXJhY3RlcnMoKTsKQEAgLTEwMDIsNyArMTAxOSw3IEBAIFBhc3NS ZWZQdHI8U3RyaW5nSW1wbD4gU3RyaW5nSW1wbDo6Y3JlYXRlU3RyaXBwaW5nTnVsbENoYXJhY3Rl cnNTbG93Q2FzZShjb25zdCBVCiAgICAgICAgIGlmIChpbnQgYyA9IGNoYXJhY3RlcnNbaV0pCiAg ICAgICAgICAgICBzdHJpcHBlZENvcHlbc3RyaXBwZWRMZW5ndGgrK10gPSBjOwogICAgIH0KLSAg ICBBU1NFUlQoc3RyaXBwZWRMZW5ndGggPCBsZW5ndGgpOyAgLy8gT25seSB0YWtlIHRoZSBzbG93 IGNhc2Ugd2hlbiBzdHJpcHBpbmcuCisgICAgQVNTRVJUKHN0cmlwcGVkTGVuZ3RoIDwgbGVuZ3Ro KTsgLy8gT25seSB0YWtlIHRoZSBzbG93IGNhc2Ugd2hlbiBzdHJpcHBpbmcuCiAgICAgc3RyaXBw ZWRDb3B5LnNocmluayhzdHJpcHBlZExlbmd0aCk7CiAgICAgcmV0dXJuIGFkb3B0KHN0cmlwcGVk Q29weSk7CiB9CkBAIC0xMDEwLDcgKzEwMjcsNyBAQCBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IFN0 cmluZ0ltcGw6OmNyZWF0ZVN0cmlwcGluZ051bGxDaGFyYWN0ZXJzU2xvd0Nhc2UoY29uc3QgVQog UGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBTdHJpbmdJbXBsOjphZG9wdChTdHJpbmdCdWZmZXImIGJ1 ZmZlcikKIHsKICAgICB1bnNpZ25lZCBsZW5ndGggPSBidWZmZXIubGVuZ3RoKCk7Ci0gICAgaWYg KGxlbmd0aCA9PSAwKQorICAgIGlmICghbGVuZ3RoKQogICAgICAgICByZXR1cm4gZW1wdHkoKTsK ICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFN0cmluZ0ltcGwoYnVmZmVyLnJlbGVhc2UoKSwgbGVu Z3RoKSk7CiB9CmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJbXBs LmggYi9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJbXBsLmgKaW5kZXggY2VjMGI4MC4u MmQ4M2E5YyAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvU3RyaW5nSW1wbC5o CisrKyBiL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaApAQCAtMzM3LDYgKzMz Nyw3IEBAIHByaXZhdGU6CiAKIGJvb2wgZXF1YWwoY29uc3QgU3RyaW5nSW1wbCosIGNvbnN0IFN0 cmluZ0ltcGwqKTsKIGJvb2wgZXF1YWwoY29uc3QgU3RyaW5nSW1wbCosIGNvbnN0IGNoYXIqKTsK K2Jvb2wgZXF1YWwoY29uc3QgU3RyaW5nSW1wbCosIGNvbnN0IGNoYXIqLCB1bnNpZ25lZCk7CiBp bmxpbmUgYm9vbCBlcXVhbChjb25zdCBjaGFyKiBhLCBTdHJpbmdJbXBsKiBiKSB7IHJldHVybiBl cXVhbChiLCBhKTsgfQogCiBib29sIGVxdWFsSWdub3JpbmdDYXNlKFN0cmluZ0ltcGwqLCBTdHJp bmdJbXBsKik7Cg==