45574 2010-09-10 16:28:55 -0700 Pseudostyle resolution corrupts cached child index values 2010-09-10 19:17:44 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mitz mitz abarth cdn cfleizach eric hyatt webkit.review.bot oldest_to_newest 277526 0 mitz 2010-09-10 16:28:55 -0700 Pseudostyle resolution corrupts cached child index values 277541 1 67264 mitz 2010-09-10 16:53:23 -0700 Created attachment 67264 Patch 277574 2 mitz 2010-09-10 17:53:28 -0700 Committed r67255: <http://trac.webkit.org/changeset/67255> 277607 3 webkit.review.bot 2010-09-10 19:15:30 -0700 http://trac.webkit.org/changeset/67255 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/67253 http://trac.webkit.org/changeset/67254 http://trac.webkit.org/changeset/67255 277610 4 cfleizach 2010-09-10 19:17:44 -0700 It might be beneficial to ASSERT after getCachedPseudoStyle() is called in these two cases, in case there are other scenarios. 67264 2010-09-10 16:53:23 -0700 2010-09-10 17:20:49 -0700 Patch bug-45574-20100910165321.patch text/plain 5513 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NzI0NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjkgQEAKKzIwMTAtMDktMTAgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQc2V1 ZG9zdHlsZSByZXNvbHV0aW9uIGNvcnJ1cHRzIGNhY2hlZCBjaGlsZCBpbmRleCB2YWx1ZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1NTc0CisKKyAg ICAgICAgQ292ZXJlZCBieSBmYXN0L2RvbS9maXJzdGxpbmUtZml4ZWQtY3Jhc2guaHRtbCBhbmQg ZmFzdC9kb20vZmlyc3RsZXR0ZXItdGFibGVjZWxsLWNyYXNoLmh0bWwuCisKKyAgICAgICAgUmVu ZGVyQmxvY2s6OnVwZGF0ZUZpcnN0TGV0dGVyKCkgY2FsbHMgZ2V0Q2FjaGVkUHNldWRvU3R5bGUo KSBwYXNzaW5nIGFzIHRoZSBwYXJlbnQgc3R5bGUgdGhlCisgICAgICAgIHN0eWxlIG9mIHRoZSBw YXJlbnQgb2YgdGhlIGZpcnN0IGxldHRlciwgd2hpY2ggaXMgbm90IGFsd2F5cyB0aGUgcGFyZW50 IG9mIHRoZSBlbGVtZW50IGZvcgorICAgICAgICB3aGljaCB3ZSBhcmUgZ2V0dGluZyA6Zmlyc3Qt bGV0dGVyIHN0eWxlLiBBcyBhIHJlc3VsdCwgc3R5bGUgcmVzb2x1dGlvbiBjYWNoZXMgY2hpbGRJ bmRleCB2YWx1ZXMKKyAgICAgICAgaW4gdGhlIHdyb25nIGVsZW1lbnTigJlzIHN0eWxlLgorCisg ICAgICAgICogY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NT U3R5bGVTZWxlY3Rvcjo6cHNldWRvU3R5bGVGb3JFbGVtZW50KTogQ3JlYXRlIHRoZSBuZXcgc3R5 bGUgYW5kIGluaGVyaXQgZnJvbQorICAgICAgICB0aGUgcGFyZW50IHN0eWxlIGJlZm9yZSBtYXRj aGluZyBydWxlcywgdG8gYXZvaWQgY29ycnVwdGluZyB0aGUgcGFyZW50IHN0eWxlIGl0c2VsZi4K KyAgICAgICAgKFdlYkNvcmU6OkNTU1N0eWxlU2VsZWN0b3I6OmNoZWNrU2VsZWN0b3IpOiBBbHdh eXMgcGFzcyB0aGUgZWxlbWVudOKAmXMgcGFyZW50IHN0eWxlIGFzCisgICAgICAgIHRoZSBwYXJl bnQgc3R5bGUgaGVyZS4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OnVwZGF0ZUZpcnN0TGV0dGVyKTogUmVtb3ZlZCB0 aGUgbnVsbCBjaGVjayB0aGF0IHdhcyBhZGRlZAorICAgICAgICBpbiByNjcxODMuCisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJCbG9jazo6ZmluZE5leHRMaW5lQnJlYWspOiBSZW1vdmVkIHRoZSBudWxsIGNoZWNr IHRoYXQgd2FzIGFkZGVkCisgICAgICAgIGluIHI2NzE4NC4KKwogMjAxMC0wOS0xMDkgIFBldGVy IEthc3RpbmcgIDxwa2FzdGluZ0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh cmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAJKHJldmlzaW9uIDY3MjA0 KQorKysgV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTE1MDMsOCArMTUwMywxMCBAQCBQYXNzUmVmUHRyPFJlbmRlclN0eWxlPiBDU1NTdHlsZVNlbGVj dG9yCiAgICAgfQogCiAgICAgaW5pdEZvclN0eWxlUmVzb2x2ZShlLCBwYXJlbnRTdHlsZSwgcHNl dWRvKTsKLSAgICBtX3N0eWxlID0gcGFyZW50U3R5bGU7Ci0gICAgCisgICAgbV9zdHlsZSA9IFJl bmRlclN0eWxlOjpjcmVhdGUoKTsKKyAgICBpZiAocGFyZW50U3R5bGUpCisgICAgICAgIG1fc3R5 bGUtPmluaGVyaXRGcm9tKHBhcmVudFN0eWxlKTsKKwogICAgIG1fY2hlY2tlci5tX21hdGNoVmlz aXRlZFBzZXVkb0NsYXNzID0gbWF0Y2hWaXNpdGVkUHNldWRvQ2xhc3M7CiAKICAgICAvLyBTaW5j ZSB3ZSBkb24ndCB1c2UgcHNldWRvLWVsZW1lbnRzIGluIGFueSBvZiBvdXIgcXVpcmsvcHJpbnQg dXNlciBhZ2VudCBydWxlcywgZG9uJ3Qgd2FzdGUgdGltZSB3YWxraW5nCkBAIC0xNTIyLDEwICsx NTI0LDYgQEAgUGFzc1JlZlB0cjxSZW5kZXJTdHlsZT4gQ1NTU3R5bGVTZWxlY3RvcgogICAgIGlm IChtX21hdGNoZWREZWNscy5pc0VtcHR5KCkgJiYgIXZpc2l0ZWRTdHlsZSkKICAgICAgICAgcmV0 dXJuIDA7CiAKLSAgICBtX3N0eWxlID0gUmVuZGVyU3R5bGU6OmNyZWF0ZSgpOwotICAgIGlmIChw YXJlbnRTdHlsZSkKLSAgICAgICAgbV9zdHlsZS0+aW5oZXJpdEZyb20ocGFyZW50U3R5bGUpOwot CiAgICAgbV9zdHlsZS0+c2V0U3R5bGVUeXBlKHBzZXVkbyk7CiAgICAgCiAgICAgbV9saW5lSGVp Z2h0VmFsdWUgPSAwOwpAQCAtMTg4OCw3ICsxODg2LDcgQEAgYm9vbCBDU1NTdHlsZVNlbGVjdG9y OjpjaGVja1NlbGVjdG9yKENTUwogICAgIG1fZHluYW1pY1BzZXVkbyA9IE5PUFNFVURPOwogCiAg ICAgLy8gQ2hlY2sgdGhlIHNlbGVjdG9yCi0gICAgU2VsZWN0b3JNYXRjaCBtYXRjaCA9IG1fY2hl Y2tlci5jaGVja1NlbGVjdG9yKHNlbCwgbV9lbGVtZW50LCAmbV9zZWxlY3RvckF0dHJzLCBtX2R5 bmFtaWNQc2V1ZG8sIGZhbHNlLCBmYWxzZSwgc3R5bGUoKSwgbV9wYXJlbnRTdHlsZSk7CisgICAg U2VsZWN0b3JNYXRjaCBtYXRjaCA9IG1fY2hlY2tlci5jaGVja1NlbGVjdG9yKHNlbCwgbV9lbGVt ZW50LCAmbV9zZWxlY3RvckF0dHJzLCBtX2R5bmFtaWNQc2V1ZG8sIGZhbHNlLCBmYWxzZSwgc3R5 bGUoKSwgbV9wYXJlbnROb2RlID8gbV9wYXJlbnROb2RlLT5yZW5kZXJTdHlsZSgpIDogMCk7CiAg ICAgaWYgKG1hdGNoICE9IFNlbGVjdG9yTWF0Y2hlcykKICAgICAgICAgcmV0dXJuIGZhbHNlOwog CkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCShyZXZpc2lvbiA2NzIwNCkKKysrIFdl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTE2OCwx MCArNTE2OCw2IEBAIHZvaWQgUmVuZGVyQmxvY2s6OnVwZGF0ZUZpcnN0TGV0dGVyKCkKICAgICAg ICAgLy8gQ3JlYXRlIG91ciBwc2V1ZG8gc3R5bGUgbm93IHRoYXQgd2UgaGF2ZSBvdXIgZmlyc3RM ZXR0ZXJDb250YWluZXIgZGV0ZXJtaW5lZC4KICAgICAgICAgUmVuZGVyU3R5bGUqIHBzZXVkb1N0 eWxlID0gZmlyc3RMZXR0ZXJCbG9jay0+Z2V0Q2FjaGVkUHNldWRvU3R5bGUoRklSU1RfTEVUVEVS LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBmaXJzdExldHRlckNvbnRhaW5lci0+Zmlyc3RMaW5lU3R5bGUo KSk7Ci0gICAgICAgIGlmICghcHNldWRvU3R5bGUpIHsKLSAgICAgICAgICAgIHZpZXcoKS0+ZW5h YmxlTGF5b3V0U3RhdGUoKTsKLSAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgfSAgICAgICAg CiAKICAgICAgICAgLy8gRm9yY2UgaW5saW5lIGRpc3BsYXkgKGV4Y2VwdCBmb3IgZmxvYXRpbmcg Zmlyc3QtbGV0dGVycykKICAgICAgICAgcHNldWRvU3R5bGUtPnNldERpc3BsYXkocHNldWRvU3R5 bGUtPmlzRmxvYXRpbmcoKSA/IEJMT0NLIDogSU5MSU5FKTsKSW5kZXg6IFdlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcAkocmV2aXNpb24gNjcyMDQpCisrKyBXZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xNTY4LDggKzE1NjgsNiBAQCBJbmxpbmVJdGVyYXRvciBSZW5kZXJCbG9jazo6ZmluZE5leHRM aW5lCiAgICAgICAgICAgICBjb25zdCBVQ2hhciogc3RyID0gdC0+Y2hhcmFjdGVycygpOwogCiAg ICAgICAgICAgICBSZW5kZXJTdHlsZSogc3R5bGUgPSB0LT5zdHlsZShmaXJzdExpbmUpOwotICAg ICAgICAgICAgaWYgKCFzdHlsZSkKLSAgICAgICAgICAgICAgICBnb3RvIGVuZDsKICAgICAgICAg ICAgIGNvbnN0IEZvbnQmIGYgPSBzdHlsZS0+Zm9udCgpOwogICAgICAgICAgICAgYm9vbCBpc0Zp eGVkUGl0Y2ggPSBmLmlzRml4ZWRQaXRjaCgpOwogICAgICAgICAgICAgYm9vbCBjYW5IeXBoZW5h dGUgPSBzdHlsZS0+aHlwaGVucygpID09IEh5cGhlbnNBdXRvICYmIFdlYkNvcmU6OmNhbkh5cGhl bmF0ZShzdHlsZS0+aHlwaGVuYXRpb25Mb2NhbGUoKSk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA2NzI0 NykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEy IEBACisyMDEwLTA5LTEwICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHNldWRvc3R5bGUgcmVz b2x1dGlvbiBjb3JydXB0cyBjYWNoZWQgY2hpbGQgaW5kZXggdmFsdWVzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTU3NAorCisgICAgICAgICogZmFz dC9kb20vZmlyc3RsaW5lLWZpeGVkLWNyYXNoLWV4cGVjdGVkLnR4dDogVXBkYXRlZCByZXN1bHRz LgorCiAyMDEwLTA5LTEwICBUb255IEdlbnRpbGNvcmUgIDx0b255Z0BjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0 L2RvbS9maXJzdGxpbmUtZml4ZWQtY3Jhc2gtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvZG9tL2ZpcnN0bGluZS1maXhlZC1jcmFzaC1leHBlY3RlZC50eHQJKHJl dmlzaW9uIDY3MjA0KQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vZmlyc3RsaW5lLWZpeGVkLWNy YXNoLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSwyICsxLDIgQEAKIFRoaXMgdGV4 dCBzaG91bGQgcmVuZGVyIHdpdGhvdXQgY3Jhc2hpbmcgCi0KKy4uLgo=