<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>45573</bug_id>
          
          <creation_ts>2010-09-10 16:28:07 -0700</creation_ts>
          <short_desc>[chromium] Fix incorrect drag node/selection painting.</short_desc>
          <delta_ts>2010-09-16 12:05:45 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Daniel Cheng">dcheng</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>eric</cc>
    
    <cc>jamesr</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>tony</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>277525</commentid>
    <comment_count>0</comment_count>
    <who name="Daniel Cheng">dcheng</who>
    <bug_when>2010-09-10 16:28:07 -0700</bug_when>
    <thetext>If you dragged a selection near the bottom of the page, the selection would not be renderer correctly (it would be clipped as if the page hadn&apos;t been scrolled down).
I also updated dragImageForNode to use RenderLayer::paint() as well, since that allows us to remove PaintBehavior from the RTTI helper class. I&apos;m not 100% sure if the new code in Frame::dragImageForNode correct though--it uses document()-&gt;renderer() and node-&gt;renderer(), which is a little weird. However, if I just used RenderObject* renderer = node-&gt;renderer(), it would throw the following assert during the paint:
ASSERTION FAILED: rootLayer == m_clipRectsRoot</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>277528</commentid>
    <comment_count>1</comment_count>
      <attachid>67260</attachid>
    <who name="Daniel Cheng">dcheng</who>
    <bug_when>2010-09-10 16:31:36 -0700</bug_when>
    <thetext>Created attachment 67260
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279319</commentid>
    <comment_count>2</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-09-14 18:58:17 -0700</bug_when>
    <thetext>James is really a better reviewer for this than I am.

Is this how other ports do this?  We seem to have a bunch of code which does manual painting.  I know SVG code uses some paint-into-ImageBuffer code for SVGImage and masks.  I wonder how many other places do/do-not want scroll clipping and if we should be creating a simple API for all these clients to use instead of grabbing at layers directly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279328</commentid>
    <comment_count>3</comment_count>
    <who name="James Robinson">jamesr</who>
    <bug_when>2010-09-14 19:07:50 -0700</bug_when>
    <thetext>I still don&apos;t understand what exact semantics you are going for here, so it&apos;s hard to judge whether the code does what you want.  Where are the tests for this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279370</commentid>
    <comment_count>4</comment_count>
      <attachid>67260</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2010-09-14 21:19:44 -0700</bug_when>
    <thetext>Comment on attachment 67260
Patch

I think this will do the wrong thing with iframes and compositing. Iframes pull the paint behavior flags from their parent iframe (see -[WebFrame _drawRect:] in WebKit.

Rather than paint via the RenderLayer, why not call m_view-&gt;paintContents, which does not intersect with the scrollview&apos;s frame?

It would also be nice to share more code here with Mac&apos;s Frame::imageFromRect().</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279722</commentid>
    <comment_count>5</comment_count>
      <attachid>67716</attachid>
    <who name="Daniel Cheng">dcheng</who>
    <bug_when>2010-09-15 14:25:59 -0700</bug_when>
    <thetext>Created attachment 67716
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279726</commentid>
    <comment_count>6</comment_count>
      <attachid>67716</attachid>
    <who name="Daniel Cheng">dcheng</who>
    <bug_when>2010-09-15 14:28:32 -0700</bug_when>
    <thetext>Comment on attachment 67716
Patch

(In reply to comment #3)
&gt; I still don&apos;t understand what exact semantics you are going for here, so it&apos;s hard to judge whether the code does what you want.  Where are the tests for this?

There are no tests. The problem is ScrollView::paint() seemed to be clipping as if the page was never scrolled down.

(In reply to comment #4)
&gt; (From update of attachment 67260 [details])
&gt; I think this will do the wrong thing with iframes and compositing. Iframes pull the paint behavior flags from their parent iframe (see -[WebFrame _drawRect:] in WebKit.
&gt; 
&gt; Rather than paint via the RenderLayer, why not call m_view-&gt;paintContents, which does not intersect with the scrollview&apos;s frame?
&gt; 

I didn&apos;t know about this function. I&apos;ve updated the patch.

&gt; It would also be nice to share more code here with Mac&apos;s Frame::imageFromRect().

I based the implementation of these two functions off of Frame::imageFromRect(). However, they seemed to have a lot of Cocoa-specific magic, so I&apos;m not sure how I could share any more code. Ideas are welcome.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>280078</commentid>
    <comment_count>7</comment_count>
      <attachid>67716</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-09-16 07:36:13 -0700</bug_when>
    <thetext>Comment on attachment 67716
Patch

Rejecting patch 67716 from commit-queue.

Failed to run &quot;[&apos;WebKitTools/Scripts/run-webkit-tests&apos;, &apos;--no-launch-safari&apos;, &apos;--exit-after-n-failures=1&apos;, &apos;--wait-for-httpd&apos;, &apos;--quiet&apos;]&quot; exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default&apos;.
Running tests from /Projects/CommitQueue/LayoutTests
Testing 21296 test cases.
websocket/tests/handshake-fail-by-sub-protocol-mismatch.html -&gt; failed

Exiting early after 1 failures. 21268 tests run.
529.38s total testing time

21267 test cases (99%) succeeded
1 test case (&lt;1%) had incorrect layout
33 test cases (&lt;1%) had stderr output

Full output: http://queues.webkit.org/results/4063026</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>280238</commentid>
    <comment_count>8</comment_count>
    <who name="Tony Chang">tony</who>
    <bug_when>2010-09-16 11:44:36 -0700</bug_when>
    <thetext>Trying commit queue again because it doesn&apos;t seem that this code is run by websocket tests.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>280252</commentid>
    <comment_count>9</comment_count>
      <attachid>67716</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-09-16 12:05:39 -0700</bug_when>
    <thetext>Comment on attachment 67716
Patch

Clearing flags on attachment: 67716

Committed r67645: &lt;http://trac.webkit.org/changeset/67645&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>280253</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-09-16 12:05:45 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>67260</attachid>
            <date>2010-09-10 16:31:36 -0700</date>
            <delta_ts>2010-09-15 14:25:56 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-45573-20100910163135.patch</filename>
            <type>text/plain</type>
            <size>4611</size>
            <attacher name="Daniel Cheng">dcheng</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
NTA3NDkwMzVmZGMxNmEyNWYxMTVlYTJmNTIyYjg3YTQxODQzMDc1OC4uYmY2YTdmZmU3MjMzZmQy
YWViMWQxMzllZmJlNmIxODhkYmEwODgwYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK
KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wOS0xMCAgRGFu
aWVsIENoZW5nICA8ZGNoZW5nQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIEZpeCBpbmNvcnJlY3QgZHJhZyBu
b2RlL3NlbGVjdGlvbiBwYWludGluZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTQ1NTczCisKKyAgICAgICAgRHJhZyBzZWxlY3Rpb25zIHdlcmUgYmVp
bmcgaW5jb3JyZWN0bHkgY2xpcHBlZCB3aGVuIGRyYWdnaW5nIGEgc2VsZWN0aW9uCisgICAgICAg
IG5lYXIgdGhlIGJvdHRvbSBvZiBhIHBhZ2UgdGhhdCByZXF1aXJlZCBzY3JvbGxpbmcuIFRvIGZp
eCB0aGlzLCB3ZSB1c2UKKyAgICAgICAgUmVuZGVyTGF5ZXI6OnBhaW50KCkgZGlyZWN0bHkgaW5z
dGVhZCBvZiBTY3JvbGxWaWV3OjpwYWludCgpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKwor
ICAgICAgICAqIHBhZ2UvY2hyb21pdW0vRnJhbWVDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJD
b3JlOjpGcmFtZTo6bm9kZUltYWdlKToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lOjpkcmFnSW1h
Z2VGb3JTZWxlY3Rpb24pOgorCiAyMDEwLTA5LTA3ICBKYW4gRSBIYW5zc2VuICA8amhhbnNzZW5A
c2VuY2hhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpkaWZmIC0t
Z2l0IGEvV2ViQ29yZS9wYWdlL2Nocm9taXVtL0ZyYW1lQ2hyb21pdW0uY3BwIGIvV2ViQ29yZS9w
YWdlL2Nocm9taXVtL0ZyYW1lQ2hyb21pdW0uY3BwCmluZGV4IDQxNDZiMzlhN2JjYmI1ZDY1MDc4
NzgxZDc0Yzc5MTlmZmUxODkzNjcuLjkxZmZkNTE5ZmVkMTMyZDJhYTk2ZjAyMjg5YzVhNWZiY2Iz
ZDQ5NTUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9jaHJvbWl1bS9GcmFtZUNocm9taXVtLmNw
cAorKysgYi9XZWJDb3JlL3BhZ2UvY2hyb21pdW0vRnJhbWVDaHJvbWl1bS5jcHAKQEAgLTI5LDYg
KzI5LDcgQEAKICNpbmNsdWRlICJEb2N1bWVudC5oIgogI2luY2x1ZGUgIkZsb2F0UmVjdC5oIgog
I2luY2x1ZGUgIkltYWdlQnVmZmVyLmgiCisjaW5jbHVkZSAiUmVuZGVyTGF5ZXIuaCIKICNpbmNs
dWRlICJSZW5kZXJWaWV3LmgiCiAjaW5jbHVkZSAiU2V0dGluZ3MuaCIKIApAQCAtNDAsNyArNDEs
NiBAQCBzdHJ1Y3QgU2NvcGVkU3RhdGUgewogICAgIFNjb3BlZFN0YXRlKEZyYW1lKiB0aGVGcmFt
ZSwgUmVuZGVyT2JqZWN0KiB0aGVSZW5kZXJlcikKICAgICAgICAgOiBmcmFtZSh0aGVGcmFtZSkK
ICAgICAgICAgLCByZW5kZXJlcih0aGVSZW5kZXJlcikKLSAgICAgICAgLCBwYWludEJlaGF2aW9y
KGZyYW1lLT52aWV3KCktPnBhaW50QmVoYXZpb3IoKSkKICAgICAgICAgLCBiYWNrZ3JvdW5kQ29s
b3IoZnJhbWUtPnZpZXcoKS0+YmFzZUJhY2tncm91bmRDb2xvcigpKQogICAgIHsKICAgICB9CkBA
IC00OSwxNCArNDksMTIgQEAgc3RydWN0IFNjb3BlZFN0YXRlIHsKICAgICB7CiAgICAgICAgIGlm
IChyZW5kZXJlcikKICAgICAgICAgICAgIHJlbmRlcmVyLT51cGRhdGVEcmFnU3RhdGUoZmFsc2Up
OwotICAgICAgICBmcmFtZS0+dmlldygpLT5zZXRQYWludEJlaGF2aW9yKHBhaW50QmVoYXZpb3Ip
OwogICAgICAgICBmcmFtZS0+dmlldygpLT5zZXRCYXNlQmFja2dyb3VuZENvbG9yKGJhY2tncm91
bmRDb2xvcik7CiAgICAgICAgIGZyYW1lLT52aWV3KCktPnNldE5vZGVUb0RyYXcoMCk7CiAgICAg
fQogCiAgICAgRnJhbWUqIGZyYW1lOwogICAgIFJlbmRlck9iamVjdCogcmVuZGVyZXI7Ci0gICAg
UGFpbnRCZWhhdmlvciBwYWludEJlaGF2aW9yOwogICAgIENvbG9yIGJhY2tncm91bmRDb2xvcjsK
IH07CiAKQEAgLTY0LDIxICs2MiwyMCBAQCBzdHJ1Y3QgU2NvcGVkU3RhdGUgewogCiBEcmFnSW1h
Z2VSZWYgRnJhbWU6Om5vZGVJbWFnZShOb2RlKiBub2RlKQogewotICAgIFJlbmRlck9iamVjdCog
cmVuZGVyZXIgPSBub2RlLT5yZW5kZXJlcigpOwotICAgIGlmICghcmVuZGVyZXIpCisgICAgUmVu
ZGVyT2JqZWN0KiByZW5kZXJlciA9IGRvY3VtZW50KCktPnJlbmRlcmVyKCk7CisgICAgaWYgKCFy
ZW5kZXJlciB8fCAhbm9kZS0+cmVuZGVyZXIoKSkKICAgICAgICAgcmV0dXJuIDA7CiAKICAgICBj
b25zdCBTY29wZWRTdGF0ZSBzdGF0ZSh0aGlzLCByZW5kZXJlcik7CiAKICAgICByZW5kZXJlci0+
dXBkYXRlRHJhZ1N0YXRlKHRydWUpOwotICAgIG1fdmlldy0+c2V0UGFpbnRCZWhhdmlvcihzdGF0
ZS5wYWludEJlaGF2aW9yIHwgUGFpbnRCZWhhdmlvckZsYXR0ZW5Db21wb3NpdGluZ0xheWVycyk7
CiAgICAgLy8gV2hlbiBnZW5lcmF0aW5nIHRoZSBkcmFnIGltYWdlIGZvciBhbiBlbGVtZW50LCBp
Z25vcmUgdGhlIGRvY3VtZW50IGJhY2tncm91bmQuCiAgICAgbV92aWV3LT5zZXRCYXNlQmFja2dy
b3VuZENvbG9yKGNvbG9yV2l0aE92ZXJyaWRlQWxwaGEoQ29sb3I6OndoaXRlLCAxLjApKTsKICAg
ICBtX2RvYy0+dXBkYXRlTGF5b3V0KCk7CiAgICAgbV92aWV3LT5zZXROb2RlVG9EcmF3KG5vZGUp
OyAvLyBFbmFibGUgc3BlY2lhbCBzdWItdHJlZSBkcmF3aW5nIG1vZGUuCiAKICAgICBJbnRSZWN0
IHRvcExldmVsUmVjdDsKLSAgICBJbnRSZWN0IHBhaW50aW5nUmVjdCA9IHJlbmRlcmVyLT5wYWlu
dGluZ1Jvb3RSZWN0KHRvcExldmVsUmVjdCk7CisgICAgSW50UmVjdCBwYWludGluZ1JlY3QgPSBu
b2RlLT5yZW5kZXJlcigpLT5wYWludGluZ1Jvb3RSZWN0KHRvcExldmVsUmVjdCk7CiAKICAgICBP
d25QdHI8SW1hZ2VCdWZmZXI+IGJ1ZmZlcihJbWFnZUJ1ZmZlcjo6Y3JlYXRlKHBhaW50aW5nUmVj
dC5zaXplKCkpKTsKICAgICBpZiAoIWJ1ZmZlcikKQEAgLTg2LDcgKzgzLDkgQEAgRHJhZ0ltYWdl
UmVmIEZyYW1lOjpub2RlSW1hZ2UoTm9kZSogbm9kZSkKICAgICBidWZmZXItPmNvbnRleHQoKS0+
dHJhbnNsYXRlKC1wYWludGluZ1JlY3QueCgpLCAtcGFpbnRpbmdSZWN0LnkoKSk7CiAgICAgYnVm
ZmVyLT5jb250ZXh0KCktPmNsaXAoRmxvYXRSZWN0KDAsIDAsIHBhaW50aW5nUmVjdC5yaWdodCgp
LCBwYWludGluZ1JlY3QuYm90dG9tKCkpKTsKIAotICAgIG1fdmlldy0+cGFpbnQoYnVmZmVyLT5j
b250ZXh0KCksIHBhaW50aW5nUmVjdCk7CisgICAgUmVuZGVyTGF5ZXIqIGxheWVyID0gcmVuZGVy
ZXItPmVuY2xvc2luZ0xheWVyKCk7CisgICAgbGF5ZXItPnBhaW50KGJ1ZmZlci0+Y29udGV4dCgp
LCBwYWludGluZ1JlY3QsCisgICAgICAgICAgICAgICAgIFBhaW50QmVoYXZpb3JOb3JtYWwgfCBQ
YWludEJlaGF2aW9yRmxhdHRlbkNvbXBvc2l0aW5nTGF5ZXJzLCByZW5kZXJlcik7CiAKICAgICBS
ZWZQdHI8SW1hZ2U+IGltYWdlID0gYnVmZmVyLT5jb3B5SW1hZ2UoKTsKICAgICByZXR1cm4gY3Jl
YXRlRHJhZ0ltYWdlRnJvbUltYWdlKGltYWdlLmdldCgpKTsKQEAgLTk0LDExICs5MywxNCBAQCBE
cmFnSW1hZ2VSZWYgRnJhbWU6Om5vZGVJbWFnZShOb2RlKiBub2RlKQogCiBEcmFnSW1hZ2VSZWYg
RnJhbWU6OmRyYWdJbWFnZUZvclNlbGVjdGlvbigpCiB7CisgICAgUmVuZGVyT2JqZWN0KiByZW5k
ZXJlciA9IGRvY3VtZW50KCktPnJlbmRlcmVyKCk7CisgICAgaWYgKCFyZW5kZXJlcikKKyAgICAg
ICAgcmV0dXJuIDA7CisKICAgICBpZiAoIXNlbGVjdGlvbigpLT5pc1JhbmdlKCkpCiAgICAgICAg
IHJldHVybiAwOwogCiAgICAgY29uc3QgU2NvcGVkU3RhdGUgc3RhdGUodGhpcywgMCk7Ci0gICAg
bV92aWV3LT5zZXRQYWludEJlaGF2aW9yKFBhaW50QmVoYXZpb3JTZWxlY3Rpb25Pbmx5KTsKICAg
ICBtX2RvYy0+dXBkYXRlTGF5b3V0KCk7CiAKICAgICBJbnRSZWN0IHBhaW50aW5nUmVjdCA9IGVu
Y2xvc2luZ0ludFJlY3Qoc2VsZWN0aW9uQm91bmRzKCkpOwpAQCAtMTA5LDcgKzExMSw4IEBAIERy
YWdJbWFnZVJlZiBGcmFtZTo6ZHJhZ0ltYWdlRm9yU2VsZWN0aW9uKCkKICAgICBidWZmZXItPmNv
bnRleHQoKS0+dHJhbnNsYXRlKC1wYWludGluZ1JlY3QueCgpLCAtcGFpbnRpbmdSZWN0LnkoKSk7
CiAgICAgYnVmZmVyLT5jb250ZXh0KCktPmNsaXAoRmxvYXRSZWN0KDAsIDAsIHBhaW50aW5nUmVj
dC5yaWdodCgpLCBwYWludGluZ1JlY3QuYm90dG9tKCkpKTsKIAotICAgIG1fdmlldy0+cGFpbnQo
YnVmZmVyLT5jb250ZXh0KCksIHBhaW50aW5nUmVjdCk7CisgICAgUmVuZGVyTGF5ZXIqIGxheWVy
ID0gcmVuZGVyZXItPmVuY2xvc2luZ0xheWVyKCk7CisgICAgbGF5ZXItPnBhaW50KGJ1ZmZlci0+
Y29udGV4dCgpLCBwYWludGluZ1JlY3QsIFBhaW50QmVoYXZpb3JTZWxlY3Rpb25Pbmx5LCByZW5k
ZXJlcik7CiAKICAgICBSZWZQdHI8SW1hZ2U+IGltYWdlID0gYnVmZmVyLT5jb3B5SW1hZ2UoKTsK
ICAgICByZXR1cm4gY3JlYXRlRHJhZ0ltYWdlRnJvbUltYWdlKGltYWdlLmdldCgpKTsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>67716</attachid>
            <date>2010-09-15 14:25:59 -0700</date>
            <delta_ts>2010-09-16 12:05:39 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-45573-20100915142558.patch</filename>
            <type>text/plain</type>
            <size>2040</size>
            <attacher name="Daniel Cheng">dcheng</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
ZTU5ODI3NzNhYTQxYTA0ZjFiZjRjYzQxNWE2M2UwYjcxMDM5ZmQxMy4uMDg0NjE2ZjA4NGU5Njg4
MTVkMzFhOTM4YjA1MGM0ZDQxZWIyYTdkNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK
KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wOS0xNSAgRGFu
aWVsIENoZW5nICA8ZGNoZW5nQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIEZpeCBpbmNvcnJlY3QgZHJhZyBu
b2RlL3NlbGVjdGlvbiBwYWludGluZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTQ1NTczCisKKyAgICAgICAgRHJhZyBzZWxlY3Rpb25zIHdlcmUgYmVp
bmcgaW5jb3JyZWN0bHkgY2xpcHBlZCB3aGVuIGRyYWdnaW5nIGEgc2VsZWN0aW9uCisgICAgICAg
IG5lYXIgdGhlIGJvdHRvbSBvZiBhIHBhZ2UgdGhhdCB3YXMgdGFsbGVyIHRoYW4gdGhlIHZpZXdw
b3J0LiBUbyBmaXgKKyAgICAgICAgdGhpcywgd2UgdXNlIHBhaW50Q29udGVudHMoKSBpbnN0ZWFk
IG9mIHBhaW50KCkuCisKKyAgICAgICAgKiBwYWdlL2Nocm9taXVtL0ZyYW1lQ2hyb21pdW0uY3Bw
OgorICAgICAgICAoV2ViQ29yZTo6RnJhbWU6Om5vZGVJbWFnZSk6CisgICAgICAgIChXZWJDb3Jl
OjpGcmFtZTo6ZHJhZ0ltYWdlRm9yU2VsZWN0aW9uKToKKwogMjAxMC0wOS0xNCAgUGF2ZWwgRmVs
ZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5
IFNlbWlraGF0c2t5LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL2Nocm9taXVtL0ZyYW1lQ2hy
b21pdW0uY3BwIGIvV2ViQ29yZS9wYWdlL2Nocm9taXVtL0ZyYW1lQ2hyb21pdW0uY3BwCmluZGV4
IGI5MDk3ZDA3NTYxYzY5OTBjYzRiODU5OWUxZjE1ZjNjOTRjODcxMDcuLjE1ZmY4YjQ3OGM2M2Jh
MTRjNzNmYjFiZWM0NjgzYmIxZWZhZjBmYTAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9jaHJv
bWl1bS9GcmFtZUNocm9taXVtLmNwcAorKysgYi9XZWJDb3JlL3BhZ2UvY2hyb21pdW0vRnJhbWVD
aHJvbWl1bS5jcHAKQEAgLTg2LDcgKzg2LDcgQEAgRHJhZ0ltYWdlUmVmIEZyYW1lOjpub2RlSW1h
Z2UoTm9kZSogbm9kZSkKICAgICBidWZmZXItPmNvbnRleHQoKS0+dHJhbnNsYXRlKC1wYWludGlu
Z1JlY3QueCgpLCAtcGFpbnRpbmdSZWN0LnkoKSk7CiAgICAgYnVmZmVyLT5jb250ZXh0KCktPmNs
aXAoRmxvYXRSZWN0KDAsIDAsIHBhaW50aW5nUmVjdC5yaWdodCgpLCBwYWludGluZ1JlY3QuYm90
dG9tKCkpKTsKIAotICAgIG1fdmlldy0+cGFpbnQoYnVmZmVyLT5jb250ZXh0KCksIHBhaW50aW5n
UmVjdCk7CisgICAgbV92aWV3LT5wYWludENvbnRlbnRzKGJ1ZmZlci0+Y29udGV4dCgpLCBwYWlu
dGluZ1JlY3QpOwogCiAgICAgUmVmUHRyPEltYWdlPiBpbWFnZSA9IGJ1ZmZlci0+Y29weUltYWdl
KCk7CiAgICAgcmV0dXJuIGNyZWF0ZURyYWdJbWFnZUZyb21JbWFnZShpbWFnZS5nZXQoKSk7CkBA
IC0xMDksNyArMTA5LDcgQEAgRHJhZ0ltYWdlUmVmIEZyYW1lOjpkcmFnSW1hZ2VGb3JTZWxlY3Rp
b24oKQogICAgIGJ1ZmZlci0+Y29udGV4dCgpLT50cmFuc2xhdGUoLXBhaW50aW5nUmVjdC54KCks
IC1wYWludGluZ1JlY3QueSgpKTsKICAgICBidWZmZXItPmNvbnRleHQoKS0+Y2xpcChGbG9hdFJl
Y3QoMCwgMCwgcGFpbnRpbmdSZWN0LnJpZ2h0KCksIHBhaW50aW5nUmVjdC5ib3R0b20oKSkpOwog
Ci0gICAgbV92aWV3LT5wYWludChidWZmZXItPmNvbnRleHQoKSwgcGFpbnRpbmdSZWN0KTsKKyAg
ICBtX3ZpZXctPnBhaW50Q29udGVudHMoYnVmZmVyLT5jb250ZXh0KCksIHBhaW50aW5nUmVjdCk7
CiAKICAgICBSZWZQdHI8SW1hZ2U+IGltYWdlID0gYnVmZmVyLT5jb3B5SW1hZ2UoKTsKICAgICBy
ZXR1cm4gY3JlYXRlRHJhZ0ltYWdlRnJvbUltYWdlKGltYWdlLmdldCgpKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>