45564 2010-09-10 14:04:59 -0700 Set the visible name for the web process 2010-09-10 15:53:14 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 andersca andersca darin oldest_to_newest 277416 0 andersca 2010-09-10 14:04:59 -0700 Set the visible name for the web process 277417 1 andersca 2010-09-10 14:07:25 -0700 <rdar://problem/8416970> 277418 2 67232 andersca 2010-09-10 14:07:58 -0700 Created attachment 67232 Patch 277438 3 67232 mrowe 2010-09-10 14:29:44 -0700 Comment on attachment 67232 Patch > @@ -45,6 +47,23 @@ extern "C" kern_return_t bootstrap_register2(mach_port_t, name_t, mach_port_t, u > > namespace WebKit { > > +// -[NSProcessInfo processName] isn't thread-safe so we have our own implementation. We should do this conditionally and use -[NSProcessInfo processName] on platforms where it is thread-safe. > +static const char* processName() { Misplaced {. > + static CString* processName; > + if (!processName) { > + uint32_t bufferSize = MAXPATHLEN; > + char executablePath[bufferSize]; > + > + if (_NSGetExecutablePath(executablePath, &bufferSize)) > + return “”; If _NSGetExecutablePath fails we’ll do this work every time the function is called. Is that expected? Does _NSGetExecutablePath fail temporarily and then later give us valid results? > @@ -95,6 +96,14 @@ int WebProcessMain(CommandLine* commandLine) > WTF::initializeMainThread(); > RunLoop::initializeMainRunLoop(); > > + // Set the visible application name. > + String parentProcessName = (*commandLine)["parentprocessname"]; > + if (!parentProcessName.isNull()) { > + // FIXME: Localization! > + NSString *applicationName = [NSString stringWithFormat:@"%@ Web Content", (NSString *)parentProcessName]; > + WKSetVisibleApplicationName((CFStringRef)applicationName); > + } It would’ve been nicer if WKSetVisibleApplicationName took an NSString*. r=me 277444 4 67232 darin 2010-09-10 14:41:49 -0700 Comment on attachment 67232 Patch > +static const char* processName() { Brace should move to the next line. > + static CString* processName; > + if (!processName) { > + uint32_t bufferSize = MAXPATHLEN; > + char executablePath[bufferSize]; > + > + if (_NSGetExecutablePath(executablePath, &bufferSize)) > + return ""; > + > + char *name = strrchr(executablePath, '/') + 1; > + processName = new CString(name); > + } It would be better factoring to have this in a separate function called createProcessName. And if we want to leak this can we just strdup instead of using a CString? > + // FIXME: Localization! > + NSString *applicationName = [NSString stringWithFormat:@"%@ Web Content", (NSString *)parentProcessName]; > + WKSetVisibleApplicationName((CFStringRef)applicationName); That’s an admirable FIXME, but what’s your plan here? 277448 5 andersca 2010-09-10 14:50:50 -0700 (In reply to comment #4) > (From update of attachment 67232 [details]) > > +static const char* processName() { > > Brace should move to the next line. > > > + static CString* processName; > > + if (!processName) { > > + uint32_t bufferSize = MAXPATHLEN; > > + char executablePath[bufferSize]; > > + > > + if (_NSGetExecutablePath(executablePath, &bufferSize)) > > + return ""; > > + > > + char *name = strrchr(executablePath, '/') + 1; > > + processName = new CString(name); > > + } > > It would be better factoring to have this in a separate function called createProcessName. > Sure, I'll do that. (On platforms where NSProcessInfo is thread-safe I'll just have processName() return -[NSProcessInfo processName]). > And if we want to leak this can we just strdup instead of using a CString? Yes. > > > + // FIXME: Localization! > > + NSString *applicationName = [NSString stringWithFormat:@"%@ Web Content", (NSString *)parentProcessName]; > > + WKSetVisibleApplicationName((CFStringRef)applicationName); > > That’s an admirable FIXME, but what’s your plan here? I don't know how to set up the localization infrastructure, but we should probably do it sooner rather than later. 277492 6 andersca 2010-09-10 15:53:14 -0700 Committed r67247: <http://trac.webkit.org/changeset/67247> 67232 2010-09-10 14:07:58 -0700 2010-09-10 14:41:49 -0700 Patch bug-45564-20100910140756.patch text/plain 4545 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg Y2ZjYWU0MjdlNWQ2MDBhYjRjZWJlODhhZTMyY2ZlYmM4NzgzMDNiYy4uNGM2ZjNlMTRlYjg4YzVk Mzg4Mjc1NGY0MTZmYzAxN2ZmNTBiOGQ0MyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0wOS0xMCAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNldCB0aGUgdmlzaWJsZSBuYW1lIGZvciB0aGUg d2ViIHByb2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQ1NTY0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NDE2OTcwPgorCisgICAgICAgICog VUlQcm9jZXNzL0xhdW5jaGVyL21hYy9Qcm9jZXNzTGF1bmNoZXJNYWMubW06CisgICAgICAgIChX ZWJLaXQ6OnByb2Nlc3NOYW1lKToKKyAgICAgICAgQWRkIGEgdGhyZWFkIHNhZmUgaW1wbGVtZW50 YXRpb24gb2YgLVtOU1Byb2Nlc3NJbmZvIHByb2Nlc3NOYW1lXS4KKworICAgICAgICAoV2ViS2l0 OjpQcm9jZXNzTGF1bmNoZXI6OmxhdW5jaFByb2Nlc3MpOgorICAgICAgICBQYXNzIHRoZSBwcm9j ZXNzIG5hbWUgdG8gdGhlIGNoaWxkIHByb2Nlc3MuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL21h Yy9XZWJQcm9jZXNzTWFpbk1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc01haW4p OgorICAgICAgICBTZXQgdGhlIHZpc2libGUgbmFtZS4KKwogMjAxMC0wOS0xMCAgQWRhbSBCYXJ0 aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVs LgpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvbWFjL1Byb2Nlc3NMYXVu Y2hlck1hYy5tbSBiL1dlYktpdDIvVUlQcm9jZXNzL0xhdW5jaGVyL21hYy9Qcm9jZXNzTGF1bmNo ZXJNYWMubW0KaW5kZXggYjBjOWFmYjgyMmY0OThiMjJiOTVmMTc3ODRiNjBkN2UwNzIxNmY4Yy4u YWFiNGYxODcxNmZlNDA2YzgxZWExNjU2YTc3NjkyN2UxYmFlMzg3MiAxMDA2NDQKLS0tIGEvV2Vi S2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvbWFjL1Byb2Nlc3NMYXVuY2hlck1hYy5tbQorKysgYi9X ZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9tYWMvUHJvY2Vzc0xhdW5jaGVyTWFjLm1tCkBAIC0y OSwxMCArMjksMTIgQEAKICNpbmNsdWRlICJXZWJQcm9jZXNzLmgiCiAjaW5jbHVkZSAiV2ViU3lz dGVtSW50ZXJmYWNlLmgiCiAjaW5jbHVkZSA8Y3J0X2V4dGVybnMuaD4KKyNpbmNsdWRlIDxtYWNo LW8vZHlsZC5oPgogI2luY2x1ZGUgPG1hY2gvbWFjaGluZS5oPgogI2luY2x1ZGUgPHJ1bnRpbWUv SW5pdGlhbGl6ZVRocmVhZGluZy5oPgogI2luY2x1ZGUgPHNlcnZlcnMvYm9vdHN0cmFwLmg+CiAj aW5jbHVkZSA8c3Bhd24uaD4KKyNpbmNsdWRlIDxzeXMvcGFyYW0uaD4KICNpbmNsdWRlIDx3dGYv UGFzc1JlZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi9UaHJlYWRpbmcuaD4KICNpbmNsdWRlIDx3dGYv dGV4dC9DU3RyaW5nLmg+CkBAIC00NSw2ICs0NywyMyBAQCBleHRlcm4gIkMiIGtlcm5fcmV0dXJu X3QgYm9vdHN0cmFwX3JlZ2lzdGVyMihtYWNoX3BvcnRfdCwgbmFtZV90LCBtYWNoX3BvcnRfdCwg dQogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAorLy8gLVtOU1Byb2Nlc3NJbmZvIHByb2Nlc3NOYW1l XSBpc24ndCB0aHJlYWQtc2FmZSBzbyB3ZSBoYXZlIG91ciBvd24gaW1wbGVtZW50YXRpb24uCitz dGF0aWMgY29uc3QgY2hhciogcHJvY2Vzc05hbWUoKSB7CisgICAgc3RhdGljIENTdHJpbmcqIHBy b2Nlc3NOYW1lOworICAgIGlmICghcHJvY2Vzc05hbWUpIHsKKyAgICAgICAgdWludDMyX3QgYnVm ZmVyU2l6ZSA9IE1BWFBBVEhMRU47CisgICAgICAgIGNoYXIgZXhlY3V0YWJsZVBhdGhbYnVmZmVy U2l6ZV07CisKKyAgICAgICAgaWYgKF9OU0dldEV4ZWN1dGFibGVQYXRoKGV4ZWN1dGFibGVQYXRo LCAmYnVmZmVyU2l6ZSkpCisgICAgICAgICAgICByZXR1cm4gIiI7CisKKyAgICAgICAgY2hhciAq bmFtZSA9IHN0cnJjaHIoZXhlY3V0YWJsZVBhdGgsICcvJykgKyAxOworICAgICAgICBwcm9jZXNz TmFtZSA9IG5ldyBDU3RyaW5nKG5hbWUpOworICAgIH0KKworICAgIHJldHVybiBwcm9jZXNzTmFt ZS0+ZGF0YSgpOworfQorCiB2b2lkIFByb2Nlc3NMYXVuY2hlcjo6bGF1bmNoUHJvY2VzcygpCiB7 CiAgICAgLy8gQ3JlYXRlIHRoZSBsaXN0ZW5pbmcgcG9ydC4KQEAgLTYxLDcgKzgwLDcgQEAgdm9p ZCBQcm9jZXNzTGF1bmNoZXI6OmxhdW5jaFByb2Nlc3MoKQogICAgIENTdHJpbmcgc2VydmljZU5h bWUgPSBTdHJpbmc6OmZvcm1hdCgiY29tLmFwcGxlLldlYktpdC5XZWJQcm9jZXNzLSVkLSVwIiwg Z2V0cGlkKCksIHRoaXMpLnV0ZjgoKTsKIAogICAgIGNvbnN0IGNoYXIqIHBhdGggPSBbd2ViUHJv Y2Vzc0FwcEV4ZWN1dGFibGVQYXRoIGZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbl07Ci0gICAgY29u c3QgY2hhciogYXJnc1tdID0geyBwYXRoLCAiLW1vZGUiLCAibGVnYWN5d2VicHJvY2VzcyIsICIt c2VydmljZW5hbWUiLCBzZXJ2aWNlTmFtZS5kYXRhKCksIDAgfTsKKyAgICBjb25zdCBjaGFyKiBh cmdzW10gPSB7IHBhdGgsICItbW9kZSIsICJsZWdhY3l3ZWJwcm9jZXNzIiwgIi1zZXJ2aWNlbmFt ZSIsIHNlcnZpY2VOYW1lLmRhdGEoKSwgIi1wYXJlbnRwcm9jZXNzbmFtZSIsIHByb2Nlc3NOYW1l KCksIDAgfTsKIAogICAgIC8vIFJlZ2lzdGVyIG91cnNlbHZlcy4KICAgICBrZXJuX3JldHVybl90 IGtyID0gYm9vdHN0cmFwX3JlZ2lzdGVyMihib290c3RyYXBfcG9ydCwgY29uc3RfY2FzdDxjaGFy Kj4oc2VydmljZU5hbWUuZGF0YSgpKSwgbGlzdGVuaW5nUG9ydCwgMCk7CmRpZmYgLS1naXQgYS9X ZWJLaXQyL1dlYlByb2Nlc3MvbWFjL1dlYlByb2Nlc3NNYWluTWFjLm1tIGIvV2ViS2l0Mi9XZWJQ cm9jZXNzL21hYy9XZWJQcm9jZXNzTWFpbk1hYy5tbQppbmRleCBkZWNlNDlhYzc1YTYzYWFhYWY3 NTZkOThiNTU1NzQ3MTQ4MGMxZWYzLi40YjQ5OTIxZGJlZGQ2NmI3NGFiODNiZDQxMDU5MTZiMjJk Y2FhZmIwIDEwMDY0NAotLS0gYS9XZWJLaXQyL1dlYlByb2Nlc3MvbWFjL1dlYlByb2Nlc3NNYWlu TWFjLm1tCisrKyBiL1dlYktpdDIvV2ViUHJvY2Vzcy9tYWMvV2ViUHJvY2Vzc01haW5NYWMubW0K QEAgLTMwLDYgKzMwLDcgQEAKICNpbXBvcnQgIldlYlByb2Nlc3MuaCIKICNpbXBvcnQgIldlYlN5 c3RlbUludGVyZmFjZS5oIgogI2ltcG9ydCA8V2ViS2l0Mi9XS1ZpZXcuaD4KKyNpbXBvcnQgPFdl YktpdFN5c3RlbUludGVyZmFjZS5oPgogI2ltcG9ydCA8b2JqYy9vYmpjLWF1dG8uaD4KICNpbXBv cnQgPHJ1bnRpbWUvSW5pdGlhbGl6ZVRocmVhZGluZy5oPgogI2ltcG9ydCA8c2VydmVycy9ib290 c3RyYXAuaD4KQEAgLTM3LDYgKzM4LDcgQEAKICNpbXBvcnQgPHN0ZGlvLmg+CiAjaW1wb3J0IDxz eXNleGl0cy5oPgogI2ltcG9ydCA8dW5pc3RkLmg+CisjaW1wb3J0IDx3dGYvUmV0YWluUHRyLmg+ CiAjaW1wb3J0IDx3dGYvVGhyZWFkaW5nLmg+CiAjaW1wb3J0IDx3dGYvdGV4dC9DU3RyaW5nLmg+ CiAKQEAgLTgwLDcgKzgyLDYgQEAgaW50IFdlYlByb2Nlc3NNYWluKENvbW1hbmRMaW5lKiBjb21t YW5kTGluZSkKICAgICAgICAgcHJpbnRmKCJib290c3RyYXBfbG9va191cDIgcmVzdWx0OiAleCIs IGtyKTsKICAgICAgICAgcmV0dXJuIDI7CiAgICAgfQotICAgIAogCiAjaWYgIVNIT1dfQ1JBU0hf UkVQT1JURVIKICAgICAvLyBJbnN0YWxscyBzaWduYWwgaGFuZGxlcnMgdGhhdCBleGl0IG9uIGEg Y3Jhc2ggc28gdGhhdCBDcmFzaFJlcG9ydGVyIGRvZXMgbm90IHNob3cgdXAuCkBAIC05NSw2ICs5 NiwxNCBAQCBpbnQgV2ViUHJvY2Vzc01haW4oQ29tbWFuZExpbmUqIGNvbW1hbmRMaW5lKQogICAg IFdURjo6aW5pdGlhbGl6ZU1haW5UaHJlYWQoKTsKICAgICBSdW5Mb29wOjppbml0aWFsaXplTWFp blJ1bkxvb3AoKTsKIAorICAgIC8vIFNldCB0aGUgdmlzaWJsZSBhcHBsaWNhdGlvbiBuYW1lLgor ICAgIFN0cmluZyBwYXJlbnRQcm9jZXNzTmFtZSA9ICgqY29tbWFuZExpbmUpWyJwYXJlbnRwcm9j ZXNzbmFtZSJdOworICAgIGlmICghcGFyZW50UHJvY2Vzc05hbWUuaXNOdWxsKCkpIHsKKyAgICAg ICAgLy8gRklYTUU6IExvY2FsaXphdGlvbiEKKyAgICAgICAgTlNTdHJpbmcgKmFwcGxpY2F0aW9u TmFtZSA9IFtOU1N0cmluZyBzdHJpbmdXaXRoRm9ybWF0OkAiJUAgV2ViIENvbnRlbnQiLCAoTlNT dHJpbmcgKilwYXJlbnRQcm9jZXNzTmFtZV07CisgICAgICAgIFdLU2V0VmlzaWJsZUFwcGxpY2F0 aW9uTmFtZSgoQ0ZTdHJpbmdSZWYpYXBwbGljYXRpb25OYW1lKTsKKyAgICB9CisgICAgCiAgICAg Ly8gQ3JlYXRlIHRoZSBjb25uZWN0aW9uLgogICAgIFdlYlByb2Nlc3M6OnNoYXJlZCgpLmluaXRp YWxpemUoc2VydmVyUG9ydCwgUnVuTG9vcDo6bWFpbigpKTsKICAgICAK