45554 2010-09-10 11:51:25 -0700 compositing/iframes/iframe-src-change.html test fails on Windows 2010-09-10 14:24:11 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Windows 7 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser aroben cmarrin oldest_to_newest 277340 0 simon.fraser 2010-09-10 11:51:25 -0700 This test fails on Windows (when building with compositing). The reason is that the test sets the iframe source, and immediately dumps layers. On windows, it seems that resource loading is timer-based, so the iframe load doesn't happen until after the test completes. We can fix this with a setTimeout in the test. 277341 1 aroben 2010-09-10 11:53:24 -0700 (In reply to comment #0) > On windows, it seems that resource loading is timer-based, so the iframe load doesn't happen until after the test completes. How does this work on Mac? Are we just getting lucky? 277344 2 67215 simon.fraser 2010-09-10 11:55:19 -0700 Created attachment 67215 Patch 277364 3 simon.fraser 2010-09-10 12:18:56 -0700 I see the "about:blank" load happening via WebKit.dll!WebCore::FrameLoader::loadWithDocumentLoader(WebCore::DocumentLoader * loader=0x046959d8, WebCore::FrameLoadType type=FrameLoadTypeRedirectWithLockedBackForwardList, WTF::PassRefPtr<WebCore::FormState> prpFormState={...}) Line 1488 C++ WebKit.dll!WebCore::FrameLoader::loadWithNavigationAction(const WebCore::ResourceRequest & request={...}, const WebCore::NavigationAction & action={...}, bool lockHistory=false, WebCore::FrameLoadType type=FrameLoadTypeRedirectWithLockedBackForwardList, WTF::PassRefPtr<WebCore::FormState> formState={...}) Line 1411 C++ WebKit.dll!WebCore::FrameLoader::loadURL(const WebCore::KURL & newURL={...}, const WTF::String & referrer={...}, const WTF::String & frameName={...}, bool lockHistory=false, WebCore::FrameLoadType newLoadType=FrameLoadTypeRedirectWithLockedBackForwardList, WTF::PassRefPtr<WebCore::Event> event={...}, WTF::PassRefPtr<WebCore::FormState> prpFormState={...}) Line 1354 C++ WebKit.dll!WebCore::FrameLoader::loadFrameRequest(const WebCore::FrameLoadRequest & request={...}, bool lockHistory=false, bool lockBackForwardList=true, WTF::PassRefPtr<WebCore::Event> event={...}, WTF::PassRefPtr<WebCore::FormState> formState={...}, WebCore::ReferrerPolicy referrerPolicy=SendReferrer) Line 1293 C++ WebKit.dll!WebCore::FrameLoader::urlSelected(const WebCore::ResourceRequest & request={...}, const WTF::String & passedTarget={...}, WTF::PassRefPtr<WebCore::Event> triggeringEvent={...}, bool lockHistory=false, bool lockBackForwardList=true, bool userGesture=false, WebCore::ReferrerPolicy referrerPolicy=SendReferrer, WebCore::ShouldReplaceDocumentIfJavaScriptURL shouldReplaceDocumentIfJavaScriptURL=ReplaceDocumentIfJavaScriptURL) Line 304 C++ WebKit.dll!WebCore::FrameLoader::changeLocation(const WebCore::KURL & url={...}, const WTF::String & referrer={...}, bool lockHistory=false, bool lockBackForwardList=true, bool userGesture=false, bool refresh=false) Line 273 + 0x40 bytes C++ > WebKit.dll!WebCore::ScheduledURLNavigation::fire(WebCore::Frame * frame=0x046640e0) Line 98 + 0x43 bytes C++ WebKit.dll!WebCore::RedirectScheduler::timerFired(WebCore::Timer<WebCore::RedirectScheduler> * __formal=0x04664390) Line 360 + 0x20 bytes C++ WebKit.dll!WebCore::Timer<WebCore::RedirectScheduler>::fired() Line 98 + 0x23 bytes C++ WebKit.dll!WebCore::ThreadTimers::sharedTimerFiredInternal() Line 112 + 0xf bytes C++ This doesn't seem synchronous. 277369 4 aroben 2010-09-10 12:27:10 -0700 I guess about:blank only loads synchronously for new frames. I still wonder how this works on Mac. 277372 5 67215 simon.fraser 2010-09-10 12:38:09 -0700 Comment on attachment 67215 Patch The test is wrong; I'll come up with a better one. 277423 6 67237 simon.fraser 2010-09-10 14:17:45 -0700 Created attachment 67237 Patch 277427 7 67237 aroben 2010-09-10 14:20:46 -0700 Comment on attachment 67237 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67237&action=prettypatch > LayoutTests/compositing/iframes/iframe-src-change.html:52 > + results.innerText = "FAIL: should have initially had layers, and did not." I would say "but did not" r=me 277428 8 simon.fraser 2010-09-10 14:24:11 -0700 http://trac.webkit.org/changeset/67232 67215 2010-09-10 11:55:19 -0700 2010-09-10 12:38:09 -0700 Patch bug-45554-20100910115518.patch text/plain 1823 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4MjZiODQ1NDhlM2EzYjBhMDFhODgyZTYwYjdlMjg2Y2E4OTJkZDA4Li41MjNkZDYw NTNiNTUwZDQ0ZTM2NzFjZDVjNDU2YmUxZDk1M2I0NDc1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAK IDIwMTAtMDktMTAgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgY29tcG9zaXRpbmcv aWZyYW1lcy9pZnJhbWUtc3JjLWNoYW5nZS5odG1sIHRlc3QgZmFpbHMgb24gV2luZG93cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU1NTQKKworICAg ICAgICBBZGQgYSBzZXRUaW1lb3V0IGFmdGVyIHRoZSBpZnJhbWUgc291cmNlIGNoYW5nZSwgc28g dGhhdCB0aGUgaWZyYW1lCisgICAgICAgIGxvYWQgaGFwcGVucyBjb3JyZWN0bHkgb24gV2luZG93 cyBiZWZvcmUgZHVtcGluZyBsYXllcnMuCisKKyAgICAgICAgKiBjb21wb3NpdGluZy9pZnJhbWVz L2lmcmFtZS1zcmMtY2hhbmdlLmh0bWw6CisKKzIwMTAtMDktMTAgIFNpbW9uIEZyYXNlciAgPHNp bW9uLmZyYXNlckBhcHBsZS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgQ2hyaXMgTWFycmlu LgogCiAgICAgICAgIFVwZGF0ZSBXaW5kb3dzIExheW91dFRlc3QvY29tcG9zaXRpbmcgcmVzdWx0 cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvaWZyYW1lcy9pZnJhbWUtc3Jj LWNoYW5nZS5odG1sIGIvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvaWZyYW1lcy9pZnJhbWUtc3Jj LWNoYW5nZS5odG1sCmluZGV4IGY3N2U1NDY4ZWEzNWU3NGNlZTQwMWU2YTJkYjljMWE4ZjExOWM0 NWIuLmFmOWZhMGE4ODFlMDQwZTYxODY3MjU4MTA4OGM1YTc1ZGU5ZmZmNTAgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL2lmcmFtZXMvaWZyYW1lLXNyYy1jaGFuZ2UuaHRtbAor KysgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9pZnJhbWVzL2lmcmFtZS1zcmMtY2hhbmdlLmh0 bWwKQEAgLTM0LDEwICszNCwxMiBAQAogICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIu ZGlzcGxheSgpOwogCiAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdwYXJlbnQtaWZy YW1lJykuc3JjID0gImFib3V0OmJsYW5rIjsKLSAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0 Q29udHJvbGxlcikgewotICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2xheWVy cycpLmlubmVySFRNTCA9IGxheW91dFRlc3RDb250cm9sbGVyLmxheWVyVHJlZUFzVGV4dCgpOwot ICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOwotICAgICAgICB9 CisgICAgICAgIHdpbmRvdy5zZXRUaW1lb3V0KGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgaWYg KHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgICAgICAgICAgICAgIGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCdsYXllcnMnKS5pbm5lckhUTUwgPSBsYXlvdXRUZXN0Q29udHJvbGxl ci5sYXllclRyZWVBc1RleHQoKTsKKyAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci5ub3RpZnlEb25lKCk7CisgICAgICAgICAgICB9CisgICAgICAgIH0sIDApOwogICAgIH0KICAg ICAKICAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcignbG9hZCcsIGRvVGVzdCwgZmFsc2UpOwo= 67237 2010-09-10 14:17:45 -0700 2010-09-10 14:20:46 -0700 Patch bug-45554-20100910141744.patch text/plain 3875 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4MjZiODQ1NDhlM2EzYjBhMDFhODgyZTYwYjdlMjg2Y2E4OTJkZDA4Li5hZjkxNjU2 ZGMzYzllMWMxZmU1MGRmOTJiZjI0Y2FjM2JlN2Q3NTcyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAK IDIwMTAtMDktMTAgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgY29tcG9zaXRpbmcv aWZyYW1lcy9pZnJhbWUtc3JjLWNoYW5nZS5odG1sIHRlc3QgZmFpbHMgb24gV2luZG93cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU1NTQKKyAgICAg ICAgCisgICAgICAgIFRoaXMgdGVzdCBoYWQgdGhlIHdyb25nIGJlaGF2aW9yLiBJdCBuZXZlciBh Y3R1YWxseSBlbnRlcmVkIGNvbXBvc2l0aW5nIG1vZGUuCisgICAgICAgIE5vdyBnaXZlIGl0IGEg Y2hhbmNlIHRvIGRvIHNvIChhbmQgdGVzdCBmb3IgaXQpLCBhbmQgdGhlbiB0ZXN0IHRoYXQgdGhl IGxheWVycworICAgICAgICBkaXNhcHBlYXJlZC4KKworICAgICAgICAqIGNvbXBvc2l0aW5nL2lm cmFtZXMvaWZyYW1lLXNyYy1jaGFuZ2UtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGNvbXBvc2l0 aW5nL2lmcmFtZXMvaWZyYW1lLXNyYy1jaGFuZ2UuaHRtbDoKKworMjAxMC0wOS0xMCAgU2ltb24g RnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKwogICAgICAgICBSZXZpZXdlZCBieSBD aHJpcyBNYXJyaW4uCiAKICAgICAgICAgVXBkYXRlIFdpbmRvd3MgTGF5b3V0VGVzdC9jb21wb3Np dGluZyByZXN1bHRzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9pZnJhbWVz L2lmcmFtZS1zcmMtY2hhbmdlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5n L2lmcmFtZXMvaWZyYW1lLXNyYy1jaGFuZ2UtZXhwZWN0ZWQudHh0CmluZGV4IDkxY2NlMzk4ODFm YTc2MDc5NTVlYTEwM2NkNzhiODY2YjE5MzI1OTAuLjEyMDAyNjliZDgxZDczNDMwNTQzYmE0MmNl MDcxMzhiNzhkYzc1NWIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL2lmcmFt ZXMvaWZyYW1lLXNyYy1jaGFuZ2UtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2NvbXBv c2l0aW5nL2lmcmFtZXMvaWZyYW1lLXNyYy1jaGFuZ2UtZXhwZWN0ZWQudHh0CkBAIC0xLDQgKzEs NCBAQAogCiBUaGUgaWZyYW1lIGNvbnRlbnQgd2FzIHJlbW92ZWQuIFRoZXJlIHNob3VsZCBiZSBu byBsYXllcnMgaGVyZS4KIAotCitQQVNTOiBsYXllcnMgZGlzYXBwZWFyZWQgd2hlbiBpZnJhbWUg c291cmNlIGNoYW5nZWQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9pZnJh bWVzL2lmcmFtZS1zcmMtY2hhbmdlLmh0bWwgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9pZnJh bWVzL2lmcmFtZS1zcmMtY2hhbmdlLmh0bWwKaW5kZXggZjc3ZTU0NjhlYTM1ZTc0Y2VlNDAxZTZh MmRiOWMxYThmMTE5YzQ1Yi4uMTg1NWRkMjNmNTQ5YzZiZTc0YjdiMDIyMGE5ZTVjMzdiZmE0N2E2 MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvaWZyYW1lcy9pZnJhbWUtc3Jj LWNoYW5nZS5odG1sCisrKyBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL2lmcmFtZXMvaWZyYW1l LXNyYy1jaGFuZ2UuaHRtbApAQCAtMzAsMTQgKzMwLDMzIEBACiAKICAgICBmdW5jdGlvbiBkb1Rl c3QoKQogICAgIHsKLSAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKLSAg ICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmRpc3BsYXkoKTsKKyAgICAgICAgLy8gRm9y IHNvbWUgcmVhc29uIHRoaXMgZGVsYXkgaXMgcmVxdWlyZWQgZm9yIEFwcEtpdCB0byBub3Qgc2hv cnQtY2lyY3VpdCB0aGUgZGlzcGxheS4KKyAgICAgICAgd2luZG93LnNldFRpbWVvdXQoZnVuY3Rp b24oKSB7CisgICAgICAgICAgICB2YXIgaGFkTGF5ZXJzQmVmb3JlID0gZmFsc2U7CisgICAgICAg ICAgICB2YXIgaGFkTGF5ZXJzQWZ0ZXIgPSBmYWxzZTsKKyAgICAgICAgICAgIGlmICh3aW5kb3cu bGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJv bGxlci5kaXNwbGF5KCk7IC8vIE5lZWQgdG8gcGFpbnQgZm9yIG92ZXJsYXAgdGVzdGluZy4KKyAg ICAgICAgICAgICAgICBoYWRMYXllcnNCZWZvcmUgPSBsYXlvdXRUZXN0Q29udHJvbGxlci5sYXll clRyZWVBc1RleHQoKSAhPSAiIjsKKyAgICAgICAgICAgIH0KIAotICAgICAgICBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgncGFyZW50LWlmcmFtZScpLnNyYyA9ICJhYm91dDpibGFuayI7Ci0gICAg ICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKLSAgICAgICAgICAgIGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCdsYXllcnMnKS5pbm5lckhUTUwgPSBsYXlvdXRUZXN0Q29udHJv bGxlci5sYXllclRyZWVBc1RleHQoKTsKLSAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVy Lm5vdGlmeURvbmUoKTsKLSAgICAgICAgfQorICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoJ3BhcmVudC1pZnJhbWUnKS5zcmMgPSAiYWJvdXQ6YmxhbmsiOworICAgICAgICAgICAg CisgICAgICAgICAgICB3aW5kb3cuc2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgICAgICAgICAg ICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgICAgICAgICAgICAg ICAgIGhhZExheWVyc0FmdGVyID0gbGF5b3V0VGVzdENvbnRyb2xsZXIubGF5ZXJUcmVlQXNUZXh0 KCkgIT0gIiI7CisKKyAgICAgICAgICAgICAgICAgICAgdmFyIHJlc3VsdHMgPSBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgncmVzdWx0cycpOworICAgICAgICAgICAgICAgICAgICBpZiAoaGFkTGF5 ZXJzQmVmb3JlICYmICFoYWRMYXllcnNBZnRlcikKKyAgICAgICAgICAgICAgICAgICAgICAgIHJl c3VsdHMuaW5uZXJUZXh0ID0gIlBBU1M6IGxheWVycyBkaXNhcHBlYXJlZCB3aGVuIGlmcmFtZSBz b3VyY2UgY2hhbmdlZC4iCisgICAgICAgICAgICAgICAgICAgIGVsc2UgaWYgKCFoYWRMYXllcnNC ZWZvcmUpCisgICAgICAgICAgICAgICAgICAgICAgICByZXN1bHRzLmlubmVyVGV4dCA9ICJGQUlM OiBzaG91bGQgaGF2ZSBpbml0aWFsbHkgaGFkIGxheWVycywgYW5kIGRpZCBub3QuIgorICAgICAg ICAgICAgICAgICAgICBlbHNlIGlmIChoYWRMYXllcnNBZnRlcikKKyAgICAgICAgICAgICAgICAg ICAgICAgIHJlc3VsdHMuaW5uZXJUZXh0ID0gIkZBSUw6IGxheWVycyBkaWQgbm90IGRpc2FwcGVh ciB3aGVuIGlmcmFtZSBzb3VyY2UgY2hhbmdlZC4iCisKKyAgICAgICAgICAgICAgICAgICAgbGF5 b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworICAgICAgICAgICAgICAgIH0KKyAgICAg ICAgICAgIH0sIDApOworICAgICAgICB9LCAwKTsKICAgICB9CiAgICAgCiAgICAgd2luZG93LmFk ZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBkb1Rlc3QsIGZhbHNlKTsKQEAgLTUxLDYgKzcwLDYgQEAK ICAgICA8L2Rpdj4KIAogICAgIDxwPlRoZSBpZnJhbWUgY29udGVudCB3YXMgcmVtb3ZlZC4gVGhl cmUgc2hvdWxkIGJlIG5vIGxheWVycyBoZXJlLjwvcD4KLSAgICA8cHJlIGlkPSJsYXllcnMiPkxh eWVyIHRyZWUgYXBwZWFycyBoZXJlIGluIERSVC48L3ByZT4KKyAgICA8cCBpZD0icmVzdWx0cyI+ VGhpcyB0ZXN0IG5lZWRzIHRvIGJlIHJ1biBpbiBEUlQuPC9wPgogPC9ib2R5PgogPC9odG1sPgo=