45552 2010-09-10 11:23:02 -0700 [chromium] Make compositor obey finish flag 2010-09-16 05:51:21 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 nduca webkit-unassigned commit-queue fishd vangelis oldest_to_newest 277318 0 nduca 2010-09-10 11:23:02 -0700 The compositor should obey the finish flag on doComposite. Paired with a Chromium-side change, this will fix our resizing problems. 277333 1 67211 nduca 2010-09-10 11:41:18 -0700 Created attachment 67211 First attempt. 278584 2 67211 nduca 2010-09-13 17:08:25 -0700 Comment on attachment 67211 First attempt. I think we can land this now? 278709 3 67211 fishd 2010-09-13 21:26:28 -0700 Comment on attachment 67211 First attempt. View in context: https://bugs.webkit.org/attachment.cgi?id=67211&action=prettypatch > WebKit/chromium/src/WebViewImpl.cpp:989 > + m_layerRenderer->finish(); nit: indentation needs to be 4 spaces otherwise, R=me 279067 4 67584 nduca 2010-09-14 12:07:01 -0700 Created attachment 67584 Fixed tabs 279784 5 67211 eric 2010-09-15 15:47:14 -0700 Comment on attachment 67211 First attempt. Cleared Darin Fisher's review+ from obsolete attachment 67211 so that this bug does not appear in http://webkit.org/pending-commit. 280034 6 67584 commit-queue 2010-09-16 05:51:16 -0700 Comment on attachment 67584 Fixed tabs Clearing flags on attachment: 67584 Committed r67610: <http://trac.webkit.org/changeset/67610> 280035 7 commit-queue 2010-09-16 05:51:21 -0700 All reviewed patches have been landed. Closing bug. 67211 2010-09-10 11:41:18 -0700 2010-09-15 15:47:13 -0700 First attempt. bug-45552-20100910114117.patch text/plain 3543 nduca ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjMzMGIzZDIwYTM4MWEwOWQ0MmFkY2VmMDQxZGIyMzg5NjI5ZTM4YS4uODM4NDEyMWY0NzBjYzM1 MWQ3YTU4ZjYxYjMzY2FlZDA0NTEyNDA4YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wOS0xMCAgTmF0 IER1Y2EgIDxuZHVjYUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBNYWtlIGNvbXBvc2l0b3Igb2JleSBmaW5p c2ggZmxhZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDU1NTIKKworICAgICAgICBUaGUgY29tcG9zaXRvciBzaG91bGQgb2JleSB0aGUgZmluaXNoIGZs YWcgb24gZG9Db21wb3NpdGUuIFRoaXMKKyAgICAgICAgZmxhZyBjYXVzZXMgdGhlIGNvbXBvc2l0 b3IgdG8gZmluaXNoIHJlbmRlcmluZyBiZWZvcmUgcmV0dXJuaW5nLAorICAgICAgICB3aGljaCBp cyBuZWVkZWQgd2hlbiByZXNpemluZyB0aGUgd2luZG93IHRvIGF2b2lkIGZsYXNoZXMgb2YgZ3Jl ZW4uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVy Q2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJSZW5kZXJlckNocm9taXVtOjpm aW5pc2gpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVy ZXJDaHJvbWl1bS5oOgorCiAyMDEwLTA5LTA5ICBOYXQgRHVjYSAgPG5kdWNhQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmNw cCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9t aXVtLmNwcAppbmRleCBiZGUyNDk3ZjhjNTBkODgxYmY0OGE3YTA2ZGY3OThiY2ExN2NiZTIyLi5j MTkxOGMxYTlkOTVmZjgwNjE2YzRjZmFhMDFhOGJkOGZiNzZiZThhIDEwMDY0NAotLS0gYS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHAK KysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hy b21pdW0uY3BwCkBAIC0zNTIsNiArMzUyLDExIEBAIHZvaWQgTGF5ZXJSZW5kZXJlckNocm9taXVt OjpkcmF3TGF5ZXJzKGNvbnN0IEludFJlY3QmIHZpc2libGVSZWN0LCBjb25zdCBJbnRSZWN0CiAg ICAgR0xDKGdsRGlzYWJsZShHTF9TQ0lTU09SX1RFU1QpKTsKIH0KIAordm9pZCBMYXllclJlbmRl cmVyQ2hyb21pdW06OmZpbmlzaCgpCit7CisgICAgZ2xGaW5pc2goKTsKK30KKwogdm9pZCBMYXll clJlbmRlcmVyQ2hyb21pdW06OnByZXNlbnQoKQogewogICAgIC8vIFdlJ3JlIGRvbmUhIFRpbWUg dG8gc3dhcGJ1ZmZlcnMhCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uaAppbmRleCAyNzQ4MTVmM2ZlMjNjM2Iw NzhjNDcwM2U4NDViM2JiYzhjMzNlY2JkLi4wZWY0MzZkMzg4MDAwOTZmNDQ3NjAxMjZkYWJmNWE0 ZWE5OWQxNjYwIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L0xheWVyUmVuZGVyZXJDaHJvbWl1bS5oCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmgKQEAgLTcwLDYgKzcwLDkgQEAgcHVibGlj OgogICAgIC8vIGRyYXdzIHRoZSBjdXJyZW50IGxheWVycyBvbnRvIHRoZSBiYWNrYnVmZmVyCiAg ICAgdm9pZCBkcmF3TGF5ZXJzKGNvbnN0IEludFJlY3QmIHZpc2libGVSZWN0LCBjb25zdCBJbnRS ZWN0JiBjb250ZW50UmVjdCk7CiAKKyAgICAvLyB3YWl0cyBmb3IgcmVuZGVyaW5nIHRvIGZpbmlz aAorICAgIHZvaWQgZmluaXNoKCk7CisKICAgICAvLyBwdXRzIGJhY2tidWZmZXIgb25zY3JlZW4K ICAgICB2b2lkIHByZXNlbnQoKTsKIApkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL0NoYW5n ZUxvZyBiL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMjg3M2JmMDkxNzcwMjAyMzBj ZDAwOTZhYjM4Y2ZlNzkwYzNhYTgyZS4uZjIwODUxMjcyYTAwY2I5ZDE2MzJlMzdiYjJlYzU0MGQx N2U0ZGEyNCAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9XZWJL aXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDktMTAgIE5hdCBE dWNhICA8bmR1Y2FAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gTWFrZSBjb21wb3NpdG9yIG9iZXkgZmluaXNo IGZsYWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1 NTUyCisKKyAgICAgICAgVGhlIGNvbXBvc2l0b3Igc2hvdWxkIG9iZXkgdGhlIGZpbmlzaCBmbGFn IG9uIGRvQ29tcG9zaXRlLiBUaGlzCisgICAgICAgIGZsYWcgY2F1c2VzIHRoZSBjb21wb3NpdG9y IHRvIGZpbmlzaCByZW5kZXJpbmcgYmVmb3JlIHJldHVybmluZywKKyAgICAgICAgd2hpY2ggaXMg bmVlZGVkIHdoZW4gcmVzaXppbmcgdGhlIHdpbmRvdyB0byBhdm9pZCBmbGFzaGVzIG9mIGdyZWVu LgorCisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi Vmlld0ltcGw6OmNvbXBvc2l0ZSk6CisKIDIwMTAtMDktMDkgIE5hdCBEdWNhICA8bmR1Y2FAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0t Z2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAgYi9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRleCAxNGYyNzgxNDM3NDJlNWRmMThjNzQxNDYzOGE2 Y2VhODFiY2NkYTk4Li5mMjQ3NjNjYTkzMTQzMWFmOGZjZGQ5YWE5ODZjYTg0NmExNmNmMmFkIDEw MDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcApAQCAtOTg1LDcgKzk4NSw4IEBAIHZvaWQg V2ViVmlld0ltcGw6OmNvbXBvc2l0ZShib29sIGZpbmlzaCkKICAgICBkb0NvbXBvc2l0ZSgpOwog CiAgICAgLy8gRmluaXNoIGlmIHJlcXVlc3RlZC4KLSAgICAvLyBGSVhNRTogaGFuZGxlIGZpbmlz aCBmbGFnLgorICAgIGlmIChmaW5pc2gpCisgICAgICBtX2xheWVyUmVuZGVyZXItPmZpbmlzaCgp OwogCiAgICAgLy8gUHV0IHJlc3VsdCBvbnNjcmVlbi4KICAgICBtX2xheWVyUmVuZGVyZXItPnBy ZXNlbnQoKTsK 67584 2010-09-14 12:07:01 -0700 2010-09-16 05:51:16 -0700 Fixed tabs patch2 text/plain 3545 nduca ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjMzMGIzZDIwYTM4MWEwOWQ0MmFkY2VmMDQxZGIyMzg5NjI5ZTM4YS4uODM4NDEyMWY0NzBjYzM1 MWQ3YTU4ZjYxYjMzY2FlZDA0NTEyNDA4YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wOS0xMCAgTmF0 IER1Y2EgIDxuZHVjYUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBNYWtlIGNvbXBvc2l0b3Igb2JleSBmaW5p c2ggZmxhZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDU1NTIKKworICAgICAgICBUaGUgY29tcG9zaXRvciBzaG91bGQgb2JleSB0aGUgZmluaXNoIGZs YWcgb24gZG9Db21wb3NpdGUuIFRoaXMKKyAgICAgICAgZmxhZyBjYXVzZXMgdGhlIGNvbXBvc2l0 b3IgdG8gZmluaXNoIHJlbmRlcmluZyBiZWZvcmUgcmV0dXJuaW5nLAorICAgICAgICB3aGljaCBp cyBuZWVkZWQgd2hlbiByZXNpemluZyB0aGUgd2luZG93IHRvIGF2b2lkIGZsYXNoZXMgb2YgZ3Jl ZW4uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVy Q2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJSZW5kZXJlckNocm9taXVtOjpm aW5pc2gpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVy ZXJDaHJvbWl1bS5oOgorCiAyMDEwLTA5LTA5ICBOYXQgRHVjYSAgPG5kdWNhQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmNw cCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9t aXVtLmNwcAppbmRleCBiZGUyNDk3ZjhjNTBkODgxYmY0OGE3YTA2ZGY3OThiY2ExN2NiZTIyLi5j MTkxOGMxYTlkOTVmZjgwNjE2YzRjZmFhMDFhOGJkOGZiNzZiZThhIDEwMDY0NAotLS0gYS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHAK KysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hy b21pdW0uY3BwCkBAIC0zNTIsNiArMzUyLDExIEBAIHZvaWQgTGF5ZXJSZW5kZXJlckNocm9taXVt OjpkcmF3TGF5ZXJzKGNvbnN0IEludFJlY3QmIHZpc2libGVSZWN0LCBjb25zdCBJbnRSZWN0CiAg ICAgR0xDKGdsRGlzYWJsZShHTF9TQ0lTU09SX1RFU1QpKTsKIH0KIAordm9pZCBMYXllclJlbmRl cmVyQ2hyb21pdW06OmZpbmlzaCgpCit7CisgICAgZ2xGaW5pc2goKTsKK30KKwogdm9pZCBMYXll clJlbmRlcmVyQ2hyb21pdW06OnByZXNlbnQoKQogewogICAgIC8vIFdlJ3JlIGRvbmUhIFRpbWUg dG8gc3dhcGJ1ZmZlcnMhCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uaAppbmRleCAyNzQ4MTVmM2ZlMjNjM2Iw NzhjNDcwM2U4NDViM2JiYzhjMzNlY2JkLi4wZWY0MzZkMzg4MDAwOTZmNDQ3NjAxMjZkYWJmNWE0 ZWE5OWQxNjYwIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L0xheWVyUmVuZGVyZXJDaHJvbWl1bS5oCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmgKQEAgLTcwLDYgKzcwLDkgQEAgcHVibGlj OgogICAgIC8vIGRyYXdzIHRoZSBjdXJyZW50IGxheWVycyBvbnRvIHRoZSBiYWNrYnVmZmVyCiAg ICAgdm9pZCBkcmF3TGF5ZXJzKGNvbnN0IEludFJlY3QmIHZpc2libGVSZWN0LCBjb25zdCBJbnRS ZWN0JiBjb250ZW50UmVjdCk7CiAKKyAgICAvLyB3YWl0cyBmb3IgcmVuZGVyaW5nIHRvIGZpbmlz aAorICAgIHZvaWQgZmluaXNoKCk7CisKICAgICAvLyBwdXRzIGJhY2tidWZmZXIgb25zY3JlZW4K ICAgICB2b2lkIHByZXNlbnQoKTsKIApkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL0NoYW5n ZUxvZyBiL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMjg3M2JmMDkxNzcwMjAyMzBj ZDAwOTZhYjM4Y2ZlNzkwYzNhYTgyZS4uZjIwODUxMjcyYTAwY2I5ZDE2MzJlMzdiYjJlYzU0MGQx N2U0ZGEyNCAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9XZWJL aXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDktMTAgIE5hdCBE dWNhICA8bmR1Y2FAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gTWFrZSBjb21wb3NpdG9yIG9iZXkgZmluaXNo IGZsYWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1 NTUyCisKKyAgICAgICAgVGhlIGNvbXBvc2l0b3Igc2hvdWxkIG9iZXkgdGhlIGZpbmlzaCBmbGFn IG9uIGRvQ29tcG9zaXRlLiBUaGlzCisgICAgICAgIGZsYWcgY2F1c2VzIHRoZSBjb21wb3NpdG9y IHRvIGZpbmlzaCByZW5kZXJpbmcgYmVmb3JlIHJldHVybmluZywKKyAgICAgICAgd2hpY2ggaXMg bmVlZGVkIHdoZW4gcmVzaXppbmcgdGhlIHdpbmRvdyB0byBhdm9pZCBmbGFzaGVzIG9mIGdyZWVu LgorCisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi Vmlld0ltcGw6OmNvbXBvc2l0ZSk6CisKIDIwMTAtMDktMDkgIE5hdCBEdWNhICA8bmR1Y2FAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0t Z2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAgYi9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRleCAxNGYyNzgxNDM3NDJlNWRmMThjNzQxNDYzOGE2 Y2VhODFiY2NkYTk4Li5mMjQ3NjNjYTkzMTQzMWFmOGZjZGQ5YWE5ODZjYTg0NmExNmNmMmFkIDEw MDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcApAQCAtOTg1LDcgKzk4NSw4IEBAIHZvaWQg V2ViVmlld0ltcGw6OmNvbXBvc2l0ZShib29sIGZpbmlzaCkKICAgICBkb0NvbXBvc2l0ZSgpOwog CiAgICAgLy8gRmluaXNoIGlmIHJlcXVlc3RlZC4KLSAgICAvLyBGSVhNRTogaGFuZGxlIGZpbmlz aCBmbGFnLgorICAgIGlmIChmaW5pc2gpCisgICAgICAgIG1fbGF5ZXJSZW5kZXJlci0+ZmluaXNo KCk7CiAKICAgICAvLyBQdXQgcmVzdWx0IG9uc2NyZWVuLgogICAgIG1fbGF5ZXJSZW5kZXJlci0+ cHJlc2VudCgpOwo=