45548 2010-09-10 09:32:40 -0700 AX: accessibilityIsIgnored is returning nil when return value expects a BOOL 2010-09-13 15:49:26 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach abarth ddkilzer eric webkit.review.bot oldest_to_newest 277250 0 cfleizach 2010-09-10 09:32:40 -0700 this will actually result in an element NOT being ignored when it should, since returning NO (or nil) will make it appear in the hierarchy in these error cases 277259 1 67197 cfleizach 2010-09-10 09:46:03 -0700 Created attachment 67197 patch 277701 2 67197 ddkilzer 2010-09-11 04:35:14 -0700 Comment on attachment 67197 patch r=me It would be great if you could write a test for this as well! :) 278459 3 cfleizach 2010-09-13 14:02:28 -0700 will add layout test as well (figured out how to do so) 278461 4 cfleizach 2010-09-13 14:07:07 -0700 http://trac.webkit.org/changeset/67408 278540 5 webkit.review.bot 2010-09-13 15:49:26 -0700 http://trac.webkit.org/changeset/67408 might have broken GTK Linux 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/67408 http://trac.webkit.org/changeset/67409 http://trac.webkit.org/changeset/67410 http://trac.webkit.org/changeset/67411 http://trac.webkit.org/changeset/67412 67197 2010-09-10 09:46:03 -0700 2010-09-11 04:35:14 -0700 patch patch.txt text/plain 1321 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NzIwOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDUgKzEsMTUgQEAKIDIwMTAtMDktMTAgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBWDogYWNjZXNzaWJpbGl0eUlzSWdub3JlZCBpcyByZXR1cm5pbmcgbmlsIHdoZW4gcmV0dXJu IHZhbHVlIGV4cGVjdHMgYSBCT09MCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00NTU0OAorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9tYWMvQWNjZXNz aWJpbGl0eU9iamVjdFdyYXBwZXIubW06CisgICAgICAgICgtW0FjY2Vzc2liaWxpdHlPYmplY3RX cmFwcGVyIGFjY2Vzc2liaWxpdHlJc0lnbm9yZWRdKToKKworMjAxMC0wOS0xMCAgQ2hyaXMgRmxl aXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlk IEtpbHplci4KIAogICAgICAgICBNYWlsIGNyYXNoZXMgd2l0aCBzZWFyY2hpbmcgZm9yIG5leHQg bWlzc3BlbGxlZCB3b3JkIHdpdGggVm9pY2VPdmVyCkluZGV4OiBXZWJDb3JlL2FjY2Vzc2liaWxp dHkvbWFjL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyLm1tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvYWNjZXNzaWJpbGl0eS9tYWMvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIubW0JKHJldmlz aW9uIDY3MjA5KQorKysgV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9BY2Nlc3NpYmlsaXR5T2Jq ZWN0V3JhcHBlci5tbQkod29ya2luZyBjb3B5KQpAQCAtMTk3MiwxMSArMTk3MiwxMSBAQAogLSAo Qk9PTClhY2Nlc3NpYmlsaXR5SXNJZ25vcmVkCiB7CiAgICAgaWYgKCFtX29iamVjdCkKLSAgICAg ICAgcmV0dXJuIG5pbDsKKyAgICAgICAgcmV0dXJuIFlFUzsKIAogICAgIG1fb2JqZWN0LT51cGRh dGVCYWNraW5nU3RvcmUoKTsKICAgICBpZiAoIW1fb2JqZWN0KQotICAgICAgICByZXR1cm4gbmls OworICAgICAgICByZXR1cm4gWUVTOwogCiAgICAgaWYgKG1fb2JqZWN0LT5pc0F0dGFjaG1lbnQo KSkKICAgICAgICAgcmV0dXJuIFtbc2VsZiBhdHRhY2htZW50Vmlld10gYWNjZXNzaWJpbGl0eUlz SWdub3JlZF07Cg==