45547 2010-09-10 09:20:08 -0700 Fix a windows build of plugins 2010-10-13 21:32:38 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 fridrich.strba webkit-unassigned abarth commit-queue eric webkit.review.bot oldest_to_newest 277239 0 fridrich.strba 2010-09-10 09:20:08 -0700 Add a WebCore/plugins/win directory among the directories where to look for include files, since it contains some include files needed for the Windows build. 277243 1 67193 fridrich.strba 2010-09-10 09:21:34 -0700 Created attachment 67193 Patch 277246 2 67193 kling 2010-09-10 09:28:05 -0700 Comment on attachment 67193 Patch > + -I$(srcdir)/WebCore/plugins/win \ Wouldn't this fit better into the "TARGET_WIN32" section? 277251 3 fridrich.strba 2010-09-10 09:34:47 -0700 (In reply to comment #2) > (From update of attachment 67193 [details]) > > + -I$(srcdir)/WebCore/plugins/win \ > > Wouldn't this fit better into the "TARGET_WIN32" section? Just a matter of taste because the files there will be included only if the following condition is fulfilled: #elif defined(GDK_WINDOWING_WIN32) #include "PluginMessageThrottlerWin.h" #include <gdk/gdkwin32.h> #endif So, if you can accept it as it is, it is ok, if not I will redo the patch. 277265 4 67198 fridrich.strba 2010-09-10 09:52:08 -0700 Created attachment 67198 Patch 293902 5 67198 commit-queue 2010-10-13 19:03:12 -0700 Comment on attachment 67198 Patch Clearing flags on attachment: 67198 Committed r69726: <http://trac.webkit.org/changeset/69726> 293903 6 commit-queue 2010-10-13 19:03:17 -0700 All reviewed patches have been landed. Closing bug. 293949 7 webkit.review.bot 2010-10-13 21:32:38 -0700 http://trac.webkit.org/changeset/69726 might have broken GTK Linux 64-bit Debug The following tests are not passing: canvas/philip/tests/2d.gradient.radial.negative.html editing/selection/context-menu-on-text.html 67193 2010-09-10 09:21:34 -0700 2010-09-10 09:52:03 -0700 Patch bug-45547-20100910182132.patch text/plain 1034 fridrich.strba SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NzIwNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDktMTAgIEZyaWRyaWNoIFN0cmJhICA8ZnJpZHJpY2guc3Ry YmFAYmx1ZXdpbi5jaD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGQgV2ViQ29yZS9wbHVnaW5zL3dpbiBkaXJlY3RvcnkgdG8gQ0ZMQUdTCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTU0NworCisgICAg ICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogR05VbWFrZWZpbGUuYW06CisK IDIwMTAtMDktMDkgIFRvbnkgR2VudGlsY29yZSAgPHRvbnlnQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFdlYkNvcmUvR05VbWFrZWZpbGUu YW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQkocmV2aXNpb24gNjcyMDUp CisrKyBXZWJDb3JlL0dOVW1ha2VmaWxlLmFtCSh3b3JraW5nIGNvcHkpCkBAIC01MCw2ICs1MCw3 IEBAIHdlYmNvcmVfY3BwZmxhZ3MgKz0gXAogCS1JJChzcmNkaXIpL1dlYkNvcmUvcGxhdGZvcm0v dGV4dCBcCiAJLUkkKHNyY2RpcikvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L3RyYW5zY29kZXIgXAog CS1JJChzcmNkaXIpL1dlYkNvcmUvcGx1Z2lucyBcCisJLUkkKHNyY2RpcikvV2ViQ29yZS9wbHVn aW5zL3dpbiBcCiAJLUkkKHNyY2RpcikvV2ViQ29yZS9yZW5kZXJpbmcgXAogCS1JJChzcmNkaXIp L1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlIFwKIAktSSQoc3JjZGlyKS9XZWJDb3JlL3JlbmRlcmlu Zy9zdmcgXAo= 67198 2010-09-10 09:52:08 -0700 2010-10-13 19:03:12 -0700 Patch bug-45547-20100910185206.patch text/plain 1002 fridrich.strba SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NzIxMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTAtMDktMTAgIEZyaWRyaWNoIFN0cmJhICA8ZnJpZHJpY2guc3Ry YmFAYmx1ZXdpbi5jaD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGQgV2ViQ29yZS9wbHVnaW5zL3dpbiBkaXJlY3RvcnkgdG8gQ0ZMQUdTCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTU0NworCisgICAg ICAgICogR05VbWFrZWZpbGUuYW06CisKIDIwMTAtMDktMTAgIENocmlzIEZsZWl6YWNoICA8Y2Zs ZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBLaWx6ZXIuCklu ZGV4OiBXZWJDb3JlL0dOVW1ha2VmaWxlLmFtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvR05VbWFr ZWZpbGUuYW0JKHJldmlzaW9uIDY3MjEwKQorKysgV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQkod29y a2luZyBjb3B5KQpAQCAtNTAsNiArNTAsNyBAQCB3ZWJjb3JlX2NwcGZsYWdzICs9IFwKIAktSSQo c3JjZGlyKS9XZWJDb3JlL3BsYXRmb3JtL3RleHQgXAogCS1JJChzcmNkaXIpL1dlYkNvcmUvcGxh dGZvcm0vdGV4dC90cmFuc2NvZGVyIFwKIAktSSQoc3JjZGlyKS9XZWJDb3JlL3BsdWdpbnMgXAor CS1JJChzcmNkaXIpL1dlYkNvcmUvcGx1Z2lucy93aW4gXAogCS1JJChzcmNkaXIpL1dlYkNvcmUv cmVuZGVyaW5nIFwKIAktSSQoc3JjZGlyKS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZSBcCiAJLUkk KHNyY2RpcikvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnIFwK