45543 2010-09-10 08:25:41 -0700 Make webkit-gtk windows build not to depend on pthreads 2010-10-13 21:32:57 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 fridrich.strba webkit-unassigned abarth commit-queue dbates eric mrobinson webkit.review.bot xan.lopez oldest_to_newest 277204 0 fridrich.strba 2010-09-10 08:25:41 -0700 The windows implementation of pthreads is undermaintained, and it is perfectly possible to build webkit-gtk without using pthreads 277206 1 67188 fridrich.strba 2010-09-10 08:31:14 -0700 Created attachment 67188 Patch 1 278030 2 67188 xan.lopez 2010-09-13 00:28:59 -0700 Comment on attachment 67188 Patch 1 The reason why we started using pthreads was, in fact, GTK/win32, so if pthreads is actually worse there I think we should just drop the usage completely. See http://trac.webkit.org/changeset/37732 278420 3 67461 fridrich.strba 2010-09-13 13:13:50 -0700 Created attachment 67461 Avoid gratuitous dependency on pthreads-win32 278425 4 webkit.review.bot 2010-09-13 13:17:29 -0700 Attachment 67461 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/wtf/TCSpinLock.h:140: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/TCSpinLock.h:142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 278475 5 fridrich.strba 2010-09-13 14:21:59 -0700 (In reply to comment #4) > Attachment 67461 [details] did not pass style-queue: > Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 > JavaScriptCore/wtf/TCSpinLock.h:140: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] > JavaScriptCore/wtf/TCSpinLock.h:142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] > Total errors found: 2 in 2 files The problem is that in this particular file, all indentation is done by two spaces. I can fix this easily by making those two lines indented by 4 spaces but it will make the readability a mess. The other solution would be to reformat the file, but there again, it would mean to have a huge whitespace modification :( 293908 6 67461 commit-queue 2010-10-13 19:16:30 -0700 Comment on attachment 67461 Avoid gratuitous dependency on pthreads-win32 Clearing flags on attachment: 67461 Committed r69728: <http://trac.webkit.org/changeset/69728> 293909 7 commit-queue 2010-10-13 19:16:35 -0700 All reviewed patches have been landed. Closing bug. 293951 8 webkit.review.bot 2010-10-13 21:32:57 -0700 http://trac.webkit.org/changeset/69728 might have broken GTK Linux 64-bit Debug The following tests are not passing: canvas/philip/tests/2d.gradient.radial.negative.html editing/selection/context-menu-on-text.html 67188 2010-09-10 08:31:14 -0700 2010-09-13 13:13:45 -0700 Patch 1 bug-45543-20100910173112.patch text/plain 2935 fridrich.strba SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDY3MTk5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDkt MTAgIEZyaWRyaWNoIFN0cmJhICA8ZnJpZHJpY2guc3RyYmFAYmx1ZXdpbi5jaD4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb24ndCB0cnkgdG8gZGV0 ZWN0IHB0aHJlYWRzIHdoZW4gYnVpbGRpbmcgb24gd2luZG93cworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU1NDMKKworICAgICAgICAqIEdOVW1ha2Vm aWxlLmFtOgorICAgICAgICAqIGNvbmZpZ3VyZS5hYzoKKwogMjAxMC0wOS0wOSAgQmVuamFtaW4g UG91bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQgYnVpbGRmaXguCkluZGV4OiBHTlVtYWtlZmlsZS5hbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBHTlVtYWtl ZmlsZS5hbQkocmV2aXNpb24gNjcxOTkpCisrKyBHTlVtYWtlZmlsZS5hbQkod29ya2luZyBjb3B5 KQpAQCAtMTMxLDcgKzEzMSw3IEBAIGxpYkphdmFTY3JpcHRDb3JlX2xhX1NPVVJDRVMgPSBcCiBs aWJKYXZhU2NyaXB0Q29yZV9sYV9MSUJBREQgPSBcCiAJJChVTklDT0RFX0xJQlMpIFwKIAkkKEdM SUJfTElCUykgXAotCS1scHRocmVhZAorCSQoUFRIUkVBRF9MSUJTKQogCiBsaWJKYXZhU2NyaXB0 Q29yZV9sYV9DWFhGTEFHUyA9IFwKIAkkKGdsb2JhbF9jeHhmbGFncykgXApAQCAtMjI0LDcgKzIy NCw2IEBAIGxpYndlYmtpdGd0a19AV0VCS0lUR1RLX0FQSV9NQUpPUl9WRVJTSU8KIAkkKG5vX3Vu ZGVmaW5lZCkKIAogbGlid2Via2l0Z3RrX0BXRUJLSVRHVEtfQVBJX01BSk9SX1ZFUlNJT05AX0BX RUJLSVRHVEtfQVBJX01JTk9SX1ZFUlNJT05AX2xhX0xJQkFERCA9IFwKLQktbHB0aHJlYWQgXAog CWxpYkphdmFTY3JpcHRDb3JlLmxhIFwKIAkkKHdlYmNvcmVfbGRmbGFncykgXAogCSQoQ0FJUk9f TElCUykgXApAQCAtMjQ1LDcgKzI0NCw4IEBAIGxpYndlYmtpdGd0a19AV0VCS0lUR1RLX0FQSV9N QUpPUl9WRVJTSU8KIAkkKFBOR19MSUJTKSBcCiAJJChTUUxJVEUzX0xJQlMpIFwKIAkkKFVOSUNP REVfTElCUykgXAotCSQoWFRfTElCUykKKwkkKFhUX0xJQlMpIFwKKwkkKFBUSFJFQURfTElCUykK IAogIwogIyBFeHRyYSBjaGVja3MgYW5kIGZsYWdzCkluZGV4OiBjb25maWd1cmUuYWMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gY29uZmlndXJlLmFjCShyZXZpc2lvbiA2NzE5OSkKKysrIGNvbmZpZ3VyZS5hYwko d29ya2luZyBjb3B5KQpAQCAtMTAxLDEwICsxMDEsMTQgQEAgZmkKIAogIyBwdGhyZWFkIChub3Qg bmVlZGVkIG9uIFdpbmRvd3MpCiBpZiB0ZXN0ICIkb3Nfd2luMzIiID0gIm5vIjsgdGhlbgotQUNf Q0hFQ0tfSEVBREVSUyhbcHRocmVhZC5oXSwKLSAgICAgICAgICAgICAgICAgQUNfREVGSU5FKFtI QVZFX1BUSFJFQURfSF0sWzFdLFtEZWZpbmUgaWYgcHRocmVhZCBleGlzdHNdKSwKLSAgICAgICAg ICAgICAgICAgQUNfTVNHX0VSUk9SKFtwdGhyZWFkIHN1cHBvcnQgaXMgcmVxdWlyZWQgdG8gYnVp bGQgV2ViS2l0XSkpCisgICBBQ19DSEVDS19IRUFERVJTKFtwdGhyZWFkLmhdLAorICAgICAgICAg ICAgICAgICAgICBBQ19ERUZJTkUoW0hBVkVfUFRIUkVBRF9IXSxbMV0sW0RlZmluZSBpZiBwdGhy ZWFkIGV4aXN0c10pLAorICAgICAgICAgICAgICAgICAgICBBQ19NU0dfRVJST1IoW3B0aHJlYWQg c3VwcG9ydCBpcyByZXF1aXJlZCB0byBidWlsZCBXZWJLaXRdKSkKKyAgIFBUSFJFQURfTElCUz0t bHB0aHJlYWQKK2Vsc2UKKyAgIFBUSFJFQURfTElCUz0KIGZpCitBQ19TVUJTVChbUFRIUkVBRF9M SUJTXSkKIAogIyBjaGVjayBmb3IgbGlianBlZyB0aGUgd2F5IEd0ayBkb2VzIGl0LgogQUNfQ0hF Q0tfTElCKGpwZWcsIGpwZWdfZGVzdHJveV9kZWNvbXByZXNzLApAQCAtNjc2LDggKzY4MCw4IEBA IEFDX01TR19SRVNVTFQoWyRlbmFibGVfY292ZXJhZ2VdKQogQUNfTVNHX0NIRUNLSU5HKFt3aGV0 aGVyIHRvIGVuYWJsZSBvcHRpbWl6ZWQgbWVtb3J5IGFsbG9jYXRvcl0pCiBBQ19BUkdfRU5BQkxF KGZhc3RfbWFsbG9jLAogICAgICAgICAgICAgICBBQ19IRUxQX1NUUklORyhbLS1lbmFibGUtZmFz dC1tYWxsb2NdLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICBbZW5hYmxlIG9wdGltaXpl ZCBtZW1vcnkgYWxsb2NhdG9yIGRlZmF1bHQ9eWVzLCBkZWZhdWx0PW5vIGZvciBkZWJ1ZyBidWls ZHNdKSwKLSAgICAgICAgICAgICAgW10sW2lmIHRlc3QgIiRlbmFibGVfZGVidWciID0gInllcyI7 IHRoZW4gZW5hYmxlX2Zhc3RfbWFsbG9jPSJubyI7IGVsc2UgZW5hYmxlX2Zhc3RfbWFsbG9jPSJ5 ZXMiOyBmaV0pCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFtlbmFibGUgb3B0aW1pemVk IG1lbW9yeSBhbGxvY2F0b3IgZGVmYXVsdD15ZXMsIGRlZmF1bHQ9bm8gZm9yIGRlYnVnIGJ1aWxk cyBhbmQgZm9yIFdpbmRvd3NdKSwKKyAgICAgICAgICAgICAgW10sW2lmIHRlc3QgIiRlbmFibGVf ZGVidWciID0gInllcyIgLW8gIiRvc193aW4zMiIgPSAieWVzIjsgdGhlbiBlbmFibGVfZmFzdF9t YWxsb2M9Im5vIjsgZWxzZSBlbmFibGVfZmFzdF9tYWxsb2M9InllcyI7IGZpXSkKIEFDX01TR19S RVNVTFQoWyRlbmFibGVfZmFzdF9tYWxsb2NdKQogCiBBQ19NU0dfQ0hFQ0tJTkcoW3doZXRoZXIg dG8gZW5hYmxlIEpJVCBjb21waWxhdGlvbl0pCg== 67461 2010-09-13 13:13:50 -0700 2010-10-13 19:16:30 -0700 Avoid gratuitous dependency on pthreads-win32 bug-45543-20100913221348.patch text/plain 1742 fridrich.strba SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY3NDA0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDktMTMgIEZyaWRyaWNo IFN0cmJhICA8ZnJpZHJpY2guc3RyYmFAYmx1ZXdpbi5jaD4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb24ndCBkZXBlbmQgb24gV2luZG93cyBvbiBz Y2hlZF95aWVsZCBhbmQgc2NoZWQuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDU1NDMKKworICAgICAgICBzY2hlZC5oIGlzIHBhcnQgb2YgcHRocmVh ZHMgYW5kIHNjaGVkX3lpZWxkIGlzIGltcGxlbWVudGVkCisgICAgICAgIGluIHB0aHJlYWRzLXdp bjMyIGFzIFNsZWVwKDApLiBUaGlzIHBhdGNoIGF2b2lkcyBhIGdyYXR1aXRvdXMKKyAgICAgICAg ZGVwZW5kZW5jeSBvbiBwdGhyZWFkcy13aW4zMiBpbiB0aGlzIGZpbGUuCisKKyAgICAgICAgKiB3 dGYvVENTcGluTG9jay5oOgorICAgICAgICAoVENNYWxsb2NfU2xvd0xvY2spOgorCiAyMDEwLTA5 LTEzICBEYXJpbiBGaXNoZXIgIDxkYXJpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRGF2aWQgTGV2aW4uCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvVENTcGluTG9jay5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9UQ1NwaW5Mb2NrLmgJKHJldmlzaW9u IDY3NDA0KQorKysgSmF2YVNjcmlwdENvcmUvd3RmL1RDU3BpbkxvY2suaAkod29ya2luZyBjb3B5 KQpAQCAtMzgsOCArMzgsNiBAQAogCiAjaW5jbHVkZSA8dGltZS5oPiAgICAgICAvKiBGb3IgbmFu b3NsZWVwKCkgKi8KIAotI2luY2x1ZGUgPHNjaGVkLmg+ICAgICAgLyogRm9yIHNjaGVkX3lpZWxk KCkgKi8KLQogI2lmIEhBVkUoU1RESU5UX0gpCiAjaW5jbHVkZSA8c3RkaW50Lmg+CiAjZWxpZiBI QVZFKElOVFRZUEVTX0gpCkBAIC01Myw2ICs1MSw4IEBACiAjZGVmaW5lIFdJTjMyX0xFQU5fQU5E X01FQU4KICNlbmRpZgogI2luY2x1ZGUgPHdpbmRvd3MuaD4KKyNlbHNlCisjaW5jbHVkZSA8c2No ZWQuaD4gICAgICAvKiBGb3Igc2NoZWRfeWllbGQoKSAqLwogI2VuZGlmCiAKIHN0YXRpYyB2b2lk IFRDTWFsbG9jX1Nsb3dMb2NrKHZvbGF0aWxlIHVuc2lnbmVkIGludCogbG9ja3dvcmQpOwpAQCAt MTM1LDcgKzEzNSwxMiBAQCBzdHJ1Y3QgVENNYWxsb2NfU3BpbkxvY2sgewogI2RlZmluZSBTUElO TE9DS19JTklUSUFMSVpFUiB7IDAgfQogCiBzdGF0aWMgdm9pZCBUQ01hbGxvY19TbG93TG9jayh2 b2xhdGlsZSB1bnNpZ25lZCBpbnQqIGxvY2t3b3JkKSB7Ci0gIHNjaGVkX3lpZWxkKCk7ICAgICAg ICAvLyBZaWVsZCBpbW1lZGlhdGVseSBzaW5jZSBmYXN0IHBhdGggZmFpbGVkCisvLyBZaWVsZCBp bW1lZGlhdGVseSBzaW5jZSBmYXN0IHBhdGggZmFpbGVkCisjaWYgT1MoV0lORE9XUykKKyAgU2xl ZXAoMCk7CisjZWxzZQorICBzY2hlZF95aWVsZCgpOworI2VuZGlmCiAgIHdoaWxlICh0cnVlKSB7 CiAgICAgaW50IHI7CiAjaWYgQ09NUElMRVIoR0NDKQo=